Commit Graph

511 Commits

Author SHA1 Message Date
Michael Koziarski
1902ef6caa Give DateTime correct .to_s implementations, lets it play nice with ActiveRecord quoting. [gbuesing] Closes #7649
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6263 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-02-27 23:25:16 +00:00
Michael Koziarski
203932ec88 Add File.atomic_write to prevent users from seeing half written files. Useful for situations like Page Caching and the like. [Koz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6262 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-02-27 23:16:06 +00:00
Michael Koziarski
c9770d8a5a Allow users to provide custom formatters to Logger. [aeden] Closes #7106, #2484
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6225 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-02-25 00:07:54 +00:00
Jeremy Kemper
002c0aeef3 Hash#to_query CGI-escapes its keys.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6148 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-02-11 06:29:04 +00:00
Jeremy Kemper
39ae7025e8 Don't test for hash sort order.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6147 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-02-11 04:40:58 +00:00
Jeremy Kemper
9daddf0116 Deprecation: warn on stderr if RAILS_DEFAULT_LOGGER isn't set yet.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6140 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-02-08 00:17:39 +00:00
Michael Koziarski
517bf0814e Fix for DateTime superclass mismatch errors seen on some linux distributions. [Koz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6121 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-02-04 21:17:49 +00:00
Rick Olson
4790228bc4 fix problem with EMPTY_INHERITABLE_ATTRIBUTES being redefined
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6115 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-02-04 19:23:27 +00:00
Rick Olson
0a454cd73e fix #write_inheritable_attribute bug that crept in
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-02-04 18:33:54 +00:00
Rick Olson
3340261515 Optimize Class Inheritable Attributes so that unnecessary hashes are not created. Closes #7472 [Bruce Perens]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6110 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-02-04 18:20:04 +00:00
Jeremy Kemper
593b1b837d Ruby 1.8-cvs and 1.9 define a private Time#to_date that overrides Active Support. Make it public to preserve compatibility.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6099 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-02-01 18:06:16 +00:00
David Heinemeier Hansson
e720ba0b5f Remove noisy nodoc for Ruby 1.8.4
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6083 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-28 17:42:44 +00:00
Jeremy Kemper
50c1150e53 Mark the last release in the changelog.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6076 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-28 15:54:42 +00:00
Jeremy Kemper
b0ed5057e0 Full test coverage for Inflector. Closes #7228.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6075 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-28 15:52:45 +00:00
Jeremy Kemper
17fee001a9 :db format for Date#to_s
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6060 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-28 07:36:34 +00:00
Rick Olson
5e85a1c7f8 Added :instance_writer option to #mattr_writer/accessor, #cattr_writer/accessor, and #class_inheritable_writer to skip the creation of the instance writer. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6050 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-28 01:18:51 +00:00
Rick Olson
eca93d0970 Rename test file so it's not ignored by rake
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6049 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-28 00:47:32 +00:00
David Heinemeier Hansson
0aa0c84c17 Nodoc the irrelevant (from 1.2)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6044 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-26 21:37:38 +00:00
David Heinemeier Hansson
92af801465 Make to_query safe against nils
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-24 22:33:17 +00:00
David Heinemeier Hansson
35433859bd Added Hash#to_query to turn a hash of values into a form-encoded query string [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6038 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-24 22:12:31 +00:00
Nicholas Seckar
6ee09b6a0a Increase test coverage for subclasses_of. Closes #7335.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6036 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-24 20:47:32 +00:00
Rick Olson
be7f86e37a Added test coverage for Inflector.inflections.clear. Closes #7179. [Rich Collins]. Remove unused code from Duration#inspect. Closes #7180. [Rich Collins]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6022 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-23 05:32:08 +00:00
Rick Olson
a44cee2549 ActiveSupport::Multibyte::Handlers::UTF8Handler should raise when a range and an integer are passed in (just like the native implementation). Closes #7176 [Rich Collins]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6021 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-23 05:27:25 +00:00
Rick Olson
f3f691eaf2 A couple extra tests for #classify. Closes #7273. [Josh Susser]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6019 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-23 05:11:34 +00:00
Jamis Buck
1e9ce3c6a1 Better docs for Object extensions (closes #7002)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6011 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-22 22:53:38 +00:00
Michael Koziarski
59418618b9 Improve test coverage of Duration. Closes #7182 [richcollins]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6007 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-21 23:31:41 +00:00
Sam Stephenson
312e6edf91 Fix that Dates couldn't be subtracted from Dates after [5940].
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5954 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-15 22:02:11 +00:00
Jamis Buck
5314960d8b change Duration to use the new Object#acts_like? helper to do duck typing
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5952 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-15 17:13:45 +00:00
Jamis Buck
f28eef9a27 Add Object#acts_like? and Time#acts_like_time? and Date#acts_like_date? to facilitate duck-typing
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5951 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-15 17:12:32 +00:00
Jamis Buck
8368e160b4 Make sure Duration uses duck-typing instead of explicit classes, so apps can pass proxy objects around and have it all "just work"
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5948 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-15 16:47:51 +00:00
Michael Koziarski
276c9f29cd Make 1.months and friends accurate by introducing a Duration class. #6835 [eventualbuddha]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5940 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-15 06:54:50 +00:00
Jeremy Kemper
6714b39a13 Document Inflector.ordinalize and merge docs from String inflections. Closes #7023.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5924 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-14 12:18:51 +00:00
Jeremy Kemper
7b07baac27 Unbundle flexmock.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5917 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-13 07:15:07 +00:00
Jeremy Kemper
0a06ffc08e tighten test_load_once_paths_should_behave_when_recursively_loading
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5816 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-01-01 00:25:30 +00:00
Jeremy Kemper
cbe0c3c54f Check for nil name also. Closes #6561.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5814 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-31 23:53:05 +00:00
David Heinemeier Hansson
7ed7930769 Make RDoc not spew errors on install because of HTML comments in code comments
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5813 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-31 19:28:28 +00:00
Nicholas Seckar
91b71ed30c Fix Dependencies.autoloaded? to ignore anonymous modules. Closes #6561.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5811 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-31 18:53:58 +00:00
David Heinemeier Hansson
d88e83f211 False is a reasonable default
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5793 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-27 00:42:31 +00:00
Nicholas Seckar
e2acd16810 Update load once paths to prevent nested once constants from being detected and claimed by an external non-once load. References #6720
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-24 14:53:35 +00:00
Nicholas Seckar
1e170da30d Checkin failing test case related to load once paths
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5781 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-24 14:41:29 +00:00
Jeremy Kemper
01452feff1 DeprecatedInstanceVariable#inspect doesn't warn since test/unit, error logs, and others use it for diagnostics.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-20 21:28:31 +00:00
Jeremy Kemper
d68f559640 Don't require test/unit since it tries to turn everything into a test run.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5740 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-18 20:59:40 +00:00
Jeremy Kemper
8a73d4fe6f Deprecation: silence warnings when reporting test errors.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5728 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-17 08:21:45 +00:00
Jeremy Kemper
86deb27095 Hash#slice(*keys) returns a new hash with only the given keys. #slice! replaces the hash with only the given keys. Works with HashWithIndifferentAccess also.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5726 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-17 00:49:41 +00:00
Jeremy Kemper
05a5209f82 HashWithIndifferentAccess#to_hash converts to a Hash with String keys and the same default value. Fix Hash#reverse_update to be an alias for reverse_merge./script/console More thoroughly test the reverse_* methods.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5725 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-16 23:48:24 +00:00
Jeremy Kemper
0fc8056975 Silence warnings; use more precise assertions.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5724 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-16 23:45:44 +00:00
Nicholas Seckar
6a485c3100 Fix remove_constant to correctly handle constant names of the form "::A::...". References #6720.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5710 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-09 05:21:33 +00:00
David Heinemeier Hansson
0297b31b82 Fixed Array#to_xml when it contains a series of hashes (each piece would get its own XML declaration) (closes #6610) [thkarcher/cyu]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5668 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-03 16:47:53 +00:00
David Heinemeier Hansson
eacca8d7e6 Added Time#to_s(:time) which will just return H:M, like 17:44 [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5628 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-25 23:56:28 +00:00
Jeremy Kemper
44e6aa7e19 Improve readability.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5547 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-17 14:09:46 +00:00