github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
26,768 Commits 34 Branches 105 Tags
1945bafba2dba80ae0e5595127361fed8bb2d5de
Commit Graph

2731 Commits

Author SHA1 Message Date
Lucas Mazza
b5bb3f8558 raises an ArgumentError if no valid options are given to TemplateRenderer#determine_template 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-12-21 21:17:17 +01:00
Brian Rose
a1b2dbd7d4 Check for response to #last instead of #first. 2011-12-20 13:38:16 -07:00
Brian Rose
bd89946dd3 Ensure option for select helper responds to #first before comparison. 2011-12-20 13:26:10 -07:00
José Valim
437f1e0af1 Merge pull request #4064 from nashby/date-helper-field-error-proc 
fix adding field_with_errors to date selects, closes #3487
 2011-12-20 09:43:58 -08:00
Vasiliy Ermolovich
92088131ac fix adding field_with_errors to date selects, closes #3487 2011-12-20 20:25:56 +03:00
José Valim
2305a98f7a Check if source is encoding aware. 2011-12-20 12:39:28 +01:00
José Valim
2e0050ce5c Do not hard code encoding to UTF8 2011-12-20 11:56:38 +01:00
Xu Pan
1897be9b50 don't encode an UTF-8 encoded template 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-12-20 11:56:33 +01:00
Vijay Dev
5f6bcd74fd Merge pull request #3780 from marcbowes/master 
Fix favicon_link_tag help text
 2011-12-16 11:13:39 -08:00
Sergey Nartimov
caa1c19787 fix separator insertion in date_select helper 2011-12-14 23:20:23 +03:00
José Valim
f3531a8fc9 Clean up details keys before some tests to expire the cache. 2011-12-14 09:23:34 +01:00
Aaron Patterson
c7552d988e dup the details hash if a key has already been set for this object 2011-12-13 15:26:29 -08:00
Aaron Patterson
ab802e72dc locale and default_locale may be the same, so uniq the array 2011-12-13 11:28:30 -08:00
Aaron Patterson
9d87a67590 stop freezing the details hash 2011-12-13 11:25:03 -08:00
Aaron Patterson
8b85e4a4a1 stop freezing hash value 2011-12-13 11:13:14 -08:00
Erik Michaels-Ober
196407c54f Include TagHelper but don't explicitly require it 
Allow autoloading to work as intended and avoid multiple requires.
 2011-12-12 14:05:25 -08:00
Lennart Fridén
dc43e402a1 Added :use_two_digit_numbers option [Lennart Fridén & Kim Persson] 
Added use_two_digit_numbers select_tag option for displaying months and days with leading zeros without affecting the values (useful for e.g. ISO-style dates, 2011-08-01).

Signed-off-by: José Valim <jose.valim@gmail.com>

Conflicts:

	actionpack/CHANGELOG.md
 2011-12-11 22:54:28 +01:00
Will Farrington
3f65e7f7be Add button_tag support to ActionView::Helpers::FormBuilder. 
This support is near-identical to the existing submit_tag support.

Example:

    <%= form_for @post do |f| %>
      <%= f.button %>
    <% end %>
 2011-12-11 08:56:26 -05:00
Piotr Sarnacki
efed2d56e2 Update partials documentation, partial_path is no longer generated using RecordIdentifier 2011-12-10 01:30:21 +01:00
José Valim
2995134cba Simplify path traversal logic 2011-12-09 06:25:10 +01:00
Aaron Patterson
2c471b3ac8 load the encoding converter to work around [ruby-core:41556] when switching encodings 2011-12-08 15:14:07 -08:00
José Valim
d4d99bbc87 Fix another regression related to the layout optimization. 2011-12-08 22:56:50 +01:00
José Valim
ebd71fd0e3 Fix a regression and also fix broken test. 2011-12-08 21:00:34 +01:00
José Valim
859a4556dd Revert accidental change from cattr_accessor to class_attribute. 2011-12-08 19:01:15 +01:00
José Valim
239262fee0 Optimize layout lookup to avoid double calls. 2011-12-08 16:39:06 +01:00
José Valim
efc28a7f70 Some small optimizations and improvements to benchmark code. 2011-12-08 16:39:06 +01:00
José Valim
30f0d7bac8 Remove #:nodoc: from partial renderer. 2011-12-07 19:16:14 +01:00
Vijay Dev
7eb596cddd Merge branch 'master' of github.com:lifo/docrails 2011-12-06 23:05:43 +05:30
Uģis Ozols
d645aed91f Use do end for multiline block. 2011-12-05 23:11:20 +02:00
Uģis Ozols
1c65962b9d .rhtml and .rxml was removed in Rails 3. 2011-12-05 20:40:48 +02:00
Vasiliy Ermolovich
e29773f885 form_for with +:as+ option uses "action_as" as css class and id 2011-12-04 22:12:24 +03:00
Vijay Dev
a72839bc9d minor typo fix 2011-12-01 01:42:54 +05:30
lest
13cab6ef50 fix exception page when template contains utf-8 and parameters contain utf-8 2011-11-30 21:51:01 +03:00
José Valim
6093d88ed8 Fixes for using action view template in isolation. 2011-11-30 09:53:09 +01:00
Marc-Andre Lafortune
d3bc12b27f Handle correctly optional parameters for callable asset_host. 2011-11-29 02:01:18 -05:00
Vijay Dev
9ca58ba492 Revert "use any? to check for size" 
This reverts commit c4af5f00f6.
 2011-11-28 16:29:55 +05:30
Marc Bowes
9d7795638d * A / is required if you want to explicitly skip the assets directory. This is important because public/assets is typically git-ignored. 
* The asset id is no longer generated.
 2011-11-28 11:55:14 +02:00
Vasiliy Ermolovich
fb8b555c49 add namespace options to form_for 
You can provide a namespace for your form to ensure uniqueness of id attributes on form elements.
The namespace attribute will be prefixed with underscore on the generate HTML id
 2011-11-27 23:41:23 +03:00
lest
bc81ba2451 fix label with block in erb 2011-11-27 16:59:44 +03:00
Vijay Dev
1d89540686 Merge branch 'master' of github.com:lifo/docrails 2011-11-26 19:14:39 +05:30
Vijay Dev
c4af5f00f6 use any? to check for size 2011-11-26 18:52:10 +05:30
Marc Chung
745b7a1437 - Avoid using .first since it will create an additional query. 
- Handle scenario where @posts is empty.
 2011-11-22 17:04:19 -07:00
Yehuda Katz
9b7be78820 Merge pull request #3724 from marcandre/media_default 
stylesheet_tag default's media is "screen"
 2011-11-22 12:38:05 -08:00
Marc-Andre Lafortune
05e02deb68 Make explicit the default media when calling stylesheet_tag and change the default generators. 2011-11-22 15:16:23 -05:00
Yehuda Katz
bc04455f10 Merge pull request #3695 from tobiassvn/partial_path_error 
Meaningful errors for unexpected partial arguments. Fixes #3573
 2011-11-19 07:38:22 -08:00
Jon Leighton
603a679e87 Don't html-escape the :count option to translate if it's a Numeric. Fixes #3685. 2011-11-19 13:28:07 +00:00
Tobias Svensson
771635e858 Meaningful errors for unexpected partial arguments. Fixes #3573 2011-11-19 13:05:57 +00:00
Vijay Dev
48b580a03b Merge branch 'master' of github.com:lifo/docrails 2011-11-18 23:11:46 +05:30
Vijay Dev
5a2db4c7c3 put back the removed eg 2011-11-18 23:09:30 +05:30
Edward Anderson
fe88745d5f Fix a number_with_delimiter :separator example 2011-11-17 20:10:49 -05:00