github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
20,410 Commits 34 Branches 105 Tags
199e220e885277dad5e222bf98f00a67b2e6674e
Commit Graph

49 Commits

Author SHA1 Message Date
Emilio Tagua
c37800aae1 _ is not a valid scheme name character, \w includes it and also is redundant with \d. 
'The scheme name consists of a letter followed by any combination of letters, digits, and the plus ("+"), period ("."), or hyphen ("-") characters; and is terminated by a colon (":").'
 2010-09-29 12:55:43 -03:00
Emilio Tagua
8823b85010 Remove redundant conditional. 2010-09-29 12:42:51 -03:00
Emilio Tagua
523f98099d Remove more warnings on AP. 2010-09-28 18:01:48 -03:00
Emilio Tagua
059d609a1a Avoid more uninitialized variable warnings. 2010-09-28 15:46:30 -03:00
Emilio Tagua
adcc5e11fe @selected may not be defined here, avoid warning. 2010-09-28 15:29:40 -03:00
Emilio Tagua
1ab2ab07b5 Remove more warnings shadowing outer local variable. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-27 16:43:17 -03:00
Emilio Tagua
50decfbc0e _routes must be inside @controller conditional. 2010-09-27 11:19:24 -03:00
Emilio Tagua
c2940a6bf4 Refactor method to avoid warnings and not run unnecessary code. 2010-09-27 11:19:24 -03:00
Emilio Tagua
583ddf22a2 Remove more warnings shadowing outer local variable. 2010-09-27 11:19:22 -03:00
Emilio Tagua
24ef32fe93 Ask is @controller is defined to avoid warning. 2010-09-27 11:19:21 -03:00
Joost Baaij
4b14de72e1 The call-seq directive has no useful effect on our documentation and is not used anywhere else. 
Worse still, its use breaks some rdoc, replacing method names with a curly brace.
Having just one call-seq directive doesn't add anything since this is covered by regular rdoc.
Having multiple might make sense, but these are already documented with examples.

This partly re-reverts 60de0e56b7 but does not
touch the vendorized code in html-scanner.
 2010-08-28 00:50:50 +02:00
Xavier Noria
27d42a56b9 Revert "call-seq directive makes rdoc cry and replaces method names with a curly brace; besides it doesn't add anything when you only list one call example since this is obviously documented already" 
Reason: Part of this commit touches vendorized stuff, the rest is fine, could you please repatch?

This reverts commit 60de0e56b7.
 2010-08-27 23:30:52 +02:00
Joost Baaij
4a56f8f314 escape constants that should not be linked to 2010-08-27 22:47:11 +02:00
Joost Baaij
60de0e56b7 call-seq directive makes rdoc cry and replaces method names with a curly brace; besides it doesn't add anything when you only list one call example since this is obviously documented already 2010-08-27 22:20:53 +02:00
Andrew White
7c9bf45b0d Support routing constraints in functional tests 
Extend assert_recognizes and assert_generates to support passing
full urls as the path argument. This allows testing of routing
constraints such as subdomain and host within functional tests.

[#5005 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-20 14:51:25 -03:00
José Valim
c3c349ec3e Remove assert_valid. It was already deprecated on Rails 2.3. 2010-07-19 22:35:17 +02:00
Paco Guzman
ec37452f68 Remove unused variable on assert_recognizes [#4912 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 17:37:18 +02:00
Josh Kalderimis
dad71c6099 removed 'unless const_defined?' code smell 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-21 23:34:45 +02:00
Evgeniy Dolzhenko
ccf9577aee Fix a bunch of minor spelling mistakes 2010-06-11 14:15:34 +04:00
wycats
d6953cbfd3 regular expressions are usually ASCII-encoded, so force_encoding the content of a Node to the encoding of the regular expression is wrong. 2010-06-07 18:06:08 -04:00
Paco Guzman
cdf700147c fix assert_select messages to its declaration behaviour 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-15 16:31:36 +02:00
Santiago Pastorino
961aa70e4a Some require indifferent_access added 
Signed-off-by: Xavier Noria <fxn@ubuntu.(none)>
 2010-04-21 07:45:29 -07:00
Joshua Peek
cdf8c35ffd Consistent routing language 2010-03-30 14:05:42 -05:00
Joshua Peek
17f0c1e9e8 Fix stack overflow bug in integration test router helpers 2010-03-30 13:58:18 -05:00
Carlhuda
a5d80f84d2 Each controller class has it's own view context subclass. This removes the need for ActionView::Base.for_controller 2010-03-18 18:14:54 -07:00
Carlhuda
71c9337f45 All tests pass without memoizing view_context 2010-03-18 15:52:43 -07:00
Carlhuda
947f86c699 Modify assert_template to use instrumentation 2010-03-17 14:29:18 -07:00
Carl Lerche
23b6def0eb Do not always include the named URL helpers into AC::Base and AV::Base. 2010-03-16 15:47:49 -07:00
Jeremy Kemper
9f83cdc38e No longer add missing leading / on path args to assert_redirected_to. Deprecated in 2.3.6. 2010-03-02 14:16:25 -08:00
Yehuda Katz
3f0ed205e7 Remind us that RoutingAssertions should work in an integration context 2010-02-26 22:47:36 -08:00
Carlhuda
ab0cc7286f Setting UrlFor in with_routing is no longer needed now that it's not global 2010-02-26 15:56:38 -08:00
Carlhuda
98f77e0827 Rename named_url_helpers to url_helpers and url_helpers to url_for 2010-02-26 15:04:50 -08:00
Carlhuda
f863045c45 Rename metaclass to singleton_class 2010-02-25 17:56:58 -08:00
Carlhuda
fc4582fb66 Final pass at removing the router from a global constant 2010-02-25 17:53:29 -08:00
Carlhuda
226dfc2681 WIP: Remove the global router 2010-02-25 17:53:00 -08:00
Martin Schürrer
6bc24d40d5 Use ActionDispatch::Routing everywhere 2010-02-21 13:43:51 -08:00
Pratik Naik
dba196cb7f Merge docrails 2010-01-17 03:26:20 +05:30
José Valim
0cf190001e Remove CGI.escape in function of Rack::Mount.escape 2010-01-06 00:33:17 +01:00
Joshua Peek
8ff4faf66a assert_template depends on AV::Template monkey patches in action_view/test_case 2010-01-05 11:48:06 -06:00
Joshua Peek
b1aee9f4ee All AD modules are "deferrable" 2009-12-22 17:11:21 -06:00
Joshua Peek
a1bf2f96ce AD::StatusCodes support is now part of rack 2009-12-22 16:08:03 -06:00
Joshua Peek
5f8e48cbd2 Move route reloading into railties 2009-12-14 17:54:41 -06:00
Joshua Peek
ee395fe626 TestProcess belongs in AD 2009-12-12 18:09:44 -06:00
Joshua Peek
2f90d70049 Kill RouteSet#recognize 2009-12-10 23:45:04 -06:00
Jon Wood
271baf235d Add :redirect to the testable RJS statements [#2612 state:resolved] 
Example :
  assert_select_rjs :redirect, root_path

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2009-08-09 02:00:15 +01:00
Jeremy Kemper
249d9a6606 Depend on Hash#diff extension 2009-05-30 11:59:17 -07:00
Joshua Peek
11af089cee Extract ActionController rescue templates into Rescue and ShowExceptions middleware. 
This commit breaks all exception catching plugins like ExceptionNotifier. These plugins should be rewritten as middleware instead overriding Controller#rescue_action_in_public.
 2009-05-02 23:02:22 -05:00
Joshua Peek
3900f4007e Deprecate assert_redirect_to's partial hash matching 2009-05-02 14:23:44 -05:00
Joshua Peek
7b3b7cb2ab Move generic assertions into ActionDispatch 2009-04-30 11:55:53 -05:00