github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-08 21:25:19 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,222 Commits 34 Branches 105 Tags
1c71a5d25fff323eef25ca3f744151e59c1ee86b
Commit Graph

913 Commits

Author SHA1 Message Date
Jamis Buck
da18193d5f More consistent implementation of filter replacement (thanks Martin! closes #5949) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5331 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-21 16:55:14 +00:00
Rick Olson
1d7196b552 Force *_url named routes to show the host in ActionView [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-20 18:00:20 +00:00
David Heinemeier Hansson
f366eb4b2d GET parameter keys can be escaped too [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5318 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-17 22:06:54 +00:00
Jamis Buck
2d33676691 Fix deprecation warnings when rendering the template error template. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5315 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 19:59:46 +00:00
Nicholas Seckar
03b383853d Fix routing to correctly determine when generation fails. Closes #6300. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5314 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 19:52:21 +00:00
Jamis Buck
b5ec0fe313 Fix broken assert_generates when extra keys are being checked. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5309 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 14:32:11 +00:00
Jamis Buck
39963b4b9d remove an obsolete #dup call. avoid double negatives, to make the code easier to understand and explain 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5304 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-15 03:11:08 +00:00
Jamis Buck
ef6921628d make sure filters in subclasses with :only or :except conditions are treated like skip_filter calls 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5301 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-14 01:54:42 +00:00
Marcel Molina
065908a4c5 Make page caching respect the format of the resource that is being requested even if the current route is the default route so that, e.g. posts.rss is not transformed by url_for to '/' and subsequently cached as '/index.html' when it should be cached as '/posts.rss'. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5289 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-12 23:29:04 +00:00
Nicholas Seckar
214d236e7d Install named routes into ActionView::Base instead of proxying them to the view via helper_method. Closes #5932. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5283 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-11 04:31:57 +00:00
Nicholas Seckar
bbcd508d64 Fix typo 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5278 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 22:54:53 +00:00
Jamis Buck
02dc646d55 Fix relative URL root matching problems 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5272 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 19:14:11 +00:00
Jeremy Kemper
eaae0399ad r5540@ks: jeremy | 2006-10-08 23:05:30 -0700 
#5949
 r5541@ks:  jeremy | 2006-10-08 23:07:08 -0700
 Fix filter skipping in controller subclasses.
 r5557@ks:  jeremy | 2006-10-08 23:11:24 -0700
 Update changelog.  Closes #5949, references #6297, references #6299.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5268 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 06:11:40 +00:00
Jeremy Kemper
a307b8c7dc render_text may optionally append to the response body. render_javascript appends by default. This allows you to chain multiple render :update calls by setting @performed_render = false between them (awaiting a better public API). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:26:35 +00:00
David Heinemeier Hansson
f9650a23f0 Fixed that caches_action breaks with file extensions (closes #6257) [Catfish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:56:13 +00:00
David Heinemeier Hansson
31d3048706 Fixed that rescue template path shouldn't be hardcoded, then it's easier to hook in your own (closes #6295) [mnaberez] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5243 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:40:05 +00:00
David Heinemeier Hansson
2e766b159f Fixed that some 500 rescues would cause 500's themselves because the response had not yet been generated #6329 [cmselmer] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5241 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:21:47 +00:00
David Heinemeier Hansson
3c6b7a2191 Fixed that assert_select selects the wrong tag by its contents (closes #6332) [jgarber] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5240 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:20:31 +00:00
David Heinemeier Hansson
717e26dd0e Deprecation cleanup for rescues (closes #6339) [adam] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5239 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:17:11 +00:00
Jeremy Kemper
7ea86773a9 r5515@ks: jeremy | 2006-10-08 13:24:42 -0700 
#6281
 r5516@ks:  jeremy | 2006-10-08 13:29:49 -0700
 respond_to :html doesn't assume .rhtml. Closes #6281.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5232 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-08 20:30:24 +00:00
Jeremy Kemper
8cb0079fea add response to list of deprecated instance variables 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5221 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-02 22:36:02 +00:00
Jeremy Kemper
297ac55b29 use instance vars in rescue templates since controller may not be instantiated yet 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5217 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-02 16:32:51 +00:00
Rick Olson
3010e30f0e Fixed some deprecation warnings in ActionPack [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5212 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-30 01:38:22 +00:00
Jeremy Kemper
d15d15b2c2 Deprecate @response 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5207 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 08:26:45 +00:00
Jeremy Kemper
d7b5b44a0e Deprecate @headers 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5206 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 08:12:16 +00:00
Jeremy Kemper
4f3bf6cb23 Deprecate @cookies 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5205 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 08:04:39 +00:00
Jeremy Kemper
643d17ce9e assert_select_rjs decodes escaped unicode chars since the Javascript generators encode them. Closes #6240. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5202 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 07:39:31 +00:00
Jeremy Kemper
d7674637f9 Deprecation: @request will be removed after 1.2. Use the request method instead. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5201 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 07:34:02 +00:00
Jamis Buck
c0eccc9aef modify head so that you can specify a bare status code as the first parameter 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5200 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-28 19:32:40 +00:00
Jamis Buck
b2ede64a89 Add ActionController::Base#head for rendering empty responses. Add support for symbolic status codes, as well as for having raw integer statuses expand with their default messages. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5199 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-28 19:13:55 +00:00
Rick Olson
e537de00d8 Fix bug that kept any before_filter except the first one from being able to halt the before_filter chain. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5196 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-27 04:55:44 +00:00
Jamis Buck
6a8dcc8a5b Make sure map.resources(:things, :new => { :new => :any }) correctly sets /things/new to be accessible by any method rather than creating another resource at /things/new;new 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5195 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-26 22:45:09 +00:00
Jeremy Kemper
82558186a3 whitespace 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5190 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-26 16:25:27 +00:00
Nicholas Seckar
8d809e724a Clear the cache of possible controllers whenever Routes are reloaded. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-23 17:25:06 +00:00
Jeremy Kemper
a0c677c8e6 Filters overhaul including meantime filter support for around filters. Closes #5949. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5163 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-22 03:41:03 +00:00
David Heinemeier Hansson
d137281d25 Just use the vanilla mime type string, no need for fancy lookups [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-20 20:02:41 +00:00
Nicholas Seckar
5e5b87b412 Update CGI process to allow sessions to contain namespaced models. Closes #4638. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-20 17:46:59 +00:00
Nicholas Seckar
4ae3db8366 Fix routing to respect user provided requirements and defaults when assigning default routing options (such as :action => 'index'). Closes #5950. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-20 17:45:03 +00:00
David Heinemeier Hansson
54c393f5fa Hash.create_from_xml has been renamed to Hash.from_xml, alias will exist until Rails 2.0 [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5149 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-20 09:34:29 +00:00
Jeremy Kemper
0da2357527 Rescue Errno::ECONNRESET to handle an unexpectedly closed socket connection. Improves SCGI reliability. Closes #3368, closes #6226. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5146 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-18 23:52:03 +00:00
David Heinemeier Hansson
caa8a00520 Added that respond_to blocks will automatically set the content type to be the same as is requested [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5131 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-17 18:10:25 +00:00
David Heinemeier Hansson
2caf4d5a93 Added proper getters and setters for content type and charset [DHH] Added utf-8 as the default charset for all renders. You can change this default using ActionController::Base.default_charset=(encoding) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5129 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-17 16:20:32 +00:00
Jeremy Kemper
35ffc1afbe Declare file extensions exempt from layouts. Closes #6219. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-16 01:31:17 +00:00
Jeremy Kemper
3d3ba58dbb remove implicit primary actions - more pain than gain. test collection actions for other http methods. strip whitespace. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-14 19:53:04 +00:00
Rick Olson
6dbac689a8 Add chained replace/update support for assert_select_rjs [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5110 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-14 17:50:46 +00:00
David Heinemeier Hansson
73a8d7393f Make sure that formatted routes for all verbs are created. Still needs to resolve two failing tests after this refactoring [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5096 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-13 04:04:19 +00:00
Jeremy Kemper
7661c2b50a Skip params with empty names, such as the &=Save query string from <input type=submit/>. Closes #2569. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-12 20:57:09 +00:00
Jamis Buck
3f0952d9df Fix assert_tag so that :content => "foo" does not match substrings, but only exact strings. Use :content => /foo/ to match substrings. closes #2799 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5086 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-10 02:51:38 +00:00
Jeremy Kemper
f1b639cffb Update descriptive messages for exceptions thrown by cgi_methods. Closes #6103. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5070 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-08 07:25:14 +00:00
Nicholas Seckar
9d9ac01c7d Add descriptive messages to the exceptions thrown by cgi_methods. Closes #6091. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5066 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 20:10:14 +00:00