Commit Graph

99 Commits

Author SHA1 Message Date
Jeremy Kemper
ce99c87551 Cope with missing content type and length headers. Parse parameters from multipart and urlencoded request bodies only. Accept multipart PUT parameters. Closes #5235.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4388 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-01 00:01:48 +00:00
Michael Koziarski
ff96498848 performance enhancement for previous patch [skaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4344 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-16 21:09:41 +00:00
Michael Koziarski
d153525c53 Fix NoMethodError when parsing params like &&. [Adam Greenfield]. Closes #4955
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4343 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-16 20:56:41 +00:00
Jamis Buck
79a82e3a97 Make sure xml_simple requests don't blow up if an empty request body is recieved
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3936 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 18:56:19 +00:00
Jamis Buck
459559a8bc XML-formatted requests are typecast according to "type" attributes for :xml_simple
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 05:07:27 +00:00
Jamis Buck
1340eb1a7e Be sure to look at array elements when dasherizing keys of a formatted request
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-17 23:15:20 +00:00
Jamis Buck
2429074075 Underscore dasherized keys in formatted requests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3878 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-15 21:46:41 +00:00
Jamis Buck
4ba5aa257b use "mime_type" instead of "format"
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3874 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-15 18:04:24 +00:00
David Heinemeier Hansson
de37f7df4f Mime types are separated by a comma, not semicolon, in the Accept header. Also switch all internal configuration of mime types away from strings and over to Mime::Type [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3847 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-12 16:03:44 +00:00
David Heinemeier Hansson
6fd737b76b Proper options for XmlSimple
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3808 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-07 04:52:49 +00:00
David Heinemeier Hansson
dc4b5cff39 XmlSimple _should_ be the default since XmlNode is not compatible with regular parameters -- also known as Why Did My Etech Demo Not Work? [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3806 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-07 04:42:13 +00:00
Tobias Lütke
0635f633cc ActionController::Base.param_parsers now accept symbols. currently supported are :xml_node, :xml_simple and :yaml
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3778 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 19:16:55 +00:00
Tobias Lütke
03d37a2d68 Added new infrastructure support for REST webservices.
By default application/xml posts are handled by creating a XmlNode object with the same name as the root element of the submitted xml. M$

 ActionController::Base.param_parsers['application/atom+xml'] = Proc.new do |data|
    node = REXML::Document.new(post)
   { node.root.name => node.root }
 end

 XmlSimple and Yaml web services were retired, ActionController::Base.param_parsers carries an example which shows how to get this functio$
 request.[formatted_post?, xml_post?, yaml_post? and post_format] were all deprecated in favor of request.content_type [Tobias Luetke]

Closes #4081


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3777 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 18:59:58 +00:00
Marcel Molina
489ace60fb Remove Upload Progress. Closes #2871.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3406 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-13 04:27:53 +00:00
Sam Stephenson
ede2a222ee Strip out trailing &_= for raw post bodies #2868
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3137 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-21 08:04:28 +00:00
Jeremy Kemper
08fd13d17c Handle cookie parsing irregularity for certain Nokia phones. Closes #2530.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-11-15 07:51:09 +00:00
Nicholas Seckar
0b1abc3360 Undo condition change made in [2345] to prevent normal parameters arriving as StringIO.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2379 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-27 23:39:56 +00:00
Jeremy Kemper
17d2732b1c Ticket #2295 - Tolerate consecutive delimiters in query parameters
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2375 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-27 22:23:37 +00:00
Jeremy Kemper
9852197f83 r3573@asus: jeremy | 2005-09-26 11:38:44 -0700
Ticket 1507 - IE file uploads give the filename as a full Windows path, but Ruby on UNIX doesn't know how to File.basename('C:\\blah\blah.foo').
 r3574@asus:  jeremy | 2005-09-26 14:32:11 -0700
 Get rid of constant redefine warning.
 r3575@asus:  jeremy | 2005-09-26 14:33:07 -0700
 Override the file upload's original_filename singleton method in CGIMethods.get_typed_value.
 r3576@asus:  jeremy | 2005-09-26 14:33:49 -0700
 Unit test overridden original_filename against normal filenames and full Windows paths.
 r3577@asus:  jeremy | 2005-09-26 14:33:57 -0700
 Update change log.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2345 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-26 17:59:46 +00:00
David Heinemeier Hansson
b37d7a70f9 Speed up cookie use by decreasing string copying #2194 [skae]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-15 05:30:56 +00:00
Nicholas Seckar
689cca132a Performance improvements to CGI methods. Closes #1980
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-08 11:28:54 +00:00
Jamis Buck
89550ee7e9 Use chop! instead of chop! for efficiency
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2109 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 18:01:26 +00:00
Jamis Buck
62ec1a5373 Drop trailing \000 if present on RAW_POST_DATA (works around bug in Safari Ajax implementation) #918
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2106 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 14:40:33 +00:00
David Heinemeier Hansson
eddd7c453b Fix that env_qs might be nil
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1907 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 09:18:16 +00:00
David Heinemeier Hansson
d554227411 Fix that env_qs might be nil
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1906 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 09:16:35 +00:00
David Heinemeier Hansson
b366dbd952 Improved performance with 5-30% through a series of Action Pack optimizations #1811 [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 09:00:05 +00:00
David Heinemeier Hansson
128e352614 Fixed that hashes was not working properly when passed by GET to lighttpd #849 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 19:21:48 +00:00
Jamis Buck
fcdcd9b9fa Hashes sent via multipart post should be converted to strings #1032 [me@julik.nl]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1664 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 15:31:37 +00:00
David Heinemeier Hansson
5651a69130 Load models and frequency typo on upoad progress #1555 [Sean Treadway]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-01 08:31:30 +00:00
David Heinemeier Hansson
beffb77e05 Added support for upload progress indicators in Apache and lighttpd 1.4.x (won't work in WEBrick or lighttpd 1.3.x) #1475 [Sean Treadway]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1553 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-28 17:44:16 +00:00
David Heinemeier Hansson
62ed6950c9 Added support for upload progress indicators in Apache and lighttpd 1.4.x (won't work in WEBrick or lighttpd 1.3.x) #1475 [Sean Treadway]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1552 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-28 17:42:51 +00:00
David Heinemeier Hansson
a895be0259 Fixed query parser to deal gracefully with equal signs inside keys and values #1345 [gorou]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:42:49 +00:00
Jamis Buck
f6ec9e3d66 Arrays sent via multipart posts are converted to strings #1032 [dj@omelia.org]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-10 12:21:25 +00:00
Jamis Buck
f8542a64b3 Make sure the benchmarking render method always returns the result of the render, regardless of whether logging is enabled or not.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1371 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 09:00:46 +00:00
David Heinemeier Hansson
db11abbfba Added support for POST data in form of YAML or XML, which is controller through the POST_DATA_MARSHAL header
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1303 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-14 08:36:19 +00:00
David Heinemeier Hansson
ac44be3494 Treat all request types as upper-case so the switch will work
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1283 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-04 10:46:33 +00:00
David Heinemeier Hansson
8b2598bb64 Made it default to assuming a GET request and reading from command-line only in case of the new CMD method
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1282 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-04 09:39:41 +00:00
David Heinemeier Hansson
e9681eb9c5 Added graceful handling of PUT, DELETE, and OPTIONS requests for a complete coverage of REST functionality #1136 [joshknowles@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1208 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-18 14:15:26 +00:00
David Heinemeier Hansson
bf1bcff2bd Fixed that an exception would be thrown when an empty form was submitted #1090 [jan@ulbrich-boerwang.de]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 04:50:54 +00:00
David Heinemeier Hansson
93e361e58a Fixed that on very rare occasions, webrick would raise a NoMethodError: private method 'split' called for nil #1001 [Flurin Egger]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1045 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-31 11:46:50 +00:00
David Heinemeier Hansson
216b1b7897 Fixed "bad environment variable value" exception caused by Safari, Apache, and Ajax calls #918
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1018 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-27 00:10:53 +00:00
David Heinemeier Hansson
b8e4c78abb Fixed that query params could be forced to nil on a POST due to the raw post fix #562 [moriq@moriq.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@526 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-07 14:23:19 +00:00
David Heinemeier Hansson
098fa94356 Fixed documentation snafus #575, #576, #577, #585
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@525 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-02-07 14:15:53 +00:00
David Heinemeier Hansson
2f11b7cfee Added @request.raw_post as a convenience access to @request.env['RAW_POST_DATA'] and fixed the patch problems with the session #534 [Tobias Luetke]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@502 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-25 11:15:26 +00:00
David Heinemeier Hansson
bbd3e39668 Fixed no-binding fragment caching
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-20 17:54:06 +00:00
David Heinemeier Hansson
dfed3d309e A few missing files
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@468 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-01-20 14:55:13 +00:00
David Heinemeier Hansson
5d0f633239 Moved the cookies fix to cgi_ext
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@274 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-29 21:07:50 +00:00
David Heinemeier Hansson
50f333b203 Added graceful handling of non-alphanumeric names and misplaced brackets in input parameters [bitsweat]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@39 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-12-01 12:57:16 +00:00
David Heinemeier Hansson
db045dbbf6 Initial
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-11-24 01:04:44 +00:00