github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
13,504 Commits 34 Branches 105 Tags
21dcbb17de86b92df1a67e233fdc457be4fdf2d7
Commit Graph

5161 Commits

Author SHA1 Message Date
José Valim
21dcbb17de Ensure json is loaded before using responders. 2010-03-17 23:09:28 +01:00
Carlhuda
6416a35f4b Remove unneeded AV::Base and AV::Template monkey-patches 2010-03-17 14:29:18 -07:00
Carlhuda
947f86c699 Modify assert_template to use instrumentation 2010-03-17 14:29:18 -07:00
Joshua Peek
13a783672a Install url helpers on module instance so they can be accessed 
globally
 2010-03-17 16:05:29 -05:00
wycats
a5587efc19 Remove some 1.9 warnings (resulting in some fixed bugs). Remaining AM warnings are in dependencies. 2010-03-17 00:20:09 -07:00
wycats
cd9ffd11e1 Eliminate warnings for AM on 1.8 2010-03-16 23:24:00 -07:00
wycats
c738812415 Another missing require 2010-03-16 21:37:54 -07:00
Joshua Peek
d69e5616e8 link_to_function is here to stay 2010-03-16 22:06:16 -05:00
wycats
55aac2c696 Fix missing require 2010-03-16 17:32:42 -07:00
wycats
7c49b1adbb Make sure options[:anchor] is correct in shorthand cases 2010-03-16 17:29:11 -07:00
Santiago Pastorino
0c1ac36ccb scope_key_by_partial fix for Ruby 1.9 when there's virtual_path [#4202 state:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-16 16:20:10 -07:00
Carl Lerche
23b6def0eb Do not always include the named URL helpers into AC::Base and AV::Base. 2010-03-16 15:47:49 -07:00
Carl Lerche
3abf5ad7f8 Make RouteSet#finalize! a NOOP if it's been called already. Call finalize! the first time call() and url_for() are called if the RouteSet has not been finalized yet. 2010-03-16 15:47:48 -07:00
José Valim
56fb60ebfe Fix rendering of HTML partials inside JS templates [#4197 status:resolved] 2010-03-16 23:36:29 +01:00
Santiago Pastorino
12bf636461 translation method of TranslationHelper module returns always SafeBuffer [#4194 status:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-16 13:49:13 -07:00
Xavier Noria
9659d18c9b adds tests for #flush_output_buffer 
[#4196 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-16 13:16:44 -07:00
Xavier Noria
986cac73e3 adds tests for #capture 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-16 13:10:54 -07:00
Carlhuda
c61ed70b00 Some more tweaks on <% %>. 
* The cache helper is now semantically "mark this region for caching"
  * As a result, <% x = cache do %> no longer works
 2010-03-16 11:43:04 -07:00
Santiago Pastorino
e13c179499 Change array entries to safe doesn't worth then the array is joined as a string losing the safe property of his entries [#4134 status:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-03-16 11:10:31 +01:00
Jeremy Kemper
b65b989725 Break a window :/ 2010-03-15 23:49:35 -07:00
Jeremy Kemper
748c78ffc8 RJS may cache an array 2010-03-15 23:48:32 -07:00
Jeremy Kemper
b3b6ff48df Fix link_to with block 2010-03-15 23:26:48 -07:00
Jeremy Kemper
9e1e95f70a link_to_remote -> link_to :remote => true 2010-03-15 23:05:12 -07:00
Jeremy Kemper
b9c48f519f Swear I ran this test 2010-03-15 22:44:49 -07:00
Jeremy Kemper
2a50eabf45 Integration test url options should account for :protocol not just https? 2010-03-15 19:52:41 -07:00
José Valim
8dd731bc50 Move more normalization up to the lookup context, so it does not have to repeat in every resolver. 2010-03-16 02:09:16 +01:00
Jeremy Kemper
1f5e2f2bad Revert "Reinstate old default_url_options method signature" 
This reverts commit 5913dd4781.
 2010-03-15 16:49:03 -07:00
Xavier Noria
c5a877f142 adds test coverage for with_output_buffer 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-15 16:30:31 -07:00
Jeremy Kemper
5913dd4781 Reinstate old default_url_options method signature 2010-03-15 15:54:37 -07:00
Carlhuda
9de83050d3 Add deprecation notices for <% %>. 
* The approach is to compile <% %> into a method call that checks whether
    the value returned from a block is a String. If it is, it concats to the buffer and
    prints a deprecation warning.
  * <%= %> uses exactly the same logic to compile the template, which first checks
    to see whether it's compiling a block.
  * This should have no impact on other uses of block in templates. For instance, in
    <% [1,2,3].each do |i| %><%= i %><% end %>, the call to each returns an Array,
    not a String, so the result is not concatenated
  * In two cases (#capture and #cache), a String can be returned that should *never*
    be concatenated. We have temporarily created a String subclass called NonConcattingString
    which behaves (and is serialized) identically to String, but is not concatenated
    by the code that handles deprecated <% %> block helpers. Once we remove support
    for <% %> block helpers, we can remove NonConcattingString.
 2010-03-15 14:50:43 -07:00
Xavier Noria
a594a22267 with_output_buffer cannot assume there's an output_buffer 
[#4182 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-15 11:26:51 -07:00
Jeremy Kemper
c937da9e2f to_str works here 2010-03-15 11:18:45 -07:00
Andrew White
96bc6bcfee Don't force singularization of singleton resource names, e.g. /preferences [#4089 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2010-03-15 09:45:29 -05:00
Jeremy Kemper
16572fd46e read_ and write_fragment cache preserve html safety yet cache strings only 2010-03-14 19:09:32 -07:00
Santiago Pastorino
d1eed89ac3 There's a Ruby issue with File.basename different versions returns different things, so we shouldn't test that 2010-03-14 14:57:45 -05:00
Santiago Pastorino
beeb02076a Making escaped things more readable 2010-03-14 12:07:15 -05:00
José Valim
3da9a08a73 Optimize DetailsKey generation. 2010-03-14 10:25:29 +01:00
José Valim
4ba334c0f4 Ensure controller filters are executed before stuff starts to happen. 2010-03-13 21:28:34 +01:00
José Valim
ee4c89627a Remove formats setters from render template, speeding up partial and collection renderings. 2010-03-13 09:15:13 +01:00
Denis Odorcic
e484d4ae56 Made asset_tag_helper use config.perform_caching instead of ActionController::Base.perform_caching 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-03-12 21:33:39 +01:00
José Valim
f2c0a353ae Finish cleaning up rendering stack from views and move assigns evaluation to controller (so plugins and/or controllers can overwrite just one method). 2010-03-12 20:39:53 +01:00
José Valim
2a12686832 Allow anything that responds to render to be given as :template and use find_template instead of find in views. 2010-03-12 14:25:10 +01:00
José Valim
4840acd485 %= works for content_tag and does not require parenthesis on method call 2010-03-12 12:08:23 +01:00
José Valim
839362fa07 Make all AP tests pass for Ruby 1.9.1. 2010-03-12 11:50:45 +01:00
Jeremy Kemper
5a7f7928a6 Fix test 2010-03-11 17:49:17 -08:00
Jeremy Kemper
47bc138fc1 Write strings to fragment cache, not outputbuffers 2010-03-11 17:43:29 -08:00
Jeremy Kemper
698312de87 Delegate #encoding to SafeBuffer too 2010-03-11 17:42:27 -08:00
Eaden McKee
b27376773e simplify alt tag generation for images 
[#2837 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-11 17:33:41 -08:00
Carl Lerche
8b4dca109a ActionController::Base.request_forgery_protection_token should actually be the name of the token and not true. 2010-03-11 10:08:18 -08:00
José Valim
6c027443b0 Add tests for lookup context. 2010-03-11 13:23:14 +01:00