Commit Graph

870 Commits

Author SHA1 Message Date
Jeremy Kemper
3d3ba58dbb remove implicit primary actions - more pain than gain. test collection actions for other http methods. strip whitespace.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-14 19:53:04 +00:00
Rick Olson
6dbac689a8 Add chained replace/update support for assert_select_rjs [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5110 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-14 17:50:46 +00:00
David Heinemeier Hansson
73a8d7393f Make sure that formatted routes for all verbs are created. Still needs to resolve two failing tests after this refactoring [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5096 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-13 04:04:19 +00:00
Jeremy Kemper
7661c2b50a Skip params with empty names, such as the &=Save query string from <input type=submit/>. Closes #2569.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-12 20:57:09 +00:00
Jamis Buck
3f0952d9df Fix assert_tag so that :content => "foo" does not match substrings, but only exact strings. Use :content => /foo/ to match substrings. closes #2799
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5086 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-10 02:51:38 +00:00
Jeremy Kemper
f1b639cffb Update descriptive messages for exceptions thrown by cgi_methods. Closes #6103.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5070 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-08 07:25:14 +00:00
Nicholas Seckar
9d9ac01c7d Add descriptive messages to the exceptions thrown by cgi_methods. Closes #6091.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5066 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-07 20:10:14 +00:00
Nicholas Seckar
00685ad8fd Update UrlWriter to support :only_path.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-06 22:21:36 +00:00
David Heinemeier Hansson
951b4d2799 Still need the regular assertions
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5028 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-05 23:04:14 +00:00
David Heinemeier Hansson
bd09d9aafb caller is necessary for proper trace in deprecation
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5021 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-05 22:08:33 +00:00
David Heinemeier Hansson
9598176390 Better bundling of new assertions and make integration tests work again
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5020 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-05 21:28:22 +00:00
David Heinemeier Hansson
40c86a7bda Documentation for routes (closes #5165) [rramdas@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5000 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:34:19 +00:00
David Heinemeier Hansson
40762a4873 Fixed default routing NoMethodError downcase for nil when default controller provided (closes #5400) [kajism@yahoo.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4998 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:09:15 +00:00
David Heinemeier Hansson
939017487d Update usage notes to verify
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4996 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 19:42:10 +00:00
David Heinemeier Hansson
fc901e6f5d Doc fix (closes #6023)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4988 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 16:47:48 +00:00
David Heinemeier Hansson
653bfe9600 Dont raise deprecation warning on render :action => "stuff"
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4975 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:24:08 +00:00
Jeremy Kemper
96c45a8118 Don't use deprecated render API. Cosmetics.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4973 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:07:26 +00:00
Jeremy Kemper
2dd5820280 silence deprecation warnings. cosmetics.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4969 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 04:58:08 +00:00
Jeremy Kemper
29f04510e9 pass caller to deprecation warning
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4965 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 03:36:13 +00:00
Jeremy Kemper
c3a52523ce Active Record integration deprecation tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4962 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 03:07:17 +00:00
David Heinemeier Hansson
3558322b9d Changed that uncaught exceptions raised any where in the application will cause RAILS_ROOT/public/500.html to be read and shown instead of just the static "Application error (Rails)" [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4955 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 23:51:34 +00:00
Jeremy Kemper
71dbef6d27 Integration tests: thoroughly test ActionController::Integration::Session. Closes #6022.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4954 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 23:34:57 +00:00
David Heinemeier Hansson
8ca3f34db1 Docs and deprecation
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4953 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 23:28:54 +00:00
David Heinemeier Hansson
6d88a992b5 Added deprecation language for in_place_editor and auto_complete_field that both pieces will become plugins by Rails 2.0 [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4952 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 23:22:24 +00:00
David Heinemeier Hansson
0f956d1d6d Deprecated all of ActionController::Dependencies. All dependency loading is now handled from Active Support [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4948 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 23:08:43 +00:00
David Heinemeier Hansson
5048aa9831 Deprecated old render parameter calls
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4947 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 23:02:56 +00:00
David Heinemeier Hansson
315603e2be Backout of blowup fix
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4945 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 22:46:16 +00:00
David Heinemeier Hansson
4bd444c1fe More deprecation fun
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4943 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 22:35:31 +00:00
David Heinemeier Hansson
761f1f1f3a Deprecate deprecated assertions
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4938 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 20:36:51 +00:00
David Heinemeier Hansson
d52b4a6645 Moved in deprecated assertions and remove duplicated requires
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4935 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 20:27:48 +00:00
David Heinemeier Hansson
a4bef314fe Follow proper naming conventions
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 20:22:47 +00:00
David Heinemeier Hansson
f12fdc50a6 Better compartmentalizing of assertions
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4931 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 20:18:06 +00:00
David Heinemeier Hansson
3142502964 Added assert_select* for CSS selector-based testing (deprecates assert_tag) #5936 [assaf.arkin@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4929 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 19:54:21 +00:00
Jeremy Kemper
db9be58719 Cleanup assert_tag :children counting. Closes #2181.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 16:40:01 +00:00
Rick Olson
ad63005cdd Update routing documentation. Closes #6017 [Nathan Witmer]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4908 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-02 20:43:29 +00:00
Jeremy Kemper
7aa9eed88f Deprecation: update docs. Closes #5998.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4898 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-01 23:37:10 +00:00
Jeremy Kemper
9c99be88b2 Integration tests: headers beginning with X aren't excluded from the HTTP_ prefix, so X-Requested-With becomes HTTP_X_REQUESTED_WITH as expected.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4892 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-01 02:25:29 +00:00
David Heinemeier Hansson
e278b72bf3 Fixed a few find_alls
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-31 23:38:03 +00:00
Jeremy Kemper
12ff554cd4 Tighten rescue clauses. Closes #5985.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4885 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-31 03:16:28 +00:00
Jeremy Kemper
785e1fa599 Fix send_data documentation typo. Closes #5982.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4884 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-31 03:07:38 +00:00
Nicholas Seckar
d34a346d9d Switch to using FormEncodedPairParser for parsing request parameters.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4866 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-30 05:50:02 +00:00
Tobias Lütke
ff063d700d respond_to .html now always renders #{action_name}.rhtml so that registered custom template handlers do not override it in priority.
Custom mime types require a block and throw proper error now.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4860 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-30 00:34:36 +00:00
David Heinemeier Hansson
d164d09649 FormEncodedStringParser needs a tad more work before it can handle POST data (like file handling), so were backing out for a bit
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-28 14:05:05 +00:00
Jeremy Kemper
9f8b8f5ca8 Typo in integration app session. Closes #5864.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4825 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-26 06:54:26 +00:00
David Heinemeier Hansson
7b34d0f8c5 Actually, indifferent access mattered in the bowels (hashes hidden in arrays)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4823 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-26 03:09:32 +00:00
David Heinemeier Hansson
a78519071c Result is made indifferent on the way out
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4822 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-26 02:58:55 +00:00
David Heinemeier Hansson
04fda65306 Changed the POST parameter processing to use the new QueryStringParser and make the result a indifferent hash [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4821 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-26 02:49:09 +00:00
Nicholas Seckar
3b1972a896 Add UrlWriter to allow writing urls from Mailers and scripts.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4814 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-24 06:15:01 +00:00
Jeremy Kemper
d65a8f6e9e map.resources docs typo closes #5895
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4812 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-24 01:52:23 +00:00
Jeremy Kemper
04d2d5f288 Correct example in cookies docs. Closes #5832.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4793 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-20 05:28:47 +00:00