Joshua Peek
ead93c5be5
Move Flash into middleware
2010-01-15 14:55:13 -06:00
Joshua Peek
3eaf525213
Make HEAD method masquerade as GET so requests are routed correctly
2010-01-15 12:38:50 -06:00
José Valim
8b9bff9557
Small tweaks in ActionController subscriber messages format.
2010-01-15 12:24:31 +01:00
José Valim
8c8942ed4f
Move Dispatcher setup to Railties and add instrumentation hook.
2010-01-15 12:24:30 +01:00
Joshua Peek
be968ecd8b
Respect resources_path_names and :path_names options in new dsl
2010-01-13 20:26:01 -06:00
Joshua Peek
0f51e45307
optimise_named_routes is unnecessary
2010-01-13 20:22:53 -06:00
José Valim
f921ad5c97
Tidy up ActiveRecord and Views runtime information on process action logger.
2010-01-14 01:07:03 +01:00
José Valim
01839834fd
ControllerRuntime tests also use Rails::Subscriber::TestHelper.
2010-01-13 01:19:24 +01:00
José Valim
b0d35ad00c
Test fragment/page cache and send data/file notifications.
2010-01-13 01:19:24 +01:00
José Valim
da5978c223
Add subscriber for ActionPack and move all logging inside it.
2010-01-13 01:19:23 +01:00
José Valim
d2e7c1b97d
Raise an error if respond_with is invoked and no format is declared.
2010-01-10 20:21:08 +01:00
José Valim
3b631df101
Ensure that segments in default_url_options also work with format specified.
2010-01-07 17:17:06 +01:00
José Valim
f149eb19d4
From now on, parameters defined in default_url_options can be absent from named routes.
...
This allows the following setup to work:
# app/controllers/application_controller.rb
class ApplicationController
def default_url_options(options=nil)
{ :locale => I18n.locale }
end
end
# From your views and controllers:
I18n.locale #=> :en
users_url #=> "/en/users"
users_url(:pl) #=> "/pl/users"
user_url(1) #=> "/en/users/1"
user_url(:pl, 1) #=> "/pl/users/1"
user_url(1, :locale => :pl) #=> "/pl/users/1"
If you provide all expected parameters, it still works as previously.
But if any parameter is missing, it tries to assign all possible ones
with the hash returned in default_url_options or the one passed straight
to the named route method.
Beware that default_url_options in ApplicationController is not shared
with ActionMailer, so you are required to always give the locale in your
email views.
2010-01-07 15:34:14 +01:00
José Valim
f564f947d9
Remove duplicated url_for code and move methods shared between ActionMailer and ActionController up to AbstractController.
2010-01-07 15:31:50 +01:00
José Valim
bd729344a7
Remove deprecated formatted named routes
2010-01-04 23:05:27 +01:00
José Valim
f2d276fefd
Ensure no notification is on the queue before running notifications related tests.
2010-01-03 23:39:09 +01:00
José Valim
6fbe9ef2ff
Use namespaces in notifications.
2010-01-03 20:39:42 +01:00
Jeremy Kemper
db49b7dc94
Fix new year heisenbug
2009-12-31 18:32:16 -08:00
José Valim
75ba102a80
Remove ActionView inline logging to ActiveSupport::Notifications and create ActionController::Base#log_event, so everything can be logged within one listener. Also expose log_process_action as a hook for different modules to include their own information during the action processing. This allow ActiveRecord to hook and any other ORM. Finally, this commit changes 'Processing' and 'Rendering' in logs to 'Processed' and 'Rendered' because at the point it's logged, everying already happened.
2009-12-26 20:28:53 +01:00
Joshua Peek
a1bf2f96ce
AD::StatusCodes support is now part of rack
2009-12-22 16:08:03 -06:00
David Heinemeier Hansson
fee07b9da0
Merge branch 'master' of github.com:rails/rails
2009-12-21 15:50:19 -08:00
Joshua Peek
f82e1046f8
reset_session needs to be a real method so flash can override it
2009-12-21 17:29:59 -06:00
David Heinemeier Hansson
c06aff0a7e
Added cookies.permanent, cookies.signed, and cookies.permanent.signed accessor for common cookie actions [DHH]
2009-12-20 14:33:13 -08:00
David Heinemeier Hansson
fa575973b1
Added alert/notice from 2-3-stable and refactored redirect_to into just living in Redirector [DHH]
2009-12-17 16:37:11 -08:00
Joshua Peek
5f8e48cbd2
Move route reloading into railties
2009-12-14 17:54:41 -06:00
Joshua Peek
ce970a8bb9
Remove route loading tests since it should be tested by railties
2009-12-14 16:52:22 -06:00
Joshua Peek
ee395fe626
TestProcess belongs in AD
2009-12-12 18:09:44 -06:00
Joshua Peek
588225f885
Remove fancy method not allowed resource exceptions since they are
...
too much of a hack
2009-12-11 00:01:22 -06:00
Joshua Peek
2f90d70049
Kill RouteSet#recognize
2009-12-10 23:45:04 -06:00
Yehuda Katz
8b9275340f
Merge branch 'master' of github.com:rails/rails
2009-12-10 13:11:15 -08:00
Carlhuda
f9d570bdd8
Simpler RenderOption API -- removes the need for registering the types and extending a module
2009-12-09 13:40:49 -08:00
Joshua Peek
9fbde11b8b
More test porting
2009-12-08 17:41:00 -06:00
Joshua Peek
2be5e088d2
Use new routing dsl in tests
2009-12-08 16:52:26 -06:00
José Valim
2ecfa817c9
Responder redirects to resource if destroy fails.
...
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local >
2009-12-07 15:05:27 -08:00
Joshua Peek
48127c637c
Deprecate recalling generation params when the defaults are nil
2009-12-06 20:40:07 -06:00
Joshua Peek
4663f75f6b
Update rackmount to fix some pending tests
2009-12-05 13:10:00 -06:00
Carlhuda
c1304098cc
Reorganize autoloads:
...
* A new module (ActiveSupport::Autoload) is provide that extends
autoloading with new behavior.
* All autoloads in modules that have extended ActiveSupport::Autoload
will be eagerly required in threadsafe environments
* Autoloads can optionally leave off the path if the path is the same
as full_constant_name.underscore
* It is possible to specify that a group of autoloads live under an
additional path. For instance, all of ActionDispatch's middlewares
are ActionDispatch::MiddlewareName, but they live under
"action_dispatch/middlewares/middleware_name"
* It is possible to specify that a group of autoloads are all found
at the same path. For instance, a number of exceptions might all
be declared there.
* One consequence of this is that testing-related constants are not
autoloaded. To get the testing helpers for a given component,
require "component_name/test_case". For instance, "action_controller/test_case".
* test_help.rb, which is automatically required by a Rails application's
test helper, requires the test_case.rb for all active components, so
this change will not be disruptive in existing or new applications.
2009-12-02 20:01:08 -08:00
Joshua Peek
4dee277a9b
Stop escaping "[]" in query string
2009-12-02 12:46:14 -06:00
Jeremy Kemper
de40bc033a
Ensure Cache-Control max-age is an integer
2009-12-02 03:23:00 -08:00
Joshua Peek
7fe19d415a
Make recognize try to constantize controller to see if it exists
2009-12-01 22:22:48 -06:00
Joshua Peek
44587b7fae
Merge branch 'master' of github.com:rails/rails
2009-12-01 14:53:39 -06:00
Joshua Peek
61a31f3d3d
Fix generating params with optional defaults [ #3404 state:resolved]
2009-12-01 14:52:19 -06:00
Jeremy Kemper
0c4990b5f4
Fix caching test to ensure notifications are all delivered
2009-12-01 12:19:42 -08:00
José Valim
6e30361260
Allow ActionController::Responder to have a common entry point for all formats.
...
Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local >
2009-12-01 08:23:43 -08:00
Jeremy Kemper
4f2a04cc08
Notifications: extract central Notifier, cordon off the internal Fanout implementation, and segregate instrumentation concerns
2009-11-28 12:50:09 -08:00
Joshua Peek
59dbae145b
Privatize Routing.possible_controllers and fix brittle url helper
...
controller test loading.
2009-11-23 21:50:21 -06:00
Joshua Peek
350d3daa88
Remove inflection reloads routes test
2009-11-23 19:25:39 -06:00
Jeremy Kemper
f8d06e62a9
Pending test now passing
2009-11-23 14:07:54 -08:00
Joshua Peek
6e67f88a11
Extended and case insensitive regexp routes aren't that important.
...
Mark them as pending till I figure it out.
2009-11-19 17:58:57 -08:00
Jeremy Kemper
0dfd993e77
Fix test bleed
2009-11-18 17:54:27 -08:00
