github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-08 05:05:04 -05:00
Code Issues Packages Projects Releases Wiki Activity
1,966 Commits 34 Branches 105 Tags
2a35baa0bb4312d95e1340074cce731afedecde0
Commit Graph

471 Commits

Author SHA1 Message Date
Jamis Buck
2a35baa0bb Wrap :conditions in parentheses to prevent problems with OR's #1871 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2324 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-24 23:58:13 +00:00
David Heinemeier Hansson
caaf40d535 Added AbstractAdapter#select_value and AbstractAdapter#select_values as convenience methods for selecting single values, instead of hashes, of the first column in a SELECT #2283 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2323 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-24 19:50:57 +00:00
David Heinemeier Hansson
66820a4aa7 Just include activerecord/schema with AR so it doesnt need to be dumped 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2322 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-24 17:50:07 +00:00
Jamis Buck
1f4dc25250 Make the sqlite adapter preserve not-null constraints and index names when altering tables 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2318 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-24 00:33:47 +00:00
Jamis Buck
11411effde Allow the postgresql adapter to work with the SchemaDumper. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2317 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-23 17:27:59 +00:00
Jamis Buck
9838a5f8b3 Post the postgresql adapter (and hopefully other adapters) pass all tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2316 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-23 15:46:04 +00:00
Jamis Buck
6d4a4a0d2e Make sqlite adapter pass all tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2315 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-23 15:00:56 +00:00
Jamis Buck
7dc45818dc Add ActiveRecord::SchemaDumper for dumping a DB schema to a pure-ruby file, making it easier to consolidate large migration lists and port database schemas between databases. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2312 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-23 13:29:33 +00:00
David Heinemeier Hansson
2d4fe31af6 Fixed migrations for Windows when using more than 10 [David Naseby] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2285 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-21 13:27:45 +00:00
David Heinemeier Hansson
66ecf31ffe Fixed that the create_x method from belongs_to wouldn't save the association properly #2042 [Florian Weber] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2279 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-20 18:36:14 +00:00
Jamis Buck
5213a1f733 Fixed saving a record with two unsaved belongs_to associations pointing to the same object #2023 [Tobias Luetke] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2278 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-20 16:12:13 +00:00
David Heinemeier Hansson
3c0129af6d Fixed memory leak with Active Record classes when Dependencies.mechanism = :load #1704 [c.r.mcgrath@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2273 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-20 10:33:26 +00:00
Nicholas Seckar
3e2bac428d Improved migrations' behavior when the schema_info table is empty. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2269 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-20 01:33:43 +00:00
David Heinemeier Hansson
6f95c49a15 Fixed that Observers didn't observe sub-classes #627 [Florian Weber] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2263 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-19 16:34:34 +00:00
Nicholas Seckar
251a5d4508 Fix eager loading error messages, allow :include to specify tables using strings or symbols. Closes #2222 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2258 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-18 20:41:44 +00:00
David Heinemeier Hansson
40b7809de5 Added check for RAILS_CONNECTION_ADAPTERS on startup and only load the connection adapters specified within if its present (available in Rails through config.connection_adapters using the new config) #1958 [skae] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-15 06:40:39 +00:00
David Heinemeier Hansson
5dbf5ded5c Only attempt to require Active Support if it hasnt been already #1959 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2247 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-15 05:34:59 +00:00
David Heinemeier Hansson
4307d7ecbe Fixed various problems with has_and_belongs_to_many when using customer finder_sql #2094 [Florian Weber] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2233 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-13 10:15:54 +00:00
David Heinemeier Hansson
a16528f715 Added dump of schema version to the db_structure_dump task for databases that support migrations #1835 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2215 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-12 05:33:18 +00:00
David Heinemeier Hansson
b646e0ddf7 Rolled back broken #1814 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2203 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 10:05:46 +00:00
David Heinemeier Hansson
c0e618cf6f Refactored to a more readble form #1813 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2202 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 10:04:37 +00:00
David Heinemeier Hansson
57070277b4 Added better exception error when unknown column types are used with migrations #1814 [fbeausoleil@ftml.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2201 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 09:41:24 +00:00
David Heinemeier Hansson
3e00e1a297 Use the inflector rules made for the purpose 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2186 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 06:25:09 +00:00
David Heinemeier Hansson
04594cfadb Fixed "connection lost" issue with the bundled Ruby/MySQL driver (would kill the app after 8 hours of inactivity) #2163, #428 [kajism@yahoo.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2182 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 05:43:46 +00:00
David Heinemeier Hansson
0faca07056 Fixed comparison of Active Record objects so two new objects are not equal #2099 [deberg] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2172 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:54:02 +00:00
David Heinemeier Hansson
3004217855 Fixed that the SQL Server adapter would sometimes return DBI::Timestamp objects instead of Time #2127 [Tom Ward] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:37:05 +00:00
David Heinemeier Hansson
0439769324 Refactored away all the legacy validate_options calls and replaced them with Hash#assert_valid_keys 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:32:47 +00:00
David Heinemeier Hansson
b063067321 Added the instance methods #root and #ancestors on acts_as_tree and fixed siblings to not include the current node #2142, #2140 [coffee2code] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2163 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:01:44 +00:00
David Heinemeier Hansson
9053c4c83e Added documentation for #1904 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2157 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 17:49:31 +00:00
David Heinemeier Hansson
febc24dee7 An explicit include ClassInheritableAttributes is no longer needed #1948 [Caleb Tennis] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 16:28:10 +00:00
David Heinemeier Hansson
eec24a16c7 Fixed that Active Record would call SHOW FIELDS twice (or more) for the same model when the cached results were available #1947 [sd@notso.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2153 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 12:21:36 +00:00
David Heinemeier Hansson
f2a89d7862 Give AR the new benchmark method too 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2143 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 17:47:31 +00:00
David Heinemeier Hansson
f86276b305 Fix fragment benchmark calls and limit timings to 5 decimals 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 17:33:11 +00:00
David Heinemeier Hansson
5e8e8d6564 Added use_silence parameter to ActiveRecord::Base.benchmark that can be passed false to include all logging statements during the benchmark block. Added ActionController::Base.benchmark and ActionController::Base.silence to allow for easy benchmarking and turning off the log 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2140 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 16:48:18 +00:00
Jamis Buck
7a0e1bd56a Make sure the schema_info table is created before querying the current version #1903 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2105 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 14:20:20 +00:00
Jamis Buck
e3d34286e3 Fixtures ignore table name prefix and suffix #1987 [Jakob S] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2101 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 10:51:23 +00:00
Jamis Buck
bf3f920989 Add documentation for index_type argument to add_index method for migrations #2005 [blaine@odeo.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2100 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 10:07:14 +00:00
Jamis Buck
69d662051e Modify read_attribute to allow a symbol argument #2024 [Ken Kunz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2096 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 08:31:11 +00:00
Jamis Buck
7d65f7cd3d Revert [2040], caused assignment of belongs_to associations to fail in some cases 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2048 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-24 16:45:46 +00:00
Jamis Buck
dfe1aeb776 Saving a record with two unsaved belongs_to associations pointing to the same object fails #2023 [Tobias Luetke] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2040 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-23 11:05:04 +00:00
Jamis Buck
b1a4f91a58 Make destroy return self #1913 [sebastian.kanthak@muehlheim.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2011 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-14 08:58:53 +00:00
Jamis Buck
73594d88f3 Fix typo in validations documentation #1938 [court3nay] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2010 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-14 08:50:51 +00:00
Jamis Buck
85c603fc9e Make acts_as_list work for insert_at(1) #1966 [hensleyl@papermountain.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2008 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-14 08:35:08 +00:00
Jamis Buck
e17bf81823 Fix typo in count_by_sql documentation #1969 [Alexey Verkhovsky] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2007 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-14 08:20:51 +00:00
Jamis Buck
da874a4af8 Allow add_column and create_table to specify NOT NULL #1712 [emptysands@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1955 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-30 10:16:21 +00:00
Jamis Buck
369d054338 Fix create_table so that id column is implicitly added [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1949 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 17:06:22 +00:00
David Heinemeier Hansson
14ea312808 Made Oracle a first-class connection adapter by adhering closer to idiomatic Oracle style #1798 [The Gang of Oracles] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1912 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-24 14:01:35 +00:00
David Heinemeier Hansson
eb10742581 Dont be ambigious about the condition key 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1896 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 20:22:55 +00:00
David Heinemeier Hansson
34f9d30e39 Added support for calling constrained class methods on has_many and has_and_belongs_to_many collections #1764 [Tobias Luetke] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1894 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 20:05:42 +00:00
David Heinemeier Hansson
ea8f3f0a37 Added migration support for SQLite (using temporary tables to simulate ALTER TABLE) #1771 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1893 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 19:58:03 +00:00