github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-10 06:04:55 -05:00
Code Issues Packages Projects Releases Wiki Activity
6,227 Commits 34 Branches 105 Tags
2b326a7155ec74c7dad2c7adbd4356976847d411
Commit Graph

1556 Commits

Author SHA1 Message Date
Jeremy Kemper
9829212849 Ruby 1.9 compat: instance_eval binding to get the record binding instead of accidentally getting current Kernel#binding. Closes #10716 [Dirkjan Bussink] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8575 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-06 20:27:56 +00:00
Jeremy Kemper
ebe3a0d532 More thoroughly quote table names. Exposes some issues with sqlite2 adapter. Closes #10698. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8571 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-05 14:58:28 +00:00
Jeremy Kemper
139b92495f * Continue evolution toward ActiveSupport::TestCase and friends. #10679 [Josh Peek] 
* TestCase: introduce declared setup and teardown callbacks. Pass a list of methods and an optional block to call before setup or after teardown. Setup callbacks are run in the order declared; teardown callbacks are run in reverse.  [Jeremy Kemper]


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8570 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-05 13:34:15 +00:00
Jeremy Kemper
b144818698 Document that .build doesn't apply to has_many :through associations. Closes #10707 [GMFlash] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8562 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-05 02:21:25 +00:00
Jeremy Kemper
83f65594de Prefer to instantiate fixtures with model classes instead of their names, avoiding excess constant lookups. Closes #10677 [nwilmes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8561 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-05 02:20:57 +00:00
Jeremy Kemper
f42063d038 Cache fixture model class. References #10677 [nwilmes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8560 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-05 02:20:26 +00:00
Jeremy Kemper
752f633bc5 Document that eager loading doesn't work with polymorphic associations. Closes #10610 [Xavier Noria] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8556 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-04 23:21:52 +00:00
Jeremy Kemper
c36f8111a6 pdate_all ignores scoped :order and :limit, so post.comments.update_all doesn't try to include the comment order in the update statement. Closes #10686. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8554 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-04 03:19:50 +00:00
David Heinemeier Hansson
2a9ad9ccbc Moved the caching stores from ActionController::Caching::Fragments::* to ActiveSupport::Cache::*. If you're explicitly referring to a store, like ActionController::Caching::Fragments::MemoryStore, you need to update that reference with ActiveSupport::Cache::MemoryStore [DHH] Deprecated ActionController::Base.fragment_cache_store for ActionController::Base.cache_store [DHH] All fragment cache keys are now by default prefixed with the 'views/' namespace [DHH] Added ActiveRecord::Base.cache_key to make it easier to cache Active Records in combination with the new ActiveSupport::Cache::* libraries [DHH] Added ActiveSupport::Gzip.decompress/compress(source) as an easy wrapper for Zlib [Tobias Luetke] Included MemCache-Client to make the improved ActiveSupport::Cache::MemCacheStore work out of the box [Bob Cottrell, Eric Hodel] Added config.cache_store to environment options to control the default cache store (default is FileStore if tmp/cache is present, otherwise MemoryStore is used) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8546 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-03 21:05:12 +00:00
Michael Koziarski
288553540b Ruby 1.9: Forwards compatibility change for fixtures and the new CSV module [JEG2] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8544 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-03 19:14:38 +00:00
Jeremy Kemper
7b8ee2438f Ruby 1.9 compat: don't use obsolete ParseDate 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8540 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-03 02:59:03 +00:00
David Heinemeier Hansson
424c330634 Added by parameter to increment, decrement, and their bang varieties so you can do player1.increment!(:points, 5) (closes #10542) [Sam] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8534 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-03 00:30:22 +00:00
Rick Olson
0ad24df6ed Optimize ActiveRecord::Base#exists? to use #select_all instead of #find. Closes #10605 [jamesh, fcheung, protocool] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8531 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-02 21:39:49 +00:00
Jeremy Kemper
4e04ec4adb Ruby 1.9 compat: fix two failing tests since String#each has been removed. Closes #10655. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8524 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-02 09:11:39 +00:00
Jeremy Kemper
20d29b3797 Ruby 1.9 compat: introduce ActiveSupport::FrozenObjectError normalize TypeError vs RuntimeError handling. Closes #10645 [Frederick Cheung] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8510 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-29 19:43:07 +00:00
Jeremy Kemper
07392bfe87 Ruby 1.9 compat: workaround module_eval bug. Closes #10641 [Frederick Cheung] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8507 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-29 05:06:06 +00:00
Rick Olson
0e3a54a3b9 Don't unnecessarily load has_many associations in after_update callbacks. Closes #6822 [stopdropandrew, canadaduane] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8504 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-28 18:01:22 +00:00
Jeremy Kemper
0c0610d398 Use extract_options! rather than Hash test + pop. Closes #10628 [ssoroka] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8496 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-28 03:58:01 +00:00
Jeremy Kemper
57c613a601 Ruby 1.9 compat: calculations don't assume array implementation of ordered hash. References #1689 [Frederick Cheung] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8494 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-27 11:18:30 +00:00
Jeremy Kemper
f013e047ef Ruby 1.9 compat: don't modify iterator target within block 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8487 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-27 11:16:51 +00:00
Jeremy Kemper
240b4c527e Ruby 1.9 compat: attribute methods 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8486 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-27 11:16:39 +00:00
Jeremy Kemper
38f8252e2d Remove leaky unused signal handler for transactions. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8484 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-22 19:05:26 +00:00
Jeremy Kemper
8b5f4e474f Ruby 1.9 compat: fix warnings, shadowed block vars, and unitialized instance vars 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8481 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-22 11:26:03 +00:00
Jeremy Kemper
dc901ced44 Ruby 1.9 compat: Fixtures inherits Hash instead of YAML::Omap since it's now insertion-ordered. Work around a &:procname crash. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8480 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-22 08:28:57 +00:00
Jeremy Kemper
750f15bc26 Ruby 1.9 compat: Class#subclasses is now protected 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8478 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-22 04:50:12 +00:00
Jeremy Kemper
f6379bfe15 Eager belongs_to :include infers the foreign key from the association name rather than the class name. Closes #10517. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8456 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-21 01:49:01 +00:00
Jeremy Kemper
15b38efde8 Benchmark logs for any level below or equal to the one specified, rather than just equal. Closes #10580 [Dan Manges] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8455 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-21 01:48:20 +00:00
Jeremy Kemper
b72763a96f SQLite: fix rename_ and remove_column for columns with unique indexes. Closes #10576. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8453 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-20 22:28:12 +00:00
Jeremy Kemper
0b84af9599 Revert [8392]. Closes #10568, reopens #10379. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8442 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-19 21:16:27 +00:00
Jeremy Kemper
b4e3b5d418 Ruby 1.9 compat: check column type more carefully 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8439 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-19 09:31:57 +00:00
Jeremy Kemper
f91acf0258 Ruby 1.9 compat: move from the deprecated Base64 module to ActiveSupport::Base64. Closes #10554. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8433 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-18 21:14:07 +00:00
David Heinemeier Hansson
69edebf0f1 Prepare for 2.0.2 release 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8419 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-16 23:30:30 +00:00
Rick Olson
ce102e3af9 Ensure optimistic locking handles nil #lock_version values properly. Closes #10510 [rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8395 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-15 01:45:30 +00:00
Rick Olson
abd7cf343c Make the Fixtures Test::Unit enhancements more supporting for double-loaded test cases. Closes #10379 [brynary] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8392 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-15 01:23:05 +00:00
Marcel Molina
9661395d38 Remove references to nonexistent :joins documentation. Closes #10498 [tpope] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8381 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-13 19:51:44 +00:00
Marcel Molina
8945ea9ba2 Document what to pass the :accept option for validates_acceptance_of when mapping the attribute to an actual column (rather than a virtual one). Closes #10491 [xaviershay] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8379 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-13 03:33:54 +00:00
Rick Olson
d98728e091 Fix that validates_acceptance_of still works for non-existent tables (useful for bootstrapping new databases). Closes #10474 [hasmanyjosh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8377 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-12 23:55:14 +00:00
Rick Olson
66e97c34c1 Ensure that the :uniq option for has_many :through associations retains the order. #10463 [remvee] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8376 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-11 20:08:30 +00:00
Jeremy Kemper
f67add4283 Base.exists? doesn't rescue exceptions to avoid hiding SQL errors. Closes #10458. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8375 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-11 01:53:54 +00:00
Jeremy Kemper
4b055a4a6a Update destroy_all and delete_all documentation to better describe their tradeoffs. Closes #10447. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8367 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 09:12:18 +00:00
Jeremy Kemper
73673256ac Document Active Record exceptions. Closes #10444. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8362 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 04:13:33 +00:00
Jeremy Kemper
ed6949b2d7 Remove unused ConnectionFailed exception 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8361 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 03:34:05 +00:00
Jeremy Kemper
836f32cf7d Axe outdated :ar_joins commentary 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 01:48:14 +00:00
Jeremy Kemper
220a64e9b6 post.comments.reload returns the association rather than the result of load_target. Closes #10438 [Fred Cheung] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8347 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 01:07:04 +00:00
Jeremy Kemper
1542886e40 Document the validates class method. Closes #10216 [Farley Knight] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8345 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 00:47:55 +00:00
Jeremy Kemper
77de690a56 Be careful not to reference ActiveRecord if it isn't loaded, fixing rake test when you're working without a database. [eedn] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8339 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-09 04:37:46 +00:00
David Heinemeier Hansson
1acd54a5b4 Make ready for 2.0.1 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8330 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-07 13:37:13 +00:00
David Heinemeier Hansson
7f02cdd4a0 Removed query cache rescue as it could cause code to be run twice (closes #10408) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8329 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-07 13:34:06 +00:00
David Heinemeier Hansson
731ecec15e Fixed that the Query Cache should just be ignored if the database is misconfigured (so that the "About your applications environment" works even before the database has been created) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-06 22:05:48 +00:00
Jeremy Kemper
699da7001b The test task stops with a warning if you have pending migrations. Closes #10377. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8324 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-06 18:57:19 +00:00