Pratik Naik
2b69840e5e
Remove ActionController::Base#view_controller_internals
...
Get rid of ActionController::Base#view_controller_internals flag and
use @@protected_view_variables for storing the list of controller
specific instance variables which should be inaccessible inside views.
2008-04-21 03:45:38 +01:00
Paul Horsfall
14a40804a2
Add conditional options to caches_page method [ #25 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2008-04-19 16:21:34 -05:00
Pratik Naik
ef4c65088f
Move missing template logic to ActionView
2008-04-19 18:59:13 +01:00
Pratik Naik
534c6b2444
Introduce ActionView::InlineTemplate class
2008-04-19 16:21:18 +01:00
Pratik Naik
986aec5dbb
Refactor Dispatcher callbacks to remove unnecessary Dependencies checks in production environment.
2008-04-18 13:05:43 +01:00
Joshua Peek
745359a494
Stub out Dispatcher#log_failsafe_exception method to please the test gods.
2008-04-15 18:04:12 -05:00
David Heinemeier Hansson
420c4b3d88
Added Rails.public_path to control where HTML and assets are expected to be loaded from (defaults to Rails.root + "/public") #11581 [nicksieger]
2008-04-13 17:33:27 -05:00
Michael Koziarski
60be4b09f5
Merge branch 'master' into custom_paths_for_resource_names
2008-04-12 12:40:51 +12:00
Michael Koziarski
063c393bf0
Allow alternative values for the 'new' and 'edit' actions in resourceful routes.
...
map.resource :schools, :as => 'escuelas', :path_names => { :new => 'nueva' }
Closes #11181 . [ivanvr]
2008-04-12 12:40:40 +12:00
Jeremy Kemper
9a7ab8b05b
stub the instance method, there is no class method
2008-04-11 16:46:46 -07:00
David Heinemeier Hansson
e89093aeb4
Fixed that formatted_polymorphic_route should be able to take the :format as part of a single hash or as the option hash (references #8741 )
2008-04-11 12:34:44 -05:00
Rick Olson
4d594cffcf
Automatically parse posted JSON content for Mime::JSON requests. [rick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-04-08 05:05:54 +00:00
Josh Peek
917423d664
Provide a helper proxy to access helper methods from outside views. Closes #10839 [Josh Peek]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9234 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-04-06 18:42:34 +00:00
Pratik Naik
1e087fd3fd
Ensure RJS redirect_to doesn't html-escapes string argument. Closes #8546
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9212 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-04-02 12:48:59 +00:00
Jeremy Kemper
30fa377f33
Ruby 1.9 compat: encoding and multibyte test fixes
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9194 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-04-01 07:39:04 +00:00
Jeremy Kemper
ecdddc4de5
Ruby 1.9 compat: proc arity
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9190 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-04-01 06:11:56 +00:00
Jeremy Kemper
a2ad945627
style & whitespace
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9189 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-04-01 06:11:48 +00:00
Jeremy Kemper
b79f7d127a
Ruby 1.9: no args is 0 arity, not -1 as in 1.8
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9187 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-04-01 06:11:31 +00:00
Jeremy Kemper
9cc478a254
Support render :partial => collection of heterogeneous elements. Closes #11491 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9177 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-04-01 00:50:09 +00:00
Jeremy Kemper
a61b63d420
Avoid remote_ip spoofing
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9124 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-28 21:38:01 +00:00
Jeremy Kemper
5c0656c9ee
Fix layouts in symlinked paths. Closes #9136 [court3nay, caio]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9120 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-28 20:54:26 +00:00
David Heinemeier Hansson
db3a60eb92
Added support for regexp flags like ignoring case in the :requirements part of routes declarations ( closes #11421 ) [NeilW]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9115 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-28 20:01:21 +00:00
David Heinemeier Hansson
388e5d3fac
Fixed that ActionController::Base#read_multipart would fail if boundary was exactly 10240 bytes ( closes #10886 ) [ariejan]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9113 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-28 19:55:31 +00:00
David Heinemeier Hansson
c57254d449
Fixed HTML::Tokenizer (used in sanitize helper) didnt handle unclosed CDATA tags ( closes #10071 ) [esad, packagethief]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-28 19:45:32 +00:00
Rick Olson
0381398708
Fix regression from filter refactoring where re-adding a skipped filter resulted in it being called twice. [rick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9080 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-23 01:48:17 +00:00
Jeremy Kemper
f2840f508d
Fix an edge case with extra periods in Routing.normalize_paths. Closes #11337 [cavalle, veejar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9069 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-21 22:44:04 +00:00
Jeremy Kemper
856a4dcf12
Refactor filters to use Active Support callbacks. Closes #11235 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9055 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-18 17:56:05 +00:00
David Heinemeier Hansson
db08329946
Fixed that polymorphic routes would modify the input array ( closes #11363 ) [thomas.lee]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9053 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-17 23:45:42 +00:00
Rick Olson
1e0ac3a673
Fix more obscure nested parameter hash parsing bug. Closes #10797 [thomas.lee]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9020 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-13 03:22:25 +00:00
Rick Olson
3a17ea9031
Fix nested parameter hash parsing bug. #10797 [thomas.lee]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9010 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-11 07:46:39 +00:00
Pratik Naik
cff3ecc2ae
Allow using named routes in ActionController::TestCase before any request has been made. Closes #11273 [alloy]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8992 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-08 12:56:41 +00:00
Pratik Naik
011e469410
Make MimeResponds::Responder#any work without explicit types. Closes #11140 [jaw6]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8987 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-07 11:17:05 +00:00
Pratik Naik
d7627361d3
Remove unused ActionController::Base.template_class. Closes #10787
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8985 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-05 12:12:17 +00:00
Pratik Naik
a96272a0c5
Moved template handlers related code from ActionView::Base to ActionView::Template
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8981 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-05 02:03:24 +00:00
Michael Koziarski
cc5a957d2b
Allow file uploads in Integration Tests. Closes #11091 [RubyRedRick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8978 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-03 06:42:24 +00:00
Michael Koziarski
51b6619d4e
Refactor partial rendering into a PartialTemplate class. [Pratik]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-03-03 04:01:35 +00:00
David Heinemeier Hansson
7dcd0d7d96
Added that requests with JavaScript as the priority mime type in the accept header and no format extension in the parameters will be treated as though their format was :js when it comes to determining which template to render. This makes it possible for JS requests to automatically render action.js.rjs files without an explicit respond_to block [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8956 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-29 18:09:23 +00:00
Jeremy Kemper
5e83612766
Fix Hash#from_xml with Type records. Closes #9242 [Juanjo Bazan, Isaac Feliu]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8937 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-27 23:11:08 +00:00
Michael Koziarski
1537aec184
use stubbing instead of monkeypatching to stop tests from interfering with one another. Closes #11163 [RubyRedRick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8899 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-19 21:43:13 +00:00
Michael Koziarski
db4f421b0b
Add :trailing_slash option to UrlWriter. Closes #9117 [juanjo.bazan]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8892 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-18 00:42:06 +00:00
Michael Koziarski
1d5ea1857f
Sort files to test to make load order platform independent. Fix the clash this exposes. Closees #11081 [tpope]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8880 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-16 03:08:05 +00:00
Michael Koziarski
46356100d1
Make sure render :update support the options hash. Closes #11088 [ernesto.jimenez]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8862 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-12 22:42:36 +00:00
Jamis Buck
11787b802a
remove support for ampersand-delimited cookie values
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8861 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-12 21:45:39 +00:00
Marcel Molina
c848c4c621
Fix problem with render :partial collections, records, and locals. #11057 [lotswholetime]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8822 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-08 22:04:06 +00:00
Rick Olson
8e6638afa4
Fix bug with setting Request#format= after the getter has cached the value. Closes #10889 [cch1]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8811 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-07 16:46:50 +00:00
Michael Koziarski
692dbbf793
Introduce a Template class to ActionView. Closes #11024 [lifofifo]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8805 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-06 04:26:40 +00:00
Jeremy Kemper
0da2aa6d11
Introduce the :index option for form_for and fields_for to simplify multi-model forms (see http://railscasts.com/episodes/75 ). Closes #9883 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-02 06:16:04 +00:00
Jeremy Kemper
fadaba679a
Introduce map.resources :cards, :as => 'tarjetas' to use a custom resource name in the URL: cards_path == '/tarjetas'. Closes #10578 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8785 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-02 05:57:16 +00:00
Jeremy Kemper
9e1d91c24b
TestSession supports indifferent access. Closes #7372 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-02 05:32:44 +00:00
Jeremy Kemper
b84a33ddd1
Don't split cookies on comma also. References r8505.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2008-02-02 02:55:44 +00:00