Corin Langosch
2bfeda3f09
fix bug in usage example of #unscoped
2011-05-11 09:19:12 +02:00
Jon Leighton
a8c1fa4afd
Add test to specify that attributes from an association's conditions should be assigned without mass-assignment protection when a record is built on the association.
2011-05-10 23:35:15 +01:00
Jon Leighton
93a85ce333
Remove unnecessary '|| {}'
2011-05-10 23:35:15 +01:00
Jon Leighton
9a7dbe2c05
Don't use mass-assignment protection when applying the scoped.scope_for_create. Fixes #481 .
2011-05-10 22:54:40 +01:00
Vishnu Atrai
9a0e3d44d1
minor cleaning with new api method
2011-05-11 00:15:16 +05:30
Aaron Patterson
558334a899
deprecating CSV fixture support
2011-05-10 11:08:18 -07:00
Aaron Patterson
714fea81e4
deprecating read_csv_fixture_files method
2011-05-10 11:08:18 -07:00
Piotr Sarnacki
9f0af6d6dd
Merge pull request #495 from vatrai/minor_fixes
...
minor cleaning
2011-05-10 10:57:15 -07:00
Vishnu Atrai
33f0b6b67d
minor cleaning
2011-05-10 22:51:54 +05:30
Aaron Patterson
134a05adcb
Merge pull request #493 from guilleiguaran/changelog-fixes
...
Merging 3.0.x CHANGELOGs
2011-05-10 10:04:54 -07:00
Guillermo Iguaran
259c749de1
Merging 3.0.x CHANGELOGs
2011-05-10 11:51:35 -05:00
Joshua Wehner
2cef2d411a
Methods that return nil should not be considered YAML
2011-05-10 12:06:09 -04:00
slainer68
95b4989559
Puts ActiveRecord::SessionStore attributes in white list, fixes #483
2011-05-10 16:11:28 +02:00
Vijay Dev
a4765f74cd
Fix typos in IM documentation
2011-05-10 03:44:57 -07:00
José Valim
302c912bf6
Document identity map inconsistency with associations, closes #474 .
2011-05-10 11:33:39 +02:00
José Valim
5fc3564a50
Fix #480 . Passing nil to create association works.
2011-05-10 11:18:16 +02:00
José Valim
0ceb21e335
Revert "b9ea751d0e56bd00d341766977a607ed3f7ddd0f".
...
Wrapping each Record.associations.build in a transaction is going to
make several unneeded queries. Reverting this commit also fixes #479 .
2011-05-10 11:14:39 +02:00
José Valim
7c353d576a
Add failing tests according to #479 .
2011-05-10 11:11:30 +02:00
José Valim
b6a2113b8d
Add failing tests, according to #480 .
2011-05-10 11:02:34 +02:00
José Valim
9e4b715d79
Ensure assign_attributes and update_attributes do not fail on nil, closes #478 .
2011-05-10 10:30:27 +02:00
Aaron Patterson
73ff6797ef
use a null byte as a bind parameter substitute as it is not allowed in normal SQL. fixes #411 , #417
2011-05-09 13:53:57 -07:00
Josh Kalderimis
d9f95c76a4
removed an unneed AS::Concern from AR::IdentityMap
2011-05-09 22:13:25 +02:00
Christopher Wade
e585121539
Interleave db_list and file_list.
2011-05-09 01:46:35 -05:00
Christopher Wade
2952040f70
Sort migrations by the migration ID.
2011-05-09 01:45:45 -05:00
Jon Leighton
72a4893452
Merge pull request #451 from baroquebobcat/fixing_last_for_issue_371
2011-05-08 23:43:34 +01:00
Nick Howard
92c10760d7
Fix for #371
...
if a query contains a limit or an offset, ActiveRecord::FinderMethods#find_last had inconsistent behavior.
If the records were loaded, it returned the last record in the cached list.
If they were not, it reversed the order of the query and changed the limit to one.
If the earlier limit was less than the total matching the query in the db,
it would return a different record than if the records had been cached.
This commit changes find_last so that it loads the records when getting the
last record on a query containing a limit or an offset, which makes the behavior consistent.
2011-05-08 23:42:53 +01:00
Jon Leighton
8f10ccd311
Ensure that ORDER BY clauses from default scopes are not included in calculation queries. Fixes #406 .
2011-05-08 23:31:16 +01:00
Christopher Meiklejohn
4fbd8adf48
Don't quote ID's as Arel will quote them -- follow same conventions as the delete method.
2011-05-08 18:37:28 +01:00
Josh Kalderimis
b2451f4a7f
renamed mass-assignment scopes to roles, updated code, tests, docs and security guide
2011-05-08 16:43:29 +02:00
Jason Noble
e5c18ff2cc
Added deprecation warning for Fixture(s) (Use ActiveRecord::Fixture(s))
2011-05-07 16:15:09 -06:00
Jason Noble
7db2ef47a1
Namespace Fixtures in ActiveRecord
...
[Fixes #439 ]
2011-05-07 14:20:51 -06:00
José Valim
ba23bf43f2
Class.new.name returns an empty string on 1.8
2011-05-07 17:46:44 +02:00
José Valim
5d6c8d5e9d
Revert "Revert the merge because tests did not pass."
...
This reverts commit 886818d2ba
2011-05-07 17:33:40 +02:00
Hemant Kumar
20c35bca5a
fix yield not working from around filter of observers, fixes Github#329
2011-05-07 03:03:41 +05:30
Xavier Noria
29dbccff30
Merge pull request #396 from asanghi/lh_4346
...
Multiparameter POLA (principle of least authority) with respect to time_select fixes. See LH4346
2011-05-06 03:53:17 -07:00
José Valim
41a6d96c1b
Update CHANGELOGs.
2011-05-06 05:53:58 +02:00
Jon Leighton
030e1d06ca
Merge pull request #399 from ernie/join_conditions_on_join
...
Add association join conditions to JOIN clause, not WHERE
2011-05-05 13:23:15 -07:00
Ernie Miller
9b7cd75db3
Add a test for outer joins with conditions where value IS NULL
2011-05-05 14:34:48 -04:00
Aaron Patterson
f098c80947
Merge pull request #358 from baroquebobcat/fix_find_or_create_master
...
Fix for lighthouse #6741
2011-05-05 11:13:05 -07:00
Ernie Miller
8d270a2abb
Add join conditions to JOIN clause, not WHERE
2011-05-05 12:35:29 -04:00
Aditya Sanghi
7d0f26796d
Multiparameter POLA, time_select fixes. See LH4346
2011-05-05 15:41:14 +05:30
David Heinemeier Hansson
169ae75e09
Prepare for beta1
2011-05-04 20:21:05 -05:00
Aaron Patterson
38d92d705e
ensure query cache is cleared when Rack body is closed, fixes bug reported on 951e18abea
2011-05-04 15:24:26 -07:00
Santiago Pastorino
bd4831d699
Bump up rack-cache, tzinfo and thor
2011-05-04 16:47:48 -03:00
José Valim
92661b0c50
Move sandbox to AR and pass the sandbox as a value. This way, other ORMs like Datamapper can also have their own sandboxing in rails console.
2011-05-04 16:47:35 +02:00
José Valim
b9bba555ca
Remove defined?(ActiveRecord) and use the railtie hook instead.
2011-05-04 16:32:24 +02:00
Xavier Noria
cea3b3cc9d
Merge branch 'master' of git://github.com/lifo/docrails
2011-05-04 14:51:04 +02:00
Sebastian Martinez
24586edae2
Remove extra whitespaces
2011-05-03 21:38:19 -03:00
Sebastian Martinez
0ee2513356
Improves Mysql2 adapter docs
2011-05-03 21:26:02 -03:00
Sebastian Martinez
fab9bb77bf
Added #recreate_database docs
2011-05-03 21:25:38 -03:00
