Commit Graph

700 Commits

Author SHA1 Message Date
Marcel Molina
4859b6c09e Honor skipping filters conditionally for only certain actions even when the parent class sets that filter to conditionally be executed only for the same actions. Closes #4522.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-05 04:39:59 +00:00
Jamis Buck
3bf3bc228c Delegate xml_http_request in integration tests to the session instance.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4161 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-04 20:16:29 +00:00
Nicholas Seckar
e714b25723 Update the diagnostics template skip the useless '<controller not set>' text.
Fix symbol extensions test case.
Clean paths inside of exception messages and traces.
Add Pathname.clean_within for cleaning all the paths inside of a string.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-04 19:37:29 +00:00
David Heinemeier Hansson
62dc792a48 CHANGED DEFAULT: Don't parse YAML input by default, but keep it available as an easy option [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4157 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-04 19:28:25 +00:00
David Heinemeier Hansson
dc87eba062 Fixed fragment caching of binary data on Windows (closes #4493) [bellis@deepthought.org]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4125 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-01 20:41:53 +00:00
Marcel Molina
f28d619534 Add documentation for respond_to
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4083 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-28 03:39:23 +00:00
David Heinemeier Hansson
dfd953ea96 Fixed docs
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4079 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-28 03:19:27 +00:00
David Heinemeier Hansson
b6e7cc63de Spell existence properly (closes #4442)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4072 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-27 23:43:50 +00:00
Rick Olson
3f496c6638 add the TestCase.fixture_path when testing file uploads
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4058 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-27 02:24:47 +00:00
David Heinemeier Hansson
9326222941 Use example.com as standard (closes #4413) [anna]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4026 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-25 19:43:40 +00:00
Jamis Buck
7bcf4c6659 Enable application/x-yaml processing by default
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4024 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-25 18:44:28 +00:00
Jamis Buck
b0189f3f2f Fix assert_redirected_to so it works with symbols
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4004 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 18:16:48 +00:00
David Heinemeier Hansson
6d7335752a Comments, comments
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3994 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 05:40:42 +00:00
David Heinemeier Hansson
faecde0ec8 My beautiful eyes [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3993 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 05:39:13 +00:00
David Heinemeier Hansson
eedd9d7604 Updated Kernel#returning for the AP performance patch [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3991 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 04:37:32 +00:00
Rick Olson
a4f1262ac5 fix usage of #returning in ActionController::Base
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3990 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 04:33:13 +00:00
David Heinemeier Hansson
d19e8f412f Performance speedup for ActionController (closes #4174) [Stefan Kaes] Includes caching of filter chains -- be on the lookout for problems with that!
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3989 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 04:01:10 +00:00
David Heinemeier Hansson
8ea1fadcbe If RAW_POST_DATA was set explicitly, use that (closes #4281)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3972 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 06:42:29 +00:00
Rick Olson
891a962a19 Added nicer message for assert_redirected_to (closes #4294) [court3nay, Chris McGrath]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3969 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 03:50:14 +00:00
David Heinemeier Hansson
cc6e8ae57a Removed XML argument style for respond_to, so type.xml(object.to_xml) no longer works -- it wasnt worth the exception
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 21:17:14 +00:00
David Heinemeier Hansson
f22f352ee3 Added easy support for testing file uploads with fixture_file_upload (closes #4105) [turnip@turnipspatch.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3939 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 20:10:52 +00:00
Jamis Buck
79a82e3a97 Make sure xml_simple requests don't blow up if an empty request body is recieved
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3936 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 18:56:19 +00:00
Nicholas Seckar
240213177e Add ability for relative_url_root to be specified via an environment variable RAILS_RELATIVE_URL_ROOT. Closes #4243.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3931 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 16:45:40 +00:00
David Heinemeier Hansson
c2fb8ca393 Just use a normal update on the indifferent hash
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3927 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 16:11:21 +00:00
Jamis Buck
9d7de52c2d Add Integration::Session.accept for setting the HTTP Accept header to use (defaults to FF 1.5 value)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3924 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 15:09:27 +00:00
Jamis Buck
36ea93e4b9 rename 'integration_test.rb' -> 'integration.rb'
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3923 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 14:27:36 +00:00
David Heinemeier Hansson
9840dc84f1 Allow for respond_to(:html, :js, :xml) (closes #4277) [Caio Chassot]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3919 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 06:43:37 +00:00
Jamis Buck
4e0028fbab Make Mime::Type.parse consider q values (if any)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3917 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 06:15:28 +00:00
Jamis Buck
459559a8bc XML-formatted requests are typecast according to "type" attributes for :xml_simple
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 05:07:27 +00:00
David Heinemeier Hansson
fe94ba1003 Added access to remote_addr in integration tests (closes #4266) [Chad Fowler]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3908 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 03:27:37 +00:00
Jamis Buck
1340eb1a7e Be sure to look at array elements when dasherizing keys of a formatted request
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-17 23:15:20 +00:00
David Heinemeier Hansson
4e15bf787e Fixed proxy support for lighttpd (closes #3267) [stephen_purcell@yahoo.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3894 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 04:16:08 +00:00
Nicholas Seckar
065b3af358 Explain thyself
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3893 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 04:09:18 +00:00
David Heinemeier Hansson
f7359342af Added protection against proxy setups treating requests as local even when they're not #3898 [stephen_purcell@yahoo.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3892 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 03:31:40 +00:00
David Heinemeier Hansson
275ea6de49 Added TestRequest#raw_post that simulate raw_post from CgiRequest (closes #3042) [francois.beausoleil@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 03:15:12 +00:00
David Heinemeier Hansson
500c734935 Breakpoints in running code makes for no fun ;)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3883 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 02:48:25 +00:00
Tobias Lütke
7bbc759dc0 Fixes a bug in routes controller traversing which caused it to fail on for double nested controllers. [Tobias Luetke]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3879 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-15 22:48:22 +00:00
Jamis Buck
2429074075 Underscore dasherized keys in formatted requests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3878 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-15 21:46:41 +00:00
Jamis Buck
6480d49749 Add MimeResponds::Responder#any for managing multiple types with identical responses
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3876 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-15 18:27:26 +00:00
Jamis Buck
4ba5aa257b use "mime_type" instead of "format"
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3874 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-15 18:04:24 +00:00
Jamis Buck
6784749f3b Fix Mime::Type#to_sym to do @string.to_sym. Add text/yaml as alias for Mime::YAML
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3873 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-15 15:12:24 +00:00
Jamis Buck
953d7c9aa4 Make the xml_http_request testing method set the HTTP_ACCEPT header
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3867 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-14 19:53:27 +00:00
Michael Koziarski
c6abe81b1e Add verification to scaffolds (generated and reflection based). Require POST for unsafe actions [Michael Koziarski]. Closes #2601
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3864 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-14 01:57:12 +00:00
Nicholas Seckar
8ff4463193 Simplify controller_path
Cache File.directory? calls to avoid filesystem calls when using layouts


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3861 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-13 15:54:33 +00:00
David Heinemeier Hansson
97dd9a91c2 Always use application/xml, then the charset is determined by the XML doc
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3860 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-13 05:51:55 +00:00
David Heinemeier Hansson
928627292c The mere existance of a rjs file shouldnt cause the layout to disappear. Made it easier to specify a :with on observer_field
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3859 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-13 03:29:39 +00:00
David Heinemeier Hansson
75b8a66638 The mere existance of a rjs file shouldnt cause the layout to disappear. Made it easier to specify a :with on observer_field
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3858 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-13 03:27:26 +00:00
David Heinemeier Hansson
06c2b43f36 Rendering xml shouldnt happen inside any layout. Added class proxying to RJS, so you can call page.field.clear("my_field") to generate Field.clear("my_field");. Added :content_type option to render, so you can change the content type on the fly. Do type/subtype reordering of Accept header preferences for xml types (aka make Firefox work with respond_to). CHANGED DEFAULT: The default content type for .rxml is now application/xml instead of type/xml, see http://www.xml.com/pub/a/2004/07/21/dive.html for reason
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3852 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-13 01:33:57 +00:00
David Heinemeier Hansson
60e40647d7 Prepare for mime type reordering depending on the branch [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3850 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-12 19:01:09 +00:00
David Heinemeier Hansson
09cec78248 Default mime type for XML should be application/xml [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3849 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-12 18:50:14 +00:00