github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
16,838 Commits 34 Branches 105 Tags
312f43324159fbcd8749cd331ed7d6500a714a83
Commit Graph

3094 Commits

Author SHA1 Message Date
José Valim
312f433241 Clear DescendantsTracker on each request. 2010-06-19 17:51:44 +02:00
José Valim
033e0a041f ActiveRecord and ActionPack now use the new descendants implementation. 2010-06-19 17:15:21 +02:00
Aaron Patterson
bf6661c5d7 setting the timezone in postgres to whatever ruby thinks the timezone is [#4895 state:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-06-17 16:49:21 -07:00
Xavier Noria
5cd3c2a855 Merge remote branch 'rails/master' 2010-06-14 23:24:41 +02:00
Xavier Noria
f17159b029 edit pass: the names of Rails components have a space, ie, "Active Record", not "ActiveRecord" 2010-06-14 23:22:04 +02:00
Xavier Noria
4a8c8804ff refactors AR::Base#reset_table_name 2010-06-14 18:36:04 +02:00
Thiago Pradi
8d82bef58a Documentation for #quoted_table_name method 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-06-14 17:32:45 +02:00
Pratik Naik
9a23a03505 Remove an unused method 2010-06-12 11:54:52 +05:30
José Valim
85cc1fa657 Revert "Don't overwrite unsaved updates when loading an association but preserve the order of the loaded records. [#4642 state:open]" 
This commit introduced a regression described in ticket [#4830].

This reverts commit 0265c708b9.
 2010-06-11 17:05:54 +02:00
José Valim
b67ec8ba20 class_attribute is not a direct replacement of class_inheritable_*. 
If you are setting a hash or an array in class_attribute or you need
to freeze it, to ensure people won't modify it in place or you need
to dup it on inheritance.
 2010-06-10 19:39:09 +02:00
David Heinemeier Hansson
983815632c Cut down even further on rake -T noise 2010-06-09 17:14:53 -04:00
David Heinemeier Hansson
fa15111d30 Silence even more noisy rake task docs 2010-06-09 16:39:01 -04:00
James Le Cuirot
0265c708b9 Don't overwrite unsaved updates when loading an association but preserve the order of the loaded records. [#4642 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2010-06-09 18:17:52 +05:30
Brian Durand
2500e6af66 Make logic for after_commit and after_rollback :on option work like it does for validation callbacks. 
[#2991 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-06-08 17:05:29 -04:00
Jeremy Kemper
b070739240 Revert "Temporarily revert "Update after_commit and after_rollback docs and tests to use new style API with an :on options instead of on_* suffix." and "Add after_commit and after_rollback callbacks to ActiveRecord that are called after transactions either commit or rollback on all records saved or destroyed in the transaction."" 
This reverts commit 1b2941cba1.

[#2991]
 2010-06-08 17:05:29 -04:00
Jeremy Kemper
87cc3d5569 Clarify Fixture#key_ and value_list 2010-06-08 17:05:29 -04:00
Xavier Noria
f1c0bcfbb6 Merge remote branch 'docrails/master' 2010-06-08 22:39:30 +02:00
Andrew Bloomgarden
0e9b9d5985 Fix ActiveRecord::Base.compute_type swallowing NoMethodError. [#4751 state:resolved] 
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
 2010-06-08 15:34:47 -04:00
Xavier Noria
751f79a033 Merge remote branch 'rails/master' 2010-06-08 21:23:29 +02:00
Jeremy Kemper
1b2941cba1 Temporarily revert "Update after_commit and after_rollback docs and tests to use new style API with an :on options instead of on_* suffix." and "Add after_commit and after_rollback callbacks to ActiveRecord that are called after transactions either commit or rollback on all records saved or destroyed in the transaction." 
This reverts commits d2a49e4b1f and da840d13da.

[#2991]

Conflicts:

	activerecord/CHANGELOG
	activerecord/lib/active_record/transactions.rb
	activerecord/test/cases/transaction_callbacks_test.rb
 2010-06-08 14:56:08 -04:00
David Heinemeier Hansson
32d4330b81 Get ready for beta 4 2010-06-08 14:47:02 -04:00
Aaron Patterson
eb69721c9b forcing encoding on 1.9 when dealing with "binary" columns [#4612 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-06-08 14:33:28 -04:00
Ernie Miller
a4eaa1fd39 Fix multiple self-referencing eager loads failing to join multiple times 
[#4679 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-06-08 01:02:19 -04:00
wycats
b97a3f33a3 Merge remote branch 'rsim/oracle_enhanced_rails3' 2010-06-07 23:03:59 -04:00
Santiago Pastorino and José Ignacio Costa
100f8b2dfc update docs before_validation_on_create => before_validation(:on => :create) 2010-06-07 22:21:28 -03:00
José Valim
634c9310e3 Make the logic for nested_records_changed_for_autosave? simpler. 
[#4648 state:resolved]
 2010-06-07 11:01:10 +02:00
Carlos Antonio da Silva
7eedc3f397 Fixing test class names and refactor line in autosave association 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-07 10:45:47 +02:00
Tom Meier
3f1cdb85b8 Require active support/string/conversions so constantize can be used in associations.rb 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-07 10:29:26 +02:00
Jeremy Kemper
a5f3f3ef7a MySQL: require 2.7 or later so we can rely on result.each_hash 2010-06-05 14:59:51 -07:00
wycats
a260e02fd3 Whoops. _run_*_callbacks is private 2010-06-04 20:11:05 -07:00
wycats
a87b627297 Use faster form of running callbacks 2010-06-04 20:11:05 -07:00
Raimonds Simanovskis
c51fa6bdfc ignore raw_sql_ table alias that is used by Oracle adapter 2010-06-04 22:44:04 +03:00
Raimonds Simanovskis
edf79a7fe7 Downcase quoted table name in regex in count_aliases_from_table_joins 
Oracle adapter's quote_table_name returns quoted table name in uppercase and therefore it should be downcased before scanning downcased join_sql
 2010-06-04 22:44:03 +03:00
Raimonds Simanovskis
a83e6b1b6a downcase table names in aliased_table_name_for and references_eager_loaded_tables? methods (as Oracle quoted table names are in uppercase) 2010-06-04 22:44:03 +03:00
Pratik Naik
517f709b51 Properly cache association_collection#scopes calls having arguments 2010-06-04 00:53:45 +01:00
Pratik Naik
4b91daff13 Special treatement for Relation#select { with block } 2010-06-02 14:42:25 +01:00
José Valim
0570720d66 Configure generators before invoking. 2010-06-02 09:37:38 +02:00
Mislav Marohnić
bc84bd17d1 fix reset_counters to work even with complex class names 
e.g. it guesses that a belongs_to association to Namespace::MyModel is
named "my_model", unlike before where it would look up an association
named "namespace::mymodel" and fail.
 2010-05-24 11:44:53 +02:00
Mislav Marohnić
f493f31533 cleanup update/reset_counters: less SQL strings, more ActiveRecord/Arel 2010-05-24 11:42:03 +02:00
Santiago Pastorino
aacf2581cd refactor evals and adds some __FILE__ and __LINE__ 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-20 15:18:57 +02:00
Xavier Noria
7f07cc364a Merge remote branch 'rails/master' 2010-05-19 23:29:39 +02:00
Jeremy Kemper
223d6415d0 Revert "Don't carry default value when changing column for a binary type on MySQL" 
Broke mysql tests.

This reverts commit edec1afe25.

Conflicts:

	activerecord/test/cases/migration_test.rb

[#3234 state:open]
 2010-05-18 11:02:39 -07:00
Étienne Barrié
3809c80cd5 make add_index and remove_index more resilient; new rename_index method; track database limits 
[#3452 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-05-18 10:55:41 -07:00
Ian White
b439d85a19 Nested records (re: autosave) are now updated even when the intermediate parent record is unchanged [#4242 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-18 16:13:00 +02:00
Pratik Naik
5ddc904941 Remove Model.clear_default_scope 2010-05-18 12:22:23 +01:00
José Valim
c536835957 Cut the fat and make session stores rely on request.cookie_jar and change set_session semantics to return the cookie value instead of a boolean. 2010-05-18 03:18:23 +02:00
pleax
4db10bce7b AR::Base#clone fixed to set dirty bits for cloned object 
[#2919 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-05-16 17:45:12 -07:00
Comron Sattari
e1a340a91d cache connection when quoting 
[#3642 state:committed]

Signed-off-by: Marius Nuennerich <marius@nuenneri.ch>
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-05-16 17:40:40 -07:00
Rizwan Reza
d148a6f6ba Merge branch 'master' of git://github.com/rails/rails 2010-05-17 02:40:15 +04:30
Federico Brubacher
6b4e0cc526 a cloned object no longer mimics changed flags from creator , plus a test case [#4614 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-16 23:04:40 +02:00