github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
16,839 Commits 34 Branches 105 Tags
324de1993bf507a31025db3dc787f63b2152b4f5
Commit Graph

3866 Commits

Author SHA1 Message Date
Rizwan Reza
fde9504847 Adds title to activerecord/lib/active_record/associations/* 2010-06-16 22:28:20 +04:30
Rizwan Reza
6445441253 Adds title to the rest of the files in activerecord/lib 2010-06-16 22:25:15 +04:30
Rizwan Reza
4e3eec3d01 Adds title and proper formatting to docs. 2010-06-16 22:22:35 +04:30
Rizwan Reza
0ebdc26cae Adds title where needed. 2010-06-16 22:17:05 +04:30
Rizwan Reza
2b7f08428c Adds basic description and title. 2010-06-16 22:15:04 +04:30
Rizwan Reza
d8277804b2 Adds title and minor changes. 2010-06-16 22:08:14 +04:30
Rizwan Reza
c86915450a Adds title. 2010-06-15 23:11:30 +04:30
Rizwan Reza
cef442f92c Added typewriter tag to code. 2010-06-15 23:03:54 +04:30
Rizwan Reza
c7f78b184d Added description and title to Dynamic Scope Match 2010-06-15 23:02:51 +04:30
Rizwan Reza
4ad6103c4f Adds title and basic description where needed. 2010-06-15 22:41:41 +04:30
Bryan Woods
538b7b97bb Active Record Associations - minor change of DeleteRestrictionError doc for clarity 2010-06-15 12:36:21 -04:00
Evgeniy Dolzhenko
ef404c771d Fix a bunch of minor spelling mistakes 2010-06-15 12:04:22 +04:00
Neeraj Singh
3cc2d196c0 Revert "removing the extra \" 
This reverts commit 51a9703b1e.
 2010-06-15 00:48:22 -04:00
Neeraj Singh
5e60e65713 Merge branch 'master' of github.com:lifo/docrails 2010-06-15 00:46:44 -04:00
Neeraj Singh
51a9703b1e removing the extra \ 2010-06-15 00:46:35 -04:00
Xavier Noria
5cd3c2a855 Merge remote branch 'rails/master' 2010-06-14 23:24:41 +02:00
Xavier Noria
f17159b029 edit pass: the names of Rails components have a space, ie, "Active Record", not "ActiveRecord" 2010-06-14 23:22:04 +02:00
Xavier Noria
4a8c8804ff refactors AR::Base#reset_table_name 2010-06-14 18:36:04 +02:00
Thiago Pradi
8d82bef58a Documentation for #quoted_table_name method 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-06-14 17:32:45 +02:00
wycats
a087bc85fd Revert "Revert "Validators should at model level and not at AR:Base level [Closes #4804]"" 
This reverts commit d675493065.
 2010-06-12 18:48:27 -07:00
wycats
d675493065 Revert "Validators should at model level and not at AR:Base level [Closes #4804]" 
This reverts commit e11bb95d56.
 2010-06-12 18:47:37 -07:00
José Valim
b308a6030e Use load_paths on AR benchmarks so it uses the bundler setup instead of system gems. 2010-06-12 10:07:35 +02:00
Pratik Naik
9a23a03505 Remove an unused method 2010-06-12 11:54:52 +05:30
José Valim
85cc1fa657 Revert "Don't overwrite unsaved updates when loading an association but preserve the order of the loaded records. [#4642 state:open]" 
This commit introduced a regression described in ticket [#4830].

This reverts commit 0265c708b9.
 2010-06-11 17:05:54 +02:00
Evgeniy Dolzhenko
ccf9577aee Fix a bunch of minor spelling mistakes 2010-06-11 14:15:34 +04:00
José Valim
b67ec8ba20 class_attribute is not a direct replacement of class_inheritable_*. 
If you are setting a hash or an array in class_attribute or you need
to freeze it, to ensure people won't modify it in place or you need
to dup it on inheritance.
 2010-06-10 19:39:09 +02:00
Neeraj Singh
e11bb95d56 Validators should at model level and not at AR:Base level [Closes #4804] 
[#4804 state:resolved]

Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
 2010-06-10 11:50:42 -04:00
David Heinemeier Hansson
983815632c Cut down even further on rake -T noise 2010-06-09 17:14:53 -04:00
David Heinemeier Hansson
fa15111d30 Silence even more noisy rake task docs 2010-06-09 16:39:01 -04:00
James Le Cuirot
0265c708b9 Don't overwrite unsaved updates when loading an association but preserve the order of the loaded records. [#4642 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2010-06-09 18:17:52 +05:30
Santiago Pastorino
6898c167c3 Make sure about which is the first element of the query, fixes a postgresql 8.4 failing test 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-09 10:06:41 +02:00
Santiago Pastorino
cfacae1a7d SQLite2Adapter doesn't exist 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-09 10:06:24 +02:00
Brian Durand
2500e6af66 Make logic for after_commit and after_rollback :on option work like it does for validation callbacks. 
[#2991 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-06-08 17:05:29 -04:00
Jeremy Kemper
b070739240 Revert "Temporarily revert "Update after_commit and after_rollback docs and tests to use new style API with an :on options instead of on_* suffix." and "Add after_commit and after_rollback callbacks to ActiveRecord that are called after transactions either commit or rollback on all records saved or destroyed in the transaction."" 
This reverts commit 1b2941cba1.

[#2991]
 2010-06-08 17:05:29 -04:00
Jeremy Kemper
87cc3d5569 Clarify Fixture#key_ and value_list 2010-06-08 17:05:29 -04:00
Xavier Noria
f1c0bcfbb6 Merge remote branch 'docrails/master' 2010-06-08 22:39:30 +02:00
Emilio Tagua
4b4a548a60 Avoid PostgreSQL and MySQL tests warnings. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-08 22:36:19 +02:00
Andrew Bloomgarden
0e9b9d5985 Fix ActiveRecord::Base.compute_type swallowing NoMethodError. [#4751 state:resolved] 
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
 2010-06-08 15:34:47 -04:00
Xavier Noria
751f79a033 Merge remote branch 'rails/master' 2010-06-08 21:23:29 +02:00
Emilio Tagua
ab2877cbe8 Add parentheses to avoid warnings when running AR tests. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-08 21:16:19 +02:00
Emilio Tagua
d103c73d95 Bump Arel to 0.4.0 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-08 20:59:14 +02:00
Jeremy Kemper
1b2941cba1 Temporarily revert "Update after_commit and after_rollback docs and tests to use new style API with an :on options instead of on_* suffix." and "Add after_commit and after_rollback callbacks to ActiveRecord that are called after transactions either commit or rollback on all records saved or destroyed in the transaction." 
This reverts commits d2a49e4b1f and da840d13da.

[#2991]

Conflicts:

	activerecord/CHANGELOG
	activerecord/lib/active_record/transactions.rb
	activerecord/test/cases/transaction_callbacks_test.rb
 2010-06-08 14:56:08 -04:00
David Heinemeier Hansson
32d4330b81 Get ready for beta 4 2010-06-08 14:47:02 -04:00
Aaron Patterson
eb69721c9b forcing encoding on 1.9 when dealing with "binary" columns [#4612 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-06-08 14:33:28 -04:00
Ernie Miller
a4eaa1fd39 Fix multiple self-referencing eager loads failing to join multiple times 
[#4679 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-06-08 01:02:19 -04:00
wycats
b97a3f33a3 Merge remote branch 'rsim/oracle_enhanced_rails3' 2010-06-07 23:03:59 -04:00
Santiago Pastorino and José Ignacio Costa
100f8b2dfc update docs before_validation_on_create => before_validation(:on => :create) 2010-06-07 22:21:28 -03:00
Santiago Pastorino
94ed39d146 This test shouldn't rely on the order of the data returned by select 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-06-07 20:06:31 -04:00
José Valim
a04060fb6f Really make include_root_in_json default to true [#3770 state:resolved] 2010-06-08 01:02:45 +02:00
José Valim
634c9310e3 Make the logic for nested_records_changed_for_autosave? simpler. 
[#4648 state:resolved]
 2010-06-07 11:01:10 +02:00