Commit Graph

702 Commits

Author SHA1 Message Date
Jeremy Kemper
c7df5bd6ac More nested polymorphic url helper fixes. Closes #6432, references #8601.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-07 21:35:01 +00:00
Jeremy Kemper
5600776e30 Fix incomplete work from [6951] that was hidden by test stubs. Closes #6432.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6959 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-06 16:52:37 +00:00
Jeremy Kemper
5dd3db8615 Resources: url_for([parent, child]) generates /parents/1/children/2 for the nested resource. Likewise with the other simply helpful methods like form_for and link_to. Closes #6432.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6951 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-05 19:10:59 +00:00
Rick Olson
b83efadb32 Assume html format when rendering partials in RJS. #8076 [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6950 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-05 16:51:49 +00:00
Jeremy Kemper
7709df5f17 Don't double-escape url_for in views. Closes #8144.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-05 04:29:19 +00:00
Thomas Fuchs
3cfb894bac Allow JSON-style values for the :with option of observe_field. Closes #8557 [kommen]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6930 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-03 14:27:43 +00:00
Jeremy Kemper
83ce4c59be Remove RAILS_ROOT from backtrace paths. Closes #8540.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6923 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-01 05:18:21 +00:00
Jeremy Kemper
a6a1dc967c render :partial recognizes Active Record associations as Arrays. Closes #8538.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6920 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-06-01 03:53:39 +00:00
David Heinemeier Hansson
0cf79f07b0 Fixed that DateHelper#date_select should set the day to the 1st when its a hidden option and the month is visible (or invalid dates can be produced) [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-31 16:38:36 +00:00
Jeremy Kemper
3c356aa9ff Reduce file stat calls when checking for template changes. Closes #7736.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6871 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-27 19:16:09 +00:00
Jeremy Kemper
9dac6b759f auto_complete_field takes a :method option so you can GET or POST. Closes #8120.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6851 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-26 00:32:52 +00:00
David Heinemeier Hansson
74d1512b99 Added option to suppress :size when using :maxlength for FormTagHelper#text_field #3112 [rails@tpope.info]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6830 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-24 20:47:03 +00:00
Rick Olson
4b9e67c5b9 catch possible WSOD when trying to render a missing partial. Closes #8454 [Catfish]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-24 16:42:10 +00:00
Sam Stephenson
f52021ddd2 Update to Prototype 1.5.1
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6785 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-19 20:57:11 +00:00
Thomas Fuchs
81ee044fda Update edge to script.aculo.us to 1.7.1_beta3
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6781 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-19 00:23:42 +00:00
Jeremy Kemper
4221494348 observe_form always sends the serialized form. Closes #5271.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6775 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-18 21:27:05 +00:00
Jeremy Kemper
b6541b8dcc select :include_blank option can be set to a string instead of true, which just uses an empty string. Closes #7664.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-18 05:29:22 +00:00
Jeremy Kemper
1ac7cd56fe Clean up the simply_helpful merge.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6751 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-18 00:36:14 +00:00
Rick Olson
ebf9b3737b Add some performance enhancements to ActionView.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6736 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-15 06:36:34 +00:00
Rick Olson
80074cb4de Assume that rendered partials go by the HTML format by default
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6734 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-15 03:13:32 +00:00
David Heinemeier Hansson
6e7b593992 Added record identifications to FormHelper#form_for and PrototypeHelper#remote_form_for [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6731 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-14 17:30:35 +00:00
David Heinemeier Hansson
c769ad8533 Removed deprecated parameters_for_method_reference concept (legacy from before named routes) [DHH] Added record identification with polymorphic routes for ActionController::Base#url_for and ActionView::Base#url_for [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6729 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-12 21:12:31 +00:00
Marcel Molina
e4c5ddd839 Modernize documentation for form helpers. Closes #8035. [jeremymcanally]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6689 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-06 05:23:03 +00:00
Marcel Molina
f02a0bf274 Minor wording tweak to documentation for the debug helper. Closes #8037. [jeremymcanally]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6688 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-06 05:19:02 +00:00
Marcel Molina
4e51123a01 Fix various documentation typos throughout ActionPack. Closes #8111. [Henrik N]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6679 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-06 04:46:11 +00:00
Marcel Molina
f07d0e29da Enhance documentation and add examples for url_for. Closes #8227. [jeremymcanally]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6674 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-06 04:29:42 +00:00
David Heinemeier Hansson
edaf6baea7 Fixed that content_tag with a block will just return the result instead of concate it if not used in a ERb view #7857, #7432 [michael.niessner]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6652 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-02 22:30:41 +00:00
David Heinemeier Hansson
da257eb81b Added the first part of Simply Helpful to core. The rest is pending a clean integartion of polymorphic urls [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6633 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-30 01:17:56 +00:00
Rick Olson
eb7a3045e3 apply [6543] to edge. Closes #5044 [tpope]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6545 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-20 21:44:08 +00:00
Rick Olson
39ccb5e807 Tweak template format rules so that the ACCEPT header is only used if it's text/javascript. This is so ajax actions without a :format param get recognized as Mime::JS. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-15 18:01:40 +00:00
Rick Olson
6351e0a541 The default respond_to blocks don't set a specific extension anymore, so that both 'show.rjs' and 'show.js.rjs' will work. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6517 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-12 20:25:32 +00:00
Rick Olson
ec4d407d4f add #view_paths attr_accessor for ActionView::Base
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6509 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-08 18:29:57 +00:00
Rick Olson
bdb1fcc3b8 Fix WSOD due to modification of a formatted template extension so that requests to templates like 'foo.html.erb' fail on the second hit. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6506 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-08 16:53:37 +00:00
Rick Olson
142b074e91 Fix WSOD when template compilation fails [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6505 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-08 02:32:25 +00:00
Rick Olson
da6f5a1cb4 Change ActionView template defaults. Look for templates using the request format first, such as show.html.erb or show.xml.builder, before looking for the old defaults like show.erb or show.builder [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6499 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-02 00:02:11 +00:00
Jeremy Kemper
67d5a1abed Highlight helper highlights one or many terms in a single pass.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6493 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-30 01:19:01 +00:00
David Heinemeier Hansson
0228975a4e Added that FormTagHelper#submit_tag will return to its original state if the submit fails and you're using :disable_with [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6480 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-27 19:42:54 +00:00
Rick Olson
2a305949d7 documentation project patches, closes #7342, #7319, #7316, #7190 [jeremymcanally]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6470 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-27 14:04:06 +00:00
Jeremy Kemper
1def3f0073 Deprecation: remove deprecated update_element_function, start_form_tag, and end_form_tag. Use RJS and form_tag instead.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6409 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-13 05:24:10 +00:00
Jeremy Kemper
2823a56f14 Deprecation: remove deprecated human_size helper alias. Use number_to_human_size instead.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6407 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-13 05:18:49 +00:00
Jeremy Kemper
dfc1285aad Deprecation: remove deprecated link_to_image and link_image_to methods. Use link_to(image_path(...), url).
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6405 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-13 05:12:59 +00:00
Jeremy Kemper
d20b943551 Deprecation: privatize deprecated render_partial and render_partial_collection methods.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-13 05:06:41 +00:00
Jeremy Kemper
83c8db9818 Deprecation: remove deprecated instance variables.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-13 03:49:52 +00:00
Jeremy Kemper
3edc98a1cc form_options_helper refactoring for clarity. Closes #7787.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6377 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-11 13:14:53 +00:00
David Heinemeier Hansson
182b3ed70c Backed out of using File.atomic_write in the asset_tag_helper.rb as its still half-baked. Most importantly, it creates files with different permissions than File.open/write
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-07 00:48:28 +00:00
David Heinemeier Hansson
d4528effbb Caching shouldnt include the host still
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6353 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-07 00:33:13 +00:00
Tobias Lütke
3644415a1e Cached versions of concatted js/css asset tags have to be written out atomically.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6351 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-06 14:22:40 +00:00
Jeremy Kemper
dbf42e379b Prefer MIME constants to strings. Closes #7707.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-06 09:46:04 +00:00
Jeremy Kemper
a752099082 Sort asset sources for consistent results across filesystems. Closes #7615.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6308 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-04 12:36:45 +00:00
David Heinemeier Hansson
1dc56ba481 Fixed that FormTagHelper#text_area_tag should disregard :size option if it's not a string [Brendon Davidson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6300 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-03 18:04:44 +00:00