github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-31 09:18:17 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,121 Commits 34 Branches 105 Tags
34b94de8b87d7c32a1fdba72eb1f02296f31cffe
Commit Graph

905 Commits

Author SHA1 Message Date
Jeremy Kemper
34b94de8b8 Improve Action View test coverage. Closes #7241, #7243, #7244. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6967 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-08 04:00:15 +00:00
Jeremy Kemper
bab8966064 Test periodically_call_remote with frequency. Closes #7244 [Rich Collins] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-08 01:30:47 +00:00
Jeremy Kemper
c7df5bd6ac More nested polymorphic url helper fixes. Closes #6432, references #8601. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-07 21:35:01 +00:00
Jeremy Kemper
5600776e30 Fix incomplete work from [6951] that was hidden by test stubs. Closes #6432. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6959 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-06 16:52:37 +00:00
Jeremy Kemper
5dd3db8615 Resources: url_for([parent, child]) generates /parents/1/children/2 for the nested resource. Likewise with the other simply helpful methods like form_for and link_to. Closes #6432. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6951 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-05 19:10:59 +00:00
Rick Olson
b83efadb32 Assume html format when rendering partials in RJS. #8076 [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6950 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-05 16:51:49 +00:00
Jeremy Kemper
7709df5f17 Don't double-escape url_for in views. Closes #8144. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-05 04:29:19 +00:00
Jeremy Kemper
f80468c3c3 Remove junk form helper test. Closes #8416 [eric_oconnell] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6941 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-05 04:09:39 +00:00
Thomas Fuchs
3cfb894bac Allow JSON-style values for the :with option of observe_field. Closes #8557 [kommen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6930 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-03 14:27:43 +00:00
Jeremy Kemper
8ce5479307 Routing: map.resource :logo routes to LogosController so the controller may be reused for multiple nestings or namespaces. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6922 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-01 04:40:30 +00:00
Jeremy Kemper
a6a1dc967c render :partial recognizes Active Record associations as Arrays. Closes #8538. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6920 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-06-01 03:53:39 +00:00
David Heinemeier Hansson
0cf79f07b0 Fixed that DateHelper#date_select should set the day to the 1st when its a hidden option and the month is visible (or invalid dates can be produced) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-31 16:38:36 +00:00
Rick Olson
32b307bc32 fix test cases to match new json output. Closes #8371 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6894 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-29 09:42:13 +00:00
Jeremy Kemper
8139de2812 Routing: drop semicolon and comma as route separators. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-29 06:40:33 +00:00
Jeremy Kemper
e5b3d4b3b5 request.remote_ip understands X-Forwarded-For addresses with nonstandard whitespace. Closes #7386. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6877 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-28 00:10:13 +00:00
Jeremy Kemper
0aed1d629e Don't croak if ruby-debug isn't installed. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6876 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-28 00:00:07 +00:00
Jeremy Kemper
3f336ad5cc Don't prepare response when rendering a component. Closes #8493. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6875 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-27 23:48:28 +00:00
David Heinemeier Hansson
d3b5db8919 Added custom path cache_page/expire_page parameters in addition to the options hashes [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6868 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-27 16:38:02 +00:00
Rick Olson
cd599aad71 Action Caching speedup. #8231 [skaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6867 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-27 07:38:09 +00:00
Michael Koziarski
62455f56b4 Ensure compiled template tests pass on windows where there are no symlinks. [skaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6866 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-27 07:21:01 +00:00
Jeremy Kemper
dcaa074abf Routing: respond with 405 Method Not Allowed status when the route path matches but the HTTP method does not. Closes #6953. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6862 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 20:07:34 +00:00
Marcel Molina
42ebf559cc Add support for assert_select_rjs with :show and :hide. #7780 [dchelimsky] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6861 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 17:29:23 +00:00
Marcel Molina
dc4d23f2d7 Make assert_select's failure messages clearer about what failed. #7779 [dchelimsky] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6860 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 17:25:19 +00:00
Jeremy Kemper
40860e9852 Missed svn add from [6856]. References #8174. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6857 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 03:18:57 +00:00
Jeremy Kemper
672941decb Introduce a default respond_to block for custom types. Closes #8174. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6856 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 03:11:34 +00:00
Jeremy Kemper
9dac6b759f auto_complete_field takes a :method option so you can GET or POST. Closes #8120. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6851 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 00:32:52 +00:00
Jeremy Kemper
06f325f478 Add multipart request parsing test with bracketed parameter key. References #8449. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6831 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-24 23:37:37 +00:00
David Heinemeier Hansson
74d1512b99 Added option to suppress :size when using :maxlength for FormTagHelper#text_field #3112 [rails@tpope.info] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6830 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-24 20:47:03 +00:00
Rick Olson
4b9e67c5b9 catch possible WSOD when trying to render a missing partial. Closes #8454 [Catfish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-24 16:42:10 +00:00
Jeremy Kemper
4bd3e3aa1b Set RAW_POST_DATA when request parameters are parsed. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6823 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-23 19:09:37 +00:00
Jeremy Kemper
b0d01921d8 Rewind request body after reading it, if possible. Closes #8438. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6815 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-23 05:43:00 +00:00
Tobias Lütke
19fbd84e12 Rescuing in around_filters works as expected again [codahale, Stephan Kaes]. Closes #8341 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6810 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-22 19:17:43 +00:00
Jeremy Kemper
def8f101b8 Strip junk whitespace from [6806]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6807 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-22 09:38:54 +00:00
Jeremy Kemper
5a3b4cf0bc Resource namespaces are inherited by their has_many subresources. Closes #8280. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6806 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-22 09:37:07 +00:00
Jeremy Kemper
8ba22a690c Fix filtered parameter logging with nil parameter values. Closes #8422. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6802 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-21 23:01:17 +00:00
Jeremy Kemper
d1c957d067 Integration tests: alias xhr to xml_http_request and add a request_method argument instead of always using POST. Closes #7124. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6796 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-21 09:15:16 +00:00
Jeremy Kemper
055ff9f418 Fix incorrent content type lookup in request parsing. Closes #8407. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-19 21:34:36 +00:00
Tobias Lütke
1008535905 Allow routes to be declared off namespaces 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6783 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-19 16:26:44 +00:00
Jeremy Kemper
4221494348 observe_form always sends the serialized form. Closes #5271. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6775 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-18 21:27:05 +00:00
Jeremy Kemper
c597e7d9ac Include location header in args. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6774 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-18 21:23:07 +00:00
Jeremy Kemper
d2ed32d592 Parse url-encoded and multipart requests ourselves instead of delegating to CGI. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6764 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-18 06:24:50 +00:00
Jeremy Kemper
b6541b8dcc select :include_blank option can be set to a string instead of true, which just uses an empty string. Closes #7664. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-18 05:29:22 +00:00
Jeremy Kemper
f7bb3ddce8 Fix render :location => ... test. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6762 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-18 05:25:17 +00:00
Jeremy Kemper
1ac7cd56fe Clean up the simply_helpful merge. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6751 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-18 00:36:14 +00:00
David Heinemeier Hansson
ebee0a742d Added url_for usage on render :location, which allows for record identification [DHH] (still need to figure out why that test doesnt pass, seems like a test issue) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6750 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-17 20:48:47 +00:00
Tobias Lütke
04823ff48f Allow nested namespaces in routing 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6748 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-17 01:27:54 +00:00
Jeremy Kemper
73fbf7771b Add multipart and url-encoded form mime types. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6744 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-15 23:57:16 +00:00
Jeremy Kemper
f73e1c2ec0 Move request parameter parsing from CGI to AbstractRequest. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6742 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-15 22:10:03 +00:00
Jeremy Kemper
32d03af341 Introduce the request.body stream. Lazy-read to parse parameters rather than always setting RAW_POST_DATA. Reduces the memory footprint of large binary PUT requests. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6740 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-15 21:36:21 +00:00
Rick Olson
ebf9b3737b Add some performance enhancements to ActionView. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6736 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-15 06:36:34 +00:00