github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-03 02:35:08 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,121 Commits 34 Branches 105 Tags
34b94de8b87d7c32a1fdba72eb1f02296f31cffe
Commit Graph

5121 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
David Heinemeier Hansson
afd288cf81 Fixed that setting RAILS_ASSET_ID to "" should not add a trailing slash after assets (closes #6454) [BobSilva/chrismear] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5335 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-22 23:41:11 +00:00
Marcel Molina
ba5591f212 Expose methods added to Enumerable in the documentation, such as group_by. Closes #6170. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5334 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-22 03:04:50 +00:00
Marcel Molina
fb7807e244 Document other options available to migration's add_column. #6419 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5333 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-22 02:55:21 +00:00
Jamis Buck
da18193d5f More consistent implementation of filter replacement (thanks Martin! closes #5949) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5331 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-21 16:55:14 +00:00
Jeremy Kemper
8949ce0982 MySQL: all_hashes compatibility with old MysqlRes class. Closes #6429. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5330 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-20 20:30:59 +00:00
Jeremy Kemper
1742d0d707 mailer unit test handles nested fixture paths 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5329 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-20 19:33:14 +00:00
Jeremy Kemper
ef8f41dc68 reference view path in fixture 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5328 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-20 19:18:56 +00:00
Jeremy Kemper
8cbe2fed54 .rhtml extension for view only 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5327 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-20 19:17:02 +00:00
Jeremy Kemper
ba74754c4f Mailer generator: handle mailers in modules, set mime_version in unit test. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5326 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-20 19:06:07 +00:00
Rick Olson
1d7196b552 Force *_url named routes to show the host in ActionView [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-20 18:00:20 +00:00
Sam Stephenson
351a224d90 Add support for converting blocks into function arguments in JavaScriptGenerator#call and JavaScriptProxy#call. 
Add JavaScriptGenerator#literal for wrapping a string in an object whose #to_json is the string itself.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5323 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-19 22:03:27 +00:00
Rick Olson
dbd0bd5e5c Add <%= escape_once html %> to escape html while leaving any currently escaped entities alone. Fix button_to double-escaping issue. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5322 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-18 16:42:19 +00:00
Rick Olson
02358c83b7 Fix double-escaped entities, such as &amp;amp;, &amp;#123;, etc. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-18 15:58:07 +00:00
Jeremy Kemper
a0f74092a8 test deprecated instance variables using to_s instead of inspect which touches other ivars 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5320 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-18 00:04:47 +00:00
Michael Koziarski
301f721ef8 Default $KCODE to 'u' to enable the multibyte-safe chars proxy. [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5319 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-17 23:11:47 +00:00
David Heinemeier Hansson
f366eb4b2d GET parameter keys can be escaped too [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5318 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-17 22:06:54 +00:00
David Heinemeier Hansson
c1a52510ea Added config.plugins to control which plugins are loaded #6269 [skaes]. By default, everything in vendor/plugins will be loaded, but if you specify config.plugins, only those will be loaded. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5317 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-17 20:27:03 +00:00
Michael Koziarski
911f3db00a Ensure Chars#tidy_bytes only tidies broken bytes. Closes #6397 [Manfred Stienstra] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5316 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-17 08:29:16 +00:00
Jamis Buck
2d33676691 Fix deprecation warnings when rendering the template error template. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5315 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 19:59:46 +00:00
Nicholas Seckar
03b383853d Fix routing to correctly determine when generation fails. Closes #6300. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5314 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 19:52:21 +00:00
Nicholas Seckar
d1ae92eeb2 Remove extraneous expand_path; fix plugin load paths 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5313 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 18:29:31 +00:00
Nicholas Seckar
25b5161e16 Add plugins and builtins to the load_path. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5312 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 18:19:21 +00:00
Nicholas Seckar
64c7bf7481 Remove autoload_paths to simplify configuration. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5311 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 18:12:01 +00:00
Rick Olson
c5536f9f00 Fix has_many :through to add the appropriate conditions when going through an association using STI. Closes #5783. [Jonathan Viney] (sorry, forgot to commit the actual files) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5310 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 15:42:55 +00:00
Jamis Buck
b5ec0fe313 Fix broken assert_generates when extra keys are being checked. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5309 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 14:32:11 +00:00
Nicholas Seckar
497b5dcf19 Add 'unloadable', a method used to mark any constant as requiring an unload after each request. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5307 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-15 23:32:31 +00:00
Michael Koziarski
fa5080ae24 Tidy up the markup on the bundled error pages. Closes #6379. [Tim Lucas] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5306 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-15 23:32:30 +00:00
Rick Olson
cdb5132c41 Fix has_many :through to add the appropriate conditions when going through an association using STI. Closes #5783. [Jonathan Viney] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5305 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-15 16:37:11 +00:00
Jamis Buck
39963b4b9d remove an obsolete #dup call. avoid double negatives, to make the code easier to understand and explain 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5304 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-15 03:11:08 +00:00
Nicholas Seckar
2049313e3c Undo accidental commit 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5303 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-14 20:29:05 +00:00
Nicholas Seckar
4257fd6970 Rename overlapping test names 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5302 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-14 20:27:29 +00:00
Jamis Buck
ef6921628d make sure filters in subclasses with :only or :except conditions are treated like skip_filter calls 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5301 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-14 01:54:42 +00:00
Michael Koziarski
81ddeadd49 Replace KCODE checks with String#chars for truncate. Closes #6385 [Manfred Stienstra] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5300 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-14 00:31:30 +00:00
Jamis Buck
d73f32ce00 make sure the String::Access methods return strings, and not multibyte Char instances 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5299 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-13 20:27:46 +00:00
Rick Olson
2c6b6e2866 automatically add primary key to #select_limited_ids_list order by clause for databases that require order columns in the distinct statements (postgresql) [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5292 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-13 08:52:33 +00:00
Rick Olson
e789b26e65 fix select_limited_ids_list issues in postgresql, retain current behavior in other adapters [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5291 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-13 08:29:00 +00:00
Rick Olson
ce1d14430f add test for select_limited_ids_list that passes in mysql/sqlite and fails in postgresql 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5290 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-13 07:46:38 +00:00
Marcel Molina
065908a4c5 Make page caching respect the format of the resource that is being requested even if the current route is the default route so that, e.g. posts.rss is not transformed by url_for to '/' and subsequently cached as '/index.html' when it should be cached as '/posts.rss'. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5289 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-12 23:29:04 +00:00
Michael Koziarski
41c3623524 Use String#chars in TextHelper::excerpt. Closes #6386 [Manfred Stienstra] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5288 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-12 21:13:05 +00:00
Michael Koziarski
48cef84150 Make core_ext/string/access.rb multibyte safe. Closes #6388 [Manfred Stienstra] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5287 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-12 21:03:32 +00:00
Michael Koziarski
cb927c8774 Make String#chars slicing behaviour consistent with String. Closes #6387 [Manfred Stienstra] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5286 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-12 21:00:34 +00:00
Rick Olson
7870494673 Restore eager condition interpolation, document it's differences [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5284 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-11 14:02:24 +00:00
Nicholas Seckar
214d236e7d Install named routes into ActionView::Base instead of proxying them to the view via helper_method. Closes #5932. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5283 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-11 04:31:57 +00:00
Jeremy Kemper
1117387376 Compare to 0 rather than call zero? to handle nil. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5282 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-11 00:29:59 +00:00
Jeremy Kemper
629b8af2b0 Wrap save! in a transaction. Closes #6324. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5281 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-10 19:34:25 +00:00
David Heinemeier Hansson
5e08c668d2 Fixed default 404.html and 500.htmls to remove extreme ugliness and added error language fit for humans [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5279 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-10 18:18:27 +00:00
Nicholas Seckar
bbcd508d64 Fix typo 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5278 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 22:54:53 +00:00
Thomas Fuchs
b0e78c6278 Update to latest Prototype and script.aculo.us trunk versions 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5276 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 22:09:08 +00:00
Jeremy Kemper
f65ab3b233 improve example in migrations docs, closes #6370 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5275 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 22:05:50 +00:00
Jamis Buck
02dc646d55 Fix relative URL root matching problems 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5272 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 19:14:11 +00:00