github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-25 06:18:04 -05:00
Code Issues Packages Projects Releases Wiki Activity
1,243 Commits 34 Branches 105 Tags
359caef33ca71b37b3ea2feef0960beccfabf4de
Commit Graph

408 Commits

Author SHA1 Message Date
David Heinemeier Hansson
dab360e181 Added DoubleRenderError exception that'll be raised if render* is called twice #518 [Nicholas Seckar]. Fixed exceptions occuring after render has been called #1096 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1348 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 18:51:08 +00:00
David Heinemeier Hansson
3022ee84cc Added note of limitation for #1279 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1347 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 18:23:35 +00:00
David Heinemeier Hansson
a1e9ceebd5 Added Errors#add_on_blank which works like Errors#add_on_empty, but uses Object#blank? instead. CHANGED: validates_presence_of now uses Errors#add_on_blank, which will make " " fail the validation where it didnt before #1309. Added that " " is now also blank? (using strip if available) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1346 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 18:12:36 +00:00
David Heinemeier Hansson
10eb22cdce Added the :if option to all validations that can either use a block or a method pointer to determine whether the validation should be run or not. #1324 [Duane Johnson/jhosteny] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1340 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-21 10:57:18 +00:00
David Heinemeier Hansson
c8b4cf65df Speed up timestamping a tad #1227 [skaen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1327 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 19:05:12 +00:00
David Heinemeier Hansson
47dcc5ffc6 Fixed use of construct_finder_sql when using :join #1288 [dwlt@dwlt.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1316 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:23:28 +00:00
David Heinemeier Hansson
190e04645b Fixed that :delete_sql in has_and_belongs_to_many associations couldn't access record properties #1299 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1313 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:07:56 +00:00
David Heinemeier Hansson
b3fcf2fa3c Fixed docs for scaffolding generator #1303 [thijs@vandervossen.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1312 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 17:00:16 +00:00
David Heinemeier Hansson
6ea6a725c4 Push to .org instead 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1310 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 16:42:47 +00:00
David Heinemeier Hansson
bd79a4eb3b Fixed that clone would break when an aggregate had the same name as one of its attributes #1307 [bitsweat] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1309 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 16:39:50 +00:00
David Heinemeier Hansson
c8bd316754 Changed that destroying an object will only freeze the attributes hash, which keeps the object from having attributes changed (as that wouldn't make sense), but allows for the querying of associations after it has been destroyed. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1274 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-02 16:48:07 +00:00
David Heinemeier Hansson
24a9050b6e Changed the callbacks such that observers are notified before the in-object callbacks are triggered. Without this change, it wasn't possible to act on the whole object in something like a before_destroy observer without having the objects own callbacks (like deleting associations) called first. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1273 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-02 16:46:30 +00:00
David Heinemeier Hansson
cce294fd71 Started work on a per-request query cache 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1267 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-02 07:04:20 +00:00
David Heinemeier Hansson
5f77f64e92 Added option for passing an array to the find_all version of the dynamic finders and have it evaluated as an IN fragment 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1266 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-02 05:34:27 +00:00
David Heinemeier Hansson
b921b5da15 Fixed association picture reference 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1264 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 15:55:25 +00:00
David Heinemeier Hansson
2bf223051e Added compatibility with camelCase column names for dynamic finders #533 [Dee.Zsombor] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1263 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 15:49:28 +00:00
David Heinemeier Hansson
eefe4d0ddd Fixed extraneous comma in count() function that made it not work with joins #1156 [jarkko/Dee.Zsombor] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1262 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 15:45:15 +00:00
David Heinemeier Hansson
787951348b Fixed incompatibility with Base#find with an array of ids that would fail when using eager loading #1186 [Alisdair McDiarmid] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1259 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 14:04:01 +00:00
David Heinemeier Hansson
9f1b57779f Fixed that validate_length_of lost :on option when :within was specified #1195 [jhosteny@mac.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1258 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 14:02:03 +00:00
David Heinemeier Hansson
06f1895ac6 A few more tests #1199 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 13:24:43 +00:00
David Heinemeier Hansson
9ede45f60f Added encoding and min_messages options for PostgreSQL #1205 [shugo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 13:21:47 +00:00
David Heinemeier Hansson
b09fde1924 Fixed acts_as_list where deleting an item that was removed from the list would ruin the positioning of other list items #1197 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1237 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-25 16:11:31 +00:00
David Heinemeier Hansson
d8fc381ebc Added validates_exclusion_of as a negative of validates_inclusion_of 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1236 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-24 16:25:57 +00:00
David Heinemeier Hansson
56412f4441 Optimize counting of has_many associations by setting the association to empty if the count is 0 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1235 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-23 18:18:18 +00:00
David Heinemeier Hansson
83a531ed5b Fixed frivilous database queries being triggered with eager loading on empty associations and other things 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1232 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 17:05:54 +00:00
David Heinemeier Hansson
3140e37d18 Dont reload on empty associations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1231 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 16:59:30 +00:00
David Heinemeier Hansson
6f34400086 Fixed order of loading in eager associations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1229 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 16:32:57 +00:00
David Heinemeier Hansson
5462358cd3 Fixed that :get, :post, and the others should take a flash array as the third argument just like process #1144 [rails@cogentdude.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1227 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 11:04:38 +00:00
David Heinemeier Hansson
7881e4dae0 Fixed OCI fixtures [Ryan Carver] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1225 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 10:58:22 +00:00
David Heinemeier Hansson
4e2f7bec6f Added documentation about :limit not working with eager loading 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1224 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 10:39:12 +00:00
David Heinemeier Hansson
cdf88b7b04 Fixed stray comma when using eager loading and ordering together from has_many associations #1143 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1220 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-19 05:24:50 +00:00
David Heinemeier Hansson
7d01005514 Fixed documentation and prepared for release of 0.12 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1216 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 20:10:11 +00:00
David Heinemeier Hansson
f46486d37e Added Base.save! that attempts to save the record just like Base.save but will raise a InvalidRecord exception instead of returning false if the record is not valid [After much pestering from Dave Thomas] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1215 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 19:19:23 +00:00
David Heinemeier Hansson
49d0f0cb66 Speeded up eager loading a whole bunch 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1212 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 18:49:34 +00:00
David Heinemeier Hansson
c1611a703c Updated documentation here and there 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1210 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 15:31:20 +00:00
David Heinemeier Hansson
515886a565 Added documentation for new Base.find API and eager association loading 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1209 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 14:39:36 +00:00
David Heinemeier Hansson
c35ad2d508 Fixed PostgreSQL usage of fixtures with regards to public schemas and table names with dots #962 [gnuman1@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1206 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 08:11:15 +00:00
David Heinemeier Hansson
03097d3a60 Fixed that fixtures were being deleted in the same order as inserts causing FK errors #890 [andrew.john.peters@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1205 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 07:52:58 +00:00
David Heinemeier Hansson
b8c07c0325 Move nodoc to the individual methods 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1204 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 07:40:27 +00:00
David Heinemeier Hansson
a263612b7e Refactored a bit 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1202 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 07:02:12 +00:00
David Heinemeier Hansson
1a6954af01 Changed habtm eager loading to also use joins 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1201 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 05:55:20 +00:00
David Heinemeier Hansson
76690111d5 Fixes for postgresql testing #1129, #1130, #1131 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1199 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 05:03:56 +00:00
David Heinemeier Hansson
0591c53efd Made the dynamic finders use the new find API and updated the examples here and there 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1196 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 17:16:24 +00:00
David Heinemeier Hansson
7ff635c8eb Fixes a problem with the SQL Adapter which was resulting in IDENTITY_INSERT not being set to ON when it should be #1104 [adelle] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1192 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 13:59:02 +00:00
David Heinemeier Hansson
44073321a8 SqlServer fixtures - CategoriesPosts 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1191 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 13:57:25 +00:00
David Heinemeier Hansson
d5b67ed8d3 Added the option to specify the acceptance string in validates_acceptance_of #1106 [caleb@aei-tech.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1188 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 10:04:07 +00:00
David Heinemeier Hansson
78d8503a94 Added acts_as_nested_set #1000 [wschenk] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1186 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 09:59:52 +00:00
David Heinemeier Hansson
339f4956b3 Added acts_as_nested_set #1000 [wschenk] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1185 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 09:52:12 +00:00
David Heinemeier Hansson
ed46cc3058 Added insert_at(position) to acts_as_list #1083 [DeLynnB] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1179 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 06:50:17 +00:00
David Heinemeier Hansson
949294e0f7 Cleaned up validates_length_of by calling existing validations on the common stuff #1108 [caleb@aei-tech.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1178 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 06:34:13 +00:00