github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-25 22:38:33 -05:00
Code Issues Packages Projects Releases Wiki Activity
1,462 Commits 34 Branches 105 Tags
397c8ee2a9bd3e5a0113b8aaa8ccf6500a70ea77
Commit Graph

113 Commits

Author SHA1 Message Date
David Heinemeier Hansson
177ed3e681 Added more tests on assert_redirected_to #1581 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1609 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 18:16:38 +00:00
David Heinemeier Hansson
524d1b5e04 Uncommented request.recycle! as it breaks more than it fixes, left test case in, xal? 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1572 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-30 14:49:36 +00:00
David Heinemeier Hansson
94cae0d0a2 Got back to functional testing harmony 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1563 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-29 09:44:55 +00:00
Jeremy Kemper
31e48939b1 r1475@iwill: jeremy | 2005-06-28 23:19:51 -0700 
Ticket 1543 - Fix test_process
 r1476@iwill:  jeremy | 2005-06-29 00:20:53 -0700
 Correct expected, actual order for assert_equal.  Use new render method in TestController.
 r1477@iwill:  jeremy | 2005-06-29 00:23:45 -0700
 Generate route and assign parameters without modifying the user's params.
 r1480@iwill:  jeremy | 2005-06-29 00:28:52 -0700
 Update changelog.
 r1481@iwill:  jeremy | 2005-06-29 00:34:02 -0700
 Directly generate paths with a leading slash instead of tacking it on later.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1557 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-29 02:41:00 +00:00
Jamis Buck
453ed15395 Routes fail with leading slash #1540 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1555 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-28 21:18:04 +00:00
David Heinemeier Hansson
beffb77e05 Added support for upload progress indicators in Apache and lighttpd 1.4.x (won't work in WEBrick or lighttpd 1.3.x) #1475 [Sean Treadway] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1553 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-28 17:44:16 +00:00
David Heinemeier Hansson
b8689c77a4 Don't ignore :controller for urls made inside a controller module #1526 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-27 15:17:59 +00:00
David Heinemeier Hansson
a7116b6534 Make named routes work without hashes #1523 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-27 14:32:19 +00:00
David Heinemeier Hansson
2269c23699 Fixed assert_redirected_to to handle absolute controller paths properly #1472 [Rick Olson/Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1533 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-27 05:36:03 +00:00
David Heinemeier Hansson
930b59eb39 Fixed that Functional tests do not set request.path_parameters properly #1512 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1527 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-26 14:36:13 +00:00
David Heinemeier Hansson
6f6c6b8bcb Updated assert_generates/routing to the new Routes code #1498 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1505 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-25 10:58:44 +00:00
Jamis Buck
17928b7347 Eliminate a "string literal in condition" warning from some routes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1502 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-25 09:20:38 +00:00
Jamis Buck
af33a6a6b1 Fix problem with symbol/string mismatch on some routes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1500 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-24 22:15:45 +00:00
David Heinemeier Hansson
8e56f5ea3e Improved performance of Routes generation by a factor of 5 #1434 [Nicholas Seckar] Added named routes (NEEDS BETTER DESCRIPTION) #1434 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1496 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-24 16:40:01 +00:00
David Heinemeier Hansson
964a477340 Include Routing tests in rake run #1287 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-21 16:39:28 +00:00
David Heinemeier Hansson
1e0d9a642f Added :xhr => true/false option to verify so you can ensure that a request is coming from an Ajax call or not #1464 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1463 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-21 07:02:30 +00:00
David Heinemeier Hansson
92473b8f96 Fixed relative urls support for lighttpd #1048 [Nicholas Seckar/maznawak@nerim.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1450 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-18 05:17:18 +00:00
David Heinemeier Hansson
a895be0259 Fixed query parser to deal gracefully with equal signs inside keys and values #1345 [gorou] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-16 06:42:49 +00:00
Jeremy Kemper
7bb486055e r1318@iwill: jeremy | 2005-06-15 01:08:22 -0700 
Ticket 1394 - Helper isolation
 r1319@iwill:  jeremy | 2005-06-15 01:10:00 -0700
 Formulate a test case for helper isolation.
 r1331@iwill:  jeremy | 2005-06-15 15:21:07 -0700
 Update changelog
 r1332@iwill:  jeremy | 2005-06-15 15:21:30 -0700
 Remove superfluous, broken layout_test
 r1333@iwill:  jeremy | 2005-06-15 15:24:10 -0700
 Use an anonymous Module to store helpers per-class instead of tossing them all in template_class.  Create a new helper module for subclasses which includes its superclass' helper module.  Remove unnecessary ActionView::Base.controller_delegate.  Update helper tests.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1425 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-15 17:17:58 +00:00
Jamis Buck
14c378cc7f render(:template) applies a layout by default. render("foo/bar") works with a layout again. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-15 13:20:17 +00:00
David Heinemeier Hansson
cb79118111 Fixed double-singularization on scaffolded pagination call (Address would be turned into Addres) #1216, #1404 [nilsga] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-15 04:17:45 +00:00
Jamis Buck
75fb0a32a8 Support :render option to :verify #1440 [TobiasLuetke] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 13:23:55 +00:00
Jamis Buck
b2b757be39 Fix broken test case caused by change of testing address from 127.0.0.1 to 0.0.0.0 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1417 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-14 10:31:31 +00:00
Jamis Buck
f6ec9e3d66 Arrays sent via multipart posts are converted to strings #1032 [dj@omelia.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-10 12:21:25 +00:00
Jamis Buck
e4c047e489 render(:action) and render() are the only two render calls to use a layout by default. All others default to :layout => false. Also, allow :layout => true to be a synonym for :layout => nil. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1378 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-01 13:39:58 +00:00
Jamis Buck
6ce58318f5 render(:inline) defaults to :layout => false 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1372 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 09:12:12 +00:00
Jamis Buck
f8542a64b3 Make sure the benchmarking render method always returns the result of the render, regardless of whether logging is enabled or not. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1371 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 09:00:46 +00:00
Jamis Buck
f57ee365e1 render(:text), render(:partial), and render(:nothing) always default to :layout => false. This also fixes send_file, which was applying a layout if one existed for the current action. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1369 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 07:51:02 +00:00
Jamis Buck
613260606b verify with :redirect_to won't redirect if a redirect or render has already been performed #1350 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1367 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 07:24:46 +00:00
Jamis Buck
00db6f0faa render(:partial => "...") uses an empty hash for the local assigns #1365. render(:partial => true) is identical to the older render_partial() 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1366 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-30 07:20:37 +00:00
David Heinemeier Hansson
79d9794f09 Updated unit test style 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1355 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 17:12:29 +00:00
David Heinemeier Hansson
c41f0cc720 Test for no layout on nothing 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 16:59:55 +00:00
David Heinemeier Hansson
da0c4c5c96 Deprecated all render_* methods in favor of consolidating all rendering behavior in Base#render(options). This enables more natural use of combining options, such as layouts 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 08:58:43 +00:00
David Heinemeier Hansson
0367317dd6 Deprecated redirect_to_path and redirect_to_url in favor of letting redirect_to do the right thing when passed either a path or url. Introduced r as a unified method for render (still under construction) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1349 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-22 07:43:05 +00:00
David Heinemeier Hansson
d3704f888b Fixed assert_redirect_to to work with redirect_to_path #869 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1332 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 19:19:58 +00:00
David Heinemeier Hansson
dd8c92ea5b Fixed Request#remote_ip in testing #1251 [bitsweat] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1322 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 18:24:52 +00:00
David Heinemeier Hansson
aa20834222 Added accessors to logger, params, response, session, and headers from the view, so you can write <% logger.info "stuff" %> instead of <% @logger.info "others" %> -- more consistent with the preferred way of accessing these attributes and collections from the controller 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1307 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-05-19 16:00:04 +00:00
David Heinemeier Hansson
e6f3e5d900 Fixed action/fragment caching using the filestore when a directory and a file wanted to to use the same name. Now there's a .cache prefix that sidesteps the conflict #1188 [imbcmdth@hotmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1260 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 15:29:27 +00:00
David Heinemeier Hansson
b4fe4daa84 Fixed assert_redirected_to to work with :only_path => false #1204 [Alisdair McDiarmid] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-30 08:34:02 +00:00
David Heinemeier Hansson
3b9bf64130 Added support for web servers that use PATH_INFO instead of REQUEST_URI like IIS #1014 [BradG/Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1211 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-18 15:43:07 +00:00
David Heinemeier Hansson
806cf6d76a Added assert_tag and assert_no_tag as a much improved alternative to the deprecated assert_template_xpath_match #1126 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1195 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 16:43:48 +00:00
David Heinemeier Hansson
dca7efa67e Deprecated the majority of all the testing assertions and replaced them with a much smaller core and access to all the collections the old assertions relied on. That way the regular test/unit assertions can be used against these. Added documentation about how to use it all. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1189 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 11:38:01 +00:00
David Heinemeier Hansson
e5b3d08a0a Added that render_partial called from a controller will use the action name as default #828 [Dan Peterson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1182 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 09:25:54 +00:00
David Heinemeier Hansson
68dfe3e046 Clean up load paths to avoid unit test interaction #1113 [alles@atomicobject.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1174 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-17 06:16:00 +00:00
David Heinemeier Hansson
7f558cbd05 Fixed that *rest parameter in map.connect couldn't accept an empty list #1037 [Dee.Zsombor@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-13 05:35:51 +00:00
David Heinemeier Hansson
4ab40059b7 Added simulation of @request.request_uri in functional tests #1038 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-07 06:22:19 +00:00
David Heinemeier Hansson
7c8d2f28e1 Removed broken attempt to DRY module ClassMethod #970 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1069 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-02 09:29:43 +00:00
David Heinemeier Hansson
ce96c5b30b Added assert_no_cookie and fixed assert_cookie_equal to deal with non-existing cookies #979 [bitsweat] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1065 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-02 08:54:25 +00:00
David Heinemeier Hansson
00121b2ca2 Added :method option to verify for ensuring that either GET, POST, etc is allowed #984 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1060 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-04-02 08:33:30 +00:00
David Heinemeier Hansson
9fb6a54a16 Added fourth option to process in test cases to specify the content of the flash #949 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1009 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-26 21:43:25 +00:00