github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-04 03:05:27 -05:00
Code Issues Packages Projects Releases Wiki Activity
7,322 Commits 34 Branches 105 Tags
39ba2da82bcc2f9fad494e6ac0a66a3387ab8ee2
Commit Graph

883 Commits

Author SHA1 Message Date
Michael Koziarski
c3aaba0180 Simplify the implementation of assert_redirected_to to normalise the urls before comparing. Also allows for a simpler implementation of redirect_to without most of the recursion. 
Also allows for assert_redirected_to @some_record
 2008-07-04 10:41:40 +03:00
Michael Koziarski
db58391079 Remove old broken follow_redirect from functional tests. Still works in integration tests. 
The follow_redirect in functional tests only worked if you used redirect_to :id=>foo, :action=>bar, rather than named routes.
 2008-07-04 10:41:40 +03:00
Joshua Peek
01637796d7 Revert "Moved TemplateHandlers to Base" 
This reverts commit 42d215a925.

Conflicts:

	actionpack/lib/action_view/inline_template.rb
	actionpack/lib/action_view/template.rb
 2008-07-03 21:09:37 -05:00
josevalim
bad1eac91d Allow caches_action to accept cache store options. [#416 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-04 02:00:51 +01:00
Joshua Peek
42d215a925 Moved TemplateHandlers to Base 2008-07-03 12:48:00 -05:00
Michael Koziarski
12cf8f348b Move template_format logic out to the request so it's alongside the 'regular' request format. 
Use xhr? instead of the expensive trip through Request#accepts.
 2008-07-03 19:43:06 +03:00
Michael Koziarski
efd18066a2 Tighten the rescue clause here to prevent hiding strange mock related errors behind the line offset test 2008-07-03 19:21:04 +03:00
Tarmo Tänav
a37d065f85 Use :namespace instead of :path_prefix for finding controller. [#544 state:resolved] 
:namespace is supposed to be the module where controller exists.
:path_prefix can contain anything, including variables, which
makes it unsuitable for determining the module for a controller.

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-03 16:11:50 +01:00
Joshua Peek
3b3790a435 Deprecate :use_full_path render option. The supplying the option no longer has an effect. 2008-07-02 21:38:58 -05:00
Mike Subelsky
8f640c381d Added application/jsonrequest as a synonym for application/json 
[#536 state:resolved]
 2008-07-02 11:39:42 -07:00
Pratik Naik
2b43620e3c Add :as option to render a collection of partials with a custom local variable name. [#509 state:resolved] [Simon Jefford, Pratik Naik] 2008-07-02 16:40:42 +01:00
Tim Haines
f5052dd8a3 Make sure render :template works with :locals. [#524 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-07-02 04:30:34 +01:00
Joshua Peek
aff2d33172 Improved test coverage and added RackRequest support for CGI environment variables. 2008-07-01 21:53:55 -05:00
Joshua Peek
339491a6b3 Set precompiled fixture load path constant to speed up tests 2008-06-25 15:24:12 -05:00
Joshua Peek
6f5327013d Consolidate CustomHandlerTest, TemplateFileTest, and TemplateObjectTest and test them at a higher level of abstraction in ViewRenderTest. 2008-06-25 05:49:38 -05:00
Jimmy Baker
670e22e372 Patched HTML::Document#initialize call to Node.parse so that it includes the strict argument. [#330] 2008-06-24 23:11:35 -07:00
Tammer Saleh
bb6e8eea5a Fixed polymorphic_url to be able to handle singleton resources. 
Example usage:
polymorphic_url([:admin, @user, :blog, @post]) # => admin_user_blog_post_url(@user, @post)

[#461 state:resolved]
 2008-06-22 18:58:47 -07:00
Joshua Peek
40557e17dd Improved test coverage for integration test's api 2008-06-17 21:25:51 -05:00
Joshua Peek
bec4b69a3b Replaced TemplateFinder abstraction with ViewLoadPaths 2008-06-17 21:21:07 -05:00
Luke Redpath
7650ff892c Fix url_for with no arguments when default_url_options is not explicitly defined. [#339 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-06-17 20:53:41 +01:00
Amos King
1b4b8fbbd9 verify :redirect_to => :back should redirect to the referrer. [#280 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-06-17 18:08:56 +01:00
David Heinemeier Hansson
6573f6a4bc Revert "Lazy load cache and session stores" 
This reverts commit 19895f087c.
 2008-06-12 19:52:33 -05:00
Jonathan del Strother
3e07f320c1 Improve ActionCaching's format-handling 
Make ActionCaching more aware of different mimetype formats.
It will now use request.format to look up the cache type, in addition to the path extension.
When expiring caches, the request format no longer affects which cache is expired.

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-06-11 13:15:01 +01:00
Pratik Naik
0ad0bdc01c Delegate ActionView::Base#controller_name to controller 2008-06-10 23:55:04 +01:00
Pratik Naik
19895f087c Lazy load cache and session stores 2008-06-10 10:29:25 +01:00
Joshua Peek
d5539958a8 Wrap CGIResponse, LegacyRouteSet, Route, RouteSet and RouteLoading tests inside mocha block. 2008-06-07 23:42:05 -05:00
Jeremy Kemper
fe9d2ad6e8 Remove some internal dead code that supported content_for 2008-06-06 18:01:14 -07:00
Jeremy Kemper
9c9da5d927 Merge branch 'master' into erbout 2008-06-05 17:34:14 -07:00
Pratik Naik
1dbfe9766e Ensure render :file works inside templates 2008-06-05 23:33:10 +01:00
Frederick Cheung
2e0765a003 Make partial counter start from 0. 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-06-05 22:11:40 +01:00
Jeremy Kemper
e7f1556d0e Merge branch 'master' into erbout 2008-06-05 13:25:33 -07:00
Joshua Peek
c4d570c2eb Use CGI::Cookie::parse for request cookies until we officially deprecated CGI. 2008-06-04 22:32:09 -05:00
Jeremy Kemper
53bcbfbdc1 Merge branch 'master' into erbout 2008-06-03 22:38:27 -07:00
David Heinemeier Hansson
885453537e Merge branch 'master' of git@github.com:rails/rails 2008-06-03 18:12:56 -05:00
David Heinemeier Hansson
edfa195e2a Fixed Request#remote_ip to only raise hell if the HTTP_CLIENT_IP and HTTP_X_FORWARDED_FOR doesnt match (not just if theyre both present) [Mark Imbriaco, Bradford Folkens] 2008-06-03 18:11:47 -05:00
Gabe da Silveira
025515b234 Fix assert_redirected_to for nested controllers and named routes 
[#308 state:resolved]

Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2008-06-04 11:08:58 +12:00
josevalim
d54d90f2b5 Allow caches_action to accept a layout option [#198 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-06-03 14:02:51 -05:00
Joshua Peek
c08547d226 Namespace Inflector, Dependencies, OrderedOptions, and TimeZone under ActiveSupport [#238 state:resolved] 2008-06-03 13:32:53 -05:00
Jeremy Kemper
f55ad960d2 Stack @output_buffer for nested rendering 2008-06-03 01:10:00 -07:00
Jeremy Kemper
0bdb7d353b Work with @output_buffer instead of _erbout 2008-06-02 21:32:50 -07:00
Joshua Peek
92050f6c6f Ensure Rack processor reads CGI output_cookies for the session cookie. 2008-06-02 21:02:51 -05:00
Ezra Zygmuntowicz
06cb20708b Added Rack processor 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2008-06-01 11:25:11 -07:00
Jeremy Kemper
b43309328a Ruby 1.9 compat: ensure binary encoding for post body parsing 2008-05-19 16:24:26 -07:00
Jeremy Kemper
b5c8433a6f Ruby 1.9 compat: qualify module name within module_evaled block 2008-05-19 12:57:42 -07:00
Chris Hapgood
e6f5079a48 Test for assert_response for failure response without an exception. [#141 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-19 11:20:36 +01:00
José Valim
99860b72ae Add fragment_exist? and exist? methods to cache stores. [#203 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-19 10:38:59 +01:00
Sven Fuchs
345f030c5b Ensure routing generator works with non-string keys. [#172 state:resolved] 
Make sure that (with recent correction to globbed parameter escaping) non-string
values can still be passed route generation helpers for globbed route segments.

For example, foo_path([1, 2, 3]) should still work for a route like map.foo "*globbed"
by implicitely calling to_s on the Fixnums.

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2008-05-16 17:36:09 +01:00
Joshua Peek
bc3cc91a3f One last fix to test_filter_parameters_is_protected. 2008-05-14 14:14:23 -05:00
Joshua Peek
f32b974338 Clean up previously commited test. 2008-05-14 13:55:14 -05:00
Joshua Peek
1066b16237 Improve test coverage for filter_parameters [José Valim] 2008-05-14 13:38:02 -05:00