github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-01 17:54:59 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,847 Commits 34 Branches 105 Tags
39ccb5e807eadfc9bf6ac780778aa1de4d09e196
Commit Graph

1890 Commits

Author SHA1 Message Date
Rick Olson
39ccb5e807 Tweak template format rules so that the ACCEPT header is only used if it's text/javascript. This is so ajax actions without a :format param get recognized as Mime::JS. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-15 18:01:40 +00:00
Rick Olson
596112dcf8 remove useless mock test 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6518 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-12 20:26:42 +00:00
Rick Olson
6351e0a541 The default respond_to blocks don't set a specific extension anymore, so that both 'show.rjs' and 'show.js.rjs' will work. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6517 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-12 20:25:32 +00:00
Rick Olson
f5b8fc0335 Allow layouts with extension of .html.erb. Closes #8032 [Josh Knowles] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6516 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-12 17:11:48 +00:00
Tobias Lütke
01c35c8175 Removed ill faded xml_node class from codebase. Use XmlSimple instead 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6511 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-09 15:33:38 +00:00
Rick Olson
ec4d407d4f add #view_paths attr_accessor for ActionView::Base 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6509 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-08 18:29:57 +00:00
Rick Olson
da336c1cad add tip on keeping backwards compatibility 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6508 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-08 17:18:10 +00:00
Rick Olson
e0f8342676 Change default respond_to templates for xml and rjs formats. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6507 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-08 17:16:36 +00:00
Rick Olson
bdb1fcc3b8 Fix WSOD due to modification of a formatted template extension so that requests to templates like 'foo.html.erb' fail on the second hit. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6506 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-08 16:53:37 +00:00
Rick Olson
142b074e91 Fix WSOD when template compilation fails [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6505 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-08 02:32:25 +00:00
Rick Olson
da6f5a1cb4 Change ActionView template defaults. Look for templates using the request format first, such as show.html.erb or show.xml.builder, before looking for the old defaults like show.erb or show.builder [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6499 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-02 00:02:11 +00:00
Rick Olson
cf865196fe add ActionView::Base#find_template_extension_for tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6498 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-01 22:29:19 +00:00
Jeremy Kemper
67d5a1abed Highlight helper highlights one or many terms in a single pass. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6493 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-30 01:19:01 +00:00
David Heinemeier Hansson
0cac2806a6 Dropped the use of ; as a separator of non-crud actions on resources and went back to the vanilla slash. It was a neat idea, but lots of the non-crud actions turned out not to be RPC (as the ; was primarily intended to discourage), but legitimate sub-resources, like /parties/recent, which didn't deserve the uglification of /parties;recent. Further more, the semicolon caused issues with caching and HTTP authentication in Safari. Just Not Worth It [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6485 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-28 21:55:40 +00:00
Tobias Lütke
df3ee41126 Improved the handling of broken accept headers 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6484 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-28 16:42:21 +00:00
David Heinemeier Hansson
0228975a4e Added that FormTagHelper#submit_tag will return to its original state if the submit fails and you're using :disable_with [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6480 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-27 19:42:54 +00:00
Rick Olson
2a305949d7 documentation project patches, closes #7342, #7319, #7316, #7190 [jeremymcanally] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6470 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-27 14:04:06 +00:00
Jamis Buck
777deb9d15 Make sure the expiry hash is built by comparing the to_param-ized values of each hash 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-26 19:02:19 +00:00
Jeremy Kemper
b0685e9684 Fix PStore typo. Closes #7900. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6455 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-23 16:53:57 +00:00
Rick Olson
c6d7260841 Allow configuration of the default action cache path for #caches_action calls. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6453 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-22 10:12:34 +00:00
Tobias Lütke
f39fe3091f Fix nil error for requests with empty PATH_INFO header such as those which are send by the ScanAlert spider 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6451 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-19 18:02:24 +00:00
Jeremy Kemper
65704aeacd Never return nil from CGI#read_query for compatibility with plain CGI query params parser. Closes #7581. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6446 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-18 13:39:58 +00:00
Jeremy Kemper
c593721e7c Revert [6430] since the test is faulty. References #7837, closes #7842. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6435 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 13:55:36 +00:00
Jeremy Kemper
814dd007e5 Performance: patch cgi/session/pstore to require digest/md5 once rather than per #initialize. Closes #7583. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6431 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 05:52:12 +00:00
Jeremy Kemper
f596dda0bb Undeprecate redirect_to with Hash argument and additional url_for parameters. Closes #7837. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6430 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 05:21:19 +00:00
Jeremy Kemper
bbcfb9b625 Cookie session store: ensure that new sessions doesn't reuse data from a deleted session in the same request. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-14 11:33:10 +00:00
Jeremy Kemper
1f02271048 Deprecation: verification with :redirect_to => :named_route shouldn't be deprecated. Closes #7525. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-14 01:38:41 +00:00
Jeremy Kemper
5219aa9008 Cookie session store: raise ArgumentError when :session_key is blank. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6415 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 20:44:16 +00:00
Jeremy Kemper
f770165cc2 Deprecation: remove deprecated url_for(:symbol, *args) and redirect_to(:symbol, *args) controller methods. Use named routes instead. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6412 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 05:44:18 +00:00
Jeremy Kemper
1def3f0073 Deprecation: remove deprecated update_element_function, start_form_tag, and end_form_tag. Use RJS and form_tag instead. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6409 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 05:24:10 +00:00
Jeremy Kemper
2823a56f14 Deprecation: remove deprecated human_size helper alias. Use number_to_human_size instead. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6407 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 05:18:49 +00:00
Jeremy Kemper
dfc1285aad Deprecation: remove deprecated link_to_image and link_image_to methods. Use link_to(image_path(...), url). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6405 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 05:12:59 +00:00
Jeremy Kemper
d20b943551 Deprecation: privatize deprecated render_partial and render_partial_collection methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 05:06:41 +00:00
Jeremy Kemper
da87839c89 Deprecation: remove toplevel components directory and uses_component_template_root. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 04:46:12 +00:00
Jeremy Kemper
ee71950f60 Deprecation: remove deprecated dependency methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6402 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 04:37:39 +00:00
Jeremy Kemper
0631400b4a Deprecation: remove deprecated request methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6401 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 04:32:45 +00:00
Jeremy Kemper
cb6d94cc57 Deprecation: remove deprecated redirect methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6400 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 03:58:22 +00:00
Jeremy Kemper
83c8db9818 Deprecation: remove deprecated instance variables. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 03:49:52 +00:00
Jeremy Kemper
9c0fe36d46 Credit Dan by name rather than nick. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 02:16:27 +00:00
Jeremy Kemper
07d8f46b85 Consistent public/protected/private visibility for chained methods. Closes #7813. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6396 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 02:14:31 +00:00
Jeremy Kemper
8e01143854 Adjust test for unsorted Array#to_query. References #7756. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6380 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-11 13:29:40 +00:00
Jeremy Kemper
3edc98a1cc form_options_helper refactoring for clarity. Closes #7787. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6377 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-11 13:14:53 +00:00
Jeremy Kemper
9cc32a9ec8 Give time_ago_in_words test some DST slop. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6374 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-11 12:29:20 +00:00
David Heinemeier Hansson
182b3ed70c Backed out of using File.atomic_write in the asset_tag_helper.rb as its still half-baked. Most importantly, it creates files with different permissions than File.open/write 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-07 00:48:28 +00:00
David Heinemeier Hansson
d4528effbb Caching shouldnt include the host still 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6353 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-07 00:33:13 +00:00
Tobias Lütke
3644415a1e Cached versions of concatted js/css asset tags have to be written out atomically. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6351 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-06 14:22:40 +00:00
Jeremy Kemper
dbf42e379b Prefer MIME constants to strings. Closes #7707. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-06 09:46:04 +00:00
Jeremy Kemper
e17df19b86 Allow array and hash query parameters. Array route parameters are converted/to/a/path as before. References #6765, #7462. Closes #7047. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6343 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-06 07:47:23 +00:00
Rick Olson
2b7dbad8e0 Add a #dbman attr_reader for CGI::Session and make CGI::Session::CookieStore#generate_digest public so it's easy to generate digests 
using the cookie store's secret. [Rick]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6342 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-06 04:09:14 +00:00
Tobias Lütke
e52c28a425 Ignore odd charset declaration in CONTENT_TYPE header which would throw off mime type lookup. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6340 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-05 18:24:17 +00:00