Michael Koziarski
|
3fbfc13ee3
|
Move from select * to select tablename.* to avoid clobbering IDs. Closes #8889 [dasil003]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-07-07 02:42:42 +00:00 |
|
Michael Koziarski
|
d0ff4ec193
|
Don't call unsupported methods on associated objects when using :include, :method with to_xml [manfred, jwilger] Closes #7307
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-30 03:31:48 +00:00 |
|
Tobias Lütke
|
817d5d489d
|
Add the type="array" moniker to has_many / has_and_belongs_to_many associations upon serialization.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7144 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-27 16:37:40 +00:00 |
|
Jeremy Kemper
|
b5b16a80a9
|
Define collection singular ids method for has_many :through associations. Closes #8763.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7137 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-27 08:19:12 +00:00 |
|
Jeremy Kemper
|
02311a5db1
|
Array attribute conditions work with proxied association collections. Closes #8318.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7133 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-27 02:56:11 +00:00 |
|
Jeremy Kemper
|
89c79b8b95
|
Fix polymorphic has_one associations declared in an abstract class. Closes #8638.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7119 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-25 22:42:19 +00:00 |
|
David Heinemeier Hansson
|
279113f9b3
|
Fixed validates_associated should not stop on the first error (closes #4276) [mrj/manfred/josh]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-23 17:01:00 +00:00 |
|
Jeremy Kemper
|
048dcf31c9
|
Mock the beginning of the transaction also. References #8642.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7089 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-23 01:58:41 +00:00 |
|
Jeremy Kemper
|
c627590fd4
|
Rollback if commit raises an exception. Closes #8642.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7088 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-23 00:54:51 +00:00 |
|
Jeremy Kemper
|
dae6108998
|
Update tests' use of fixtures for the new collections api. Closes #8726.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7081 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-22 17:36:20 +00:00 |
|
Jeremy Kemper
|
989332c734
|
Save associated records only if the association is already loaded. Closes #8713.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7075 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-21 20:47:26 +00:00 |
|
Jeremy Kemper
|
eb2e30ef24
|
MySQL: fix show_variable. Closes #8448.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7071 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-20 18:30:35 +00:00 |
|
Rick Olson
|
6af2cbca07
|
remove extra debug line. Closes #8681 [Giles Bowkett]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7059 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-18 23:57:00 +00:00 |
|
Jeremy Kemper
|
7858a32e1b
|
Remove deprecated find_first and find_all.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6998 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-11 07:45:56 +00:00 |
|
Jeremy Kemper
|
800b899f96
|
Remove deprecated push_with_attributes.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6997 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-11 07:15:59 +00:00 |
|
Jeremy Kemper
|
813e8ba93b
|
Fix Base#inspect when not every attribute is present. Closes #8623.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6995 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-11 05:02:42 +00:00 |
|
Jeremy Kemper
|
9b444fe73b
|
Rollback [6961] which breaks SQLite tests. Reference #7345.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6965 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-08 01:40:05 +00:00 |
|
Jeremy Kemper
|
72401dcbd6
|
Quote db path so SQLite AR tests work on Windows. Closes #5278 [mislav@nippur.irb.hr]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6964 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-08 01:37:13 +00:00 |
|
Jeremy Kemper
|
869a172a8a
|
Migrations: raise if a column is duplicated. Closes #7345.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6961 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-07 23:25:50 +00:00 |
|
Jeremy Kemper
|
255b913637
|
Fix typo. Closes #7504 [aurelianito]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6943 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-05 04:32:08 +00:00 |
|
Jeremy Kemper
|
673daeabca
|
Fixtures: people(:technomancy, :josh) returns both fixtures. Closes #7880.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6940 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-05 03:47:02 +00:00 |
|
Jeremy Kemper
|
b05fc40b5d
|
Calculations support non-numeric foreign keys. Closes #8154.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6919 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-06-01 03:26:51 +00:00 |
|
Jeremy Kemper
|
d0360a4d5c
|
Base.inspect handles Base itself and abstract_class? Don't use #<Foo ...> since that notation's typically used for instances of a class, not the class itself. Closes #8490 [deepblue]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6913 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-31 17:31:33 +00:00 |
|
Jeremy Kemper
|
8158455ded
|
Fix an edge case with find with a list of ids, limit, and offset. Closes #8437.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6912 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-31 17:15:56 +00:00 |
|
Jeremy Kemper
|
1edd21bb02
|
with_scope is protected. Closes #8524.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6909 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-30 21:40:55 +00:00 |
|
Jeremy Kemper
|
1f802968c5
|
Calculations: return nil average instead of 0 when there are no rows to average. Closes #8298.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-30 06:57:04 +00:00 |
|
Jeremy Kemper
|
b2681cca2e
|
acts_as_nested_set: direct_children is sorted correctly. Closes #4761.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6903 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-30 06:34:25 +00:00 |
|
Jeremy Kemper
|
af98d883b9
|
Raise an exception if both attr_protected and attr_accessible are declared. Closes #8507, #6004.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6896 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-29 20:35:46 +00:00 |
|
Jeremy Kemper
|
ae242b0d23
|
Workaround test isolation failure with Task.attr_protected :starting.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6892 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-29 08:29:33 +00:00 |
|
Jeremy Kemper
|
69e4cc6e31
|
SQLite, MySQL, PostgreSQL, Oracle: quote column names in column migration SQL statements. Closes #8466.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6889 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-29 07:21:41 +00:00 |
|
Rick Olson
|
4472a30aad
|
Allow nil serialized attributes with a set class constraint. #7293 [sandofsky]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6879 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-28 15:51:53 +00:00 |
|
Jeremy Kemper
|
6f6328787c
|
Test that DateTime are quoted as DateTime not Date. Closes #8364 [chas]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6878 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-28 05:55:27 +00:00 |
|
Jeremy Kemper
|
33e96f3cb3
|
Oracle binary fixtures; pull fixture insertion into the adapters. Closes #7987.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6859 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-26 06:26:50 +00:00 |
|
Jeremy Kemper
|
2be3a33f32
|
find gracefully copes with blank :conditions. Closes #7599.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6852 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-26 00:35:49 +00:00 |
|
Jeremy Kemper
|
64d655628c
|
validates_numericality_of takes :greater_than, :greater_than_or_equal_to, :equal_to, :less_than, :less_than_or_equal_to, :odd, and :even options. Closes #3952.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6850 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-26 00:30:14 +00:00 |
|
Jeremy Kemper
|
ed2a84f99b
|
MySQL: create_database takes :charset and :collation options. Charset defaults to utf8. References #8448.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6848 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-26 00:20:37 +00:00 |
|
Jeremy Kemper
|
79212def83
|
Test that #to_xml takes a block. Closes #8471. [seth]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6847 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-25 23:04:45 +00:00 |
|
Jeremy Kemper
|
6149c39d14
|
Typo in [6845]. References #8437.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6846 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-25 22:05:57 +00:00 |
|
Jeremy Kemper
|
109926c5a3
|
Find with a list of ids supports limit/offset. Closes #8437.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6845 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-25 21:56:21 +00:00 |
|
Jeremy Kemper
|
c4a31560bd
|
Optimistic locking: revert the lock version when an update fails. Closes #7840. Also return the number of affected rows instead of true.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6843 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-25 21:31:44 +00:00 |
|
Jeremy Kemper
|
38deb0ed83
|
Migrations: add_column supports custom column types. Closes #7742. First-patch cheers to jsgarvin\!
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6842 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-25 21:21:41 +00:00 |
|
Jeremy Kemper
|
4793c5b808
|
Test reconnection after MySQL client timeout. References #428.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6838 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-25 21:09:46 +00:00 |
|
Jeremy Kemper
|
162a4c5309
|
Include some missing fixtures. Closes #7981.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6832 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-25 01:28:40 +00:00 |
|
Rick Olson
|
c57c7210cd
|
Ensure that associations with :dependent => :delete_all respect :conditions option. Closes #8034 [danger, joshpeek, Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6827 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-24 20:39:51 +00:00 |
|
Jeremy Kemper
|
4afd6c9f0a
|
belongs_to assignment creates a new proxy rather than modifying its target in-place. Closes #8412.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6804 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-22 03:39:36 +00:00 |
|
Rick Olson
|
f6edfa3553
|
forgot binary fixture
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6801 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-21 19:50:44 +00:00 |
|
Rick Olson
|
96bc3d224d
|
Fix column type detection while loading fixtures. Closes #7987 [roderickvd]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6798 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-21 18:54:51 +00:00 |
|
Jeremy Kemper
|
a995b9cde0
|
Fix #inspect for new records. Closes #8405.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-19 01:35:19 +00:00 |
|
Jeremy Kemper
|
4d753adeaf
|
Pay tribute to timezones. Tune #inspect style.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6766 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-18 07:24:03 +00:00 |
|
Jeremy Kemper
|
e48b062eed
|
Sanitize Base#inspect. Closes #8392.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6761 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-05-18 02:11:43 +00:00 |
|