Joshua Peek
4e50a35fa2
Break up DependencyModule's dual function of providing a "depend_on" DSL and "included" block DSL into separate modules. But, unify both approaches under AS::Concern.
2009-05-28 11:35:36 -05:00
Carl Lerche
a3ca5638d3
Get controller/test_test.rb to pass on new base
2009-05-26 14:13:35 -07:00
Pratik Naik
9d08f86cd4
Make assertion tests pass with the new base
2009-05-22 19:01:52 +02:00
Yehuda Katz + Carl Lerche
e693f45e15
Remove some response content type concepts from ActionView
2009-05-21 14:34:56 -07:00
Pratik Naik
386ff66e5e
Add Streaming to new base
2009-05-21 21:48:42 +02:00
Pratik Naik
e21d1614bb
Made ActionController::Verification work with new_base
2009-05-21 02:55:25 +02:00
Yehuda Katz + Carl Lerche
01f032f256
Added responds_to to new base.
2009-05-20 15:34:26 -07:00
Joshua Peek
6761759a90
Temporarily bundle rack-test while MockSession is baking
2009-05-19 22:43:22 -05:00
Bryan Helmkamp
df0faea378
Refactor ActionController instantiation capture
2009-05-19 22:43:21 -05:00
Bryan Helmkamp
0029d5e594
Integrating Rack::MockSession (from Rack::Test)
2009-05-19 22:43:21 -05:00
Pratik Naik
4a6f4b92ad
Change integration test helpers to accept Rack environment instead of just HTTP Headers.
...
Before : get '/path', {}, 'Accept' => 'text/javascript'
After : get '/path', {}, 'HTTP_ACCEPT' => 'text/javascript'
2009-05-19 23:50:03 +02:00
Joshua Peek
c3319504f0
Rescue hack was supposed to be removed. Some how it crept back in.
2009-05-17 12:24:59 -05:00
Jeremy Kemper
e8550ee032
Cherry-pick core extensions
2009-05-13 12:00:15 -07:00
Yehuda Katz + Carl Lerche
216309c165
Implemented redirects and partial rendering in new base.
2009-05-12 16:21:34 -07:00
Yehuda Katz + Carl Lerche
00a9d4b91c
Merge branch 'master' into wip_abstract_controller
...
Conflicts:
actionpack/lib/action_controller/abstract/callbacks.rb
actionpack/lib/action_controller/abstract/renderer.rb
actionpack/lib/action_controller/base/base.rb
actionpack/lib/action_controller/dispatch/dispatcher.rb
actionpack/lib/action_controller/routing/route_set.rb
actionpack/lib/action_controller/testing/process.rb
actionpack/test/abstract_controller/layouts_test.rb
actionpack/test/controller/filters_test.rb
actionpack/test/controller/helper_test.rb
actionpack/test/controller/render_test.rb
actionpack/test/new_base/test_helper.rb
2009-05-11 17:07:05 -07:00
Yehuda Katz + Carl Lerche
6694bd46f5
Aliased AbstractController::ActionNotFound to ActionController::UnknownAction
2009-05-11 12:45:26 -07:00
Joshua Peek
f32cf44870
Switch functional tests to run through the rack interface instead of process
2009-05-02 15:29:18 -05:00
Joshua Peek
a8b75c480f
Functional test runner finalizes response just like the integration test runner. In both runners, the @response object will now behave the same.
...
Some functional tests will need to be updated if they are relying on preprocessed data on the response.
2009-05-02 14:57:40 -05:00
Joshua Peek
3900f4007e
Deprecate assert_redirect_to's partial hash matching
2009-05-02 14:23:44 -05:00
Yehuda Katz
72160d9f89
Implement FooController.action(:name)
...
* Rails actions are now Rack endpoints, and can be retrieved
via FooController.action(name) and called with an env
* Updated some tests that relied on the old internal
#process/#call implementation
2009-05-02 02:15:09 -07:00
Yehuda Katz + Carl Lerche
ad2a1b5cb1
Get render :inline working
2009-05-01 18:17:08 -07:00
Yehuda Katz + Carl Lerche
7dd072d333
A few more tweaks to get new Base running old render tests again
2009-05-01 17:53:20 -07:00
Yehuda Katz + Carl Lerche
b1d34b3aa4
Starting to get new_base to run on old tests
2009-05-01 17:31:03 -07:00
Joshua Peek
05bd863c02
alias method chain process with test
2009-04-30 23:46:35 -05:00
Joshua Peek
1fcc7dbcc8
Move TestRequest#query_parameters into AD TestRequest
2009-04-30 23:46:34 -05:00
Joshua Peek
0fa1e75d41
Set rack.input instead of RAW_POST_DATA in TestRequest
2009-04-30 20:04:55 -05:00
Joshua Peek
261ec996de
Missed stray @request_uri
2009-04-30 19:36:18 -05:00
Joshua Peek
a6fff94baf
Move TestRequest cookies accessor into AD TestRequest
2009-04-30 19:23:50 -05:00
Joshua Peek
00d1a57e9f
Start moving TestRequest and TestResponse into ActionDispatch
2009-04-30 17:26:03 -05:00
Joshua Peek
64e66cf161
Vendor new Rack::Mock changes
2009-04-30 14:40:46 -05:00
Joshua Peek
9bac470c7a
Group integration test helpers and delegate other helpers to request and response objects
2009-04-30 14:28:42 -05:00
Joshua Peek
ba9887c9c0
Switch to action_dispatch rack namespace
2009-04-30 13:45:12 -05:00
Joshua Peek
7b3b7cb2ab
Move generic assertions into ActionDispatch
2009-04-30 11:55:53 -05:00
Joshua Peek
98dd726687
Test::Unit work arounds are handled by ActiveSupport
2009-04-30 11:42:01 -05:00
Joshua Peek
988513ac7a
Framework backtrace cleaning is handled by ActiveSupport now
2009-04-30 11:42:01 -05:00
Joshua Peek
c0a372ba87
Deprecate template, session, assigns, and layout accessors on response object. Instead access them through the controller instance. This mainly affects functional test assertions.
2009-04-28 23:29:46 -05:00
Joshua Peek
d63b42da36
Move header injection back into integration tests
2009-04-28 23:29:46 -05:00
Joshua Peek
afa7d7ff05
Fix validate_request method name
2009-04-28 23:29:45 -05:00
Yehuda Katz + Carl Lerche
cecafc52ee
Refactor ActionView::Template
...
ActionView::Template is now completely independent from template
storage, which allows different back ends such as the database.
ActionView::Template's only responsibility is to take in the
template source (passed in from ActionView::Path), compile it,
and render it.
2009-04-27 11:49:11 -07:00
Joshua Peek
21aa32692c
Delegate controller.session to request.session and deprecate response session
2009-04-27 13:11:17 -05:00
Jeremy Kemper
f7d7dc5aa8
Use session= writer methods
2009-04-26 17:19:14 -07:00
Joshua Peek
0494909679
Inherit TestSession from Session::AbstractStore and add indifferent access to Session::AbstractStore.
2009-04-26 14:33:57 -05:00
Joshua Peek
c8919f4c7c
Require an ActionDispatch::Request to use response assertions
2009-04-26 11:52:45 -05:00
Joshua Peek
6940c0de12
Unify functional and integration tests cookie helpers
2009-04-26 11:37:11 -05:00
Joshua Peek
5ea8d40156
Deprecate response.redirect_url_match?, use assert_match instead.
2009-04-26 11:16:14 -05:00
Joshua Peek
5352a2417b
Move useful response test helpers into request
2009-04-26 11:12:33 -05:00
Joshua Peek
044794fc9e
Remove pending rack specifications until they are official
2009-04-25 13:41:30 -05:00
Joshua Peek
dd2ed32418
Start to integrate some of the features in Rack::Test.
...
Eventually commit ActionDispatch::Test::MockRequest and ActionDispatch::Test:: UploadedFile upstream.
2009-04-24 20:24:54 -05:00
Jeremy Kemper
a22a778f86
render_for_text pushes a body part instead of replacing the whole body
2009-04-17 21:33:09 -05:00
Carl Lerche & Yehuda Katz
906aebceed
Bring abstract_controller up to date with rails/master
...
Resolved all the conflicts since 2.3.0 -> HEAD. Following is a list
of commits that could not be applied cleanly or are obviated with the
abstract_controller refactor. They all need to be revisited to ensure
that fixes made in 2.3 do not reappear in 3.0:
2259ecf36806182ea02e#1844 state:resolved]
* This will be handled generically
893e9eb995#1909 state:resolved]
* We will need to reimplement rails-dev-boost on top of the refactor;
the changes here are very implementation specific and cannot be
cleanly applied. The following commits are implicated:
199e750d463942cb406ef8ea9f85d4e3b166aab3ae9f258e0344423126c60cb020b4d6#1974 state:resolved]
* The specifics of this commit no longer apply. Since it is a two-line
commit, we will reimplement this change.
8c5cc66a83#1974 state:resolved]
* This does not apply at all. It should be trivial to apply the feature
to the reimplemented ActionController::Base.
87e8b16246#2052 state:resolved]
* There were a number of patches related to this that simply compounded
each other. Basically none of them apply cleanly, and the underlying
issue needs to be revisited. After discussing the underlying problem
with Koz, we will defer these fixes for further discussion.
2009-04-13 15:18:45 -07:00
