github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,700 Commits 34 Branches 105 Tags
4da32babdf04a151ec633cebf412fa6ca61e556d
Commit Graph

4865 Commits

Author SHA1 Message Date
Piotr Sarnacki
4da32babdf Reload action_methods in AbstractController after defining new method. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-04 14:45:55 -03:00
wycats
32d840d98a Concernify SanitizeHelper and TextHelper so including TextHelper correctly include SanitizeHelper and extends its ClassMethods 2010-08-04 03:20:44 -07:00
wycats
bd1cf94a29 Add a fake UrlRewriter, since instantiating it in tests happens, but is basically crazysauce 2010-08-04 03:20:08 -07:00
wycats
109dc3c39c Deprecate the @controller instance variable 2010-08-03 14:23:46 -07:00
wycats
af8e085190 Move the deprecations before the load hooks 2010-08-03 12:50:41 -07:00
wycats
84703be5ff Deprecate ActionController::UrlWriter properly 2010-08-03 12:41:18 -07:00
wycats
43cc69cb65 Fix the session= deprecation to include the secret key 2010-08-03 12:31:39 -07:00
wycats
01186652cc Even though exempt_from_layout is no longer needed, some people are still using it. Deprecate it instead of removing. 2010-08-03 12:29:03 -07:00
Samuel Lebeau
a44779e9bb Avoid potentially expensive inspect call in router. [#4491 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-03 12:03:45 +02:00
Carlos Antonio da Silva
11614bddc0 Fix label form helper to use I18n and html options, without the need of 'nil' text param: 
Before: f.label :title, nil, :class => 'title'
  After : f.label :title, :class => 'title'

[#5267 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-01 21:51:54 -03:00
Santiago Pastorino
fb0bd8c109 Makes form_helper use overriden model accessors 
[#3374 state:committed]
 2010-08-01 19:32:22 -03:00
Rohit Arondekar
48d85a61bc API Docs: Use 'HTTP_AUTHORIZATION' and not :authorize as key in integration tests. 2010-07-30 02:12:35 -07:00
Xavier Noria
755af49755 edit pass to apply API guideline wrt the use of "# =>" in example code 2010-07-30 02:30:04 +02:00
José Valim
0f0bdaea7b Revert "Avoid uneeded queries in session stores if sid is not given." 
First step to merge Rails and Rack session stores. Rack always expects to receive the SID since it may have different behavior if the SID is nil.

This reverts commit e210895ba9.
 2010-07-29 09:10:01 +02:00
wycats
aa24ea41d0 Forgot to check in this new file 2010-07-27 20:38:26 -07:00
wycats
123eb25fd1 Add a header that tells Internet Explorer (all versions) to use the best available standards support. This ensures that IE doesn't go into quirks mode because it has been blacklisted by too many users pressing the incompatible button. It also tells IE to use the ChromeFrame renderer, if the user has installed the plugin. 
This guarantees that the best available standards support will be used on the client.
 2010-07-27 19:25:07 -07:00
David Heinemeier Hansson
856fc4bbc3 Prep for RC 2010-07-26 12:53:25 -05:00
Wincent Colaiuta
c819c131f2 doc: cleanup respond_to documentation 
Signed-off-by: Wincent Colaiuta <win@wincent.com>
 2010-07-26 18:55:51 +02:00
Łukasz Strzałkowski
da845275dd Removed deprecated APIs in text and number helpers [#5156 state:resolved] 
They're deprecated since 2008. It's time to get rid of them.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-26 17:26:59 +02:00
Xavier Noria
6aa1253588 Merge remote branch 'docrails/master' 2010-07-26 00:23:57 +02:00
Santiago Pastorino
b1cfcedc8f Change returning with tap 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-25 16:33:04 +02:00
Sebastian A. Espindola
8d5b792e7d Fixed output_buffer encoding problem [#5179] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-25 16:33:04 +02:00
José Valim
76b6136b00 Clean up AM and AC railties. 2010-07-24 00:48:12 +02:00
José Valim
2af8fd2829 Also move asset_path to AbstractController. 2010-07-24 00:47:48 +02:00
Jeroen van Dijk and Josh Kalderimis
affeb51569 Move config_accessor :asset_host from ActionController::Base to AbstractController which fixes issues with asset_host in ActionMailer 
Including:
  - Moved mailer objects in separate directory
  - Added two tests for asset_host configuration option
 2010-07-24 00:27:25 +02:00
Andrew Kaspick
cf5c2bacb0 update remote_function docs referencing link_to_remote 2010-07-22 14:59:52 -05:00
Santiago Pastorino
a1e795f554 options could be of any kind of Hash (Hash, HashWithIndifferentAccess or OrderedHash) this way we keep the properties of the options passed as an argument 2010-07-21 17:34:02 -07:00
Wincent Colaiuta
198975ecee doc: form_for does return output rather than merely evaluate its block 2010-07-22 01:28:31 +02:00
Mislav Marohnić
efdfcf1325 correct typos in Routing examples 2010-07-22 01:28:30 +02:00
Brian Rose
622092d33e Fixed a globbed route issue where slashes were being escaped, causing assert_routing to fail. [#5135 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 22:07:40 +02:00
Andrew Kaspick
a1a41a3939 remote_function patch with more detailed test 
Signed-off-by: wycats <wycats@gmail.com>
 2010-07-21 10:04:55 -07:00
José Valim
e13e8dcf44 Use capture instead of yield in link_to_unless. 
[#5162 state:resolved]
 2010-07-21 15:23:14 +02:00
José Valim
9dfe9fa693 Ensure insert_before in middleware stack raises a meaningful error message [#3679 state:resolved] 2010-07-21 15:17:04 +02:00
José Valim
0a729b0a91 Fix failing railties tests. 2010-07-21 14:16:37 +02:00
José Valim
c565f0060a No need to delegate. Simply include the whole RecordIdentifier module. 2010-07-21 11:46:38 +02:00
Piotr Sarnacki
6807b08099 Moved a few methods from RecordIdentifier to ActiveModel::Naming 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 11:29:58 +02:00
Piotr Sarnacki
a63566dda8 Moved PolymorphicRoutes to ActionDispatch::Routing 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-20 23:12:46 +02:00
José Valim
9df9c4bac0 Add a test for elapsed and require missing benchmark file. 2010-07-20 17:07:18 +02:00
José Valim
51d2db0a63 Add missing require to metal/streaming.rb 2010-07-20 09:56:16 +02:00
Bryan Helmkamp
e466354edb Extract ParameterFilter class from FilterParameters mixin 
Signed-off-by: wycats <wycats@gmail.com>
 2010-07-19 13:44:43 -07:00
José Valim
c3c349ec3e Remove assert_valid. It was already deprecated on Rails 2.3. 2010-07-19 22:35:17 +02:00
Santiago Pastorino
17600eb435 Remove unused orig_handler and unneeded parentheses 2010-07-20 04:32:08 +08:00
José Valim
70f7ba3e3b There is absolutely no need to use __send__ here. 2010-07-19 14:56:09 +02:00
José Valim
ab6ff85906 No need to create a new module in the previous commit. 2010-07-19 14:50:38 +02:00
Neeraj Singh
33c5689e2d Exceptions from views should be rescued based on the original exception. If a handler for original exception is missing then apply ActiveView::TemplateError 
[#2034 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-19 14:50:38 +02:00
José Valim
291adcd588 Set session options id to nil is respected and cancels lazy loading. 2010-07-18 12:51:03 +02:00
Ivan Torres
cdfa11409c select :include_blank or :prompt should return escaped string [#5099 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 11:32:00 +02:00
Neeraj Singh
1f499e6d4c fixing the ternary operation where the logic is very confusing. 
[#5136 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 11:31:54 +02:00
José Valim
e210895ba9 Avoid uneeded queries in session stores if sid is not given. 2010-07-18 11:02:08 +02:00
Nick Quaranto
7aec9f9c02 Removing ActionDispatch::Http::FilterParameters#fitered_parameters alias 2010-07-18 06:04:55 +08:00