github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
19,891 Commits 34 Branches 105 Tags
4dec00a9d8262d85b733aa3bd5b68d2b7de950a7
Commit Graph

2712 Commits

Author SHA1 Message Date
Neeraj Singh
0027b65421 Ensure that while caching a page rails takes into 
account the resolved mime type for the request

[#6110 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-12-09 16:14:57 +01:00
José Valim
8e6d27641c Clean up asset_host and asset_path. 2010-12-09 13:40:45 +01:00
Xavier Noria
0aa78826e4 makes a pass to the action caching rdoc 2010-12-08 21:20:53 +01:00
Neeraj Singh
3ac844deec Add to documentation that action caching does 
handle HTTP_ACCEPT attribute properly and might
provide wrong result. Use params[:format] to
avoid this issue.
 2010-12-06 16:38:47 -05:00
Xavier Noria
fd83f9d515 Merge branch 'master' of git://github.com/lifo/docrails 2010-11-27 07:43:59 +01:00
Ryan Bigg
167964149e Add explicit statement that verify_authenticity_token can be turned off for actions. 2010-11-27 07:57:10 +11:00
Santiago Pastorino
74049b57fb implicit self here 2010-11-25 21:31:14 -02:00
Josh Kalderimis
a98d9d65ae move the setting up of the mime collector into the collector on init 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-11-25 21:24:45 -02:00
Neeraj Singh
fa2a5ae033 If a user wants json output then try best to render json output. In such cases prefer kind_of(String) over respond_to?(to_str) 
[#5841 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-24 22:08:36 +01:00
Josh Kalderimis
2fe43b694f :subdomain, :domain and :tld_length options can now be used in url_for, allowing for easy manipulation of the host during link generation. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-23 09:54:42 +01:00
Santiago Pastorino
c937ddb5ce Remove unused constant 2010-11-22 19:00:05 -02:00
Santiago Pastorino
6e559168dc There's no need for ternary op here 2010-11-22 18:47:47 -02:00
Santiago Pastorino
559c4292bc Remove unneeded metaprogramming and method generation in favor of direct definition 2010-11-22 16:02:13 -02:00
Josh Kalderimis
d7db6a8873 class inheritable attributes is used no more! all internal use of class inheritable has been changed to class_attribute. class inheritable attributes has been deprecated. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-11-20 19:40:29 +01:00
Santiago Pastorino
4f3b5b8ec1 Fix indentation 2010-11-20 02:46:55 -02:00
Piotr Sarnacki
250fb3f6c2 Add config.action_controller.include_all_helpers, by default it is set to true. 
In older rails versions there was a way to use only helpers from
helper file corresponding to current controller and you could also
include all helpers by saying 'helper :all' in controller. This config
allows to return to older behavior by setting it to false.
 2010-11-18 00:20:57 +01:00
Santiago Pastorino
46332e458c Move @assigns from the controller to the test itself 2010-11-06 21:15:59 -02:00
Santiago Pastorino
2382667955 Fix problems trying to functional test AC::Metal controllers 
[#5393 state:committed]
 2010-11-06 21:15:03 -02:00
Chris Eppstein
b1667c7c2c Correctly handle the case of an API response that returns a hash by treating a single hash argument as the resource instead of as options. 2010-11-06 06:56:36 +08:00
Krekoten' Marjan
608bf7b72c AC::Caching DRYup 
Remove ActionController::Caching::Pages#caching_allowed
because it duplicates ActionController::Caching#caching_allowed?

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-10-18 17:30:28 -02:00
Andrew White
f7573175de Reset assert_template instance variables between requests [#5832 state:resolved] 2010-10-18 09:57:51 +01:00
Neeraj Singh
ea14396c45 replace if ! with unless 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-10-17 12:26:32 -02:00
Xavier Noria
13f7f89bda Merge branch 'master' of git://github.com/lifo/docrails 2010-10-14 23:15:23 +02:00
Krekoten' Marjan
0744d36f47 Fix small typo in documentation 2010-10-12 22:55:19 +03:00
Szymon Nowak
0d33332571 Return a valid empty JSON on successful PUT and DELETE requests. [#5199 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-10-12 00:56:07 +02:00
wycats
b3cadf338b Rendering doesn't need RackDelegation 2010-10-10 00:54:11 -07:00
wycats
8cb2cfbf71 Fix a few bugs when trying to use Head standalone 2010-10-10 00:54:11 -07:00
Xavier Noria
db520042b3 Merge branch 'master' of git://github.com/lifo/docrails 2010-10-06 23:16:13 +02:00
José Valim
d649bf158b Provide a cleaner syntax for paths configuration that does not rely on method_missing. 2010-10-06 17:20:15 +02:00
John Firebaugh
b1047888fb render :text => proc { ... } is no longer supported. 2010-10-04 11:14:42 -07:00
José Valim
653acac069 Solve some warnings and a failing test. 2010-10-03 21:45:30 +02:00
José Valim
50215f9525 Rely on Rack::Session stores API for more compatibility across the Ruby world. 2010-10-03 21:24:22 +02:00
Neeraj Singh
8efdffeda3 no need of nil check 2010-09-30 08:11:34 +08:00
Aaron Patterson
ab0d216b67 reduce function calls on Array 2010-09-29 15:43:27 -07:00
Aaron Patterson
3f88f26d1e removing more lolinject 2010-09-29 15:41:06 -07:00
Aaron Patterson
2437356cda removing lollerject 2010-09-29 15:37:38 -07:00
José Valim
0bbf9029e8 Merge remote branch 'miloops/warnings' 2010-09-29 10:04:42 +02:00
Emilio Tagua
3f94b45262 Remove more warnings: no need to define attr_accessor if already exists. Initialize ivar. 2010-09-28 17:08:43 -03:00
Emilio Tagua
71acc2737a Move uri parser to AS as URI.parser method to reuse it in AP and ARes. 2010-09-28 11:38:35 +08:00
Emilio Tagua
197a995bc5 Move uri parser to AS as URI.parser method to reuse it in AP and ARes. 2010-09-27 20:57:26 -03:00
José Valim
8aa86babad Fix tests on 1.9.2. 2010-09-28 00:39:29 +02:00
Diego Carrion
72f37bd8bc renderer calls object.to_json when rendering :json => object [#5655 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-27 23:11:29 +02:00
Emilio Tagua
1ab2ab07b5 Remove more warnings shadowing outer local variable. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-27 16:43:17 -03:00
Emilio Tagua
2f326b7f27 Remove warning "URI.unescape is obsolete" from actionpack. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-27 16:43:04 -03:00
José Valim
8aa3684e07 Do not cache the script name outcome. 2010-09-27 21:14:18 +02:00
José Valim
fe0251e408 Merge remote branch 'miloops/warnings' 
Conflicts:
	actionpack/lib/action_controller/metal/url_for.rb
 2010-09-27 21:00:54 +02:00
José Valim
6067d16200 Call it compile_methods! and do the same on AM. 2010-09-27 20:43:56 +02:00
thedarkone
8fdb34b237 Cache url_options on a per-request basis. 2010-09-27 17:45:59 +02:00
thedarkone
918dc27345 Compile ActionController::Base.config's methods to avoid method_missing overhead. 2010-09-27 17:45:58 +02:00
Emilio Tagua
023c2020b3 Initialize @_routes if not defined yet, avoiding more warnings. 2010-09-27 11:19:24 -03:00