github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,988 Commits 34 Branches 105 Tags
4e40f00565c2ccff8361fd6d87abecbbcc06a87e
Commit Graph

2992 Commits

Author SHA1 Message Date
José Valim
80e1f730a2 Allow format to be skipped. This is used internally by mount. 2010-08-24 16:58:32 -03:00
José Valim
e197d6f34b Finally fix the bug where symbols and strings were not having the same behavior in the router. 
If you were using symbols before for methods like match/get/post/put/delete, it is likely that this commit will break your routes.
Everything should behave the same if you are using strings, if not, please open up a ticket.
 2010-08-24 16:58:25 -03:00
José Valim
4a90ecb3ad Ensure shortcuts inside resources also generates helpers. 2010-08-24 16:58:12 -03:00
José Valim
2916521da8 Fix how routes inside namespaces are generated. 2010-08-24 13:05:29 -03:00
Santiago Pastorino
4df19b3f27 Allow actions which start with A-Za-z_ only 2010-08-24 12:43:43 -03:00
Andrew White
11f6179f55 Reset symbolized path parameters when a test request is recycled [#5437 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-24 11:24:32 -03:00
José Valim
b4f304b7b6 Fix a bug where symbols and strings were not behaving the same in the router. [#5431 state:resolved] 2010-08-24 10:26:25 -03:00
Andrew White
2fb0cbec02 When custom resource actions are specified using strings add the default name and action if the string is a valid ruby method name. 
[#5431 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-24 10:26:25 -03:00
Santiago Pastorino
bb75c33754 Config is deprecated on 1.8.8 and 1.9.3 use RbConfig 2010-08-23 23:10:36 -03:00
Santiago Pastorino
8d1ee434da Silence warnings for Encoding.default_external= and Encoding.default_internal= 2010-08-22 18:43:31 -03:00
Andrew White
ae2c60734a Cache the symbolized path parameters using a instance variable in the request object rather than the environment hash. This it to prevent stale parameters in later routing constraints/redirects as only the normal path parameters are set by Rack::Mount. 
Also if a constraint proc arity is more than one, pass the symbolized path parameters
as the first argument to match redirect proc args and provide easier access.

[#5157 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-22 16:17:26 -03:00
Santiago Pastorino
1d888d465b Move encoding settings for testing purposes to abstract_unit file 2010-08-21 22:37:53 -03:00
Andrew White
7c9bf45b0d Support routing constraints in functional tests 
Extend assert_recognizes and assert_generates to support passing
full urls as the path argument. This allows testing of routing
constraints such as subdomain and host within functional tests.

[#5005 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-20 14:51:25 -03:00
Andrew White
0d0fbf1e64 Don't add the standard https port when using redirect in routes.rb and ensure that request.scheme returns https when using a reverse proxy. 
[#5408 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-20 10:40:34 -03:00
Andrew White
771d2f918f Allow symbols for :path resource(s) option [#5306 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-20 09:32:48 -03:00
Andrew White
c019db8ca1 Move regexps in options hash to :constraints hash so that they are pushed into the scope [#5208 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-19 15:05:57 -03:00
Andrew White
0cc483aa14 Move edit route before show route so that it will have precedence if the :id parameter allows slashes [#5409 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-19 15:05:33 -03:00
wycats
483b60b9ff Revert "It's snowing!" 
This reverts commit e4283007d6.
 2010-08-18 16:49:06 -07:00
Javier Martín
3e871eee80 Don't pluralize resource methods [#4704 state:resolved] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-18 13:56:46 -03:00
Andre Arko
fca617af14 Allow member actions (get, etc) to accept strings, with test 2010-08-17 20:41:13 -03:00
Xavier Noria
fb6b805620 code gardening: we have assert_(nil|blank|present), more concise, with better default failure messages - let's use them 2010-08-17 03:32:11 +02:00
Subba Rao Pasupuleti
54477c9848 select tags coerce the :selected option, options to strings before comparison [#5056 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-15 16:46:32 -03:00
Bryce Thornton
fd78bb7270 Allow for any possible TLD when using the :all option with the cookie session store. This works for subdomain.mysite.local, google.co.uk, google.com.au, etc. [#5147 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-15 16:42:02 -03:00
Mikel Lindsaar
fd9f3ad36b Making time_zone_options_for_select return a html_safe string 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-15 09:58:40 -03:00
Santiago Pastorino
ad4272922d object/try should be required after abstract_unit to have AS in the load path 2010-08-14 18:33:38 -03:00
Santiago Pastorino
b451de0d6d Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;) 2010-08-14 04:12:33 -03:00
Jeremy Kemper
c49144b2f7 It's snowing! 2010-08-12 13:32:00 -07:00
wycats
c6160898c8 Replace snowman with utf8=✓ 2010-08-11 18:37:57 -07:00
José Valim & Carlos Antonio da Silva
f08b58dd0c layout_for works again with objects as specified in the documentation and Rails 2.3 [#5357 state:resolved] 2010-08-11 10:23:07 -03:00
wycats
7171161124 rename _snowman to _e 2010-08-09 12:06:25 -07:00
Xavier Noria
4f7565c4de adds missing requires for Object#try 2010-08-09 15:25:21 +02:00
Xavier Noria
4434e407e9 adds URL to the body generated by the redirect macro in the routes mapper as per the RFC, extracts common test pattern into a test macro, adds a test to cover the :status option 2010-08-09 13:31:42 +02:00
Piotr Sarnacki
84f0a0bc30 Reload action_methods in AbstractController after defining new method. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-04 14:44:34 -03:00
Santiago Pastorino
111234e7c1 Use AS::OrderedHash when trusting in the order of the hash 2010-08-01 21:56:06 -03:00
Carlos Antonio da Silva
11614bddc0 Fix label form helper to use I18n and html options, without the need of 'nil' text param: 
Before: f.label :title, nil, :class => 'title'
  After : f.label :title, :class => 'title'

[#5267 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-01 21:51:54 -03:00
Santiago Pastorino
fb0bd8c109 Makes form_helper use overriden model accessors 
[#3374 state:committed]
 2010-08-01 19:32:22 -03:00
Rodrigo Dominguez
aa054c35f7 link_to_function now expects a piece of javascript code for the onclick parameter 
[#5179]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-07-29 13:11:53 -03:00
Łukasz Strzałkowski
da845275dd Removed deprecated APIs in text and number helpers [#5156 state:resolved] 
They're deprecated since 2008. It's time to get rid of them.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-26 17:26:59 +02:00
Carlos Antonio da Silva
751f89b8b2 Add assertion to link_to_function test with block and capture, and more expressive test name [#5179 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-25 23:00:15 +02:00
Santiago Pastorino
b1cfcedc8f Change returning with tap 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-25 16:33:04 +02:00
Sebastian A. Espindola
8d5b792e7d Fixed output_buffer encoding problem [#5179] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-25 16:33:04 +02:00
Santiago Pastorino
30df88ae06 These tests are trusting in the order of the elements so use OrderedHash instead of Hash 2010-07-21 17:34:43 -07:00
Brian Rose
622092d33e Fixed a globbed route issue where slashes were being escaped, causing assert_routing to fail. [#5135 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 22:07:40 +02:00
Andrew Kaspick
a1a41a3939 remote_function patch with more detailed test 
Signed-off-by: wycats <wycats@gmail.com>
 2010-07-21 10:04:55 -07:00
José Valim
9dfe9fa693 Ensure insert_before in middleware stack raises a meaningful error message [#3679 state:resolved] 2010-07-21 15:17:04 +02:00
Piotr Sarnacki
6807b08099 Moved a few methods from RecordIdentifier to ActiveModel::Naming 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 11:29:58 +02:00
Bryan Helmkamp
e466354edb Extract ParameterFilter class from FilterParameters mixin 
Signed-off-by: wycats <wycats@gmail.com>
 2010-07-19 13:44:43 -07:00
José Valim
c3c349ec3e Remove assert_valid. It was already deprecated on Rails 2.3. 2010-07-19 22:35:17 +02:00
Neeraj Singh
33c5689e2d Exceptions from views should be rescued based on the original exception. If a handler for original exception is missing then apply ActiveView::TemplateError 
[#2034 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-19 14:50:38 +02:00
José Valim
291adcd588 Set session options id to nil is respected and cancels lazy loading. 2010-07-18 12:51:03 +02:00