David Heinemeier Hansson
4f40b2d8fb
Improved performance of test app req/sec with ~10% refactoring the render method #1823 [Stefan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-24 16:45:39 +00:00
David Heinemeier Hansson
eddd7c453b
Fix that env_qs might be nil
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1907 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 09:18:16 +00:00
David Heinemeier Hansson
d554227411
Fix that env_qs might be nil
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1906 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 09:16:35 +00:00
David Heinemeier Hansson
b366dbd952
Improved performance with 5-30% through a series of Action Pack optimizations #1811 [Stefan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 09:00:05 +00:00
David Heinemeier Hansson
d172592985
Added test for template to layout variable transfer
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 08:43:01 +00:00
David Heinemeier Hansson
0223565a4d
Expiring a cache that doesnt exist is bliss not bad
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1895 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 20:08:29 +00:00
David Heinemeier Hansson
3835f6ab25
Changed caching/expiration/hit to report using the DEBUG log level and errors to use the ERROR log level instead of both using INFO
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1889 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 11:28:58 +00:00
Jamis Buck
06843f8794
Added support for per-action session management #1763
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1886 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 10:37:09 +00:00
David Heinemeier Hansson
1aab0e2c30
Doc fixes #1775 , #1776 [jon@instance-design.co.uk]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1878 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 06:27:07 +00:00
David Heinemeier Hansson
bd558ef98e
Improved rendering speed on complicated templates by up to 25% #1234 [Stephan Kaes]. This did necessasitate a change to the internals of ActionView#render_template that now has four parameters. Developers of custom view handlers (like Amrita) need to update for that.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1874 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-21 07:14:35 +00:00
Nicholas Seckar
2e175d35cd
Fix last changeset to pass unittests
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1858 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-18 03:25:53 +00:00
Nicholas Seckar
741316dc71
Fixed construction of get parameters for arrays
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1857 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-18 03:12:45 +00:00
David Heinemeier Hansson
e51221871c
Fix doc typos #1734 [moriq@moriq.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1853 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-17 10:03:47 +00:00
David Heinemeier Hansson
e69924ecdc
Log if filters return false and halt execution #1735 [Michael Koziarski]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1848 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-17 09:25:24 +00:00
David Heinemeier Hansson
d2d38f6700
Added Base#expires_in(seconds)/Base#expires_now to control HTTP content cache headers #1755 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1845 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-17 09:20:20 +00:00
David Heinemeier Hansson
45804e2c86
More pagination speed #1334 [Stefan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1839 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-15 20:27:38 +00:00
Nicholas Seckar
c0771fe7d8
Fix assert_routing with nested controllers. Closes #1582 and #1386 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1837 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-15 15:00:39 +00:00
Nicholas Seckar
bf0b7588ee
Add RouteSet#named_route so that RouteSet instance methods do not shadow available route names
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1834 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 10:32:37 +00:00
Nicholas Seckar
6ed16ff602
Provide correct defaults for Named Routes which do not specify :action
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 09:09:39 +00:00
David Heinemeier Hansson
16595c93b2
Made pagination faster #1334 [Stefan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1832 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 08:02:01 +00:00
Nicholas Seckar
fe0c7f4f76
Fix rescue handling to erase both render and redirect results
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1827 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 00:34:27 +00:00
Nicholas Seckar
2bd4ff11f8
Generate URLs for :action => index when :action => nil is supplied.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 00:13:06 +00:00
Nicholas Seckar
9314793239
Named routes should not provide nil values to url_for. Includes factoring and extra testcases.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1825 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-13 23:13:15 +00:00
Jeremy Kemper
f29ce1f356
r3023@asus: jeremy | 2005-07-12 23:43:39 -0700
...
Remove superfluous inherited override in Dependencies.
r3024@asus: jeremy | 2005-07-12 23:54:28 -0700
Make test the default railties rake target.
r3025@asus: jeremy | 2005-07-12 23:55:27 -0700
Encapsulate dispatch call in dispatcher test.
r3026@asus: jeremy | 2005-07-12 23:56:14 -0700
Expand dispatcher mock to match full method signature for process.
r3027@asus: jeremy | 2005-07-12 23:57:24 -0700
Look for app-specific generators in RAILS_ROOT/generators instead of RAILS_ROOT/script/generators.
r3028@asus: jeremy | 2005-07-13 00:00:47 -0700
Update changelog.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1819 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-13 02:12:00 +00:00
David Heinemeier Hansson
cb0f8fda96
Worked around a Safari bug where it wouldn't pass headers through if the response was zero length by having render :nothing return ' ' instead of ''
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1818 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-12 19:31:48 +00:00
Jamis Buck
847f738cfd
Make Request#subdomains handle "foo.foo.com" correctly
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1817 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-12 16:16:13 +00:00
David Heinemeier Hansson
fae7311b9c
Fixed that auto_complete_for didn't force the input string to lower case even as the db comparison was
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1815 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 07:49:56 +00:00
David Heinemeier Hansson
4259199c2c
Made ready for release of 0.13.1
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1814 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 07:36:18 +00:00
David Heinemeier Hansson
fede0f573e
Fixed documentation for :action/:template confusion #1643
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1813 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 07:10:32 +00:00
David Heinemeier Hansson
14e7c7c21d
Better documentation for Calling multiple redirects or renders #1687 [courtenay]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1795 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-10 05:26:55 +00:00
Jamis Buck
8266867881
Improved error message for DoubleRenderError
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1779 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 15:31:06 +00:00
Jeremy Kemper
37f90e0f6b
r2932@asus: jeremy | 2005-07-08 14:21:36 -0700
...
Silence find_by_session_id also.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1771 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 16:36:26 +00:00
Nicholas Seckar
c18961f185
Routes now raise an exception if a path component is misconfigured.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 08:56:24 +00:00
Nicholas Seckar
4a3ec21b62
Fix routes to generate proper URLs when given Fixnum defaults
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1768 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 08:45:51 +00:00
Nicholas Seckar
3c4295c4e0
Allow RouteSet#recognition_failed to be used to handle unknown URL forwarding
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1766 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 21:20:59 +00:00
Nicholas Seckar
f4bfacb24f
Enable routes to recognize uppercase controller names. Closes #1635
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1765 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 19:51:20 +00:00
Nicholas Seckar
5727dc2f42
Properly unescape recognized path components. Fixes #1651 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1764 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 19:43:03 +00:00
Nicholas Seckar
e3af27c51b
Improved testing of functional test setup.
...
Fixed functional test setup so that :controller and :action
are stored into path_parameters using string keys.
Added with_routing test helper which can be used to dynamically
replace the current set of routes inside a unit test.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 19:23:35 +00:00
David Heinemeier Hansson
b9b6cb95d3
Fixed routing to allow for testing of *path components #1650 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1762 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 16:16:36 +00:00
David Heinemeier Hansson
75157bbf64
Fixed that named routes didn't use the default values for action and possible other parameters #1534 [Nicholas Seckar]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1758 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 14:16:05 +00:00
David Heinemeier Hansson
e5b86efea9
Fixed that a SessionRestoreError was thrown if a model object was placed in the session that wasn't available to all controllers. This means that it's no longer necessary to use the 'model :post' work-around in ApplicationController to have a Post model in your session.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1741 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 18:43:32 +00:00
David Heinemeier Hansson
212cc3845a
Fixed routing snafu
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1736 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 10:45:14 +00:00
David Heinemeier Hansson
853ea55674
Made documentation ready for release (AP)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1731 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 09:32:00 +00:00
David Heinemeier Hansson
744058b699
Retract the session fix until 0.13.1 to preserve the truthfulness of the book
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1730 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 08:58:34 +00:00
David Heinemeier Hansson
93ec99c246
Partly tuned docs for release (AP)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1728 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 08:27:11 +00:00
David Heinemeier Hansson
8dbaae6012
Fixed that a SessionRestoreError was thrown if a model object was placed in the session that wasn't available to all controllers
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1725 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 07:06:02 +00:00
David Heinemeier Hansson
38e78c6260
Fixed documentation snafu with send_file -- the option is :stream, not :streaming #1621 [evl]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1723 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 05:23:42 +00:00
David Heinemeier Hansson
607ce7f0a0
Move URI to the end for greater overview
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1716 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 18:14:19 +00:00
David Heinemeier Hansson
977b4be208
Changed logging of SQL statements to use the DEBUG level instead of INFO. Added logging of the request URI in the benchmark statement (makes it easy to grep for slow actions). Changed the default logging level in config/environment.rb to INFO for production (so SQL statements won't be logged)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1714 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 17:23:41 +00:00
David Heinemeier Hansson
4fe0248f57
Fixed routing regression on index exception
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1713 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 15:31:51 +00:00