github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-03 02:35:08 -05:00
Code Issues Packages Projects Releases Wiki Activity
582 Commits 34 Branches 105 Tags
519fe7ccbc5798aa957e9a8ea146bb825cd79b9e
Commit Graph

138 Commits

Author SHA1 Message Date
David Heinemeier Hansson
519fe7ccbc Added URL escaping for routing #664 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@670 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-18 23:52:28 +00:00
David Heinemeier Hansson
37249f6a86 Fixed that assert_template_xpath_matches did not indicate when a path was not found #658 [Eric Hodel] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@665 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-18 17:13:57 +00:00
David Heinemeier Hansson
e39bf10594 Loading the Routes should happen in the environments #655 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@657 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-17 23:03:48 +00:00
David Heinemeier Hansson
ea3faf3df9 Only load ROUTE_FILE if one has been declared 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@651 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-17 19:20:44 +00:00
David Heinemeier Hansson
8151c4e84d Fixed that on validation errors, scaffold couldn't find template #654 [mindel] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@649 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-17 19:07:02 +00:00
David Heinemeier Hansson
04b8bc1bdd Fixed that a bunch of methods from ActionController::Base was accessible as actions (callable through a URL) when they shouldn't have been #644 [Nicholas Seckar]. Base#hide_actions(*names) to hide public methods from a controller that would otherwise have been callable through the URL. For the majority of cases, its preferred just to make the methods you don't want to expose protected or private (so they'll automatically be hidden) -- but if you must have a public method, this is a way to make it uncallable. Base#hidden_actions retrieve the list of all hidden actions for the controller #644 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@646 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-17 18:59:51 +00:00
David Heinemeier Hansson
5199aea4aa Better fix for requireing a missing route file in unit tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@643 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-17 02:14:32 +00:00
David Heinemeier Hansson
6a48e89ae7 Fix that routes werent being loaded in production environment 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@642 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-17 02:04:37 +00:00
David Heinemeier Hansson
ead404ccd0 Forget defaults :action if :controller changed at all 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@641 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-17 01:55:59 +00:00
David Heinemeier Hansson
29066036f2 Make Routes drop the default for action when the controller changes #651 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@640 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-17 01:46:29 +00:00
David Heinemeier Hansson
c00bf5f0c6 Fixed the verbosity of using the AR store 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@639 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-17 01:23:41 +00:00
David Heinemeier Hansson
2d9e59b2b6 Enable diagnostics screen again 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@638 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-16 16:39:14 +00:00
David Heinemeier Hansson
07dcbd97b9 Fixed https handling on other ports than 443 [Alan Gano] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@637 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-16 12:08:00 +00:00
David Heinemeier Hansson
dcfd6aa3bd Move Controllers wrapper module away from environment.rb and into dependencies.rb 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@627 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-15 16:21:56 +00:00
David Heinemeier Hansson
dc3d6eb9b4 Moved Active Support into its own gem 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-15 15:57:44 +00:00
David Heinemeier Hansson
b1999be5a7 A hopefully more successful attempt at the Routing branch merge 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-15 01:45:35 +00:00
David Heinemeier Hansson
88a3343ed5 Backed out of routing merge.. investigating missing patches 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@616 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-15 01:24:55 +00:00
David Heinemeier Hansson
60f7a5cab7 Added routing itself.. wonder why that didnt make it through the merge 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@615 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-15 01:02:37 +00:00
David Heinemeier Hansson
c844755e5a Merged back the Routing branch 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@614 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-15 00:51:02 +00:00
David Heinemeier Hansson
65f834ad45 Stringify the parameters on follow_redirect 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@587 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-12 21:54:34 +00:00
David Heinemeier Hansson
61a6a440cb Added follow_redirect method for functional tests that'll get-request the redirect that was made. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@585 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-12 19:35:30 +00:00
David Heinemeier Hansson
e505a45173 Fixed whitespace 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-11 13:04:10 +00:00
David Heinemeier Hansson
66b504b1f7 Fixed double requiring of models with the same name as the controller 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@579 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-11 13:03:34 +00:00
David Heinemeier Hansson
02d0558738 Make the store less verbose when saving the session data 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@529 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-07 19:12:11 +00:00
David Heinemeier Hansson
b8e4c78abb Fixed that query params could be forced to nil on a POST due to the raw post fix #562 [moriq@moriq.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@526 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-07 14:23:19 +00:00
David Heinemeier Hansson
098fa94356 Fixed documentation snafus #575, #576, #577, #585 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@525 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-07 14:15:53 +00:00
David Heinemeier Hansson
c89c2bcbfb Fixed that cookies shouldn't be frozen in TestRequest #571 [Eric Hodel] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@520 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-07 13:44:48 +00:00
David Heinemeier Hansson
838c5a3d82 Minor refactoring to prettify 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@517 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-06 18:29:11 +00:00
David Heinemeier Hansson
c328f64e37 Catch ArgumentError not NameError 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@514 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-25 20:05:17 +00:00
David Heinemeier Hansson
11611c1b00 Raise LoadErrors separately 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@510 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-25 18:35:16 +00:00
David Heinemeier Hansson
20b14e0d38 Comply to the new dependency reload system 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@508 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-25 18:05:22 +00:00
David Heinemeier Hansson
2f11b7cfee Added @request.raw_post as a convenience access to @request.env['RAW_POST_DATA'] and fixed the patch problems with the session #534 [Tobias Luetke] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@502 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-25 11:15:26 +00:00
David Heinemeier Hansson
80b656637a Added :application_prefix to url_for and friends that makes it easier to setup Rails in non-vhost environments #516 [Jamis Buck] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@494 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-24 13:50:58 +00:00
David Heinemeier Hansson
f31291ab5a Another swing at reloading 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@479 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-24 00:26:44 +00:00
David Heinemeier Hansson
d336ca5280 Fixed that the content-header was being set to application/octet_stream instead of application/octet-stream on send_date/file [Alexey] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@475 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-22 14:48:59 +00:00
David Heinemeier Hansson
bbd3e39668 Fixed no-binding fragment caching 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-20 17:54:06 +00:00
David Heinemeier Hansson
7306675fe2 Removed the need for passing the binding when using CacheHelper#cache 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@472 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-20 17:26:14 +00:00
David Heinemeier Hansson
79d7e66f78 Deactivated RAW_POST_DATA pending fix 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@469 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-20 15:10:50 +00:00
David Heinemeier Hansson
dfed3d309e A few missing files 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@468 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-20 14:55:13 +00:00
David Heinemeier Hansson
93f7cb2a80 Added TestResponse#binary_content that'll return as a string the data sent through send_data/send_file for testing #500 [Alexey] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@467 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-20 14:43:59 +00:00
David Heinemeier Hansson
1a5bf720b2 Added @request.env['RAW_POST_DATA'] for people who need access to the data before Ruby's CGI has parsed it #505 [bitsweat] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@463 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-20 14:31:48 +00:00
David Heinemeier Hansson
2ee84cc6f9 Fixed that all redirect and render calls now return true, so you can use the pattern of "do and return". Added that renders and redirects called in before_filters will have the same effect as returning false: stopping the chain. Added that only one render or redirect can happen per action. The first call wins and subsequent calls are ignored. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@462 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-20 14:13:34 +00:00
David Heinemeier Hansson
91ff8352a4 Fixed that a default fragment store wan't being set to MemoryStore as intended 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@461 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-20 14:12:53 +00:00
David Heinemeier Hansson
cd3f14cf38 Fixed a bug where cookies wouldn't be set if a symbol was used instead of a string as the key 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@453 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-17 23:38:14 +00:00
David Heinemeier Hansson
6ca5eba396 Added assert_cookie_equal to assert the contents of a named cookie 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@452 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-17 23:24:47 +00:00
David Heinemeier Hansson
4ec7a4b5b7 Fixed bug in page caching that prevented it from working at all 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@447 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-17 17:30:40 +00:00
David Heinemeier Hansson
9a33b9a737 Added more informative error message for "file not found" situation in send_file #484 [Alexey] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@427 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-16 13:06:15 +00:00
David Heinemeier Hansson
bc4156e09e Finished documentation for caching 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@426 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-15 22:16:41 +00:00
David Heinemeier Hansson
c755b29a86 Fixed page caching problems with saving cached file fails for the index action and that it shouldnt cache files with GET/POST parameters #462 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@407 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-15 13:22:58 +00:00
David Heinemeier Hansson
9c09f81bc6 Added arrays as a value option for params in url_for and friends #467 [Eric Anderson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-01-13 14:06:33 +00:00