Commit Graph

713 Commits

Author SHA1 Message Date
Rick Olson
51cd1aec00 Fix assert_redirected_to tests according to real-world usage.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-25 03:54:46 +00:00
Rick Olson
e1c7b5a7f6 Cache CgiRequest#request_parameters so that multiple calls don't re-parse multipart data.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-23 18:18:17 +00:00
Rick Olson
3900b36896 Diff compared routing options. Allow #assert_recognizes to take a second arg as a hash to specify optional request method [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-23 18:16:51 +00:00
Rick Olson
7bd6923c7f allow -'s in tag names for html scanner when scanning AR xml documents
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-22 18:12:31 +00:00
Rick Olson
92bd54ea19 Use ActiveSupport's String#join method
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4250 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-22 15:17:56 +00:00
Rick Olson
526c69b49e Diff compared options with #assert_redirected_to [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-22 15:08:25 +00:00
Rick Olson
ed02f415d7 reset TestRequest#parameters after assigning paramters
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4246 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-22 04:59:15 +00:00
Jamis Buck
0a0b5bd722 fix to ';' interpretation in route recognition--only follow a route with ';' if the segment in question actually contains a ';'
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4244 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-21 17:21:26 +00:00
Jamis Buck
1f80f540a7 Add support in routes for semicolon delimited "subpaths", like /books/:id;:action
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-21 15:17:02 +00:00
Jamis Buck
7a8883eee9 Modify routing so that you can say :require => { :method => :post } for a route, and the route will never be selected unless the request method is POST. Only works for route recognition, not for route generation.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4209 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-13 05:44:23 +00:00
Sam Stephenson
23585d721d Added :add_headers option to verify which merges a hash of name/value pairs into the response's headers hash if the prerequisites cannot be satisfied
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4201 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-08 07:04:21 +00:00
David Heinemeier Hansson
47b74e6e16 Added ActionController.filter_parameter_logging that makes it easy to remove passwords, credit card numbers, and other sensitive information from being logged when a request is handled #1897 [jeremye@bsa.ca.gov]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4200 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-07 22:26:25 +00:00
Marcel Molina
ac97c7a90e Do filter condition lookup against the actual hash
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4180 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-06 04:50:45 +00:00
Marcel Molina
4859b6c09e Honor skipping filters conditionally for only certain actions even when the parent class sets that filter to conditionally be executed only for the same actions. Closes #4522.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-05 04:39:59 +00:00
Jamis Buck
3bf3bc228c Delegate xml_http_request in integration tests to the session instance.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4161 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-04 20:16:29 +00:00
Nicholas Seckar
e714b25723 Update the diagnostics template skip the useless '<controller not set>' text.
Fix symbol extensions test case.
Clean paths inside of exception messages and traces.
Add Pathname.clean_within for cleaning all the paths inside of a string.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-04 19:37:29 +00:00
David Heinemeier Hansson
62dc792a48 CHANGED DEFAULT: Don't parse YAML input by default, but keep it available as an easy option [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4157 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-04 19:28:25 +00:00
David Heinemeier Hansson
dc87eba062 Fixed fragment caching of binary data on Windows (closes #4493) [bellis@deepthought.org]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4125 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-01 20:41:53 +00:00
Marcel Molina
f28d619534 Add documentation for respond_to
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4083 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-28 03:39:23 +00:00
David Heinemeier Hansson
dfd953ea96 Fixed docs
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4079 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-28 03:19:27 +00:00
David Heinemeier Hansson
b6e7cc63de Spell existence properly (closes #4442)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4072 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-27 23:43:50 +00:00
Rick Olson
3f496c6638 add the TestCase.fixture_path when testing file uploads
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4058 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-27 02:24:47 +00:00
David Heinemeier Hansson
9326222941 Use example.com as standard (closes #4413) [anna]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4026 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-25 19:43:40 +00:00
Jamis Buck
7bcf4c6659 Enable application/x-yaml processing by default
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4024 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-25 18:44:28 +00:00
Jamis Buck
b0189f3f2f Fix assert_redirected_to so it works with symbols
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4004 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 18:16:48 +00:00
David Heinemeier Hansson
6d7335752a Comments, comments
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3994 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 05:40:42 +00:00
David Heinemeier Hansson
faecde0ec8 My beautiful eyes [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3993 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 05:39:13 +00:00
David Heinemeier Hansson
eedd9d7604 Updated Kernel#returning for the AP performance patch [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3991 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 04:37:32 +00:00
Rick Olson
a4f1262ac5 fix usage of #returning in ActionController::Base
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3990 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 04:33:13 +00:00
David Heinemeier Hansson
d19e8f412f Performance speedup for ActionController (closes #4174) [Stefan Kaes] Includes caching of filter chains -- be on the lookout for problems with that!
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3989 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-20 04:01:10 +00:00
David Heinemeier Hansson
8ea1fadcbe If RAW_POST_DATA was set explicitly, use that (closes #4281)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3972 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 06:42:29 +00:00
Rick Olson
891a962a19 Added nicer message for assert_redirected_to (closes #4294) [court3nay, Chris McGrath]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3969 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-19 03:50:14 +00:00
David Heinemeier Hansson
cc6e8ae57a Removed XML argument style for respond_to, so type.xml(object.to_xml) no longer works -- it wasnt worth the exception
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 21:17:14 +00:00
David Heinemeier Hansson
f22f352ee3 Added easy support for testing file uploads with fixture_file_upload (closes #4105) [turnip@turnipspatch.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3939 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 20:10:52 +00:00
Jamis Buck
79a82e3a97 Make sure xml_simple requests don't blow up if an empty request body is recieved
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3936 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 18:56:19 +00:00
Nicholas Seckar
240213177e Add ability for relative_url_root to be specified via an environment variable RAILS_RELATIVE_URL_ROOT. Closes #4243.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3931 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 16:45:40 +00:00
David Heinemeier Hansson
c2fb8ca393 Just use a normal update on the indifferent hash
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3927 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 16:11:21 +00:00
Jamis Buck
9d7de52c2d Add Integration::Session.accept for setting the HTTP Accept header to use (defaults to FF 1.5 value)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3924 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 15:09:27 +00:00
Jamis Buck
36ea93e4b9 rename 'integration_test.rb' -> 'integration.rb'
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3923 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 14:27:36 +00:00
David Heinemeier Hansson
9840dc84f1 Allow for respond_to(:html, :js, :xml) (closes #4277) [Caio Chassot]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3919 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 06:43:37 +00:00
Jamis Buck
4e0028fbab Make Mime::Type.parse consider q values (if any)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3917 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 06:15:28 +00:00
Jamis Buck
459559a8bc XML-formatted requests are typecast according to "type" attributes for :xml_simple
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 05:07:27 +00:00
David Heinemeier Hansson
fe94ba1003 Added access to remote_addr in integration tests (closes #4266) [Chad Fowler]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3908 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-18 03:27:37 +00:00
Jamis Buck
1340eb1a7e Be sure to look at array elements when dasherizing keys of a formatted request
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-17 23:15:20 +00:00
David Heinemeier Hansson
4e15bf787e Fixed proxy support for lighttpd (closes #3267) [stephen_purcell@yahoo.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3894 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 04:16:08 +00:00
Nicholas Seckar
065b3af358 Explain thyself
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3893 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 04:09:18 +00:00
David Heinemeier Hansson
f7359342af Added protection against proxy setups treating requests as local even when they're not #3898 [stephen_purcell@yahoo.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3892 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 03:31:40 +00:00
David Heinemeier Hansson
275ea6de49 Added TestRequest#raw_post that simulate raw_post from CgiRequest (closes #3042) [francois.beausoleil@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 03:15:12 +00:00
David Heinemeier Hansson
500c734935 Breakpoints in running code makes for no fun ;)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3883 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-16 02:48:25 +00:00
Tobias Lütke
7bbc759dc0 Fixes a bug in routes controller traversing which caused it to fail on for double nested controllers. [Tobias Luetke]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3879 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-15 22:48:22 +00:00