Commit Graph

2336 Commits

Author SHA1 Message Date
Marcel Molina
0d82b146a1 Correct example for path parameters to use strings as keys in the hash rather than symbols. Closes #7160 [akaspick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8314 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-05 22:04:02 +00:00
Marcel Molina
b9e0b72795 Update documentation to reflect increased accuracy of date interval calculations. Closes #7192 [eventualbuddha]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8310 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-05 21:38:02 +00:00
Marcel Molina
7e608af9ff Add documentation examples to prototype helper. Closes #7211 [manfred]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8308 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-05 21:33:10 +00:00
Marcel Molina
9ffb6328ea Enhance documentation coverage for fragment caching. Closes #7315 [bscofield]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8307 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-05 21:06:36 +00:00
Marcel Molina
68261d4b27 Add many examples to PrototypeHelper documentation. Closes #7656 [jeremymcanally]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8302 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-05 20:05:51 +00:00
David Heinemeier Hansson
2af36bbbd4 Fix typos (closes #10378)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8301 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-05 18:54:41 +00:00
Marcel Molina
c27b9db39f Add many examples to assertion documentation. Closes #7803 [jeremymcanally]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8300 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-05 18:17:23 +00:00
David Heinemeier Hansson
cc0c4202be Ensure that ActionMailer::Base is there and not just the parent module
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8299 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-05 18:16:04 +00:00
Marcel Molina
d7e9780445 Fix typo in [8287]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8294 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-05 15:27:01 +00:00
Marcel Molina
228186d94a Document the supported options for sortable_element. Closes #8820 [berkelep]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8287 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-05 15:01:47 +00:00
Marcel Molina
096f3f6468 Add examples in the documentation for various assertions. Closes #9938 [zapnap]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8284 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-05 14:40:42 +00:00
Marcel Molina
da5fef45fe When a NonInferrableControllerError is raised, make the proposed fix clearer in the error message. Closes #10199 [danger]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8283 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-05 14:31:41 +00:00
Michael Koziarski
2eaa8e67c0 Remove Great Britain from the Country select helper to ensure consistency with iso 3166's long_names. Closes #6872 [Koz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8277 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-05 05:55:26 +00:00
Sam Stephenson
b6d9c17af1 Update Prototype to 1.6.0.1
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8276 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-05 03:08:29 +00:00
David Heinemeier Hansson
3a622d0045 Fix broken test (closes #10364) [chuyeow]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8271 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-05 02:34:36 +00:00
David Heinemeier Hansson
0aec2423ed Removed some of the tags that does not make sense to allow per default in the whitelist
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8269 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-04 20:04:48 +00:00
Thomas Fuchs
cfa31c30b8 Update trunk to script.aculo.us 1.8.0.1, fixes a regression in the autocompleter
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8268 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-04 18:12:54 +00:00
Rick Olson
112ed30316 Add 'disabled' attribute to <OPTION> separators used in time zone and country selects. Closes #10354 [hasmanyjosh]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8267 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-04 05:30:28 +00:00
David Heinemeier Hansson
9663f9952a Make sure that setting the format with a symbol works too
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-03 19:49:22 +00:00
Michael Koziarski
92f02adf40 Don't escape forward slashes with String#to_json, our unicode encoding of < and > prevent the XSS problems. [tpope] Closes #10273
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-02 08:45:35 +00:00
David Heinemeier Hansson
84ca7e6ef7 Deal with nested fields_for too [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-02 01:10:50 +00:00
David Heinemeier Hansson
d0ce7cd4c7 Added the same record identification guessing rules to fields_for as form_for has [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-02 00:46:43 +00:00
Jeremy Kemper
2a3dc59de0 Don't inadvertently hit const_missing in defined?(ActionMailer::Base) check
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8249 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-12-01 21:19:23 +00:00
David Heinemeier Hansson
e03f13c553 Fixed that verification violations with no specified action didn't halt the chain (now they do with a 400 Bad Request) [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-30 21:04:57 +00:00
Michael Koziarski
fd3f048f6d Make sure assert_select_rjs gets counted, Closes #10278 [tarmo]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8237 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-29 02:49:11 +00:00
Rick Olson
0a9bc591e7 Raise UnknownHttpMethod exception for unknown HTTP methods. Closes #10303 [tarmo]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8235 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-29 02:08:51 +00:00
Sam Stephenson
ab73a988ac Update to Prototype -r8232
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8234 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-29 00:39:59 +00:00
David Heinemeier Hansson
54a75de3ec Prep for RC2
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8233 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-29 00:27:53 +00:00
Michael Koziarski
fa866765c2 correct confusing comments
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8228 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-28 04:14:51 +00:00
Michael Koziarski
6a611e1e95 Make sure the optimisation code for routes doesn't get used if :host, :anchor or :port are provided in the hash arguments. [pager, Koz] Closes #10292
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8227 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-28 04:11:37 +00:00
David Heinemeier Hansson
45d679bcb8 Added protection from trailing slashes on page caching (closes #10229) [devrieda]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8226 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-28 00:29:43 +00:00
Marcel Molina
69165404be Asset timestamps are appended, not prepended. Closes #10276 [mnaberez]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8220 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-27 06:11:23 +00:00
David Heinemeier Hansson
5e94f053cb Fixed to_s bug with namespace routes (closes #10283) [johnb]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8216 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-26 22:41:28 +00:00
Marcel Molina
a0c925c0a3 Minor inconsistency in description of render example. Closes #10029 [ScottSchram]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8215 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-26 20:57:04 +00:00
Rick Olson
87e506da53 Add #prepend_view_path and #append_view_path instance methods on ActionController::Base for consistency with the class methods. [rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8214 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-26 03:59:23 +00:00
Rick Olson
1af084ecda Refactor sanitizer helpers into HTML classes and make it easy to swap them out with custom implementations. Closes #10129. [rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8213 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-26 03:45:54 +00:00
Rick Olson
3d67860cae Add deprecation for old subtemplate syntax for ActionMailer templates, use render :partial [rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8211 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-26 03:35:52 +00:00
Rick Olson
8afb4e136b Fix TemplateError so it doesn't bomb on exceptions while running tests [rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8210 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-26 03:35:04 +00:00
David Heinemeier Hansson
5ae821a7fe Add documentation about asset timestamps (just for koz)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8209 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-25 23:24:36 +00:00
David Heinemeier Hansson
9e76b59c85 Fixed that named routes living under resources shouldn't have double slashes (closes #10198) [isaacfeliu]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8206 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-25 22:24:23 +00:00
David Heinemeier Hansson
566903484c Docfix (closes #10256)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8203 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-25 21:59:17 +00:00
Michael Koziarski
7aab8b9a15 Improve error messages when providing a secret that is too short. Closes #10238 [Henrik N]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8200 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-24 22:41:16 +00:00
Jeremy Kemper
96add62ecc Document that the cookie store is the default session store. Mention the memcached store. Closes #10241 [Josh Susser, Jeremy Kemper]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8189 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-22 05:48:45 +00:00
Michael Koziarski
155eb47cf3 Tests and fix for extension extraction. References #10130 [tarmo]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8187 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-22 05:01:07 +00:00
Michael Koziarski
ec93d61fb9 Make sure that cookie sessions use a secret that is at least 30 chars in length. [Koz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-21 21:31:45 +00:00
David Heinemeier Hansson
8a086c590f Emphasize the importance of a dictionary attack-proof secret for the cookie store
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8181 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-21 15:47:50 +00:00
Michael Koziarski
41fb4904e2 Refactor cookie_only option to survive multiple requests and add regression tests. References #10048. [theflow]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8176 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-21 04:28:59 +00:00
Michael Koziarski
0c12d6c6dc Ensure that the routing optimisation code isn't used when additional arguments are passed to the named route. Closes #10209 [bscofield, Koz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-20 21:25:25 +00:00
Michael Koziarski
e1a2f3c898 Remove unnecessary route reload in integration tests, obsoleted by [7676]. Closes #10094. [Koz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8168 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-19 23:11:26 +00:00
David Heinemeier Hansson
a76490d917 Fixed that partial rendering should look at the type of the first render to determine its own type if no other clues are available (like when using text.plain.erb as the extension in AM) (closes #10130) [java] Fixed that partials would be broken when using text.plain.erb as the extension #10130 [java]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8166 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-18 22:01:33 +00:00