github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-16 00:55:02 -05:00
Code Issues Packages Projects Releases Wiki Activity
1,989 Commits 34 Branches 105 Tags
54adccda08403d8ad4df7b4d20040bfb421bc738
Commit Graph

319 Commits

Author SHA1 Message Date
Marcel Molina
b54560600b Have text helpers use built in Regexp.escape rather than home grown alternative 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 20:49:52 +00:00
Jeremy Kemper
9852197f83 r3573@asus: jeremy | 2005-09-26 11:38:44 -0700 
Ticket 1507 - IE file uploads give the filename as a full Windows path, but Ruby on UNIX doesn't know how to File.basename('C:\\blah\blah.foo').
 r3574@asus:  jeremy | 2005-09-26 14:32:11 -0700
 Get rid of constant redefine warning.
 r3575@asus:  jeremy | 2005-09-26 14:33:07 -0700
 Override the file upload's original_filename singleton method in CGIMethods.get_typed_value.
 r3576@asus:  jeremy | 2005-09-26 14:33:49 -0700
 Unit test overridden original_filename against normal filenames and full Windows paths.
 r3577@asus:  jeremy | 2005-09-26 14:33:57 -0700
 Update change log.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2345 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 17:59:46 +00:00
David Heinemeier Hansson
2a31691ee2 Fixed that auto_discovery_link_tag couldn't take a string as the URL 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2296 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-22 11:37:16 +00:00
David Heinemeier Hansson
7f26415d3c Optimized tag_options to not sort keys, which is no longer necessary when assert_dom_equal and friend is available #1995 [skae]. Added assert_dom_equal and assert_dom_not_equal to compare tags generated by the helpers in an order-indifferent manner #1995 [skae] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2271 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-20 07:54:55 +00:00
Jamis Buck
390280b842 Make the truncate() helper multi-byte safe (assuming $KCODE has been set to something other than "NONE") #2103 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2265 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-19 21:36:36 +00:00
David Heinemeier Hansson
7a4c88157f Doc fix #2197 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-17 06:39:54 +00:00
David Heinemeier Hansson
9acb1f95c9 Make upload progress not throw JavaScript errors when there is no progress bar #2208 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-16 08:44:38 +00:00
Jamis Buck
5e3364ef45 More auto-link fixes (to include query strings in autolinked text) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2241 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-14 12:07:05 +00:00
Jamis Buck
b97f4e4597 Fix autolinking to not include trailing tags as part of the URL 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2237 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-13 18:48:34 +00:00
David Heinemeier Hansson
de4cd789ae Make periodically_call_remote use type="text/javascript" on script tag #2171 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2217 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-12 05:40:27 +00:00
David Heinemeier Hansson
2fe8610673 Added TextHelper#cycle to cycle over an array of values on each hit (useful for alternating row colors etc) #2154 [dave-ml@dribin.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2213 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-12 05:26:25 +00:00
David Heinemeier Hansson
b5629c31be Fixed docs #1884 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2196 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 09:13:05 +00:00
David Heinemeier Hansson
a0ecced15b Fixed docs #1886 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2195 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 09:12:22 +00:00
David Heinemeier Hansson
2be3c00863 Split macros test into their own suite 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2194 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 08:40:46 +00:00
David Heinemeier Hansson
a15068726f Added :multipart option to ActiveRecordHelper#form to make it possible to add file input fields #2034 [jstirk@oobleyboo.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2193 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 08:39:23 +00:00
David Heinemeier Hansson
c1007377ba Added in-place editing support in the spirit of auto complete with ActionController::Base.in_place_edit_for, JavascriptHelper#in_place_editor_field, and Javascript support from script.aculo.us #2038 [Jon Tirsen] Moved auto-completion and in-place editing into the Macros module and their helper counterparts into JavaScriptMacrosHelper 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2191 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 07:52:53 +00:00
David Heinemeier Hansson
b62243a5cc Added :disabled option to all data selects that'll make the elements inaccessible for change #2167, #253 [eigentone] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 05:58:00 +00:00
David Heinemeier Hansson
da7ba91d86 Fixed that TextHelper#auto_link_urls would include punctuation in the links #2166, #1671 [eigentone] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2183 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 05:53:52 +00:00
David Heinemeier Hansson
afbfde9357 Fixed that number_to_currency(1000, {:precision => 0})) should return "$1,000", instead of "$1,000." #2122 [sd@notso.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:43:02 +00:00
David Heinemeier Hansson
7dbf051e54 Fix docs #2136 [coffee2code] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2165 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:11:53 +00:00
David Heinemeier Hansson
e54b4d3b54 Allow link_to_remote to use any DOM-element as the parent of the form elements to be submitted #2137 [erik@ruby-lang.nl] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2164 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:10:20 +00:00
David Heinemeier Hansson
e3c02d8c66 Fixed that render :partial would fail when :object was a Hash (due to backwards compatibility issues) #2148 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 07:27:44 +00:00
David Heinemeier Hansson
46110aa689 Fixed JavascriptHelper#auto_complete_for to only include unique items #2153 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2159 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 07:25:58 +00:00
David Heinemeier Hansson
079d8f4028 Fixed that onclick would be overridden even when special features werent used 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 17:54:16 +00:00
David Heinemeier Hansson
3c3d936f4d Fixed all AssetHelper methods to work with relative paths, such that javascript_include_tag('stdlib/standard') will look in /javascripts/stdlib/standard instead of '/stdlib/standard/' #1963 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 16:39:06 +00:00
David Heinemeier Hansson
7b235f0213 Use this.href, not unexisting url 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2150 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-07 13:04:09 +00:00
David Heinemeier Hansson
7e3dc807df Added :post option to UrlHelper#link_to that makes it possible to do POST requests through normal ahref links using Javascript 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2149 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-07 12:56:33 +00:00
David Heinemeier Hansson
258bacbf82 Added :popup option to UrlHelper#link_to #1996 [gabriel.gironda@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2129 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-04 00:33:45 +00:00
David Heinemeier Hansson
3f14b1e94e Updated the options_for_select to deal with the fact that Strings now implement :first 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-03 21:30:54 +00:00
David Heinemeier Hansson
51a1af96d4 Added note about how pre-packaged error functionality can be easier to recreate yourself than attempt to overly tailor #1489 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2112 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-03 07:43:15 +00:00
Jamis Buck
fd9c15e420 Fix observe_field to fall back to event-based observation if frequency <= 0 #1916 [michael@schubert.cx] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2104 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 14:06:17 +00:00
Jamis Buck
97adfdaa65 * Allow use of the :with option for submit_to_remote #1936 [jon@instance-design.co.uk] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 13:56:38 +00:00
Jamis Buck
e758c2e9db Yield @content_for_ variables to templates #2058 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-01 21:51:27 +00:00
Jamis Buck
01af965a3e Make rendering an empty partial collection behave like :nothing => true #2080 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2093 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-01 21:43:38 +00:00
Nicholas Seckar
a8b9fc9f2a Add dummy ActionView::Base.cache_template_loading accessor -- will be made functional again in short time 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2066 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-29 15:12:48 +00:00
David Heinemeier Hansson
b80f0e2ff3 Made Upload Progress work with Prototype 1.4.0 and add some documentation for it #1847, #1876 [Thomas Fuchs/Sean Treadway] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2059 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-27 06:30:33 +00:00
Nicholas Seckar
68c90ab019 Render refactoring; render error reporting fixes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2058 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-26 22:37:36 +00:00
Jamis Buck
82f44f3144 Added :use_short_month option to select_month helper to show month names as abbreviations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2033 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-22 14:47:16 +00:00
Jamis Buck
8910de6a54 Make link_to escape the javascript in the confirm option #1964 [nicolas.pouillard@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2009 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-14 08:43:07 +00:00
David Heinemeier Hansson
9fad3251d3 More fixes, but still broken 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1948 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 14:17:47 +00:00
David Heinemeier Hansson
c22ebd909d Fixing the fix, but not quite 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1946 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 13:55:56 +00:00
David Heinemeier Hansson
3d2f0001ea Fixed bug when a partial render was passing a local with the same name as the partial 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 12:24:14 +00:00
David Heinemeier Hansson
11a51648ad Document the design of the compiled templates approach and tweak the expiration check 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1929 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-26 12:37:21 +00:00
David Heinemeier Hansson
4f40b2d8fb Improved performance of test app req/sec with ~10% refactoring the render method #1823 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-24 16:45:39 +00:00
David Heinemeier Hansson
3ccea931fa Simplify content_for implementation 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1914 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-24 15:27:47 +00:00
David Heinemeier Hansson
1ae0a53d86 Fixed regression for content_for #1820 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-24 13:20:29 +00:00
David Heinemeier Hansson
023c4d68cc Caching template logging goes DEBUG 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1903 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 06:27:52 +00:00
David Heinemeier Hansson
7fe3fd23b3 Extended template caching to rxml and attempted to fix periodical caching issue [Stephan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1902 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 06:14:10 +00:00
David Heinemeier Hansson
98fb9e5093 Fixed call on inline with new render_template #1808 [Michael Shuerig] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1898 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 20:46:36 +00:00
David Heinemeier Hansson
c19ca5148f Fixed changing templates in development mode [Stephan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1891 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 15:51:34 +00:00