Commit Graph

1553 Commits

Author SHA1 Message Date
David Heinemeier Hansson
73a8d7393f Make sure that formatted routes for all verbs are created. Still needs to resolve two failing tests after this refactoring [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5096 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-13 04:04:19 +00:00
Jeremy Kemper
89840c40ce Load helpers in alphabetical order for consistency. Resolve cyclic javascript_helper dependency. Closes #6132, closes #6178.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5095 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-12 22:07:18 +00:00
Jeremy Kemper
7661c2b50a Skip params with empty names, such as the &=Save query string from <input type=submit/>. Closes #2569.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-12 20:57:09 +00:00
Jamis Buck
3f0952d9df Fix assert_tag so that :content => "foo" does not match substrings, but only exact strings. Use :content => /foo/ to match substrings. closes #2799
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5086 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-10 02:51:38 +00:00
Jamis Buck
5bf41ed8bc Add test case to test attribute matching by assert_tag
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5082 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-09 22:05:21 +00:00
David Heinemeier Hansson
2c6747f858 Split Form.serialize into Form.serialize and Form.serializeElements. The latter can be used stand-alone to serialize an array of elements you pass in, instead of the entire form [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5077 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-08 22:12:40 +00:00
David Heinemeier Hansson
e2d8451024 We cant make MySQL 5 happy if it means making SQLite and PostgreSQL cry. So currently MySQL 5 is not fully supported for Rails when youre using eager loading (closes #6133, #6135). I have contacted MySQL to make them fix http://bugs.mysql.com/bug.php?id=13551 [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5075 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-08 22:01:00 +00:00
David Heinemeier Hansson
d7e4f5f22e Since to_sing, we need to check for empty string
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5074 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-08 19:23:33 +00:00
Jeremy Kemper
f1b639cffb Update descriptive messages for exceptions thrown by cgi_methods. Closes #6103.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5070 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-08 07:25:14 +00:00
Nicholas Seckar
9d9ac01c7d Add descriptive messages to the exceptions thrown by cgi_methods. Closes #6091.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5066 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-07 20:10:14 +00:00
Thomas Fuchs
a5df861852 Fix loop_on_multiple_args to work, again (not my day), fixes #6078
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5063 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-07 14:16:58 +00:00
Thomas Fuchs
cb6309bcc9 Ahem, now for real
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5062 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-07 12:57:39 +00:00
Thomas Fuchs
984312cf85 Fix a warning in prototype_helper_test, fixes #6077
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5061 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-07 12:56:48 +00:00
Thomas Fuchs
8734da9bca Update JavaScriptGenerator#show/hide/toggle/remove to new Prototype syntax for multiple ids, fixes #6068 [petermichaux@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5057 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-07 09:19:35 +00:00
Nicholas Seckar
00685ad8fd Update UrlWriter to support :only_path.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-06 22:21:36 +00:00
David Heinemeier Hansson
5a5f85d5be Get symbol definitions of methods converted to strings [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5045 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-06 04:00:37 +00:00
Rick Olson
5360e47431 added passing test for using partials with an xml builder
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5044 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-06 03:51:45 +00:00
David Heinemeier Hansson
83313fccc0 Backed out of locals hash as it caused trouble with Builder, see ticket for more
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5043 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-06 03:38:11 +00:00
David Heinemeier Hansson
8c9ce617c9 Fixed JavaScriptHelper#link_to_function and JavaScriptHelper#button_to_function to have the script argument be optional [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-06 01:31:04 +00:00
David Heinemeier Hansson
951b4d2799 Still need the regular assertions
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5028 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-05 23:04:14 +00:00
David Heinemeier Hansson
bd09d9aafb caller is necessary for proper trace in deprecation
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5021 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-05 22:08:33 +00:00
David Heinemeier Hansson
9598176390 Better bundling of new assertions and make integration tests work again
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5020 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-05 21:28:22 +00:00
Thomas Fuchs
4f68dcb035 Update to script.aculo.us 1.6.3 [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5015 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-05 10:42:41 +00:00
Sam Stephenson
899c1b0157 Update to Prototype 1.5.0_rc1
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5012 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-05 04:17:06 +00:00
David Heinemeier Hansson
1d4d037b0d Added access to nested attributes in RJS (closes #4548) [richcollins@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5004 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:54:10 +00:00
David Heinemeier Hansson
bf8b101dd6 Fixed that AssetTagHelper#image_tag and others using compute_public_path should not modify the incoming source argument (closes #5102) [eule@space.ch]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5003 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:43:38 +00:00
David Heinemeier Hansson
4fdddc331e Expose more options of inplace_editor (but its still going plugin with v2.0) (closes #5103)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5002 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:41:38 +00:00
David Heinemeier Hansson
c2054c4289 Superseeded by action_caching_test (closes #5173)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5001 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:39:50 +00:00
David Heinemeier Hansson
40c86a7bda Documentation for routes (closes #5165) [rramdas@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5000 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:34:19 +00:00
David Heinemeier Hansson
9514e4e6ad Deprecated the auto-appending of .png to AssetTagHelper#image_tag calls that doesn't have an extension [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4999 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:25:43 +00:00
David Heinemeier Hansson
40762a4873 Fixed default routing NoMethodError downcase for nil when default controller provided (closes #5400) [kajism@yahoo.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4998 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:09:15 +00:00
David Heinemeier Hansson
df70e28e03 Added locals hash to partials, which makes for convenient access of some times available/some times not variables (closes #5491) [wbruce@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4997 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 20:01:52 +00:00
David Heinemeier Hansson
939017487d Update usage notes to verify
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4996 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 19:42:10 +00:00
David Heinemeier Hansson
4c966a07a1 Fixed FormOptionsHelper#select to respect :selected value (closes #5813)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4995 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 19:35:18 +00:00
David Heinemeier Hansson
d4bb22b220 Fixed TextHelper#simple_format to deal with multiple single returns within a single paragraph (closes #5835) [moriq@moriq.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4994 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 19:26:32 +00:00
David Heinemeier Hansson
a693b3beca Fixed TextHelper#pluralize to handle 1 as a string (closes #5905) [rails@bencurtis.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4993 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 19:23:07 +00:00
David Heinemeier Hansson
17f7eaa141 Improved resolution of DateHelper#distance_of_time_in_words for better precision (closes #5994) [Bob Silva]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4989 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 17:00:37 +00:00
David Heinemeier Hansson
fc901e6f5d Doc fix (closes #6023)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4988 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 16:47:48 +00:00
Jeremy Kemper
da8d7a7011 deprecated render assertions
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:51:48 +00:00
Jeremy Kemper
e04a6e8155 deprecated assertions tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:47:51 +00:00
David Heinemeier Hansson
653bfe9600 Dont raise deprecation warning on render :action => "stuff"
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4975 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:24:08 +00:00
Jeremy Kemper
ea831469a9 new render deprecations test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4974 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:09:18 +00:00
Jeremy Kemper
96c45a8118 Don't use deprecated render API. Cosmetics.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4973 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:07:26 +00:00
Jeremy Kemper
7cbb4ac44f deprecated keep_flash test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4972 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:06:10 +00:00
Jeremy Kemper
3158730411 redirect deprecation tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4971 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 05:05:11 +00:00
Jeremy Kemper
d4a3eff89d no more render_to_string deprecation warnings
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 04:59:05 +00:00
Jeremy Kemper
2dd5820280 silence deprecation warnings. cosmetics.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4969 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 04:58:08 +00:00
Jeremy Kemper
7818cf1123 deprecated render tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4968 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 04:05:38 +00:00
Jeremy Kemper
9b424f04ca test_test deprecation and cosmetics
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4967 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 04:03:57 +00:00
Jeremy Kemper
be54075956 set ActiveSupport::Deprecation.debug = true to see backtraces for deprecation callers. off by default. on for Rails tests.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4966 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-04 03:38:13 +00:00