github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-03 10:45:01 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,381 Commits 34 Branches 105 Tags
56ade7513156b06b2d8b8df28bfdde2427e422cb
Commit Graph

591 Commits

Author SHA1 Message Date
Jeremy Kemper
427300e08f Quote column names in generated SQL. Closes #2728. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2866 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-04 01:49:10 +00:00
Jeremy Kemper
189b7907d5 Correct the pure-Ruby MySQL 4.1.1 shim's version test. Closes #2718. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2864 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-03 21:17:32 +00:00
Jeremy Kemper
44d1420757 Add Model.create! to match existing model.save! method. When save! raises RecordInvalid, you can catch the exception, retrieve the invalid record (invalid_exception.record), and see its errors (invalid_exception.record.errors). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2863 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-03 18:54:16 +00:00
Jeremy Kemper
e024f2f1bf Correct fixture behavior when table name pluralization is off. Closes #2719. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2862 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-03 15:43:48 +00:00
David Heinemeier Hansson
8c512a1caf Added extension capabilities to has_many and has_and_belongs_to_many proxies [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2861 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-03 09:06:42 +00:00
Jeremy Kemper
aabf9093a0 Correct reader method generation for primary key attribute: handle case when primary_key is defined but its column is nil, such as when the model class is backed by a view. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2850 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-02 17:30:59 +00:00
Jeremy Kemper
c827b3f15c A missing primary key column shouldn't raise an error when generating its error message. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2837 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-01 18:21:46 +00:00
Florian Weber
d5859d0b17 Added that an DuplicateMigrationVersionError gets raised when multiple migrations have the same version number. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2832 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-31 15:43:02 +00:00
David Heinemeier Hansson
c21fdf31a5 Changed :dbfile to :database for SQLite adapter for consistency (old key still works as an alias) (closes #2644) [Dan Peterson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2825 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-30 08:10:04 +00:00
David Heinemeier Hansson
68160b3485 Added migration support for Oracle (closes #2647) [Michael Schoen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2817 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-29 18:40:49 +00:00
Jeremy Kemper
14b60fc074 Worked around that connection can't be reset if allow_concurrency is off. Closes #2648. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2816 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-29 18:17:13 +00:00
David Heinemeier Hansson
e508595cf7 Fixed SQL Server adapter so it honors options[:conditions] when applying :limits (closes #1978) [Tom Ward] Fixed SQL Server adapter to pass even more tests and do even better (closes #2634) [rtomayko@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2781 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-28 09:20:05 +00:00
David Heinemeier Hansson
816f37a2ad Added migration support to SQL Server adapter (please someone do the same for Oracle and DB2) (closes #2625) [Tom Ward] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2778 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-28 07:40:28 +00:00
Jeremy Kemper
fb61912798 r3801@sedna: jeremy | 2005-10-28 00:42:28 -0700 
Use AR::Base silencing rather than AR::Base.logger silencing in fixtures to preserve Log4r compatibility.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2775 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-28 04:53:35 +00:00
Jeremy Kemper
e7cd7e9d95 r3800@sedna: jeremy | 2005-10-28 00:39:05 -0700 
Readonly constraints, association collection method_missing, dup constraint options


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2774 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-28 04:53:22 +00:00
Marcel Molina
0ba5bd583b Update documentation for observers to reflect new configuration system. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2766 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-27 16:06:04 +00:00
David Heinemeier Hansson
beff664f2a Refactor DB exceptions and deal more with DB2 (closes #2624) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2761 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-27 08:18:41 +00:00
David Heinemeier Hansson
9b2ea172d7 Add exception to example (closes #2315) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2752 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 13:29:11 +00:00
David Heinemeier Hansson
0b92d38c00 Added :offset and :limit to the kinds of options that Base.constrain can use (closes #2466) [duane.johnson@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2748 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 13:20:02 +00:00
David Heinemeier Hansson
a8eea0b04b Fix docs (closes #2491) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2744 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 13:05:48 +00:00
David Heinemeier Hansson
dd257a3ccb Fixed handling of nil number columns on Oracle and cleaned up tests for Oracle in general #2555 [schoenm@earthlink.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2741 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 12:57:11 +00:00
David Heinemeier Hansson
85a7892644 Added quoted_true and quoted_false methods to db2_adapter and cleaned up tests for DB2 (closes #2493) [maik schmidt] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2739 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 12:47:23 +00:00
David Heinemeier Hansson
c7a6b9862d Prepared for release of 0.14.2 (RC3) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2737 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-25 22:11:48 +00:00
Jamis Buck
06303ed34e Allow symbols to rename columns when using SQLite adapter. #2531 [kevin.clark@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2731 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-25 19:28:53 +00:00
Jeremy Kemper
17d3fd3165 r2736@asus: jeremy | 2005-10-24 17:08:12 -0700 
Test for eager associations with limits should not assume that records are ordered by id.
 r2737@asus:  jeremy | 2005-10-24 19:06:09 -0700
 Fail fast if invalid primary key column.
 r2746@asus:  jeremy | 2005-10-25 15:37:28 -0700
 Begin rollback of fixture delete order.  Its solves a problem for 1% of users who already have a workaround while severely slowing down the other 99%.
 r2747@asus:  jeremy | 2005-10-25 16:03:01 -0700
 Rollback the rest.
 r2748@asus:  jeremy | 2005-10-25 16:06:26 -0700
 Re-add fixtures declaration to conditions scoping test
 r2749@asus:  jeremy | 2005-10-25 16:09:03 -0700
 Re-add fixtures declaration to finder test
 r2750@asus:  jeremy | 2005-10-25 16:13:50 -0700
 Don't assume keyboards table is empty


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2730 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-25 18:14:09 +00:00
Florian Weber
49bee8826a Minor documentation fix 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2726 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-25 10:44:07 +00:00
Jeremy Kemper
f57ba4cc52 r2727@asus: jeremy | 2005-10-24 14:14:36 -0700 
Fallback to @loaded_fixtures = {}.  Use Logger#silence.  Test fixture isolation with use_instantiated_fixtures and with no fixtures declaration.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2719 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-24 16:45:33 +00:00
Jeremy Kemper
0e4c5b0288 r2726@asus: jeremy | 2005-10-24 14:11:59 -0700 
correct primary key semantics: foo.id and foo.real_pk_column should both exist and return nil if foo.new_record?


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2718 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-24 16:45:22 +00:00
Jeremy Kemper
a2f0ae76d1 r2718@asus: jeremy | 2005-10-23 14:45:30 -0700 
Ticket 2404 - fixture delete order
 r2719@asus:  jeremy | 2005-10-23 15:01:13 -0700
 Keep closer tabs on dirty, loaded, and declared fixtures.  Closes #2404.
 r2720@asus:  jeremy | 2005-10-23 16:09:19 -0700
 ensure table names are strings.  set dirty = dirty union loaded rather than dirty = loaded.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2714 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-23 19:02:38 +00:00
Jeremy Kemper
76879f2541 Map Active Record time to SQL TIME. Closes #2576. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2713 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-23 17:22:03 +00:00
Jeremy Kemper
76487f25e7 Map AR time to PostgreSQL TIME. Closes #2575. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2712 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-23 16:54:38 +00:00
Jeremy Kemper
3ab3a70b7c Clarify semantics of ActiveRecord::Base#respond_to? Closes #2560. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2705 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-22 16:43:39 +00:00
Tobias Lütke
5f0b9369cc Fix Associations#clear for not-yet-loaded associations (Patrick Lenz) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2695 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-20 15:05:48 +00:00
Jeremy Kemper
7219e82fe6 HABTM finder sets :readonly => false. Closes #2525. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2694 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-20 14:53:04 +00:00
David Heinemeier Hansson
83dc37b910 Made ready to push RC2 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2684 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-19 06:24:12 +00:00
Jeremy Kemper
328ef3feaa Parenthesize :conditions 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2681 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-18 23:52:07 +00:00
Jeremy Kemper
311342d8e2 Correct PostgreSQL primary key sequence detection. #2507 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2680 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-18 19:46:11 +00:00
David Heinemeier Hansson
851dd0806b Added support for using limits in eager loads that involve has_many and has_and_belongs_to_many associations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2675 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-18 12:02:25 +00:00
David Heinemeier Hansson
f4aaa26eb3 Getting ready for 0.14.0 (1.0.0 Release Candidate 1) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2660 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 22:15:03 +00:00
Jamis Buck
bcd0968a6f Update/clean up ActiveRecord documentation (rdoc) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2650 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 16:00:16 +00:00
Jeremy Kemper
7117fdb8ce r3616@asus: jeremy | 2005-09-26 23:09:28 -0700 
Ticket 2292 - Sequences, schemas, and fixtures
 r3917@asus:  jeremy | 2005-10-15 10:43:24 -0700
 fix pk assert
 r3918@asus:  jeremy | 2005-10-15 10:46:52 -0700
 rework query cache connection= override
 r3919@asus:  jeremy | 2005-10-15 10:47:45 -0700
 correct fixtures usage
 r3920@asus:  jeremy | 2005-10-15 10:53:23 -0700
 correct attr assignment
 r3921@asus:  jeremy | 2005-10-15 12:59:10 -0700
 sequences
 r3922@asus:  jeremy | 2005-10-15 16:36:09 -0700
 reset fixtures work with sequences
 r3951@asus:  jeremy | 2005-10-15 23:23:12 -0700
 cut down excess features
 r3952@asus:  jeremy | 2005-10-15 23:40:30 -0700
 don't test for PostgreSQL specifically


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2639 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 03:45:39 +00:00
Jamis Buck
1ea085ec7e Comment out the memory leak test because it b0rks the testing environment. Update some contact info. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2636 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 02:30:04 +00:00
Nicholas Seckar
67e900c0f4 Fix bad commit. (Bad developer, bad\!) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2633 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 01:20:43 +00:00
Nicholas Seckar
9369137676 Add __FILE__ and __LINE__ to eval 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2629 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 22:56:36 +00:00
Jamis Buck
bfbf6bba1f Allow ARStore::Session to indicate that it should not be reloaded in dev mode 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2627 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 20:49:04 +00:00
Jamis Buck
e7f61eab56 squash the memleak in dev mode finally (fingers crossed, here) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2620 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 18:21:27 +00:00
Sam Stephenson
10714869dc Change default logging colors to work on both white and black backgrounds. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2614 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 15:34:09 +00:00
Jeremy Kemper
00a194d739 Really fix #1896. YAML class structure changed between 1.8.2 and 1.8.3, breaking the original implementation. Duck-type instead of checking kind_of? 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2603 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 02:49:22 +00:00
Marcel Molina
07b4ea2e4b Eliminate an obsolete comment. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2601 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 02:13:42 +00:00
Jeremy Kemper
da675e536d Support ordered YAML fixtures. #1896 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2600 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 02:01:38 +00:00