github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
4,138 Commits 34 Branches 105 Tags
5728b82c01b05ab55292a463771dcafaba778f11
Commit Graph

56 Commits

Author SHA1 Message Date
Nicholas Seckar
8d809e724a Clear the cache of possible controllers whenever Routes are reloaded. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-23 17:25:06 +00:00
Nicholas Seckar
4ae3db8366 Fix routing to respect user provided requirements and defaults when assigning default routing options (such as :action => 'index'). Closes #5950. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-20 17:45:03 +00:00
David Heinemeier Hansson
40762a4873 Fixed default routing NoMethodError downcase for nil when default controller provided (closes #5400) [kajism@yahoo.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4998 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-04 20:09:15 +00:00
Rick Olson
2b45e2d370 Add routing tests to assert that RoutingError is raised when conditions aren't met. Closes #6016 [Nathan Witmer] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4907 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-02 20:41:40 +00:00
Nicholas Seckar
caf546b675 Add test case from ticket #4090 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4805 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-22 07:18:24 +00:00
Nicholas Seckar
7678d123a7 Relax Routing's anchor pattern warning; it was preventing use of [^/] inside restrictions. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-15 02:04:11 +00:00
Nicholas Seckar
5baf7462c7 Add controller_paths variable to Routing; Assign Routing.controller_paths from initializer; fix script/about and rails info controller. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4762 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-15 01:28:06 +00:00
Rick Olson
8c4b599b7c Fix assert_redirected_to issue with named routes for module controllers. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-13 18:31:58 +00:00
Nicholas Seckar
127ee8c8f8 Make Routing noisy when an anchor regexp is assigned to a segment. Closes #5674 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-08-05 22:12:50 +00:00
Nicholas Seckar
e494b0a441 Add route_name_path method to generate only the path for a named routes. For example, map.person will add person_path. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4518 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-30 02:36:17 +00:00
Rick Olson
2bbcff8cf4 Fix that routes with *path segments in the recall can generate URLs. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4454 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-17 00:25:24 +00:00
Rick Olson
2f58a467e3 add passing test to make sure unhandled requests don't load unnecessary classes. Closed #5408. [nkriege@hotmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4451 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-16 03:22:09 +00:00
Jamis Buck
816d67b104 Make sure passed routing options are not mutated by routing code. (closes #5314) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4444 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-07 16:27:14 +00:00
Jamis Buck
ae7029ddd1 Do some path normalization to prevent the possible_controllers list from containing invalid entries 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4443 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-07 16:16:37 +00:00
Jamis Buck
4e3543b467 Make sure named routes are never generated relative to some containing module 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4442 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-06 19:09:56 +00:00
Jamis Buck
e768dc694d Improve parameter expiry handling to fix sticky-id issue. Add a more informative Route#to_s method. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-06 17:59:54 +00:00
Jamis Buck
6c04eb2115 Make sure changing the controller from foo/bar to bing/bang does not change relative to foo. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4438 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 15:48:29 +00:00
Jamis Buck
149f5cad85 Escape the entire path before trying to recognize it (closes #3671) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4436 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 15:30:09 +00:00
Jamis Buck
2ffc84d23f Make sure :id and friends are properly unescaped (closes #5275). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4435 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 14:51:27 +00:00
Jamis Buck
332fcfaf6b Make sure regexp chunks are grouped when the segment has a regexp constraint so that captures are counted correctly (closes #5267) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-05 14:31:38 +00:00
Jamis Buck
b20c575ac0 New routes implementation. Simpler, faster, easier to understand. The published API for config/routes.rb is unchanged, but nearly everything else is different, so expect breakage in plugins and libs that try to fiddle with routes. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4394 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-01 15:42:08 +00:00
Rick Olson
04ef7f4be6 Small fix in routing to allow dynamic routes (broken after [4242]) [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4319 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-30 21:06:49 +00:00
Jamis Buck
e75d27f405 restore some commented lines 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-21 20:15:53 +00:00
Jamis Buck
0a0b5bd722 fix to ';' interpretation in route recognition--only follow a route with ';' if the segment in question actually contains a ';' 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4244 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-21 17:21:26 +00:00
Jamis Buck
1f80f540a7 Add support in routes for semicolon delimited "subpaths", like /books/:id;:action 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-21 15:17:02 +00:00
Nicholas Seckar
5450538563 Don't let arbitrary classes match as controllers 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 23:59:37 +00:00
Nicholas Seckar
427d0a8d14 Fix bad require for rake test 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 23:14:22 +00:00
Nicholas Seckar
cc768dc900 Fix routing tests to pass when run independently of the entire AP suite 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3540 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 23:12:15 +00:00
Nicholas Seckar
b381d8511d Fix Routing tests. Fix routing where failing to match a controller would prevent the rest of routes from being attempted. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3539 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 23:09:26 +00:00
Nicholas Seckar
b9c79f195f Add routing tests from #1945 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2257 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-18 14:37:43 +00:00
Nicholas Seckar
57e0cf8e95 Add a routing test case covering #2101 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-18 14:11:24 +00:00
Nicholas Seckar
27962ead03 Add ability to specify Route Regexps for controllers. Closes #1917. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2205 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 13:56:43 +00:00
Nicholas Seckar
9e5d64b3bb Provide Named Route's hash methods as helper methods. Closes #1744. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2204 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 13:45:55 +00:00
Nicholas Seckar
741316dc71 Fixed construction of get parameters for arrays 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1857 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-18 03:12:45 +00:00
Nicholas Seckar
c0771fe7d8 Fix assert_routing with nested controllers. Closes #1582 and #1386. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1837 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-15 15:00:39 +00:00
Nicholas Seckar
bf0b7588ee Add RouteSet#named_route so that RouteSet instance methods do not shadow available route names 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1834 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-14 10:32:37 +00:00
Nicholas Seckar
6ed16ff602 Provide correct defaults for Named Routes which do not specify :action 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-14 09:09:39 +00:00
Nicholas Seckar
2bd4ff11f8 Generate URLs for :action => index when :action => nil is supplied. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-14 00:13:06 +00:00
Nicholas Seckar
9314793239 Named routes should not provide nil values to url_for. Includes factoring and extra testcases. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1825 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-13 23:13:15 +00:00
Nicholas Seckar
c18961f185 Routes now raise an exception if a path component is misconfigured. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-08 08:56:24 +00:00
Nicholas Seckar
4a3ec21b62 Fix routes to generate proper URLs when given Fixnum defaults 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1768 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-08 08:45:51 +00:00
Nicholas Seckar
f4bfacb24f Enable routes to recognize uppercase controller names. Closes #1635 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1765 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-07 19:51:20 +00:00
Nicholas Seckar
5727dc2f42 Properly unescape recognized path components. Fixes #1651. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1764 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-07 19:43:03 +00:00
David Heinemeier Hansson
75157bbf64 Fixed that named routes didn't use the default values for action and possible other parameters #1534 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1758 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-07 14:16:05 +00:00
David Heinemeier Hansson
212cc3845a Fixed routing snafu 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1736 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-06 10:45:14 +00:00
David Heinemeier Hansson
4fe0248f57 Fixed routing regression on index exception 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1713 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 15:31:51 +00:00
Jamis Buck
3b1d271e02 Routing fix 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1712 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-05 15:06:09 +00:00
David Heinemeier Hansson
5524dedc06 Fixed routing bug #1592 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1645 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 12:01:06 +00:00
Jeremy Kemper
31e48939b1 r1475@iwill: jeremy | 2005-06-28 23:19:51 -0700 
Ticket 1543 - Fix test_process
 r1476@iwill:  jeremy | 2005-06-29 00:20:53 -0700
 Correct expected, actual order for assert_equal.  Use new render method in TestController.
 r1477@iwill:  jeremy | 2005-06-29 00:23:45 -0700
 Generate route and assign parameters without modifying the user's params.
 r1480@iwill:  jeremy | 2005-06-29 00:28:52 -0700
 Update changelog.
 r1481@iwill:  jeremy | 2005-06-29 00:34:02 -0700
 Directly generate paths with a leading slash instead of tacking it on later.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1557 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-29 02:41:00 +00:00
Jamis Buck
453ed15395 Routes fail with leading slash #1540 [Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1555 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-06-28 21:18:04 +00:00