github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-31 01:08:19 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,457 Commits 34 Branches 105 Tags
5757fb61d88908eb420b9a0d15197caee5cf00a2
Commit Graph

1216 Commits

Author SHA1 Message Date
David Heinemeier Hansson
ee45d76df8 Roll back #7578, tests failed 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-22 23:10:41 +00:00
David Heinemeier Hansson
9ab8d4d9ed Improve the error message for assert_redirected_to (closes #7337) [sandofsky] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7578 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-22 22:22:20 +00:00
Michael Koziarski
7573791284 Disable the routing optimisation code when dealing with foo_url helpers. Add test to actionmailer to expose the problem they introduced. References #9450 [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7572 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-22 19:20:06 +00:00
Nicholas Seckar
defb4d08dc Remove use of & logic operator. Closes #8114. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7571 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-22 19:02:51 +00:00
David Heinemeier Hansson
712b71371d Doc fix (closes #9123) [tzaharia] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7559 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-22 18:03:31 +00:00
David Heinemeier Hansson
d1808916ae Fix buffer 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7534 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-22 05:14:56 +00:00
Michael Koziarski
9b468f4cd7 [html-scanner] Fix parsing of empty tags. Closes #7641. [anthony.bailey] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7528 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-21 20:45:49 +00:00
Michael Koziarski
045aee8912 Prevent clashing named routes when using uncountable resources. Closes #9598 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7526 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-21 18:06:01 +00:00
David Heinemeier Hansson
eede82ccb9 Added support for HTTP Only cookies (works in IE6+ and FF 2.0.5+) as an improvement for XSS attacks (closes #8895) [lifo/Spakman] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7525 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-21 15:05:49 +00:00
Nicholas Seckar
16529a92dd Don't warn when a path segment precedes a required segment. Closes #9615. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7523 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-21 04:52:18 +00:00
David Heinemeier Hansson
1373991dd8 Added that render :json will automatically call .to_json unless its being passed a string [DHH] Added Mime::Type.register_alias for dealing with different formats using the same mime type [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7520 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-20 23:34:07 +00:00
David Heinemeier Hansson
0d99423727 Fixed that default layouts did not take the format into account #9564 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7514 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-18 23:10:34 +00:00
David Heinemeier Hansson
4e7dce7e40 Added security notice to Request#remote_ip underlining the fact that its value can be spoofed (and that you should use Request#remote_addr if thats a concern for your application) [Adrian Holovaty] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7502 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-17 11:12:10 +00:00
Michael Koziarski
7cb26b5d2d Disable optimisation code for UrlWriter as request.host doesn't make sense there. 
Don't try to use the .to_query method when the route has no dynamic segments.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7501 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-17 09:30:18 +00:00
Jeremy Kemper
bfb906a905 Speed up and simplify query caching. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7498 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-17 06:15:58 +00:00
Jeremy Kemper
148202d401 Fixed optimized route segment escaping. Closes #9562. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7487 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-15 22:10:20 +00:00
Jeremy Kemper
494d2c631b root_path returns '/' not ''. Closes #9563. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7482 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-15 20:38:39 +00:00
David Heinemeier Hansson
d48039cefb Fixed that setting request.format would also affect respond_to blocks [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7479 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-15 04:18:32 +00:00
Jeremy Kemper
c87206cc57 Add option to force binary mode on tempfile used for fixture_file_upload. Closes #6380. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7478 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-14 07:34:45 +00:00
Jeremy Kemper
15f7f1a380 Missed Reloadable bits and pieces 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7475 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-14 01:00:32 +00:00
Jeremy Kemper
e6941149ab Deprecation: removed Reloadable. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-14 00:25:59 +00:00
Jeremy Kemper
9807b55c6b Purge empty files 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-11 19:54:06 +00:00
Jeremy Kemper
f028d77ed7 Remove empty macros 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7463 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-11 19:43:58 +00:00
David Heinemeier Hansson
bc290c083c Moved ActionController::Macros::AutoComplete into the auto_complete plugin on the official Rails svn #9512 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7450 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-11 02:57:19 +00:00
David Heinemeier Hansson
b611c685d9 Fixed that resource namespaces wouldnt stick to all nested resources (closes #9399) [pixeltrix] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7447 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-10 14:31:44 +00:00
David Heinemeier Hansson
2807ccc69a Moved ActionController::Macros::InPlaceEditing into the in_place_editor plugin on the official Rails svn (closes #9513) [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7442 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-10 00:53:13 +00:00
David Heinemeier Hansson
ff9ca2ca1e Random hits from the style nazi 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7438 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 23:12:57 +00:00
David Heinemeier Hansson
2c690edb94 Random hits from the style nazi 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7437 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 23:03:32 +00:00
David Heinemeier Hansson
46f217b298 Removed deprecated form of calling xml_http_request/xhr without the first argument being the http verb [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7436 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 23:00:17 +00:00
David Heinemeier Hansson
4cfc60a6c8 Removed deprecated ActionController::Base.cookie (use ActionController#Base.cookies[]= instead) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 22:55:16 +00:00
David Heinemeier Hansson
c70a731115 Removed ActionController::Base.scaffold -- it went through the whole idea of scaffolding (card board walls you remove and tweak one by one). Use the scaffold generator instead (it does resources too now!) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7429 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 22:26:36 +00:00
David Heinemeier Hansson
6b0a647236 Removed ActionController::Base#keep_flash (use flash.keep instead) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7428 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 21:54:59 +00:00
David Heinemeier Hansson
b7c565dc62 Removed deprecated ActionController::Base#expire_matched_fragments (just call expire_fragment with a regular expression) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7427 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 18:03:55 +00:00
David Heinemeier Hansson
89b7630627 Removed the deprecated ActionController#Base.template_root/= methods (use ActionController#Base.view_paths/= instead) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7426 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 18:00:55 +00:00
Michael Koziarski
80ff0b9f1c Optimise named route generation when using positional arguments. Closes #9450 [Koz] 
This change delivers significant performance benefits for the most
  common usage scenarios for modern rails applications by avoiding the
  costly trip through url_for.  Initial benchmarks indicate this is
  between 6 and 20 times as fast.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7421 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-09 00:18:55 +00:00
Jeremy Kemper
2894887925 Explicitly require active_record/query_cache before using it. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7419 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-08 04:31:26 +00:00
Jeremy Kemper
f1b12b62f4 Fix layout overriding response status. Closes #9476. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-08 03:12:03 +00:00
Michael Koziarski
32553a2d76 Fix assert_select for XML documents. Closes #8173. [dasil003] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7417 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-08 01:32:16 +00:00
Michael Koziarski
fe31f0e066 Add a user_agent to TestRequest 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7416 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-07 03:45:54 +00:00
Tobias Lütke
68d685056a Remove deprecated named routes [pixeltrix] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7415 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-06 14:28:32 +00:00
Michael Koziarski
a75d273ece Allow additional parameters to be passed to named route helpers when using positional arguments. Closes #8930 [ian.w.white@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7411 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-05 23:37:17 +00:00
Michael Koziarski
f81dae3fca Remove deprecated functionality from actionpack. Closes #8958 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-03 00:18:30 +00:00
Jeremy Kemper
ed09b621bd Documentation tweaks and fixes. Closes #9454 [sur, kampers] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7383 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-31 19:07:42 +00:00
Jeremy Kemper
33e5e41dda request.host works with IPv6 addresses. Closes #9458. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7382 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-31 19:03:42 +00:00
Michael Koziarski
35ade47a30 Fix incorrectly named instance variable. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7372 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-29 03:43:08 +00:00
Michael Koziarski
719d3e8a9a Use mocha to avoid the sleep calls in the compiled_template tests. [tarmo] Closes #9372 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7370 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-29 03:14:15 +00:00
Michael Koziarski
c6a18308ef Only reload routes.rb if its been modified. [Dreamer3] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7369 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-29 03:01:11 +00:00
Michael Koziarski
93eaaef43c Use extract_options instead of ad-hoc partial implementations. [norbert] Closes #9313 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7364 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-28 23:16:49 +00:00
Michael Koziarski
43ef688d74 Improve documentation for ActionController::Helpers [jardeon] Closes #9359 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7363 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-28 23:16:15 +00:00
David Heinemeier Hansson
5f163d256c Back out of [7300] -- it screwed up nested XML 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7357 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-08-21 22:59:42 +00:00