github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-29 08:18:03 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,892 Commits 34 Branches 105 Tags
5a02ee2bd8bbaffde71da39de850ed8ea5e66dbc
Commit Graph

620 Commits

Author SHA1 Message Date
Nicholas Seckar
de54db3c1e Check NameErrors and re-raise if they do not match the expected constant 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3636 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-22 17:29:22 +00:00
David Heinemeier Hansson
e875b0db47 Fixed that the request method would be sticky in tests (closes #3849) [lars@pinds.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3622 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-20 23:49:43 +00:00
David Heinemeier Hansson
377bdd02b9 Added :count option to pagination that'll make it possible for the ActiveRecord::Base.count call to using something else than * for the count. Especially important for count queries using DISTINCT #3839 [skaes]. Added :select option to Base.count that'll allow you to select something else than * to be counted on. Especially important for count queries using DISTINCT (closes #3839) [skaes]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3620 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-20 03:15:22 +00:00
David Heinemeier Hansson
8896efd41a Ensure backwards compatibility with symbolized action names for render_action (closes #3869) [anna@wota.jp] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3606 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-19 00:46:34 +00:00
David Heinemeier Hansson
1812dbbfde Make RJS treat symbolic action names nicely #3861 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3596 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-17 18:32:21 +00:00
David Heinemeier Hansson
db2023d4d2 The session should be saved even if the filter chain is stopped 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3584 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 16:35:15 +00:00
David Heinemeier Hansson
431edf7793 Fixed that flash wasnt being cleared after components refactoring yesterday 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3582 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 16:18:06 +00:00
David Heinemeier Hansson
ff986f19af Flash shouldnt depend on components either [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3581 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 06:11:17 +00:00
David Heinemeier Hansson
050c3964d8 Stopped the massive bleeding of concerns into ActionController::Base. Base no longer knows about flash, filters, or components. This may well have introduced some instability, please do test with apps, especially the ones using components. [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 05:51:02 +00:00
David Heinemeier Hansson
e90bbbdd83 Add caution and restyle components 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3577 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 01:06:45 +00:00
David Heinemeier Hansson
137794310b The components module should also contain the options that pertain to it, so collect it all with ClassMethods and InstanceMethods 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3576 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 00:46:01 +00:00
Jeremy Kemper
7654082260 Major components cleanup and speedup. Closes #3527. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3563 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 20:05:11 +00:00
Michael Koziarski
d49a5fcb4c * Fix pagination problems when using include 
* Introduce Unit Tests for pagination
* Allow count to work with :include by using count distinct.

[Kevin Clark & Jeremy Hopple]


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3553 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 09:17:40 +00:00
Marcel Molina
73ed47ddec Replace dubious controller parent class in filter docs. Closes #3655, #3722. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3551 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-08 05:24:53 +00:00
Nicholas Seckar
5450538563 Don't let arbitrary classes match as controllers 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 23:59:37 +00:00
Nicholas Seckar
b381d8511d Fix Routing tests. Fix routing where failing to match a controller would prevent the rest of routes from being attempted. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3539 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 23:09:26 +00:00
Tobias Lütke
28cee08fa4 fixed small bug in routing which caused the traverse_to_controller mechanism to drop out on 
Multi::Nested::Controllers


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3538 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 22:04:19 +00:00
David Heinemeier Hansson
5cbc062c8a Just go with Subclasses instead of OnlySubclasses 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3534 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 16:26:55 +00:00
David Heinemeier Hansson
ed080863d5 Just go with Subclasses instead of OnlySubclasses 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3533 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 06:11:42 +00:00
Nicholas Seckar
38aae1b122 Remove unneeded logging 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3531 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 05:41:58 +00:00
Nicholas Seckar
dfa6e14af6 Fix controller resolution to avoid accidentally inheriting a controller from a parent module. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3530 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 05:20:25 +00:00
Nicholas Seckar
c77729fd23 Set sweeper's @controller to nil after a request so that the controller may be collected between requests. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3529 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 05:00:21 +00:00
Nicholas Seckar
ad9cabd77c Remove LoadingModule 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3526 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-03 20:29:39 +00:00
Nicholas Seckar
1bce58b312 Add Reloadable::OnlySubclasses which handles the common case where a base class should not be reloaded, but its subclasses should be. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3521 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-02 05:41:00 +00:00
Nicholas Seckar
7a43a05a2b Further improvements to reloading code 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3519 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-02 04:54:07 +00:00
Sam Stephenson
49401f880c Subclasses of ActionController::Caching::Sweeper should be Reloadable 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3517 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-01 20:25:27 +00:00
David Heinemeier Hansson
26761d6d32 If included_modules doesnt take a parameter, we shouldnt either 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3509 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-01 03:58:37 +00:00
Michael Koziarski
e398045774 Fix Syntax problems which were preventing webrick from starting 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3508 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-01 03:54:37 +00:00
Marcel Molina
59d29811c5 Document the :xhr option for verifications. Closes #3666. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3507 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-01 03:22:18 +00:00
David Heinemeier Hansson
aee8db1584 ActiveRecordStore::Session shouldnt be reloadable 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3506 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-01 03:08:43 +00:00
David Heinemeier Hansson
15da1cf2ca Dont mark Sweepers as reloadables 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3505 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-01 02:58:22 +00:00
David Heinemeier Hansson
2504982945 Added :only and :except controls to skip_before/after_filter just like for when you add filters [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3504 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-31 23:55:04 +00:00
Nicholas Seckar
d2adec438e Ensure assigns are copied to the template when using render :update. Closes #3620. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3497 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-30 04:49:17 +00:00
David Heinemeier Hansson
01b1a87729 Added reusable reloading support through the inclusion of the Relodable module that all subclasses of ActiveRecord::Base, ActiveRecord::Observer, ActiveController::Base, and ActionMailer::Base automatically gets [DHH]. Added auto-loading support for classes in modules, so Conductor::Migration will look for conductor/migration.rb and Conductor::Database::Settings will look for conductor/database/settings.rb [Nicholas Seckar]. Refactored extensions to module, class, and object in active support [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3493 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-29 00:37:39 +00:00
Sam Stephenson
9c52a41241 Add the ability to call JavaScriptGenerator methods from helpers called in update blocks 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3476 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-23 17:09:15 +00:00
Sam Stephenson
4d49f2ca09 Fix render(:update) to not render layouts 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3472 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-23 16:29:37 +00:00
Sam Stephenson
5f44411d94 Backing out of [3470] until visual_effect, et al can work 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3471 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-23 07:27:24 +00:00
Sam Stephenson
8436147825 Add the ability to call JavaScriptGenerator methods from helpers called in update blocks 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3470 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-23 06:52:26 +00:00
David Heinemeier Hansson
010e999092 Fixed that SSL would not correctly be detected when running lighttpd/fcgi behind lighttpd w/mod_proxy (closes #3548) [stephen_purcell@yahoo.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3467 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-23 05:32:59 +00:00
David Heinemeier Hansson
6236d518f2 Added the possibility to specify atomatic expiration for the memcachd session container (closes #3571) [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-22 22:21:26 +00:00
Marcel Molina
8d4d88a4f0 Change layout discovery to take into account the change in semantics with File.join and nil arguments. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3462 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-22 07:41:27 +00:00
David Heinemeier Hansson
ea30f7353b Raise a RedirectBackError if redirect_to :back is called when theres no HTTP_REFERER defined (closes #3049) [kevin.clark@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3459 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-22 01:52:23 +00:00
Sam Stephenson
a14b59b4b9 Extract Test::Unit::TestCase test process behavior into an ActionController::TestProcess module 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3443 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-20 22:18:39 +00:00
Sam Stephenson
f9937dd041 Pass along blocks from render_to_string to render 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3442 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-20 22:08:41 +00:00
Sam Stephenson
06dd1f2ca3 Add render :update for inline RJS 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-20 22:04:07 +00:00
Marcel Molina
4793a2f5cd Automatically discover layouts when a controller is namespaced. Closes #2199, #3424. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3423 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-15 11:28:55 +00:00
Michael Koziarski
f9e0ba2913 Correct the case of the CSS declarations. [Blair Zajac] Closes #3171 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3416 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-13 21:28:51 +00:00
Michael Koziarski
302533b196 Add support for multiple proxy servers in HTTP_X_FORWARDED_HOST. Closes #3397 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3412 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-13 08:31:16 +00:00
Marcel Molina
489ace60fb Remove Upload Progress. Closes #2871. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3406 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-13 04:27:53 +00:00
Marcel Molina
751b6be464 Allow auto-discovery of third party template library layouts. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-01-12 07:16:23 +00:00