Commit Graph

846 Commits

Author SHA1 Message Date
Marcel Molina
b7565075c3 More documentations for typos in routes. Closes #8228 [pam]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6673 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-06 04:26:49 +00:00
Marcel Molina
dac6aae7f8 Sweep flash when filter chain is halted. Closes #6175. [Caio Chassot <lists@v2studio.com>]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6670 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-06 04:17:01 +00:00
Michael Koziarski
67ca9224d7 Bug fix for the filter implementation
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6669 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-06 04:10:26 +00:00
David Heinemeier Hansson
edaf6baea7 Fixed that content_tag with a block will just return the result instead of concate it if not used in a ERb view #7857, #7432 [michael.niessner]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6652 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-02 22:30:41 +00:00
Rick Olson
0778464168 Replace the current block/continuation filter chain handling by an implementation based on a simple loop. #8226 [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6649 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-02 13:22:38 +00:00
Nicholas Seckar
5a3bb880db Update UrlWriter to accept :anchor parameter. Closes #6771.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6648 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-02 04:40:33 +00:00
David Heinemeier Hansson
da257eb81b Added the first part of Simply Helpful to core. The rest is pending a clean integartion of polymorphic urls [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6633 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-30 01:17:56 +00:00
David Heinemeier Hansson
70ac560e42 Removed breakpointer and Binding.of_caller in favor of relying on ruby-debug by Kent Sibilev since the breakpointer has been broken since Ruby 1.8.4 and will not be coming back [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6611 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-28 15:57:29 +00:00
David Heinemeier Hansson
8326a15784 Added map.namespace to deal with the common situation of admin sections and the like [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6594 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-27 16:58:36 +00:00
David Heinemeier Hansson
f985bfd8f8 Added test case for overwritting the name prefix
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6593 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-27 05:10:23 +00:00
David Heinemeier Hansson
8bf1f25254 Name prefix should nest like path prefix
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6592 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-27 05:07:56 +00:00
David Heinemeier Hansson
0adf4a97c1 Actually make the name_prefix work like the previous checkin said it would
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6590 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-27 05:06:38 +00:00
David Heinemeier Hansson
63aea3ffa9 Added :has_many and :has_one for declaring plural and singular resources beneath the current [DHH] Added :name_prefix as standard for nested resources [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6588 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-26 23:11:31 +00:00
David Heinemeier Hansson
6a85955642 Added parsing of file type in Hash.xml_in so you can easily do file uploads with base64 from an API [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6578 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-25 17:25:44 +00:00
David Heinemeier Hansson
82d70d1d16 Added that render :xml will try to call to_xml if it can [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6574 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-24 18:29:37 +00:00
David Heinemeier Hansson
5208d8d817 Added :location option to render so that the common pattern of rendering a response after creating a new resource is now a 1-liner [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6572 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-24 17:52:03 +00:00
Jeremy Kemper
38d574c6a3 Expect string response body.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6559 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-24 04:12:11 +00:00
Rick Olson
f86ff9fd52 oops! forgot new layout for layout tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6554 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-24 01:26:44 +00:00
Rick Olson
eb7a3045e3 apply [6543] to edge. Closes #5044 [tpope]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6545 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-20 21:44:08 +00:00
Rick Olson
596112dcf8 remove useless mock test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6518 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-12 20:26:42 +00:00
Rick Olson
6351e0a541 The default respond_to blocks don't set a specific extension anymore, so that both 'show.rjs' and 'show.js.rjs' will work. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6517 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-12 20:25:32 +00:00
Rick Olson
f5b8fc0335 Allow layouts with extension of .html.erb. Closes #8032 [Josh Knowles]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6516 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-12 17:11:48 +00:00
Tobias Lütke
01c35c8175 Removed ill faded xml_node class from codebase. Use XmlSimple instead
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6511 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-09 15:33:38 +00:00
Rick Olson
e0f8342676 Change default respond_to templates for xml and rjs formats. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6507 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-08 17:16:36 +00:00
Rick Olson
da6f5a1cb4 Change ActionView template defaults. Look for templates using the request format first, such as show.html.erb or show.xml.builder, before looking for the old defaults like show.erb or show.builder [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6499 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-02 00:02:11 +00:00
Rick Olson
cf865196fe add ActionView::Base#find_template_extension_for tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6498 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-04-01 22:29:19 +00:00
Jeremy Kemper
67d5a1abed Highlight helper highlights one or many terms in a single pass.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6493 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-30 01:19:01 +00:00
David Heinemeier Hansson
0cac2806a6 Dropped the use of ; as a separator of non-crud actions on resources and went back to the vanilla slash. It was a neat idea, but lots of the non-crud actions turned out not to be RPC (as the ; was primarily intended to discourage), but legitimate sub-resources, like /parties/recent, which didn't deserve the uglification of /parties;recent. Further more, the semicolon caused issues with caching and HTTP authentication in Safari. Just Not Worth It [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6485 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-28 21:55:40 +00:00
Tobias Lütke
df3ee41126 Improved the handling of broken accept headers
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6484 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-28 16:42:21 +00:00
David Heinemeier Hansson
0228975a4e Added that FormTagHelper#submit_tag will return to its original state if the submit fails and you're using :disable_with [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6480 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-27 19:42:54 +00:00
Jamis Buck
777deb9d15 Make sure the expiry hash is built by comparing the to_param-ized values of each hash
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-26 19:02:19 +00:00
Rick Olson
c6d7260841 Allow configuration of the default action cache path for #caches_action calls. [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6453 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-22 10:12:34 +00:00
Jeremy Kemper
c593721e7c Revert [6430] since the test is faulty. References #7837, closes #7842.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6435 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-16 13:55:36 +00:00
Jeremy Kemper
f596dda0bb Undeprecate redirect_to with Hash argument and additional url_for parameters. Closes #7837.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6430 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-16 05:21:19 +00:00
Jeremy Kemper
bbcfb9b625 Cookie session store: ensure that new sessions doesn't reuse data from a deleted session in the same request.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-14 11:33:10 +00:00
Jeremy Kemper
1f02271048 Deprecation: verification with :redirect_to => :named_route shouldn't be deprecated. Closes #7525.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-14 01:38:41 +00:00
Jeremy Kemper
5219aa9008 Cookie session store: raise ArgumentError when :session_key is blank.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6415 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-13 20:44:16 +00:00
Jeremy Kemper
f770165cc2 Deprecation: remove deprecated url_for(:symbol, *args) and redirect_to(:symbol, *args) controller methods. Use named routes instead.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6412 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-13 05:44:18 +00:00
Jeremy Kemper
1def3f0073 Deprecation: remove deprecated update_element_function, start_form_tag, and end_form_tag. Use RJS and form_tag instead.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6409 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-13 05:24:10 +00:00
Jeremy Kemper
2823a56f14 Deprecation: remove deprecated human_size helper alias. Use number_to_human_size instead.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6407 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-13 05:18:49 +00:00
Jeremy Kemper
dfc1285aad Deprecation: remove deprecated link_to_image and link_image_to methods. Use link_to(image_path(...), url).
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6405 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-13 05:12:59 +00:00
Jeremy Kemper
d20b943551 Deprecation: privatize deprecated render_partial and render_partial_collection methods.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-13 05:06:41 +00:00
Jeremy Kemper
da87839c89 Deprecation: remove toplevel components directory and uses_component_template_root.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-13 04:46:12 +00:00
Jeremy Kemper
0631400b4a Deprecation: remove deprecated request methods.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6401 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-13 04:32:45 +00:00
Jeremy Kemper
cb6d94cc57 Deprecation: remove deprecated redirect methods.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6400 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-13 03:58:22 +00:00
Jeremy Kemper
83c8db9818 Deprecation: remove deprecated instance variables.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-13 03:49:52 +00:00
Jeremy Kemper
8e01143854 Adjust test for unsorted Array#to_query. References #7756.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6380 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-11 13:29:40 +00:00
Jeremy Kemper
9cc32a9ec8 Give time_ago_in_words test some DST slop.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6374 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-11 12:29:20 +00:00
Jeremy Kemper
e17df19b86 Allow array and hash query parameters. Array route parameters are converted/to/a/path as before. References #6765, #7462. Closes #7047.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6343 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-06 07:47:23 +00:00
Tobias Lütke
e52c28a425 Ignore odd charset declaration in CONTENT_TYPE header which would throw off mime type lookup.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6340 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-03-05 18:24:17 +00:00