github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-01 09:44:56 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,422 Commits 34 Branches 105 Tags
5ca8b5fca42ca09bdaadfc7c985fbec9c2fbafa5
Commit Graph

733 Commits

Author SHA1 Message Date
David Heinemeier Hansson
5132170c72 Fixed faulty regex in get_table_name method (SQLServerAdapter) (closes #2639) [Ryan Tomayko] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2910 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-07 09:54:28 +00:00
David Heinemeier Hansson
6ab9f2bb40 Fix READMEs (closes #2680) [coffee2code] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2908 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-07 09:51:47 +00:00
David Heinemeier Hansson
49c801b71d Added :include as an option for association declarations [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2898 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-06 20:39:34 +00:00
David Heinemeier Hansson
89ec75edc9 Fixed missing join table fixtures 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2897 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-06 19:25:58 +00:00
David Heinemeier Hansson
da7752e590 Sharper example 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2896 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-06 19:07:09 +00:00
David Heinemeier Hansson
c8dd66fdcd Made association extensions use simpler block syntax 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2895 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-06 19:05:42 +00:00
Jeremy Kemper
a83e0cdec5 r2916@asus: jeremy | 2005-11-06 05:04:06 -0800 
Rename conditions_scoping_test to method_scoping_test.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2889 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-06 10:19:28 +00:00
Jeremy Kemper
390e6d246c r2915@asus: jeremy | 2005-11-06 05:02:53 -0800 
Rename Base.constrain to Base.with_scope so it doesn't conflict with existing concept of database constraints.  Make scoping more robust: uniform method => parameters, validated method names and supported finder parameters, raise exception on nested scopes.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-06 10:18:51 +00:00
David Heinemeier Hansson
6c5572701a Fixed that SQL Server should ignore :size declarations on anything but integer and string in the agnostic schema representation (closes #2756) [Ryan Tomayko] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2887 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-06 07:48:24 +00:00
David Heinemeier Hansson
a5a82d978b Added extension capabilities to has_many and has_and_belongs_to_many proxies [DHH] Added find_or_create_by_X as a second type of dynamic finder that'll create the record if it doesn't already exist [DHH] Added constrain scoping for creates using a hash of attributes bound to the :creation key [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2872 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-04 19:39:50 +00:00
Jeremy Kemper
4506a463e4 Omit internal dtproperties table from SQLServer table list. Closes #2729. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2869 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-04 06:01:03 +00:00
Jeremy Kemper
56ade75131 Explicitly require topic from reply fixture. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2867 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-04 05:46:28 +00:00
Jeremy Kemper
427300e08f Quote column names in generated SQL. Closes #2728. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2866 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-04 01:49:10 +00:00
Jeremy Kemper
189b7907d5 Correct the pure-Ruby MySQL 4.1.1 shim's version test. Closes #2718. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2864 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-03 21:17:32 +00:00
Jeremy Kemper
44d1420757 Add Model.create! to match existing model.save! method. When save! raises RecordInvalid, you can catch the exception, retrieve the invalid record (invalid_exception.record), and see its errors (invalid_exception.record.errors). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2863 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-03 18:54:16 +00:00
Jeremy Kemper
e024f2f1bf Correct fixture behavior when table name pluralization is off. Closes #2719. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2862 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-03 15:43:48 +00:00
David Heinemeier Hansson
8c512a1caf Added extension capabilities to has_many and has_and_belongs_to_many proxies [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2861 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-03 09:06:42 +00:00
Jeremy Kemper
aabf9093a0 Correct reader method generation for primary key attribute: handle case when primary_key is defined but its column is nil, such as when the model class is backed by a view. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2850 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-02 17:30:59 +00:00
Jeremy Kemper
c827b3f15c A missing primary key column shouldn't raise an error when generating its error message. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2837 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-01 18:21:46 +00:00
Florian Weber
d5859d0b17 Added that an DuplicateMigrationVersionError gets raised when multiple migrations have the same version number. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2832 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-31 15:43:02 +00:00
David Heinemeier Hansson
c21fdf31a5 Changed :dbfile to :database for SQLite adapter for consistency (old key still works as an alias) (closes #2644) [Dan Peterson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2825 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-30 08:10:04 +00:00
David Heinemeier Hansson
68160b3485 Added migration support for Oracle (closes #2647) [Michael Schoen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2817 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-29 18:40:49 +00:00
Jeremy Kemper
14b60fc074 Worked around that connection can't be reset if allow_concurrency is off. Closes #2648. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2816 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-29 18:17:13 +00:00
David Heinemeier Hansson
e508595cf7 Fixed SQL Server adapter so it honors options[:conditions] when applying :limits (closes #1978) [Tom Ward] Fixed SQL Server adapter to pass even more tests and do even better (closes #2634) [rtomayko@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2781 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-28 09:20:05 +00:00
David Heinemeier Hansson
bc73b838e0 Made more tests for SQLServer pass (closes #2486) [Tom Ward] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2779 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-28 07:42:16 +00:00
David Heinemeier Hansson
816f37a2ad Added migration support to SQL Server adapter (please someone do the same for Oracle and DB2) (closes #2625) [Tom Ward] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2778 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-28 07:40:28 +00:00
Jeremy Kemper
fb61912798 r3801@sedna: jeremy | 2005-10-28 00:42:28 -0700 
Use AR::Base silencing rather than AR::Base.logger silencing in fixtures to preserve Log4r compatibility.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2775 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-28 04:53:35 +00:00
Jeremy Kemper
e7cd7e9d95 r3800@sedna: jeremy | 2005-10-28 00:39:05 -0700 
Readonly constraints, association collection method_missing, dup constraint options


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2774 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-28 04:53:22 +00:00
Marcel Molina
0ba5bd583b Update documentation for observers to reflect new configuration system. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2766 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-27 16:06:04 +00:00
David Heinemeier Hansson
beff664f2a Refactor DB exceptions and deal more with DB2 (closes #2624) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2761 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-27 08:18:41 +00:00
David Heinemeier Hansson
9b2ea172d7 Add exception to example (closes #2315) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2752 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 13:29:11 +00:00
David Heinemeier Hansson
0b92d38c00 Added :offset and :limit to the kinds of options that Base.constrain can use (closes #2466) [duane.johnson@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2748 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 13:20:02 +00:00
David Heinemeier Hansson
a8eea0b04b Fix docs (closes #2491) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2744 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 13:05:48 +00:00
David Heinemeier Hansson
dd257a3ccb Fixed handling of nil number columns on Oracle and cleaned up tests for Oracle in general #2555 [schoenm@earthlink.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2741 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 12:57:11 +00:00
David Heinemeier Hansson
85a7892644 Added quoted_true and quoted_false methods to db2_adapter and cleaned up tests for DB2 (closes #2493) [maik schmidt] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2739 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 12:47:23 +00:00
David Heinemeier Hansson
c7a6b9862d Prepared for release of 0.14.2 (RC3) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2737 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-25 22:11:48 +00:00
Jamis Buck
06303ed34e Allow symbols to rename columns when using SQLite adapter. #2531 [kevin.clark@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2731 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-25 19:28:53 +00:00
Jeremy Kemper
17d3fd3165 r2736@asus: jeremy | 2005-10-24 17:08:12 -0700 
Test for eager associations with limits should not assume that records are ordered by id.
 r2737@asus:  jeremy | 2005-10-24 19:06:09 -0700
 Fail fast if invalid primary key column.
 r2746@asus:  jeremy | 2005-10-25 15:37:28 -0700
 Begin rollback of fixture delete order.  Its solves a problem for 1% of users who already have a workaround while severely slowing down the other 99%.
 r2747@asus:  jeremy | 2005-10-25 16:03:01 -0700
 Rollback the rest.
 r2748@asus:  jeremy | 2005-10-25 16:06:26 -0700
 Re-add fixtures declaration to conditions scoping test
 r2749@asus:  jeremy | 2005-10-25 16:09:03 -0700
 Re-add fixtures declaration to finder test
 r2750@asus:  jeremy | 2005-10-25 16:13:50 -0700
 Don't assume keyboards table is empty


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2730 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-25 18:14:09 +00:00
Florian Weber
49bee8826a Minor documentation fix 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2726 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-25 10:44:07 +00:00
Jeremy Kemper
f57ba4cc52 r2727@asus: jeremy | 2005-10-24 14:14:36 -0700 
Fallback to @loaded_fixtures = {}.  Use Logger#silence.  Test fixture isolation with use_instantiated_fixtures and with no fixtures declaration.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2719 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-24 16:45:33 +00:00
Jeremy Kemper
0e4c5b0288 r2726@asus: jeremy | 2005-10-24 14:11:59 -0700 
correct primary key semantics: foo.id and foo.real_pk_column should both exist and return nil if foo.new_record?


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2718 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-24 16:45:22 +00:00
David Heinemeier Hansson
8ac9638646 A little spacing goes a long way 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-24 13:33:58 +00:00
Jeremy Kemper
b57c86ae74 r3689@sedna: jeremy | 2005-10-16 10:24:36 -0700 
Ticket 2404 - delete fixtures after using them
 r3744@sedna:  jeremy | 2005-10-23 12:28:28 -0700
 track dirty and loaded fixtures more carefully
 r3745@sedna:  jeremy | 2005-10-23 12:29:39 -0700
 fix broken tests
 r3756@sedna:  jeremy | 2005-10-23 15:51:00 -0700
 Global Logger.silencer switch for Logger#silence.
 r3757@sedna:  jeremy | 2005-10-23 15:51:35 -0700
 Correct changelogs


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2715 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-23 20:00:05 +00:00
Jeremy Kemper
a2f0ae76d1 r2718@asus: jeremy | 2005-10-23 14:45:30 -0700 
Ticket 2404 - fixture delete order
 r2719@asus:  jeremy | 2005-10-23 15:01:13 -0700
 Keep closer tabs on dirty, loaded, and declared fixtures.  Closes #2404.
 r2720@asus:  jeremy | 2005-10-23 16:09:19 -0700
 ensure table names are strings.  set dirty = dirty union loaded rather than dirty = loaded.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2714 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-23 19:02:38 +00:00
Jeremy Kemper
76879f2541 Map Active Record time to SQL TIME. Closes #2576. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2713 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-23 17:22:03 +00:00
Jeremy Kemper
76487f25e7 Map AR time to PostgreSQL TIME. Closes #2575. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2712 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-23 16:54:38 +00:00
Jeremy Kemper
3ab3a70b7c Clarify semantics of ActiveRecord::Base#respond_to? Closes #2560. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2705 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-22 16:43:39 +00:00
Tobias Lütke
5f0b9369cc Fix Associations#clear for not-yet-loaded associations (Patrick Lenz) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2695 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-20 15:05:48 +00:00
Jeremy Kemper
7219e82fe6 HABTM finder sets :readonly => false. Closes #2525. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2694 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-20 14:53:04 +00:00
Marcel Molina
e440098aba Update CHANGELOG. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2692 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-19 22:56:27 +00:00