4233 Commits

Author	SHA1	Message	Date
Santiago Pastorino	ae7732f957	remove already defined method to avoid warnings	2010-08-15 08:03:26 -03:00
Santiago Pastorino	df8a941a43	Revert "connection reader is defined later" ... This reverts commit f4cce71d96.	2010-08-15 08:03:17 -03:00
Santiago Pastorino	6d68cde2c5	connection reader is defined later	2010-08-15 07:21:10 -03:00
Santiago Pastorino	0f1b9bbbf8	Makes topics.written_on null => true back again some tests rely on that	2010-08-15 07:20:58 -03:00
Santiago Pastorino	a036999ed1	Should be Boolean there	2010-08-14 19:49:33 -03:00
Santiago Pastorino	707248a629	Add missing model	2010-08-14 18:50:15 -03:00
Santiago Pastorino	ecf59b4776	Both tests are using the same model, move the model to another file and add the missing require	2010-08-14 18:50:07 -03:00
Santiago Pastorino	3270c58ebb	Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;)	2010-08-14 04:20:06 -03:00
Santiago Pastorino	ccd4364a13	Makes AR use AMo to_key implementation ... [#5249]	2010-08-13 22:28:26 -03:00
Santiago Pastorino	6373dd466f	This method is actually not used, it's implemented on the concrete adapters ... [#5331 state:committed]	2010-08-13 21:20:50 -03:00
Aaron Patterson	59e63e76c3	converting to a symbol is not necessary	2010-08-13 16:50:22 -07:00
Prem Sichanugrist	433d7a26fe	Removing most of the symbol to proc usage in Active Record ... This will hopefully make Active Record run a bit more faster.	2010-08-13 16:22:54 -07:00
Aaron Patterson	108179b068	avoid direct use of arel constants	2010-08-13 13:32:48 -07:00
Aaron Patterson	bacf78150c	removing references to arel constants	2010-08-13 12:35:58 -07:00
Aaron Patterson	e86b758592	avoiding symbol to proc again	2010-08-13 12:35:58 -07:00
Aaron Patterson	abd973689d	do not use arel constants directly	2010-08-13 12:35:58 -07:00
Aaron Patterson	fb6edb1769	symbol to proc is slow, we should avoid it	2010-08-13 12:35:58 -07:00
Xavier Noria	91ae6e9933	be more precise re :validate and :autosave	2010-08-12 19:32:26 +02:00
Neeraj Singh	9528aa9f86	Ensure we can nest include calls [#5285 state:resolved] ... Signed-off-by: José Valim <jose.valim@gmail.com>	2010-08-12 13:13:26 -03:00
Xavier Noria	4dcce5d06e	revises some autosave docs, style and content	2010-08-12 17:40:32 +02:00
Paco Guzman	ab68d4b52e	applied guidelines to "# =>"	2010-08-12 17:40:20 +02:00
Xavier Noria	1e6e868d8c	commit review: applies guidelines to "# =>"	2010-08-12 17:40:10 +02:00
Neeraj Singh	198bffe3be	updating documentation for named_scope and default_scope	2010-08-12 17:39:52 +02:00
Neeraj Singh	06af291346	adding more documentation for autosave option	2010-08-12 17:39:05 +02:00
José Valim	30ea923040	Make update_attribute behave as in Rails 2.3 and document the behavior intrinsic to its implementation.	2010-08-12 12:06:57 -03:00
Mark Turner	7325dd21b3	fixed indentation in test cases ... Signed-off-by: wycats <wycats@gmail.com>	2010-08-11 23:56:11 -07:00
Paul Hieromnimon	1c970b8394	Raising exception if fixture file can't be found	2010-08-11 15:45:29 -07:00
Aaron Patterson	c8509d5303	subtracting blank strings is slightly faster than blank?	2010-08-11 15:44:54 -07:00
Aaron Patterson	ff760dd6ce	avoid multiple hash lookups	2010-08-11 14:59:47 -07:00
Aaron Patterson	5352a89d50	dry up the hash dup and avoid sending nil values	2010-08-11 14:45:07 -07:00
Aaron Patterson	a56ee4c9a2	avoiding tap saves us time	2010-08-11 11:43:27 -07:00
Aaron Patterson	dac2b37b03	unless Array#empty? is faster than if Array#present?	2010-08-11 11:28:13 -07:00
Aaron Patterson	8464ee0650	stop using private methods	2010-08-11 11:24:59 -07:00
Brian Lopez	2d681838c0	move mysql2 adapter into core	2010-08-09 15:30:06 -07:00
Brian Lopez	b02751c961	ignore this test for mysql2	2010-08-09 15:29:59 -07:00
Brian Lopez	3ccf3504d2	skip the before_type_cast_on_datetime test entirely for mysql2	2010-08-09 15:29:53 -07:00
Brian Lopez	a263a8ffd5	update tests for mysql2 support	2010-08-09 15:29:26 -07:00
Xavier Noria	efb2bd0409	adds missing requires for Object#try	2010-08-09 15:14:00 +02:00
Aaron Patterson	91930dc30b	reduce the number of times current_connection_id is called in with_connection()	2010-08-06 16:38:53 -07:00
Aaron Patterson	001a574785	test to ensure that respond_to? delegates to arel	2010-08-06 15:23:11 -07:00
Aaron Patterson	a897a1f4a3	sorry AR, my privates are none of your business	2010-08-06 14:52:33 -07:00
Aaron Patterson	8fb0c9f509	do not rely on arel class structure	2010-08-06 11:31:32 -07:00
Aaron Patterson	0a86cb5972	fixing whitespace errors	2010-08-05 08:15:07 -07:00
Aaron Patterson	05a49c7718	avoid passing lists of lists to the group clause	2010-08-04 16:24:29 -07:00
Xavier Noria	902d732617	Merge remote branch 'docrails/master' into 3-0-stable	2010-08-05 01:15:08 +02:00
Xavier Noria	d191db76e0	standarizes the use of the article "an" for "SQL" and "SQLite"	2010-08-05 01:09:09 +02:00
Aaron Patterson	ba9602b9e7	call to_a since we are not passing anything to all()	2010-08-04 14:22:20 -07:00
Aaron Patterson	906ef233e4	fisting indentation	2010-08-04 14:11:20 -07:00
Aaron Patterson	f316a851dd	do not pass AR objects to ARel	2010-08-04 08:44:35 -07:00
wycats	2498cdaf14	I'm unsure how cloning was working in Rails 3 before	2010-08-04 04:05:28 -07:00