github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
26,867 Commits 34 Branches 105 Tags
63f7a61246aa570ed6891cdd225df8d67e4ecc13
Commit Graph

7944 Commits

Author SHA1 Message Date
Aaron Patterson
63f7a61246 When generating routes, the last defined named route wins. This is in 
contrast to route recognition where the first recognized route wins.
This behavior will not exist in Rails 4.0.

See:

  https://github.com/rails/rails/issues/4245
  https://github.com/rails/rails/issues/4164
 2012-01-03 14:00:24 -08:00
Aaron Patterson
e9122112fa Revert "Named Routes shouldn't override existing ones (currently route recognition goes with the earliest match, named routes use the latest match)" 
This reverts commit 71d769e3b5.
 2012-01-03 13:56:12 -08:00
Santiago Pastorino
8c129f18d2 Pass extensions to javascript_path and stylesheet_path helpers. Closes #3417 2012-01-03 17:51:10 -02:00
José Valim
d38dac8ea9 Override respond_to? since we are also overriding method_missing. 2012-01-03 20:27:38 +01:00
Santiago Pastorino
0d7d3a6e77 Add font_path helper method 2012-01-03 17:05:43 -02:00
Sergey Nartimov
4f440a3833 fix base64 requires 2012-01-03 01:18:34 +03:00
Sergey Nartimov
5f09414f85 deprecate ActiveSupport::Base64 
extend and define ::Base64 if needed
 2012-01-03 00:57:03 +03:00
Alejandro Andrés
8be9d92c8b Fixed documentation error in code examples from form_tag_helper.rb 2011-12-31 19:11:00 +05:30
Vijay Dev
63c6feefc9 revise some doc changes 2011-12-29 23:39:06 +05:30
Kevin Moore
2e533e3435 Documented about using :path option for resources 2011-12-29 23:39:06 +05:30
Alejandro Andrés
5f57d2ad90 Fixed formatting of code examples in form_tag_helper.rb 2011-12-29 23:39:06 +05:30
Aaron Patterson
50af25ba87 last named route wins. fixes #4164 
This differs from route recognition where first recognized route wins.
This will not be supported in Rails 4.0 so that route recognition and
generation rules are consistent.
 2011-12-28 16:33:40 -08:00
Santiago Pastorino
a0fd9fb017 Add CHANGELOG entry 2011-12-28 15:55:06 -02:00
Santiago Pastorino
2004a13130 Bump to rack 1.4.0 2011-12-28 15:53:08 -02:00
Piotr Sarnacki
d7cfb63636 Correctly display rack apps with dynamic constraints in RoutesInspector 
If you used dynamic constraint like that:

  scope :constraint => MyConstraint.new do
    mount RackApp => "/foo"
  end

routes were not displayed correctly when using `rake routes`.
This commit fixes it. If you want nice display of dynamic
constraints in `rake routes` output, please just override
to_s method in your constraint's class.
 2011-12-26 11:54:27 +01:00
José Valim
fc4299805e Update CHANGELOGs. 2011-12-24 10:52:45 +01:00
José Valim
c4ef3d34ee Remove unecessary config_accessors. 2011-12-24 10:52:45 +01:00
José Valim
ba868929d3 Provide a class optin for page_cache_compression. 2011-12-24 10:52:45 +01:00
Andrey A.I. Sitnik
754823dd66 Gzip files on page caching 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-12-24 10:52:45 +01:00
Jeremy Kemper
684448b0c6 Remove broken #compute_source_path 2011-12-23 18:00:01 -07:00
Aaron Patterson
5f2bfce9e0 adding an integration test for splat regexp substitutions. fixes #4138 2011-12-22 18:53:09 -07:00
Aaron Patterson
a32d3d0ad9 Adding an integration test. Fixes #4136 2011-12-22 18:04:59 -07:00
Aaron Patterson
2bc3f81c89 rack bodies should be a list 2011-12-22 13:09:54 -07:00
Aaron Patterson
585e291250 refactoring routing tests 2011-12-22 12:56:36 -07:00
Lucas Mazza
b5bb3f8558 raises an ArgumentError if no valid options are given to TemplateRenderer#determine_template 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-12-21 21:17:17 +01:00
Aaron Patterson
d5ccb5cf65 adding integration test for journey #7 2011-12-21 11:46:59 -07:00
Aaron Patterson
79778ffac5 caches should not be global, so no need to clear in the teardown 2011-12-21 11:46:53 -07:00
Brian Rose
a1b2dbd7d4 Check for response to #last instead of #first. 2011-12-20 13:38:16 -07:00
Brian Rose
bd89946dd3 Ensure option for select helper responds to #first before comparison. 2011-12-20 13:26:10 -07:00
José Valim
437f1e0af1 Merge pull request #4064 from nashby/date-helper-field-error-proc 
fix adding field_with_errors to date selects, closes #3487
 2011-12-20 09:43:58 -08:00
Vasiliy Ermolovich
92088131ac fix adding field_with_errors to date selects, closes #3487 2011-12-20 20:25:56 +03:00
José Valim
f29b4a02fd Add a test case for layout nil. 2011-12-20 14:56:18 +01:00
lest
e97aa2c22c remove warnings about @variable_for_layout 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-12-20 14:24:01 +01:00
José Valim
2305a98f7a Check if source is encoding aware. 2011-12-20 12:39:28 +01:00
José Valim
2e0050ce5c Do not hard code encoding to UTF8 2011-12-20 11:56:38 +01:00
Xu Pan
1897be9b50 don't encode an UTF-8 encoded template 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-12-20 11:56:33 +01:00
José Valim
5d913640bc Remove i18n dependencies from AP and AMo since they are in AS. 2011-12-20 11:56:22 +01:00
David Heinemeier Hansson
9d6e52b55e Party like its R-C-UNO! 2011-12-19 18:34:57 -06:00
Aaron Patterson
9d0789c415 adding tests for #4029 2011-12-19 13:34:54 -08:00
Vasiliy Ermolovich
024d3b9fcc add failing tests for issue #3487 2011-12-19 21:55:37 +03:00
schneems
921dcc2570 add help text to routing error 
When a newcomer hits the routing error page they
are often confused about how to trouble shoot the
next step. Adding a simple help text can gently 
remind coders where to get more help.
 2011-12-17 14:23:40 -06:00
José Valim
941213040b Merge pull request #4012 from JustinCampbell/master 
Allow symbols to be passed as extension aliases in Mime::Type.register
 2011-12-17 05:58:18 -08:00
Justin Campbell
27f3619cd5 Add test for register_alias 2011-12-17 07:52:47 -05:00
Justin Campbell
a87690b02c Add test for type aliases 2011-12-17 07:40:54 -05:00
Justin Campbell
4d5266e270 Allow symbols to be passed for extension aliases 2011-12-17 07:40:25 -05:00
Arun Agrawal
23334be5b8 warning removed "warning: instance variable @variable_for_layout not initialized" 2011-12-17 12:00:57 +05:30
Vijay Dev
5f6bcd74fd Merge pull request #3780 from marcbowes/master 
Fix favicon_link_tag help text
 2011-12-16 11:13:39 -08:00
Vijay Dev
bd84b2bb5d Merge branch 'master' of github.com:lifo/docrails 2011-12-16 23:34:00 +05:30
José Valim
6481bc5f49 Update CHANGELOGs and guides. 2011-12-16 10:45:59 +01:00
José Valim
654df86b7b Show detailed exceptions no longer returns true if the request is local in production. 2011-12-16 10:45:59 +01:00