github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-16 09:05:14 -05:00
Code Issues Packages Projects Releases Wiki Activity
1,740 Commits 34 Branches 105 Tags
67f73c99dbd655c7ef6b71a0f0721902093ce855
Commit Graph

769 Commits

Author SHA1 Message Date
Jamis Buck
50e2474433 Make assert_redirected_to properly check URL's passed as strings #1910 [Scott Barron] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1971 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-06 08:37:25 +00:00
Jamis Buck
a3469cadad Make sure :layout => false is always used when rendering inside a layout 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-05 20:51:03 +00:00
Jamis Buck
44c64a612d Use raise instead of assert_not_nil in Test::Unit::TestCase#process to ensure that the test variables (controller, request, response) have been set 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-01 21:28:17 +00:00
Jamis Buck
08ebab5d20 Make sure assigns are built for every request when testing #1866 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1961 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-31 12:16:21 +00:00
Jamis Buck
020ed6fa1f Allow remote_addr to be queried on TestRequest #1668 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-31 10:31:47 +00:00
David Heinemeier Hansson
0ea1375d75 Really fix the syntax error issue 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1952 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-28 17:41:19 +00:00
David Heinemeier Hansson
9fad3251d3 More fixes, but still broken 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1948 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 14:17:47 +00:00
David Heinemeier Hansson
c22ebd909d Fixing the fix, but not quite 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1946 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 13:55:56 +00:00
David Heinemeier Hansson
5b52b716b7 Fixing the fix, but not quite 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1945 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 13:55:39 +00:00
David Heinemeier Hansson
3d2f0001ea Fixed bug when a partial render was passing a local with the same name as the partial 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 12:24:14 +00:00
David Heinemeier Hansson
d9033bbb28 Demonstrate breakage better 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1941 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 12:06:19 +00:00
David Heinemeier Hansson
eec7cc004b Fixed dynamic scaffolding [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1940 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 11:44:18 +00:00
David Heinemeier Hansson
e95dd53a5d Added two failing tests for partials with locals from controller 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1937 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 09:11:00 +00:00
David Heinemeier Hansson
d876daf51f Fixed #1774 again 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1936 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 08:02:26 +00:00
David Heinemeier Hansson
4b8d156ca5 Removed unused statement 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-26 18:39:05 +00:00
David Heinemeier Hansson
d440cf6483 Fixed snag in status reporting 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1933 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-26 18:35:38 +00:00
David Heinemeier Hansson
65e4e5e337 Only log status if there is one different from 200 set 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1930 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-26 12:38:50 +00:00
David Heinemeier Hansson
11a51648ad Document the design of the compiled templates approach and tweak the expiration check 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1929 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-26 12:37:21 +00:00
David Heinemeier Hansson
36fee9c02e Fixed broken error handling #1827 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1920 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-25 09:39:57 +00:00
David Heinemeier Hansson
e9cfe955cc Add a catch-all eraser 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1918 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-25 08:49:19 +00:00
David Heinemeier Hansson
4f40b2d8fb Improved performance of test app req/sec with ~10% refactoring the render method #1823 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-24 16:45:39 +00:00
David Heinemeier Hansson
3ccea931fa Simplify content_for implementation 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1914 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-24 15:27:47 +00:00
David Heinemeier Hansson
1ae0a53d86 Fixed regression for content_for #1820 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-24 13:20:29 +00:00
David Heinemeier Hansson
eddd7c453b Fix that env_qs might be nil 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1907 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 09:18:16 +00:00
David Heinemeier Hansson
d554227411 Fix that env_qs might be nil 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1906 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 09:16:35 +00:00
David Heinemeier Hansson
b366dbd952 Improved performance with 5-30% through a series of Action Pack optimizations #1811 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 09:00:05 +00:00
David Heinemeier Hansson
d172592985 Added test for template to layout variable transfer 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 08:43:01 +00:00
David Heinemeier Hansson
023c4d68cc Caching template logging goes DEBUG 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1903 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 06:27:52 +00:00
David Heinemeier Hansson
7fe3fd23b3 Extended template caching to rxml and attempted to fix periodical caching issue [Stephan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1902 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 06:14:10 +00:00
David Heinemeier Hansson
98fb9e5093 Fixed call on inline with new render_template #1808 [Michael Shuerig] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1898 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 20:46:36 +00:00
David Heinemeier Hansson
0223565a4d Expiring a cache that doesnt exist is bliss not bad 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1895 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 20:08:29 +00:00
David Heinemeier Hansson
c19ca5148f Fixed changing templates in development mode [Stephan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1891 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 15:51:34 +00:00
David Heinemeier Hansson
3835f6ab25 Changed caching/expiration/hit to report using the DEBUG log level and errors to use the ERROR log level instead of both using INFO 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1889 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 11:28:58 +00:00
Jamis Buck
d76439239d Add unit test to ensure that session management options are inherited and overridable in subclasses 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 10:56:53 +00:00
Jamis Buck
06843f8794 Added support for per-action session management #1763 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1886 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 10:37:09 +00:00
David Heinemeier Hansson
06160fd3e8 Use debug to report compilation of erb templates 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1885 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 10:11:36 +00:00
David Heinemeier Hansson
95cd46c5ec Fixed compile of template fails if template name contains non-word character #1802 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1883 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 07:39:48 +00:00
David Heinemeier Hansson
ecb0e39741 Added additional documentation to FormTagHelper #1788 [jon@instance-design.co.uk] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1880 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 06:47:03 +00:00
David Heinemeier Hansson
1aab0e2c30 Doc fixes #1775, #1776 [jon@instance-design.co.uk] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1878 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 06:27:07 +00:00
David Heinemeier Hansson
bd558ef98e Improved rendering speed on complicated templates by up to 25% #1234 [Stephan Kaes]. This did necessasitate a change to the internals of ActionView#render_template that now has four parameters. Developers of custom view handlers (like Amrita) need to update for that. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1874 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-21 07:14:35 +00:00
Nicholas Seckar
2e175d35cd Fix last changeset to pass unittests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1858 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-18 03:25:53 +00:00
Nicholas Seckar
741316dc71 Fixed construction of get parameters for arrays 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1857 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-18 03:12:45 +00:00
David Heinemeier Hansson
e51221871c Fix doc typos #1734 [moriq@moriq.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1853 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-17 10:03:47 +00:00
David Heinemeier Hansson
80cfa76f7d Added options hash as third argument to FormHelper#input, so you can do input('person', 'zip', :size=>10) #1719 [jeremye@bsa.ca.gov] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1851 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-17 09:54:01 +00:00
David Heinemeier Hansson
e69924ecdc Log if filters return false and halt execution #1735 [Michael Koziarski] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1848 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-17 09:25:24 +00:00
David Heinemeier Hansson
02c1dae551 Docs for JavaScriptHelper#remote_function #1740 [jon@instance-design.co.uk] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1847 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-17 09:23:56 +00:00
David Heinemeier Hansson
d2d38f6700 Added Base#expires_in(seconds)/Base#expires_now to control HTTP content cache headers #1755 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1845 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-17 09:20:20 +00:00
David Heinemeier Hansson
4dc2dc1402 Cleaning up of javascript_helper array options, add :only to sortable_element #1761 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1843 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-17 09:15:41 +00:00
David Heinemeier Hansson
45804e2c86 More pagination speed #1334 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1839 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-15 20:27:38 +00:00
David Heinemeier Hansson
1708a863a5 Fixed line number reporting for Builder template errors #1753 [piotr] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1838 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-15 20:18:51 +00:00