github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-12 23:25:00 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,760 Commits 34 Branches 105 Tags
6b5ef885d949e624b9f8d78d8ee2cfbfbec2c962
Commit Graph

212 Commits

Author SHA1 Message Date
Rick Olson
101ebc996a Allow form_for and fields_for to work with indexed form inputs. [Jeremy Kemper, Matt Lyon] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4613 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-18 15:42:22 +00:00
Jeremy Kemper
71234daef1 r4487@asus: jeremy | 2006-04-29 12:21:39 -0700 
Check whether @flash is defined? for warnings-safety.
 r4488@asus:  jeremy | 2006-04-29 12:23:15 -0700
 Check whether @flash is defined? for warnings-safety. Obviates nil? check.
 r4489@asus:  jeremy | 2006-04-29 12:45:18 -0700
 Check whether @session is defined? for warnings-safety.
 r4490@asus:  jeremy | 2006-04-29 12:50:41 -0700
 Check whether @rendering_runtime is defined? for warnings-safety.
 r4491@asus:  jeremy | 2006-04-29 12:55:01 -0700
 Check whether @_cycles is defined? for warnings-safety.
 r4492@asus:  jeremy | 2006-04-29 12:59:19 -0700
 Check whether instance variables are defined? for warnings-safety.
 r4493@asus:  jeremy | 2006-04-29 13:14:09 -0700
 Add nil @template to PrototypeHelperTest to suppress unitialized instance variable warning.
 r4494@asus:  jeremy | 2006-04-29 13:31:34 -0700
 Check whether @auto_index defined? for warnings-safety.
 r4495@asus:  jeremy | 2006-04-29 13:32:24 -0700
 Wrap content_columns redefinitions with silence_warnings.
 r4496@asus:  jeremy | 2006-04-29 13:35:28 -0700
 Wrap more redefinitions with silence_warnings.
 r4829@asus:  jeremy | 2006-07-08 10:59:20 -0700
 abstract unit, fix warnings
 r4830@asus:  jeremy | 2006-07-08 11:06:12 -0700
 Use parens to silence warning.
 r4831@asus:  jeremy | 2006-07-08 11:06:48 -0700
 Use parens to silence warning.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4595 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-08 18:14:49 +00:00
Jeremy Kemper
f801cd7959 Pass :id => nil or :class => nil to error_messages_for to supress that html attribute. Closes #3586. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4592 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-08 05:35:08 +00:00
Jeremy Kemper
f833a78049 text_field_with_auto_complete stylesheet uses <style type="text/css"> instead of bare <style>. Closes #5610. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4558 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-05 23:24:14 +00:00
David Heinemeier Hansson
ead99f3f2e Fixed that real files and symlinks should be treated the same when compiling templates (closes #5438) [zachary@panandscan.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4546 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-05 02:17:25 +00:00
David Heinemeier Hansson
532627452d Added special case for "1 Byte" in NumberHelper#number_to_human_size (closes #5593) [murpyh@rubychan.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4537 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-05 01:04:32 +00:00
David Heinemeier Hansson
140a998de3 Added :method handling for other verbs to remote_form_tag and remote_form_for [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4374 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-28 23:39:37 +00:00
David Heinemeier Hansson
062845b4da Expanded :method option in FormHelper#form_tag to allow for verbs other than GET and POST by automatically creating a hidden form field named _method, which will simulate the other verbs over post [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4371 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-28 01:04:27 +00:00
David Heinemeier Hansson
0b1d6fd9c8 Added :method option to UrlHelper#link_to, which allows for using other verbs than GET for the link. This replaces the :post option, which is now deprecated. Example: link_to "Destroy", person_url(:id => person), :method => :delete [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4370 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-28 00:33:53 +00:00
Jeremy Kemper
c069f361f0 form.text_area handles the :size option just like the original text_area (:size => '60x10' becomes cols="60" rows="10") 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4334 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-11 16:36:59 +00:00
Jeremy Kemper
5a960d2568 Excise ingrown code from FormOptionsHelper#options_for_select. Closes #5008. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4331 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-05-09 05:19:32 +00:00
Marcel Molina
43ee8ab6e2 Allow error_messages_for to report errors for multiple objects, as well as support for customizing the name of the object in the error summary header. Closes #4186. [andrew@redlinesoftware.com, Marcel Molina Jr.] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4287 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-26 23:09:08 +00:00
Sam Stephenson
9d8e34808f Change link_to_function and button_to_function to (optionally) take an update_page block instead of a JavaScript string. Closes #4804. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4235 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-19 18:08:15 +00:00
Thomas Fuchs
1fcc60895b Add additional autocompleter options [aballai, Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4131 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-02 14:04:03 +00:00
David Heinemeier Hansson
2cc9b21c07 Skip complete URLs 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4099 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-29 21:11:44 +00:00
David Heinemeier Hansson
91383e0426 Added automated timestamping to AssetTagHelper methods for stylesheets, javascripts, and images when Action Controller is run under Rails [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4098 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-29 20:57:53 +00:00
David Heinemeier Hansson
31199a9e4a Update description 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4074 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-28 01:11:09 +00:00
Rick Olson
666537572d finish form_for change, allow hash as the second param: form_for :post, :url => { }. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4051 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-26 20:21:27 +00:00
Rick Olson
4238666627 Change #form_for and #fields_for so that the second argument is not required [Dave Thomas] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4047 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-26 19:45:56 +00:00
Nicholas Seckar
c05c22a45f Fix double url escaping of remote_function. Add :escape => false option to ActionView's url_for. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4014 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-22 19:41:39 +00:00
David Heinemeier Hansson
f46eb2ab64 Fix test 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4012 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-22 19:28:46 +00:00
Rick Olson
f49ba114db Add :script option to in_place_editor to support evalScripts (closes #4194) [codyfauser@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3985 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-19 19:40:11 +00:00
Rick Olson
a6cfb4e0e4 Fix mixed case enumerable methods in the JavaScript Collection Proxy (closes #4314) [codyfauser@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3984 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-19 19:38:38 +00:00
Nicholas Seckar
ab9f324423 Undo accidental escaping for mail_to; add regression test. Fix incorrect credit in changelog. Closes #4202. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-19 17:03:02 +00:00
Nicholas Seckar
1e7ce13b37 Change url_for to escape the resulting URLs when called from a view. Closes #4202 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3953 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-18 22:36:52 +00:00
David Heinemeier Hansson
129a159d12 Fixed link_to "somewhere", :post => true to produce valid XHTML by using the parentnode instead of document.body for the instant form (closes #3007) [Bob Silva] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3928 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-18 16:25:11 +00:00
David Heinemeier Hansson
7bfca7e717 Added :function option to PrototypeHelper#observe_field/observe_form that allows you to call a function instead of submitting an ajax call as the trigger (closes #4268) [jonathan@daikini.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3926 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-18 16:08:09 +00:00
Sam Stephenson
3589871de8 Added simple alert() notifications for RJS exceptions when config.action_view.debug_rjs = true. Set debug_rjs = true for the default development environment. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3856 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-13 02:11:59 +00:00
David Heinemeier Hansson
06c2b43f36 Rendering xml shouldnt happen inside any layout. Added class proxying to RJS, so you can call page.field.clear("my_field") to generate Field.clear("my_field");. Added :content_type option to render, so you can change the content type on the fly. Do type/subtype reordering of Accept header preferences for xml types (aka make Firefox work with respond_to). CHANGED DEFAULT: The default content type for .rxml is now application/xml instead of type/xml, see http://www.xml.com/pub/a/2004/07/21/dive.html for reason 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3852 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-13 01:33:57 +00:00
Rick Olson
043bee3338 Re-added mixed-in helper methods for the JavascriptGenerator. Moved JavascriptGenerators methods to a module that is mixed in after the helpers are added. Also fixed that variables set in the enumeration methods like #collect are set correctly. Documentation added for the enumeration methods [Rick Olson]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3814 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-08 05:21:27 +00:00
David Heinemeier Hansson
5f724b516c Fixed tests (closes #4087) [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-05 16:35:27 +00:00
David Heinemeier Hansson
16b9409a9c allow RJS enum values to be passed to visual_effect() and other scriptaculous helpers #4080 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3772 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-05 06:42:58 +00:00
David Heinemeier Hansson
2e67f1adc8 RJS now does enumerations, baby! (closes #3876) [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3754 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-03 19:34:23 +00:00
David Heinemeier Hansson
3fb29b172f Fixed that default image extension was not appended when using a full URL with AssetTagHelper#image_tag (closes #4032, #3728) [rubyonrails@beautifulpixel.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3740 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-02 01:54:53 +00:00
David Heinemeier Hansson
fed41fbe8b Added support to AssetTagHelper#javascript_include_tag for having :defaults appear anywhere in the list, so you can now make one call ala javascript_include_tag(:defaults, "my_scripts") or javascript_include_tag("my_scripts", :defaults) depending on how you want the load order (closes #3506) [Bob Silva] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3696 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-28 05:16:34 +00:00
Thomas Fuchs
d0bd952aff Added support for visual effects scoped queues to the visual_effect helper #3530 [Abdur-Rahman Advany] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3687 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-27 10:37:59 +00:00
Thomas Fuchs
d11f8d5516 Added script.aculo.us drag and drop helpers to RJS [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3667 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-26 14:20:21 +00:00
David Heinemeier Hansson
6a83ebfe70 Fixed form_for regression (closes #3962) [t.lucas@toolmantim.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3666 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-26 07:23:42 +00:00
David Heinemeier Hansson
841d596c24 Fixed tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3665 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-26 04:25:17 +00:00
David Heinemeier Hansson
231a464d4e Fixed that form elements would strip the trailing [] from the first parameter (closes #3545) [ruby@bobsilva.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3661 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-26 01:07:05 +00:00
David Heinemeier Hansson
06dd7b8efa The image_tag helper is not converting the options hash to symbols (closes #3615) [agkr@pobox.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3660 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-26 00:55:22 +00:00
Thomas Fuchs
523d54b56d Added various InPlaceEditor options, #3746, #3891, #3896, #3906 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3626 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-21 10:52:35 +00:00
David Heinemeier Hansson
35b74de770 Use real assigns instead of a method call [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3591 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 21:31:28 +00:00
David Heinemeier Hansson
5f2292ce39 replace_element was renamed replace [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3590 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 21:19:49 +00:00
David Heinemeier Hansson
8dc4f46233 Also support replace and replace_html and some refactoring in JavaScriptElementProxy [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3588 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 20:10:59 +00:00
David Heinemeier Hansson
ebdb766e79 Added element and collection proxies to RJS [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3587 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 18:48:08 +00:00
Sam Stephenson
838ec413eb Add JavaScriptGenerator#replace_element for replacing an element's "outer HTML". Closes #3246. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3579 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 01:30:13 +00:00
Nicholas Seckar
344ae8326a Remove over-engineered form_for code for a leaner implementation. 
Document form_for's :html option.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3572 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-11 23:29:53 +00:00
Sam Stephenson
803b9a41af Add :html option for specifying form tag options in form_for 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3552 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-08 20:46:15 +00:00
Marcel Molina
ba2619f539 Don't interpret the :value option on text_area as an html attribute. Set the text_area's value. Closes #3752. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3550 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-08 05:13:21 +00:00