Commit Graph

2286 Commits

Author SHA1 Message Date
David Heinemeier Hansson
713ca5196d Docfix (closes #10155)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8165 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-18 21:51:09 +00:00
Michael Koziarski
6d0e5eaf06 memoize host with port and refactor the tests which depend on it changing
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8164 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-17 05:41:47 +00:00
Michael Koziarski
c07eae4d40 Remove unneeded code to disable optimisations. the defined?(request) stuff takes care of this now.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8163 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-17 03:57:42 +00:00
Michael Koziarski
696d140b6c Only Benchmark and log if we're going to output the information.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8136 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-14 09:39:27 +00:00
Michael Koziarski
5ce6d74531 Fix Tests broken in [8134]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8135 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-14 09:36:35 +00:00
Michael Koziarski
7106dca977 Actually cache the template names.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8134 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-14 09:30:25 +00:00
David Heinemeier Hansson
55b6697493 Fixed that has_many :through associations should render as collections too (closes #9051) [mathie/danger]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8130 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-12 15:02:12 +00:00
David Heinemeier Hansson
5c8beba9dc Prepare versions for RC1
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8121 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-09 20:02:29 +00:00
David Heinemeier Hansson
6b018e3d08 Added :mouseover short-cut to AssetTagHelper#image_tag for doing easy image swaps (closes #6893) [joost]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8110 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-07 15:37:06 +00:00
David Heinemeier Hansson
31e2a2d9bb Fixed handling of non-domain hosts (closes #9479) [purp]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8108 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-07 14:57:51 +00:00
Marcel Molina
94502623fb Standardize on using hyphens rather than colons to separate option names from their explanation in documentation. Replace + with tt tags. Closes #8732. [ryanb]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8106 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 23:33:40 +00:00
Marcel Molina
458ef3b552 Fix syntax error in documentation example for cycle method. Closes #8735 [foca]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8104 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 23:25:02 +00:00
Marcel Molina
c5588437d3 Document :with option for link_to_remote. Closes #8765 [ryanb]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 23:23:37 +00:00
Marcel Molina
4e7d332baf Document :minute_step option for time_select. Closes #8814 [brupm]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8101 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 23:00:15 +00:00
Marcel Molina
563d9efdf3 Explain how to use the :href option for link_to_remote to degrade gracefully in the absence of JavaScript. Closes #8911 [vlad]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8100 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 19:34:21 +00:00
Marcel Molina
0230fc96ec Disambiguate :size option for text area tag. Closes #8955 [redbeard]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8099 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 19:26:36 +00:00
Marcel Molina
341afb6a81 Fix broken tag in assert_tag documentation. Closes #9037 [mfazekas]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8095 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 18:57:33 +00:00
Marcel Molina
af005df811 Add documentation for route conditions. Closes #9041 [innu, manfred]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 18:54:33 +00:00
Marcel Molina
87037afc33 Fix typo left over from previous typo fix in url helper. Closes #9414 [Henrik N]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8091 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 18:44:06 +00:00
David Heinemeier Hansson
9a8d583a91 Fixed that ActionController::CgiRequest#host_with_port() should handle standard port (closes #10082) [moro]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8088 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 16:36:10 +00:00
Sam Stephenson
fdc767d447 Update Prototype to 1.6.0 and script.aculo.us to 1.8.0.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8087 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 15:17:10 +00:00
Michael Koziarski
7464a398e1 Minor documentation enhancements and white-space fixes. Closes #9819 [chuyeow]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8082 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 08:09:39 +00:00
Michael Koziarski
788ece4799 Make rescue_from behave like rescue when dealing with subclasses. Closes #10079 [fxn]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8081 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 06:02:24 +00:00
Michael Koziarski
aa1313dd3b Grammatical and whitespace fixes for form helper docs. Closes #10062 [chuyeow]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8080 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 05:56:02 +00:00
Michael Koziarski
800b69b6ad Add missing quote to send_file documentation. [developingchris] Closes #10078
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8075 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-05 22:08:44 +00:00
Jeremy Kemper
3953839e99 Update profiler changelog for integration session script usage
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8066 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-01 08:16:01 +00:00
Jeremy Kemper
dbcf59d47d Profile an integration session instead of a single request
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8065 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-01 08:01:42 +00:00
Jeremy Kemper
82314608b5 Factor Integration::Runner behavior out of IntegrationTest. Introduce Session#request_count which counts processed requests.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8064 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-01 07:59:24 +00:00
David Heinemeier Hansson
da532b92fd Expose the cookie jar as a helper method (before the view would just get the raw cookie hash) [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8062 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-31 16:46:56 +00:00
Jeremy Kemper
c240f2d48a compute_public_path behaves well with mailers also. Closes #10014.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8052 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-29 04:01:58 +00:00
Rick Olson
c708346688 Change JSON to encode %w(< > &) as 4 digit hex codes to be in compliance with the JSON spec. Closes #9975 [josh, chuyeow, tpope]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8050 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-29 00:18:43 +00:00
Jeremy Kemper
d44ce1cb73 Integration tests: get_ and post_via_redirect take a headers hash. Closes #9130.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8047 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-27 20:38:08 +00:00
Jeremy Kemper
a55caf666c Tested FormHelper#label. Closes #9850 [jarkko]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8045 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-27 20:30:05 +00:00
Rick Olson
742694e0eb Simplfy #view_paths implementation. ActionView templates get the exact object, not a dup. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8035 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-26 05:45:41 +00:00
Rick Olson
d7aa32d5d0 Update tests for ActiveSupport's JSON escaping change. [rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8034 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-26 05:32:30 +00:00
Rick Olson
d5a93b6241 FormHelper's auto_index should use #to_param instead of #id_before_type_cast. Closes #9994 [mattly]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8033 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-26 04:48:19 +00:00
Marcel Molina
7f8183e3c4 Doc typo fixes for ActiveRecordHelper. Closes #9973 [mikong]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8029 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-26 03:34:48 +00:00
Marcel Molina
27ac7ad7e5 Make example parameters in restful routing docs idiomatic. Closes #9993 [danger]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8028 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-26 03:32:20 +00:00
Marcel Molina
2f254137e2 Make documentation comment for mime responders match documentation example. Closes #9357 [yon]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8027 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-26 03:25:40 +00:00
Michael Koziarski
2cc0cac3ef Introduce TestCase subclasses for testing rails applications allowing tests to be DRY'd up a bit and to provide a path toward tidying up our monkeypatching of test/unit.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8022 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-26 02:21:21 +00:00
Marcel Molina
65e18af03a Fix incorrect path in helper rdoc. Closes #9926 [viktor tron]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8019 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-26 01:04:40 +00:00
Jeremy Kemper
4d2ae8a699 Partials also set 'object' to the default partial variable. Closes #8823.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8018 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-25 21:32:01 +00:00
Jeremy Kemper
cb1aab0552 / default uri, -b shortcut
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8017 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-25 20:46:50 +00:00
Jeremy Kemper
d69be7df6d Request profiler
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8016 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-25 20:33:28 +00:00
Michael Koziarski
12d8d48b71 Refactor the default rendering out to a method called default_render to provide a hook for plugin authors. Closes #9953 [cjheath]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8011 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-25 06:38:01 +00:00
Jeremy Kemper
4c2920e89c Remove unnecessary returns from builtin filters since render/return is now sufficient. Closes #9952 [Josh Peek]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8009 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-24 04:47:40 +00:00
Jeremy Kemper
8091ed5420 Disabled checkboxes don't submit a form value. Closes #9301.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8007 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-23 19:25:28 +00:00
Marcel Molina
6f559f871e Added tests for options to ActiveRecordHelper#form. Closes #7213 [richcollins, mikong, mislav]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8005 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-23 17:57:47 +00:00
Jeremy Kemper
562b398fd7 Some mime type refactoring. Closes #9957 [Josh Peek]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8001 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-23 06:33:28 +00:00
Jeremy Kemper
6a35ed16c2 Remove duplicate rjs layout check. Closes #9956 [Josh Peek]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7999 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-23 05:54:19 +00:00