David Heinemeier Hansson
713ca5196d
Docfix ( closes #10155 )
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8165 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-18 21:51:09 +00:00
Michael Koziarski
6d0e5eaf06
memoize host with port and refactor the tests which depend on it changing
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8164 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-17 05:41:47 +00:00
Michael Koziarski
c07eae4d40
Remove unneeded code to disable optimisations. the defined?(request) stuff takes care of this now.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8163 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-17 03:57:42 +00:00
David Heinemeier Hansson
31e2a2d9bb
Fixed handling of non-domain hosts ( closes #9479 ) [purp]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8108 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-07 14:57:51 +00:00
Marcel Molina
94502623fb
Standardize on using hyphens rather than colons to separate option names from their explanation in documentation. Replace + with tt tags. Closes #8732 . [ryanb]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8106 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 23:33:40 +00:00
Marcel Molina
341afb6a81
Fix broken tag in assert_tag documentation. Closes #9037 [mfazekas]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8095 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 18:57:33 +00:00
Marcel Molina
af005df811
Add documentation for route conditions. Closes #9041 [innu, manfred]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 18:54:33 +00:00
David Heinemeier Hansson
9a8d583a91
Fixed that ActionController::CgiRequest#host_with_port() should handle standard port ( closes #10082 ) [moro]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8088 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 16:36:10 +00:00
Michael Koziarski
7464a398e1
Minor documentation enhancements and white-space fixes. Closes #9819 [chuyeow]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8082 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 08:09:39 +00:00
Michael Koziarski
788ece4799
Make rescue_from behave like rescue when dealing with subclasses. Closes #10079 [fxn]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8081 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-06 06:02:24 +00:00
Michael Koziarski
800b69b6ad
Add missing quote to send_file documentation. [developingchris] Closes #10078
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8075 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-05 22:08:44 +00:00
Jeremy Kemper
dbcf59d47d
Profile an integration session instead of a single request
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8065 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-01 08:01:42 +00:00
Jeremy Kemper
82314608b5
Factor Integration::Runner behavior out of IntegrationTest. Introduce Session#request_count which counts processed requests.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8064 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-11-01 07:59:24 +00:00
David Heinemeier Hansson
da532b92fd
Expose the cookie jar as a helper method (before the view would just get the raw cookie hash) [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8062 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-31 16:46:56 +00:00
Jeremy Kemper
d44ce1cb73
Integration tests: get_ and post_via_redirect take a headers hash. Closes #9130 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8047 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-27 20:38:08 +00:00
Rick Olson
742694e0eb
Simplfy #view_paths implementation. ActionView templates get the exact object, not a dup. [Rick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8035 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-26 05:45:41 +00:00
Rick Olson
d7aa32d5d0
Update tests for ActiveSupport's JSON escaping change. [rick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8034 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-26 05:32:30 +00:00
Marcel Molina
27ac7ad7e5
Make example parameters in restful routing docs idiomatic. Closes #9993 [danger]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8028 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-26 03:32:20 +00:00
Marcel Molina
2f254137e2
Make documentation comment for mime responders match documentation example. Closes #9357 [yon]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8027 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-26 03:25:40 +00:00
Michael Koziarski
2cc0cac3ef
Introduce TestCase subclasses for testing rails applications allowing tests to be DRY'd up a bit and to provide a path toward tidying up our monkeypatching of test/unit.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8022 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-26 02:21:21 +00:00
Marcel Molina
65e18af03a
Fix incorrect path in helper rdoc. Closes #9926 [viktor tron]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8019 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-26 01:04:40 +00:00
Jeremy Kemper
cb1aab0552
/ default uri, -b shortcut
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8017 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-25 20:46:50 +00:00
Jeremy Kemper
d69be7df6d
Request profiler
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8016 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-25 20:33:28 +00:00
Michael Koziarski
12d8d48b71
Refactor the default rendering out to a method called default_render to provide a hook for plugin authors. Closes #9953 [cjheath]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8011 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-25 06:38:01 +00:00
Jeremy Kemper
4c2920e89c
Remove unnecessary returns from builtin filters since render/return is now sufficient. Closes #9952 [Josh Peek]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8009 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-24 04:47:40 +00:00
Jeremy Kemper
562b398fd7
Some mime type refactoring. Closes #9957 [Josh Peek]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8001 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-23 06:33:28 +00:00
Jeremy Kemper
6a35ed16c2
Remove duplicate rjs layout check. Closes #9956 [Josh Peek]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7999 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-23 05:54:19 +00:00
Jeremy Kemper
79670fb975
request.parameters doesn't overwrite request.request_parameters. Closes #9949 [nullstyle]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7992 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-22 21:10:56 +00:00
David Heinemeier Hansson
f777ff72f9
Changed before_filter halting to happen automatically on render or redirect but no longer on simply returning false [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7984 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-21 18:58:17 +00:00
Rick Olson
c9fecf20ff
Ensure that cookies handle array values correctly. Closes #9937 [queso]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7978 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-20 17:30:01 +00:00
Jeremy Kemper
a9f790a748
Use SecureRandom to generate unique ids, if available.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7966 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-18 18:25:31 +00:00
Jeremy Kemper
011a209174
caches_page uses a single after_filter instead of one per action. Closes #9891 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7949 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-16 22:24:55 +00:00
Michael Koziarski
534600eb7c
More Performant Cookie Regexp for Integration tests. [Ola Bini]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7946 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-16 20:19:27 +00:00
Jeremy Kemper
a2172e75f5
Dispatcher: fix that to_prepare should only run once in production. Closes #9889 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-16 16:36:52 +00:00
Jeremy Kemper
5cb6a9aabd
Improve the error message for assert_redirected_to. Closes #7337 [mikong, sandofsky]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-16 05:07:23 +00:00
Michael Koziarski
fe234a1538
Fix Json related documentation for render and the AR serializer. Closes #9814 . Closes #9833 . [chuyeow]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-15 07:04:10 +00:00
Jeremy Kemper
d0df7f2b12
Memcached sessions: add session data on initialization; don't silently discard exceptions; add unit tests. Closes #9823 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7885 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-14 20:46:06 +00:00
Michael Koziarski
52235a70db
Missed post_via_redirect. References #6834
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7851 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-13 03:34:24 +00:00
Michael Koziarski
569c7d5488
Define get_via_redirect as well. Closes #6834 [colthorp]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7850 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-13 03:32:20 +00:00
Michael Koziarski
bd03bf9f5e
Make sure that custom inflections are picked up by map.resources by triggering a routing reload when new inflections are defined. Closes #9815 [mislav, kampers]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7849 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-13 03:28:35 +00:00
Jeremy Kemper
4db4661a67
rescue_from accepts :with => lambda { |exception| ... } or a normal block. Closes #9827 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7822 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-10 02:34:42 +00:00
Michael Koziarski
4aabe46341
Add :status to redirect_to allowing users to choose their own response code without manually setting headers. Closes #8297 [codahale, chasgrundy]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7820 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-09 23:07:36 +00:00
Jeremy Kemper
d9f3c435f9
Fix url_for, redirect_to, etc. with :controller => :symbol instead of 'string'. Closes #8562 , #9525 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7776 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-07 19:12:02 +00:00
Jeremy Kemper
52ca5dad1e
Use StringIO and Tempfile subclasses instead of defining singleton methods on each multipart field.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7759 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-06 11:40:13 +00:00
Jeremy Kemper
3405fb3dea
Rewind stdin if possible after multipart parsing.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7758 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-06 09:39:31 +00:00
Jeremy Kemper
551f6e9bee
Don't generate strings to log unless they'll actually get logged.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-06 09:28:50 +00:00
Jeremy Kemper
12d740dd57
Move #query_string to AbstractRequest
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7727 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-03 16:39:18 +00:00
Rick Olson
3dc62ab8f9
rescue LoadError if memcache isn't available while loading the MemCache fragment store
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7726 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-03 16:15:42 +00:00
Rick Olson
408f496402
Use #require_library_or_gem to load the memcache library for the MemCache session and fragment cache stores. Closes #8662 . [Rick]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7725 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-03 14:52:56 +00:00
Rick Olson
904df818d6
Move ActionController::Routing.optimise_named_routes to ActionController::Base.optimise_named_routes. Now you can set it in the config.
...
ActionController::Routing::DynamicSegment#interpolation_chunk should call #to_s on all values before calling URI.escape. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7724 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-10-03 05:47:41 +00:00