Jeremy Kemper
|
473202df83
|
attr_readonly behaves well with optimistic locking. Closes #10188.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-11-16 20:31:24 +00:00 |
|
Jeremy Kemper
|
990a3f3a83
|
Use rexml for some tests rather than string include? checks to account for unordered attributes. Closes #10164 [Catfish]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-11-14 18:59:05 +00:00 |
|
Jeremy Kemper
|
ea256eaa7f
|
Base#to_xml supports the nil="true" attribute like Hash#to_xml. Closes #8268.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8138 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-11-14 10:33:25 +00:00 |
|
Rick Olson
|
3104291322
|
Fix HasManyThrough Association so it uses :conditions on the HasMany Association. Closes #9729 [danger]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8128 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-11-11 01:03:43 +00:00 |
|
Michael Koziarski
|
79823e0b2f
|
Ensure that column names are quoted. Closes #10134 [wesley.moxam]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-11-10 21:33:13 +00:00 |
|
David Heinemeier Hansson
|
b318134c99
|
Kill the whiny_protected_attributes setting and kill the exception raised. Instead, just log the mass-assignment misalignment as a debug warning (closes #9966)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8120 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-11-09 19:57:24 +00:00 |
|
David Heinemeier Hansson
|
37adea6ff1
|
Address shortcomings of changeset [8054] [protocool]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8109 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-11-07 15:07:39 +00:00 |
|
Michael Koziarski
|
8f74527282
|
Escape table names during calculation queries. [wesley.moxam, Koz] Closes #4593
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8061 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-31 05:58:09 +00:00 |
|
Michael Koziarski
|
3c9cd19786
|
Make fixtures work with the new test subclasses. [tarmo, Koz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8060 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-31 05:43:52 +00:00 |
|
Jeremy Kemper
|
bef071dd0b
|
Introduce finder :joins with associations. Same :include syntax but with inner rather than outer joins. Closes #10012.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-29 21:39:52 +00:00 |
|
Rick Olson
|
c708346688
|
Change JSON to encode %w(< > &) as 4 digit hex codes to be in compliance with the JSON spec. Closes #9975 [josh, chuyeow, tpope]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8050 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-29 00:18:43 +00:00 |
|
Michael Koziarski
|
df0765d8dc
|
Make sure that << works on has_many associations on unsaved records. Closes #9989 [hasmanyjosh]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8049 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-28 03:39:18 +00:00 |
|
Jeremy Kemper
|
88f951a519
|
Allow association redefinition in subclasses. Closes #9346.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8046 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-27 20:31:09 +00:00 |
|
Jeremy Kemper
|
4b639904d7
|
Fix has_many :through delete with custom foreign keys. Closes #6466.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8043 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-27 18:51:32 +00:00 |
|
Jeremy Kemper
|
49eafd8c36
|
Foxy fixtures. Adapter#disable_referential_integrity. Closes #9981.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8036 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-26 05:56:46 +00:00 |
|
Marcel Molina
|
bf658a906b
|
Allow find on a has_many association defined with :finder_sql to accept id arguments as strings like regular find does. Closes #9916 [krishna]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8030 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-26 03:42:28 +00:00 |
|
Michael Koziarski
|
2d208eb3a0
|
Make sure that the Schema Dumper supports non-standard primary keys with MySQL. Closes #9971 [RubyRedRick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8012 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-25 06:42:05 +00:00 |
|
Marcel Molina
|
c8b6b4821f
|
Limited eager loading no longer ignores scoped :order. Closes #9561 [danger, josh]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8006 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-23 18:34:01 +00:00 |
|
Jeremy Kemper
|
7b42a1d0ac
|
Assigning an instance of a foreign class to a composed_of aggregate calls an optional conversion block. Refactor and simplify composed_of implementation. Closes #6322.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8003 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-23 17:39:35 +00:00 |
|
Jeremy Kemper
|
c220e558be
|
Assigning nil to a composed_of aggregate also sets its immediate value to nil. Closes #9843.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8002 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-23 17:29:42 +00:00 |
|
Jeremy Kemper
|
28729a4829
|
validates_uniqueness_of behaves well with abstract superclasses. References #3833, closes #9886.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8000 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-23 06:18:42 +00:00 |
|
Jeremy Kemper
|
902533e6f0
|
Reinstate test_change_column_nullability for all adapters. Closes #9945 [lawrence]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7996 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-22 23:52:04 +00:00 |
|
Jeremy Kemper
|
e829e12e16
|
test_select_rows shouldn't depend on implicit result ordering. Closes #9898 [lawrence]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7995 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-22 23:50:12 +00:00 |
|
Rick Olson
|
7042163d76
|
Ensure that mysql quotes table names with database names correctly. Closes #9911 [crayz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7980 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-20 21:17:31 +00:00 |
|
Michael Koziarski
|
17ac677a2d
|
typo in test name
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-19 02:51:44 +00:00 |
|
Michael Koziarski
|
3facc8578b
|
Few more tests for Sexy Migrations
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7975 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-19 02:25:23 +00:00 |
|
Michael Koziarski
|
6ddde027c4
|
Add t.belongs_to and t.references to sexy migrations [arthurgeek]
Test harness for Sexy Migrations. [Koz]
Closes #9775
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7973 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-19 02:09:06 +00:00 |
|
Michael Koziarski
|
210f7e29e2
|
Move all Schema creation into schema.rb for Mysql. Closes #9899 [mikong, lawrence]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7972 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-19 01:52:50 +00:00 |
|
Jeremy Kemper
|
2fac5d1a8b
|
SQL Server: test for affected row count. References #9558 [lawrence, ryepup]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7968 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-18 23:47:59 +00:00 |
|
Michael Koziarski
|
2833706699
|
Read in binary mode to make sure windows support keeps working. [lawrence] Closes #9912
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7959 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-17 22:50:34 +00:00 |
|
Michael Koziarski
|
8ed1e885b7
|
Use a smaller binary fixture so we don't overflow column size limitations in some commercial / legacy databases. Closes #7987 [roderickvd, lawrence]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7958 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-17 21:35:46 +00:00 |
|
Jeremy Kemper
|
f575757ca4
|
Qualified column names work in hash conditions, like :conditions => { 'comments.created_at' => ... }. Closes #9733.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7943 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-16 08:08:08 +00:00 |
|
Jeremy Kemper
|
cfbd790ad3
|
Fix regression where the association would not construct new finder SQL on save causing bogus queries for "WHERE owner_id = NULL" even after owner was saved. Closes #8713.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-16 07:24:23 +00:00 |
|
Jeremy Kemper
|
a72c1ec43e
|
Refactor association create and build so before & after callbacks behave consistently. Closes #8854.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7935 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-16 05:07:58 +00:00 |
|
Jeremy Kemper
|
9b6207c3d0
|
Quote table names. Defaults to column quoting. Closes #4593.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7932 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-16 05:06:33 +00:00 |
|
Jeremy Kemper
|
197c888576
|
Moving SQL Server tests to the extracted adapter. References #9884.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7930 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-16 05:05:22 +00:00 |
|
Jeremy Kemper
|
671228942d
|
Alias association #build to #new so it behaves predictably. Closes #8787.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7913 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-15 08:09:04 +00:00 |
|
Jeremy Kemper
|
660a696a3f
|
Test that change_column quotes column names. Closes #9537 [lawrence]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7909 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-15 07:33:53 +00:00 |
|
Jeremy Kemper
|
e81f1acc33
|
Uncomment test for join model method_missing. Closes #8707 [Giles Bowkett, Josh Peek]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7897 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-15 04:14:10 +00:00 |
|
Jeremy Kemper
|
619f2897f5
|
Update test/all.sh
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7896 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-15 03:46:15 +00:00 |
|
Jeremy Kemper
|
6cc7095320
|
Update IGNORED_SQL for SQL Server. Closes #9638 [lawrence]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7895 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-15 03:32:00 +00:00 |
|
Rick Olson
|
f56dd107cd
|
Observers can observe model names as symbols properly now. Closes #9869 [queso]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7872 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-14 05:20:24 +00:00 |
|
Tobias Lütke
|
0ad5365bf4
|
find_and_(initialize|create)_by methods can now properly initialize protected attributes
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-10 19:11:50 +00:00 |
|
Michael Koziarski
|
1c881ca5bf
|
Ensure that 'autosaving' works when associations aren't loaded [Bryan Helmkamp] References #8713
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7824 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-10 06:45:13 +00:00 |
|
Michael Koziarski
|
3122d321fd
|
Make sure AR::Base#clone handles attr changes made in after_initialize hooks. Closes #7191 [weyus]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7802 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-08 06:21:38 +00:00 |
|
Jeremy Kemper
|
4eaa8ba5be
|
PostgreSQL: support multiline default values. Closes #7533.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7801 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-08 06:17:53 +00:00 |
|
Jeremy Kemper
|
85c86f0999
|
MySQL: fix change_column on not-null columns that don't accept dfeault values of ''. Closes #6663.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7790 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-08 03:28:28 +00:00 |
|
Jeremy Kemper
|
210ecaecc3
|
validates_uniqueness_of behaves well with single-table inheritance. Closes #3833.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7787 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-08 01:44:55 +00:00 |
|
Jeremy Kemper
|
84a14f2620
|
Raise ProtectedAttributeAssignmentError in development and test environments when mass-assigning to an attr_protected attribute. Closes #9699.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7777 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-07 19:43:19 +00:00 |
|
Michael Koziarski
|
cd64471bdb
|
Fix calling .clear on a has_many :dependent=>:delete_all association. [tarmo] Closes #6904
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7767 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
|
2007-10-07 05:05:12 +00:00 |
|