github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
25,882 Commits 34 Branches 105 Tags
71e84a3b514b6a2630dfd7f658f4e7597424d6e3
Commit Graph

1352 Commits

Author SHA1 Message Date
Jon Leighton
7776055e2d Revert "Skip test_default_external_works on the CI for Ruby 1.9.3." 
This reverts commit 10773f94ea.
 2011-11-06 10:39:59 +00:00
Jon Leighton
10773f94ea Skip test_default_external_works on the CI for Ruby 1.9.3. 
This test is affected by a bug in Ruby 1.9.3p0 and trunk:
http://redmine.ruby-lang.org/issues/5564

Given we cannot fix it for ourselves, it is better to skip for now so
that we will easily see if further failures are introduced.

Jon Leighton is monitoring the bug report and will revert this when a
suitable solution is found (either a new Ruby release or a generic
workaround).

If you are using 1.9.3 in your app and have templates that are not in
UTF-8, you should add a workaround early on in the boot process. For
example, if your templates are Shift_JIS encoded, then add the
following in an initializer:

Encoding::Converter.new('Shift_JIS', 'UTF-8')
 2011-11-05 16:42:53 +00:00
Vijay Dev
cb06727b6c add tests for the case where size is explicitly passed to number_field helper 2011-11-04 22:32:40 +05:30
Waseem Ahmad
56207a3f01 Remove 'size' attribute from number_field form helper fixes #3454 
f.number_field generates <input type="number", size="30"../> which is
invalid HTML5. See: http://dev.w3.org/html5/spec/Overview.html#number-state
 2011-11-04 15:03:02 +05:30
Jon Leighton
b5f908a7ad Stub find_template so that when handle_render_error is called in ActionView::Template, we get to see the actual underlying error rather than a NoMethodError. 
This shows an encoding bug on Ruby 1.9.3.
 2011-11-03 19:08:09 +00:00
Santiago Pastorino
408bbfe6bd Merge pull request #3435 from MDaubs/action_pack_deprecations 
Fix deprecation warnings in action pack render tests
 2011-10-26 00:36:36 -07:00
Aaron Patterson
450257c95b properly handle lists of lists. Thanks @adrianpike for reporting! 2011-10-25 17:44:17 -07:00
Matthew Daubert
f7e56a3ab6 Fix deprecation warnings in action pack test suite due to passing template formats in the template name. 2011-10-25 15:11:45 -04:00
Arun Agrawal
244dcfea47 ActionPack test fix for RBX 2011-10-24 14:11:20 +05:30
Mac Martine
20728f551c remove user-specified delimiter from start when no area code is present (in number_to_phone) 2011-10-12 17:06:44 -07:00
José Valim
501e5b0d7f Merge pull request #3196 from avakhov/patch-am-av-tests-2 
Improve tests method for ActionView::TestCase and ActionMailer::TestCase
 2011-10-09 02:15:19 -07:00
Liborio Cannici
114218e4da Fixes an issue when creating a date select with too many options. 
Inspired by dlt 9e61563474

Closes #239.

Conflicts:

	actionpack/CHANGELOG
 2011-10-08 18:02:15 -07:00
Aaron Patterson
7f64e47277 just check to see that the first item in the list is an array 2011-10-07 16:56:18 -07:00
Santiago Pastorino
fd8f0b2978 stylesheet_link_tag('/stylesheets/application') and similar helpers doesn't throw Sprockets::FileOutsidePaths exception anymore 2011-10-05 15:41:28 -02:00
José Valim
c495bfc127 Do not require railtie as it messes up Rails.application setup. 2011-10-05 15:31:38 +02:00
José Valim
87c57bb88f Fix the lame config.action_controller.present? check scattered throughout assets_path. 
Conflicts:

	actionpack/test/template/sprockets_helper_test.rb
 2011-10-05 02:35:43 +02:00
José Valim
5711a35ad8 Ensure default_asset_host_protocol is respected, closes #2980. 2011-10-05 02:08:02 +02:00
Alexey Vakhov
8df7fe3f63 normalize arg for ActionView::TestCase tests method 2011-10-03 14:27:42 +04:00
Santiago Pastorino
64b0c8888b javascript_path and stylesheet_path should honor the asset pipelining 2011-09-28 20:13:24 -03:00
Wen-Tien Chang
3058d13a06 Make button_to helper support "form" option which is the form attributes. 2011-09-29 01:40:15 +08:00
Christos Zisopoulos
b8ea31540a Correctly override image_path in sprockets rails_helper 2011-09-26 18:45:49 +02:00
Santiago Pastorino
d6cff93152 Just assert_equal here 2011-09-26 12:20:52 -03:00
Santiago Pastorino
2c3a5075b6 Merge pull request #3135 from christos/respect_assets_digest_value 
Give precedence to `config.digest = false` over the existence of manifest.yml asset digests
 2011-09-26 08:16:02 -07:00
Santiago Pastorino
b855327443 image_tag should use /assets if asset pipelining is turned on. Closes #3126 2011-09-26 11:20:30 -03:00
Christos Zisopoulos
793e9da63d Give precedence to config.digest = false over manifest.yml asset digests 2011-09-26 14:27:04 +02:00
José Valim
933ba0cf6e Merge pull request #3124 from avakhov/patch-6-stylesheet-link 
escape options for the stylesheet_link_tag method
 2011-09-25 04:03:13 -07:00
Alexey Vakhov
5ffa69793f escape options for the stylesheet_link_tag method 2011-09-25 09:40:49 +04:00
Guillermo Iguaran
038808ba1a Add public API for register new js and css compressors for Sprockets 2011-09-24 19:22:13 -05:00
Santiago Pastorino
5dcb269eb8 Merge pull request #3092 from asee/master 
Sprockets to use config.assets.prefix, with tests
 2011-09-23 09:34:04 -07:00
José Valim
48d27363f2 Fix failing tests and add tests for :formats on partial. 2011-09-23 00:42:20 +02:00
Nick Sutterer
2e3eb2560b Allow both sym and array for details options in #render. using LC#registered_details to extract options. 2011-09-23 00:36:14 +02:00
Nick Sutterer
f8e6664d86 added tests for render :file/:template and the :formats/:handlers/:locale options. 2011-09-23 00:36:10 +02:00
docunext
c070cc4ab4 Fixes #1489 again, with updated code and numerous tests to confirm 2011-09-22 13:43:08 -04:00
José Valim
43d27e9105 Deprecate passing the template handler in the template name. 
For example, calling hello.erb is now deprecated. Since Rails 3.0
passing the handler had no effect whatsover. This commit simply
deprecates such cases so we can clean up the code in later releases.
 2011-09-22 15:37:38 +02:00
José Valim
119e9e2daf Get rid of update_details in favor of passing details to find_template. 2011-09-22 15:03:05 +02:00
Nick Sutterer
cbaad674f1 it is now possible to pass details options (:formats, :details, :locales, ...) to #render, #find_template and friends. this doesn't change anything in global context. 2011-09-22 14:12:36 +02:00
Santiago Pastorino
da7f0426ec Allow asset tag helper methods to accept :digest => false option in order to completely avoid the digest generation. 2011-09-14 15:02:17 -07:00
Guillermo Iguaran
9279d1102c Set relative url root in assets when controller isn't available for Sprockets. Fix #2435 
See https://github.com/rails/sass-rails/issues/42 for details
 2011-09-13 01:02:44 -05:00
Arun Agrawal
abbd27fad8 No need to use </form> here. It's already in whole_form block 2011-09-10 12:22:29 +05:30
Santiago Pastorino
a23e3855c5 Merge pull request #2872 from sikachu/content_tag_html_safe 
Make sure that result from content_tag_for with collection is html_safe
 2011-09-05 07:08:39 -07:00
Santiago Pastorino
f4a690dae7 Merge pull request #2815 from avakhov/current-page-non-get-requests 
current_page? returns false for non-GET requests
 2011-09-05 06:13:14 -07:00
Santiago Pastorino
c255e0eed5 Merge pull request #2799 from tomstuart/3-1-stable 
Never return stored content from content_for when a block is given
 2011-09-05 10:11:43 -03:00
Prem Sichanugrist
ffe56f3b8c Make sure that result from content_tag_for with collection is html_safe 
Thank you @spastorino for catching the empty test in b84cee0, as I totally forgot that I still have to make it html_safe.
 2011-09-05 20:04:37 +07:00
Vijay Dev
24ee573d6c add blanks between methods 2011-09-05 13:41:25 +05:30
Santiago Pastorino
4f8777333d Remove empty test 2011-09-05 00:43:51 -03:00
Ray Baxter
fa0ebf4c98 Tests shouldn't produce warnings 2011-09-04 20:27:53 -07:00
Prem Sichanugrist
b84cee08c6 Make content_tag_for and div_for accepts the array of records 
So instead of having to do this:

   @items.each do |item|
     content_tag_for(:li, item) do
        Title: <%= item.title %>
     end
   end

You can now do this:

   content_tag_for(:li, @items) do |item|
     Title: <%= item.title %>
   end
 2011-09-04 11:55:12 +07:00
Alexey Vakhov
fddf7ea1c1 current_page? returns false for non-GET requests 2011-09-02 18:20:10 +04:00
Guillermo Iguaran
f236e00189 Backport f443f9cb0c to master 2011-08-31 13:12:09 -05:00
Arun Agrawal
651ef614f1 Removed Unused Variable. 2011-08-26 11:29:05 +05:30