github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
25,882 Commits 34 Branches 105 Tags
71e84a3b514b6a2630dfd7f658f4e7597424d6e3
Commit Graph

26 Commits

Author SHA1 Message Date
jbbarth
24674b3448 Fixed bad options order in ActiveRecord::Migration::CommandRecorder#invert_rename_index 2011-08-28 06:02:15 +02:00
Xavier Noria
289b5253ce Merge branch 'master' of git://github.com/lifo/docrails 2011-07-05 01:42:13 +02:00
Vijay Dev
15f35c0ac0 Reversing the changes done in c278a2c while still resolving #1857. 
The changes broke bulk migration tests and were fixed in 4d256bc6;
however that brought back the issue of #1857 and so this commit goes
back to the original scenario and just adds change_table to the list
of methods which are to be recorded in the CommandRecorder. The
method_missing now delegates all calls to the underlying connection as
before.
 2011-07-02 23:43:13 +05:30
Jon Leighton
4d256bc6b1 CommandRecorder should delegate in method_missing where possible. Fixes some tests in migration_test.rb under mysql. The problem was introduced in c278a2c5e1. 2011-06-30 00:47:35 +01:00
Vijay Dev
5a79ca660a fix typo in method name 2011-06-25 18:47:51 +05:30
Vijay Dev
2332aa6e18 Revert "add missing methods supported by reversible migrations using the change method" 
This reverts commit 7f91eebae3.

Reason: Incorrect documenting. The newly added methods to the list are
not actually supported by reversible migrations.
 2011-06-25 18:45:41 +05:30
Vijay Dev
c278a2c5e1 record unsupported methods in CommandRecorder instead of letting the unsupported methods go through to the underlying db causing errors like duplicate columns to occur when rolling back migrations 2011-06-25 17:17:02 +05:30
Vijay Dev
7f91eebae3 add missing methods supported by reversible migrations using the change method 2011-06-24 12:31:14 +05:30
Xavier Noria
5e21247131 Merge branch 'master' of git://github.com/lifo/docrails 
Conflicts:
	activerecord/RUNNING_UNIT_TESTS
 2011-06-06 22:23:30 +02:00
Vijay Dev
5d8df14d6d comment the recorder methods 2011-06-07 01:38:03 +05:30
Vijay Dev
6e02164e02 styling changes 2011-06-02 01:08:14 +05:30
Aaron Patterson
2a9b3abe19 Merge pull request #1229 from workmad3/master 
Fix for Issue #1205
 2011-05-27 14:34:05 -07:00
Sebastian Martinez
0034b7822d Remove extra white spaces on ActiveRecord docs. 2011-05-23 20:58:25 -03:00
David Workman
86afbf7464 Using .try to test for the existence of a method option in a nil-resistent manner. Inlined the determination of the options hash for reversing using a ternary operator. Shortens the method in a way that keeps the code neat 2011-05-23 22:33:03 +01:00
David Workman
8588dd431b Neatened up the invert_add_index method as per suggeston 2011-05-23 15:03:42 +01:00
David Workman
a7fad65792 Simple fix for correctly inverting an add_index migration when a name has been provided 2011-05-23 13:54:51 +01:00
Pratik Naik
30176f28a4 Add :bulk => true option to change_table 2011-01-31 13:21:25 +00:00
Aaron Patterson
a4d9b1d329 adding documentation for reversible migrations 2010-11-19 11:34:42 -08:00
Aaron Patterson
47017bd169 invertable migrations are working 2010-11-19 10:31:03 -08:00
Aaron Patterson
6519df4157 command recorder will record commands sent to a delegate object 2010-11-19 10:24:16 -08:00
Aaron Patterson
0d7410faab updating documentation 2010-11-19 10:24:16 -08:00
Aaron Patterson
96b50a0392 IrreversibleMigration is raised if we cannot invert the command 2010-11-19 10:24:15 -08:00
Aaron Patterson
b29a24bb6f commands are reversed 2010-11-19 10:24:15 -08:00
Aaron Patterson
5d93900dc6 add and remove timestamps can be inverted 2010-11-19 10:24:15 -08:00
Aaron Patterson
24b637a80f inverting add_index 2010-11-19 10:24:15 -08:00
Aaron Patterson
843e319f78 partial implementation of the command recorder 2010-11-19 10:24:15 -08:00