github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-09 21:55:24 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,724 Commits 34 Branches 105 Tags
7692191f5ab207ff76cc2558f2a02e299cd51392
Commit Graph

30 Commits

Author SHA1 Message Date
Jeremy Kemper
71234daef1 r4487@asus: jeremy | 2006-04-29 12:21:39 -0700 
Check whether @flash is defined? for warnings-safety.
 r4488@asus:  jeremy | 2006-04-29 12:23:15 -0700
 Check whether @flash is defined? for warnings-safety. Obviates nil? check.
 r4489@asus:  jeremy | 2006-04-29 12:45:18 -0700
 Check whether @session is defined? for warnings-safety.
 r4490@asus:  jeremy | 2006-04-29 12:50:41 -0700
 Check whether @rendering_runtime is defined? for warnings-safety.
 r4491@asus:  jeremy | 2006-04-29 12:55:01 -0700
 Check whether @_cycles is defined? for warnings-safety.
 r4492@asus:  jeremy | 2006-04-29 12:59:19 -0700
 Check whether instance variables are defined? for warnings-safety.
 r4493@asus:  jeremy | 2006-04-29 13:14:09 -0700
 Add nil @template to PrototypeHelperTest to suppress unitialized instance variable warning.
 r4494@asus:  jeremy | 2006-04-29 13:31:34 -0700
 Check whether @auto_index defined? for warnings-safety.
 r4495@asus:  jeremy | 2006-04-29 13:32:24 -0700
 Wrap content_columns redefinitions with silence_warnings.
 r4496@asus:  jeremy | 2006-04-29 13:35:28 -0700
 Wrap more redefinitions with silence_warnings.
 r4829@asus:  jeremy | 2006-07-08 10:59:20 -0700
 abstract unit, fix warnings
 r4830@asus:  jeremy | 2006-07-08 11:06:12 -0700
 Use parens to silence warning.
 r4831@asus:  jeremy | 2006-07-08 11:06:48 -0700
 Use parens to silence warning.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4595 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-07-08 18:14:49 +00:00
Jeremy Kemper
bbc1351344 Determine the correct template_root for deeply nested components. Closes #2841. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4474 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-06-21 00:31:43 +00:00
Marcel Molina
9f92dd3984 Replace alias method chaining with Module#alias_method_chain. [Marcel Molina Jr.] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4312 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-04-29 20:20:22 +00:00
David Heinemeier Hansson
dfd953ea96 Fixed docs 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4079 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-28 03:19:27 +00:00
David Heinemeier Hansson
d19e8f412f Performance speedup for ActionController (closes #4174) [Stefan Kaes] Includes caching of filter chains -- be on the lookout for problems with that! 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3989 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-20 04:01:10 +00:00
David Heinemeier Hansson
c2fb8ca393 Just use a normal update on the indifferent hash 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3927 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-03-18 16:11:21 +00:00
David Heinemeier Hansson
ff986f19af Flash shouldnt depend on components either [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3581 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 06:11:17 +00:00
David Heinemeier Hansson
050c3964d8 Stopped the massive bleeding of concerns into ActionController::Base. Base no longer knows about flash, filters, or components. This may well have introduced some instability, please do test with apps, especially the ones using components. [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 05:51:02 +00:00
David Heinemeier Hansson
e90bbbdd83 Add caution and restyle components 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3577 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 01:06:45 +00:00
David Heinemeier Hansson
137794310b The components module should also contain the options that pertain to it, so collect it all with ClassMethods and InstanceMethods 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3576 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-12 00:46:01 +00:00
Jeremy Kemper
7654082260 Major components cleanup and speedup. Closes #3527. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3563 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 20:05:11 +00:00
Scott Barron
339fff7950 This does not need to be thread local (thanks skaes). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 12:59:22 +00:00
David Heinemeier Hansson
82f1e19e4c Fixed docs (closes #2468) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2749 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 13:20:46 +00:00
Scott Barron
3a2943c54d Take a different approach to keeping flash around when using components. 
One that, you know, doesn't involve consuming every byte of free memory
on the system.

Closes #2589.

References #2291.



git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2722 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-25 00:38:51 +00:00
Scott Barron
f8f4eccd9a If a component redirects when called with render_component_as_string, render the 
redirected to action.

Fixes #2327


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2604 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 02:53:21 +00:00
Scott Barron
a111e1a271 Keep flash after component is rendered. Closes #2291. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2363 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 11:02:11 +00:00
David Heinemeier Hansson
971c4e61c2 Params for components should treat string and symbol keys indifferently 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@887 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-11 01:55:18 +00:00
David Heinemeier Hansson
1019bf15a3 Added shortcut :id assignment to render_component and friends (before you had to go through :params) #784 [Lucas Carlson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@862 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-03-06 17:27:11 +00:00
David Heinemeier Hansson
e4efcfd43e Updated documentation 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@780 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-24 01:29:43 +00:00
David Heinemeier Hansson
ab8642c9da Added Base#render_component_as_string 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-23 15:26:48 +00:00
David Heinemeier Hansson
94b5e57bcc More component fun 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@749 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-22 17:11:34 +00:00
David Heinemeier Hansson
6cea13a30f More component fun 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@748 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-22 17:10:00 +00:00
David Heinemeier Hansson
8838020ac4 Fixed component method names 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@747 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-22 16:58:45 +00:00
David Heinemeier Hansson
e2724aa185 Made the sharing of request and response safer 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@744 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-22 14:14:42 +00:00
David Heinemeier Hansson
e4f07888ce Made caching work for WEBrick and lighttpd by appending .html for all URLs not already containing a dot 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@715 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-20 17:18:59 +00:00
David Heinemeier Hansson
12a7573630 Added new keyword to specify load paths as being component based. Added better logging for component calls 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@713 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-20 13:50:13 +00:00
David Heinemeier Hansson
acb3d2cf75 Fixed internal calling 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@707 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-20 00:02:02 +00:00
David Heinemeier Hansson
cf6d77600a Tests and tweaks for components 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@706 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-19 23:51:59 +00:00
David Heinemeier Hansson
7d3d83e7b4 Use full status for render_component from within a controller 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@698 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-19 20:33:15 +00:00
David Heinemeier Hansson
86b86b2647 Added preliminary version of render_component 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@697 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-02-19 20:29:55 +00:00