Commit Graph

5542 Commits

Author SHA1 Message Date
Andrew White
47871b025e Remove invalid test
The test fails on PostgreSQL when trying to load the records as
the comments_count field is not included in the GROUP BY clause.
2011-03-13 08:43:19 +00:00
Chris Oliver
015192560b Fixed a bug when empty? was called on a grouped Relation that wasn't loaded
[#5829 state:resolved]

Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
2011-03-12 22:31:21 +00:00
Mike Gehard
58de03f077 Add additional text to NotImplementedErrors [#6328 state:resolved]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-12 13:43:23 -02:00
Xavier Noria
f41dd99be7 revises links to the API websites of individual components (no longer maintained), and rewrites the section about after and around filters in the controller guide 2011-03-09 07:43:18 +01:00
Xavier Noria
89ecc0a5dc Merge branch 'master' of git://github.com/lifo/docrails 2011-03-07 22:11:47 +01:00
Jon Leighton
532f915037 Referencing a table via the ON condition in a join should force that table to be eager-loaded via a JOIN rather than via subsequent queries. 2011-03-07 08:51:17 -08:00
Akira Matsuda
5bed37779a "SSL everywhere" for GitHub URLs
see: https://github.com/blog/738-sidejack-prevention-phase-2-ssl-everywhere
2011-03-07 05:56:02 +09:00
Aaron Patterson
74818a3543 use Arel::Table#alias rather than passing the :as parameter 2011-03-05 11:56:24 -08:00
R.T. Lechow
a1b4d8e7b2 Active Record typos. 2011-03-05 11:56:34 +01:00
mjy
045ca30394 fixes a missmatched column in example 2011-03-05 11:56:33 +01:00
Xavier Noria
3b10b8a201 implements ActiveRecord::Base.connection_config to be able to check the configuration of the current connection at runtime 2011-03-05 01:35:02 +01:00
Jon Leighton
8987cda2bb When preloading has_and_belongs_to_many associations, we should only instantiate one AR object per actual record in the database. (Even when IM is off.) 2011-03-04 15:16:07 -08:00
Jon Leighton
af27262ec3 Fix a couple of tests in join_model_test.rb which were failing when the identity map is turned off 2011-03-04 14:49:19 -08:00
Alexander Uvarov
24faddd60c Move ActiveModel::AttributeMethods#attribute_methods_generated? to ActiveRecord, so it's flexible now
[#6428 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2011-03-01 20:22:45 +01:00
Jon Leighton
b171b9e73d Move JoinDependency and friends from ActiveRecord::Associations::ClassMethods to just ActiveRecord::Associations 2011-02-28 22:12:43 +00:00
Jon Leighton
d90b4e2615 Rewrote AssociationPreload. 2011-02-28 22:12:34 +00:00
Aaron Patterson
a8dae084c9 skip this on oracle 2011-02-28 09:15:19 -08:00
Aaron Patterson
f3e9cbc695 use an attribute rather than a SQL literal 2011-02-26 16:05:15 -08:00
Aaron Patterson
54a2bf6601 removing limits and offsets from COUNT queries unless both are specified. [#6268 state:resolved] 2011-02-25 15:38:59 -08:00
Aaron Patterson
8fc54a2e81 only take the limit if there is a limit to take 2011-02-25 14:24:05 -08:00
Xavier Noria
2e60b00788 Merge branch 'master' of git://github.com/lifo/docrails 2011-02-25 20:53:55 +01:00
Eric Allam
13547c16d9 fixes: ActiveRecord::Base.scopes includes all scopes defined in all subclasses 2011-02-24 11:17:06 -08:00
Josep M. Bach
55105c4318 Fix missing inheritance from AR::Base in docs 2011-02-24 10:00:09 +01:00
Aaron Patterson
5f1fc0c8ac observers leak across tests, so rather than modify the object, we should just count the number of times the observer was called 2011-02-23 16:04:01 -08:00
Kamal Fariz Mahyuddin
6ba8caf3ee Fix observer callbacks firing multiple times on descendant instances 2011-02-22 16:25:19 -08:00
Prem Sichanugrist
839d06f5f2 We're in 2011, let's update our license
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-02-22 18:24:20 -02:00
Aaron Patterson
2cce44fa7c expectations change when using IM. Change oracle tests to reflect that 2011-02-22 11:27:12 -08:00
Aaron Patterson
4bd8d2607c Relation will delegate to AR::Base which already uses the Dynamic finders, so eliminate duplicate calls 2011-02-22 11:07:51 -08:00
Aaron Patterson
b3fcabb3a5 adding a test case for custom locking 2011-02-21 16:12:02 -08:00
Jon Leighton
52f8e4b9da Use proper objects to do the work to build the associations (adding methods, callbacks etc) rather than calling a whole bunch of methods with rather long names. 2011-02-21 10:16:15 -08:00
Jon Leighton
a5274bb52c Rename target_klass to klass 2011-02-21 10:16:14 -08:00
Jon Leighton
8b00da5258 Delegate through_reflection and source_reflection to reflection 2011-02-21 10:16:14 -08:00
Jon Leighton
32eef69dc1 Delegate Association#options to the reflection, and replace 'reflection.options' with 'options'. Also add through_options and source_options methods for through associations. 2011-02-21 10:16:14 -08:00
Jon Leighton
73ff0076b3 Singular associations no longer use a proxy, so no need to check for the proxy type on assignment. 2011-02-21 10:16:14 -08:00
Jon Leighton
1d85a73ceb Associations - where possible, call attributes methods rather than directly accessing the instance variables 2011-02-21 10:16:14 -08:00
Xavier Noria
f826e05835 Merge branch 'master' of git://github.com/lifo/docrails 2011-02-21 11:42:26 +01:00
Xavier Noria
b481574a33 copy-edits 8d96b89 2011-02-21 11:37:08 +01:00
Rodrigo Navarro
62fd334684 Adding new examples for update_all method 2011-02-20 22:22:52 -03:00
Rodrigo Navarro
4da0157aaf Adding examples 2011-02-20 22:03:29 -03:00
Nicholas Rowe
2a75c190d4 Tpyo: fixing several cases of the the 2011-02-19 23:47:12 -05:00
Nicholas Rowe
89b3bc4807 Typo: fixing the the 2011-02-19 23:46:30 -05:00
Peer Allan
8d96b89110 Clarification of ActiveRecord ActiveModel validation documentation 2011-02-18 20:51:56 -06:00
Aaron Patterson
289cc15f1a instance_methods includes public and protected, so reduce funcalls and object allocs 2011-02-18 17:32:08 -08:00
Aaron Patterson
8657826f41 oops, no need for puts! 2011-02-18 15:53:54 -08:00
Aaron Patterson
30679bc705 AR::AttributeMethods does not need to be included in an AR::Base class. 2011-02-18 15:51:39 -08:00
Xavier Noria
ce76cfc61f fixes a merge conflict 2011-02-19 00:42:51 +01:00
Xavier Noria
f41bf6938f merges docrails 2011-02-18 23:22:15 +01:00
Xavier Noria
2acb5e348d removes unrealistic example (authentication plus gender?), that it is not needed anyway 2011-02-18 22:54:02 +01:00
Nicholas Rowe
ad3e4e3af6 Clarify Example in ActiveRecord base 2011-02-18 14:43:53 -05:00
Emilio Tagua
00418ac96b Merge remote branch 'rails/master' into identity_map 2011-02-18 16:22:50 -03:00